Doug / smarc-fsl-linux-kernel

14 Oct, 2010

1 commit

  • 7368ddf14   tipc: clean out all instances of #if 0'd unused code ... Browse Code »

    Remove all instances of legacy, or as yet to be implemented code
    that is currently living within an #if 0 ... #endif block.
    In the rare instance that some of it be needed in the future,
    it can still be dragged out of history, but there is no need
    for it to sit in mainline.

    Signed-off-by: Paul Gortmaker
    Acked-by: Neil Horman
    Signed-off-by: David S. Miller

    Paul Gortmaker
     

10 Sep, 2010

1 commit

  • b2abd4c03   tipc: Optimize handling excess content on incoming messages ... Browse Code »

    Remove code that trimmed excess trailing info from incoming messages
    arriving over an Ethernet interface. TIPC now ignores the extra info
    while the message is being processed by the node, and only trims it off
    if the message is retransmitted to another node. (This latter step is
    done to ensure the extra info doesn't cause the sk_buff to exceed the
    outgoing interface's MTU limit.) The outgoing buffer is guaranteed to
    be linear.

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker
    Signed-off-by: David S. Miller

    Paul Gortmaker
     

13 May, 2010

1 commit

  • c68ca7b72   tipc: add tipc_ prefix to fcns targeted for un-inlining ... Browse Code »

    These functions have enough code in them such that they
    seem like sensible targets for un-inlining. Prior to doing
    that, this adds the tipc_ prefix to the functions, so that
    in the event of a panic dump or similar, the subsystem from
    which the functions come from is immediately clear.

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker
    Signed-off-by: David S. Miller

    Allan Stephens
     

31 Mar, 2010

1 commit

25 Mar, 2010

1 commit

04 Mar, 2010

1 commit

  • d0021b252   tipc: Fix oops on send prior to entering networked mode (v3) ... Browse Code »

    Fix TIPC to disallow sending to remote addresses prior to entering NET_MODE

    user programs can oops the kernel by sending datagrams via AF_TIPC prior to
    entering networked mode. The following backtrace has been observed:

    ID: 13459 TASK: ffff810014640040 CPU: 0 COMMAND: "tipc-client"
    [exception RIP: tipc_node_select_next_hop+90]
    RIP: ffffffff8869d3c3 RSP: ffff81002d9a5ab8 RFLAGS: 00010202
    RAX: 0000000000000001 RBX: 0000000000000001 RCX: 0000000000000001
    RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000001001001
    RBP: 0000000001001001 R8: 0074736575716552 R9: 0000000000000000
    R10: ffff81003fbd0680 R11: 00000000000000c8 R12: 0000000000000008
    R13: 0000000000000001 R14: 0000000000000001 R15: ffff810015c6ca00
    ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
    RIP: 0000003cbd8d49a3 RSP: 00007fffc84e0be8 RFLAGS: 00010206
    RAX: 000000000000002c RBX: ffffffff8005d116 RCX: 0000000000000000
    RDX: 0000000000000008 RSI: 00007fffc84e0c00 RDI: 0000000000000003
    RBP: 0000000000000000 R8: 00007fffc84e0c10 R9: 0000000000000010
    R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
    R13: 00007fffc84e0d10 R14: 0000000000000000 R15: 00007fffc84e0c30
    ORIG_RAX: 000000000000002c CS: 0033 SS: 002b

    What happens is that, when the tipc module in inserted it enters a standalone
    node mode in which communication to its own address is allowed but not
    to other addresses, since the appropriate data structures have not been
    allocated yet (specifically the tipc_net pointer). There is nothing stopping a
    client from trying to send such a message however, and if that happens, we
    attempt to dereference tipc_net.zones while the pointer is still NULL, and
    explode. The fix is pretty straightforward. Since these oopses all arise from
    the dereference of global pointers prior to their assignment to allocated
    values, and since these allocations are small (about 2k total), lets convert
    these pointers to static arrays of the appropriate size. All the accesses to
    these bits consider 0/NULL to be a non match when searching, so all the lookups
    still work properly, and there is no longer a chance of a bad dererence
    anywhere. As a bonus, this lets us eliminate the setup/teardown routines for
    those pointers, and elimnates the need to preform any locking around them to
    prevent access while their being allocated/freed.

    I've updated the tipc_net structure to behave this way to fix the exact reported
    problem, and also fixed up the tipc_bearers and media_list arrays to fix an
    obvious simmilar problem that arises from issuing tipc-config commands to
    manipulate bearers/links prior to entering networked mode

    I've tested this for a few hours by running the sanity tests and stress test
    with the tipcutils suite, and nothing has fallen over. There have been a few
    lockdep warnings, but those were there before, and can be addressed later, as
    they didn't actually result in any deadlock.

    Signed-off-by: Neil Horman
    CC: Allan Stephens
    CC: David S. Miller
    CC: tipc-discussion@lists.sourceforge.net

    bearer.c | 37 ++++++-------------------------------
    bearer.h | 2 +-
    net.c | 25 ++++---------------------
    3 files changed, 11 insertions(+), 53 deletions(-)
    Signed-off-by: David S. Miller

    Neil Horman
     

03 Sep, 2008

1 commit

15 Jul, 2008

1 commit

  • 0e35fd5e5   tipc: Eliminate improper use of TIPC_OK error code ... Browse Code »

    This patch corrects many places where TIPC routines indicated
    successful completion by returning TIPC_OK instead of 0.
    (The TIPC_OK symbol has the value 0, but it should only be used
    in contexts that deal with the error code field of a TIPC
    message header.)

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     

22 May, 2008

1 commit

  • 03194379a   tipc: Fix initialization sequence problems when entering network mode ... Browse Code »

    This patch ensures that TIPC's topology service and configuration
    service are shut down before switching into "network mode". This
    ensures that TIPC does not mistakenly try to send unnecessary
    "publication withdraw" messages to other nodes before it is fully
    initialized for sending off-node messages. Note that the node's
    current network address is now updated only after the two services
    are shut down; this ensures that any existing connections to the
    topology server are terminated correctly using the old address.

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     

11 Feb, 2007

1 commit

22 Jul, 2006

1 commit

28 Jun, 2006

1 commit

  • 34af946a2   [PATCH] spin/rwlock init cleanups ... Browse Code »

    locking init cleanups:

    - convert " = SPIN_LOCK_UNLOCKED" to spin_lock_init() or DEFINE_SPINLOCK()
    - convert rwlocks in a similar manner

    this patch was generated automatically.

    Motivation:

    - cleanliness
    - lockdep needs control of lock initialization, which the open-coded
    variants do not give
    - it's also useful for -rt and for lock debugging in general

    Signed-off-by: Ingo Molnar
    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

21 Mar, 2006

2 commits

  • 988f088a8   [TIPC]: Cleanups ... Browse Code »

    This patch contains the following possible cleanups:
    - make needlessly global code static
    - #if 0 the following unused global functions:
    - name_table.c: tipc_nametbl_print()
    - name_table.c: tipc_nametbl_dump()
    - net.c: tipc_net_next_node()

    Signed-off-by: Adrian Bunk
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Adrian Bunk
     
  • 1fc54d8f4   [TIPC]: Fix simple sparse warnings ... Browse Code »

    Tried to run the new tipc stack through sparse.
    Following patch fixes all cases where 0 was used
    as replacement of NULL.
    Use NULL to document this is a pointer and to silence sparse.

    This brough sparse warning count down with 127 to 24 warnings.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Sam Ravnborg
     

18 Jan, 2006

1 commit

13 Jan, 2006

4 commits