31 Oct, 2013
5 commits
-
Fix checkpatch.pl issues with space prohibited
before semicolon in r8185b_init.cSigned-off-by: Ebru Akagunduz
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch.pl issues with space prohibited after that
open parenthesis '(' in r8185b_init.cSigned-off-by: Ebru Akagunduz
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch.pl issues with braces {} are not necessary
for single statement blocks in r8185b_init.cSigned-off-by: Ebru Akagunduz
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch.pl issues with trailing whitespace
in r8185b_init.cSigned-off-by: Ebru Akagunduz
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch.pl issues with please, no space before
tabs in r8185b_init.cSigned-off-by: Ebru Akagunduz
Signed-off-by: Greg Kroah-Hartman
29 Oct, 2013
19 commits
-
This patch fixes the following coccinelle issue for a mask calculation:
drivers/staging/rtl8187se/r8180_core.c:2552:44-54: duplicated argument to & or |
Signed-off-by: Teodora Baluta
Reviewed-by: Rusty Russell
Signed-off-by: Greg Kroah-Hartman -
Fix confusingly indented code after if. This patch fixes the following
coccinelle issues:drivers/staging/rtl8187se/r8180_wx.c:1148:2-11: code aligned with following code on line 1150
drivers/staging/rtl8187se/r8180_dm.c:668:1-84: code aligned with following code on line 674
drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:623:2-38: code aligned with following code on line 625
drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:148:1-85: code aligned with following code on line 149Signed-off-by: Teodora Baluta
Reviewed-by: Rusty Russell
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following coccinelle warning:
drivers/staging/rtl8187se/r8180_core.c:2217:5-40: WARNING: Comparison to bool
Signed-off-by: Teodora Baluta
Reviewed-by: Rusty Russell
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following coccinelle warnings:
drivers/staging/rtl8187se/r8180_core.c:2433:1-20: WARNING: Assignment of bool to 0/1
drivers/staging/rtl8187se/r8180_core.c:2275:3-34: WARNING: Assignment of bool to 0/1Signed-off-by: Teodora Baluta
Reviewed-by: Rusty Russell
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following coccinelle warning to use memdup_user
rather than duplicating its implementation:drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:2947:9-16: WARNING opportunity for memdup_user
Signed-off-by: Teodora Baluta
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch.pl issues with line over 80 characters
in r8185b_init.c, Italian to English translated addedSigned-off-by: Ebru Akagunduz
Signed-off-by: Greg Kroah-Hartman -
This patch fixes this type of checkpatch warnings:
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
pr_warn(... to printk(KERN_WARNING ...Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then
pr_info(... to printk(KERN_INFOSigned-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following checkpatch warning:
WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
pr_debug(... to printk(KERN_DEBUG ...Signed-off-by: Teodora Baluta
Signed-off-by: Greg Kroah-Hartman -
This patch fixes lines that are well over 80 characters long and
silences the checkpatch warning.Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch ensures that all multi-line comments are consistent with the Linux
kernel coding style for long (multi-line) comments.Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixed the following checkpatch warning:
WARNING: Avoid unnecessary line continuationsSigned-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following checkpatch warning:
WARNING: suspect code indent for conditional statements (24, 26)Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following checkpatch warning:
ERROR: else should follow close brace '}'Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch rearranges comments that are over 80 characters.
Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the following checkpatch error:
staging/rtl8187se/ieee80211/ieee80211_tx.c:232:
ERROR: open brace '{' following function declarations go on the next
lineSigned-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixes checkpatch issues regarding space and tab like:
WARNING: please, no spaces at the start of a line
ERROR: code indent should use tabs where possible
WARNING: suspect code indent for conditional statements (2, 4)
ERROR: space required before the open parenthesis '('
ERROR: space required after that ',' (ctx:VxO)Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the comments in file ieee80211/ieee80211_tx.c from
driver rtl8187se, as reported by checkpatch. The C89 comments that
contain code
are deleted.Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Teodora Baluta
Reviewed-by: Josh Triplett
Signed-off-by: Greg Kroah-Hartman
20 Oct, 2013
4 commits
-
Fix the following checkpatch.pl errors:
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:890: "foo* bar" should be "foo *bar"
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:944: "foo* bar" should be "foo *bar"Signed-off-by: Teodora Baluta
Signed-off-by: Greg Kroah-Hartman -
This patch fixes sparse warnings regarding functions that should be
static in driver rtl8187se.Signed-off-by: Teodora Baluta
Signed-off-by: Greg Kroah-Hartman -
Fix the following type of sparse warnings:
drivers/staging/rtl8187se/r8180_core.c:163:48: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8187se/r8180_core.c:163:48: expected void const volatile [noderef] *addr
drivers/staging/rtl8187se/r8180_core.c:163:48: got unsigned char [usertype] *Signed-off-by: Teodora Baluta
Signed-off-by: Greg Kroah-Hartman -
Fix the following type of sparse warnings:
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: expected restricted gfp_t [usertype] flags
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: got int [signed] gfp_maskSigned-off-by: Teodora Baluta
Signed-off-by: Greg Kroah-Hartman
12 Oct, 2013
2 commits
-
Fix checkpatch.pl issues with suspect code indent for
conditional statements in r8185b_init.cSigned-off-by: Ebru Akagunduz
Reviewed-by: Zach Brown
Signed-off-by: Greg Kroah-Hartman -
Fix checkpatch.pl issues with avoid unnecessary line
continuations in r8185b_init.cSigned-off-by: Ebru Akagunduz
Reviewed-by: Zach Brown
Signed-off-by: Greg Kroah-Hartman
01 Oct, 2013
1 commit
-
Fixed checkpatch.pl errors in r8180_dm.c.
Signed-off-by: Adam Rall
Signed-off-by: Greg Kroah-Hartman
26 Sep, 2013
2 commits
-
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Signed-off-by: Greg Kroah-Hartman -
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)Signed-off-by: Peter Senna Tschudin
Signed-off-by: Greg Kroah-Hartman
28 Aug, 2013
1 commit
-
A lot of files contain reference to my old e-mail address.
Now I'm going not to read mail from it anymore, so update it
with my current address everywhere.Signed-off-by: Andrea Merello
Signed-off-by: Greg Kroah-Hartman
24 Aug, 2013
1 commit
-
struct pt_regs pointer is no longer passed as a irq handler
argument.v2:
remove rtl8180_interrupt cast to (void *) .Signed-off-by: navin patidar
Cc: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
19 Jun, 2013
1 commit
-
Also remove commented out list manipulation
Signed-off-by: Dave Jones
Signed-off-by: Greg Kroah-Hartman
05 May, 2013
1 commit
-
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro
02 May, 2013
2 commits
-
Supply an accessor function for getting the private data from the parent
proc_dir_entry struct of the proc_dir_entry struct associated with an inode.ReiserFS, for instance, stores the super_block pointer in the proc directory
it makes for that super_block, and a pointer to the respective seq_file show
function in each of the proc files in that directory.This allows a reduction in the number of file_operations structs, open
functions and seq_operations structs required. The problem otherwise is that
each show function requires two pieces of data but only has storage for one
per PDE (and this has no release function).Signed-off-by: David Howells
Acked-by: Mauro Carvalho Chehab
Acked-by: Greg Kroah-Hartman
cc: Jerry Chuang
cc: Maxim Mikityanskiy
cc: YAMANE Toshiaki
cc: linux-wireless@vger.kernel.org
cc: linux-scsi@vger.kernel.org
cc: devel@driverdev.osuosl.org
Signed-off-by: Al Viro -
Create a dir under /proc/net/r8180/ named for the device and create that
device's files under there. This means that there won't be a problem for
multiple devices in the system (if such is possible) and it means we don't
need to save the 'device directory' PDE any more as we can just do a proc
subtree removal.Signed-off-by: David Howells
Acked-by: Greg Kroah-Hartman
cc: Maxim Mikityanskiy
cc: YAMANE Toshiaki
cc: linux-wireless@vger.kernel.org
cc: devel@driverdev.osuosl.org
Signed-off-by: Al Viro
30 Apr, 2013
1 commit
-
Don't use create_proc_read_entry() as that is deprecated, but rather use
proc_create_data() and seq_file instead. Whilst we're at it, reduce the
number of show functions where we can share them.Question: Do any of the registers read by proc_get_registers() have side
effects upon reading? If so, locking will be required.Signed-off-by: David Howells
cc: Greg Kroah-Hartman
cc: Maxim Mikityanskiy
cc: YAMANE Toshiaki
cc: Bill Pemberton
cc: Andrea Merello
cc: linux-wireless@vger.kernel.org
cc: devel@driverdev.osuosl.org
Signed-off-by: Al Viro