03 Mar, 2010

1 commit

  • The id_table field of the struct usb_device_id is constant in
    so it is worth to make the initialization data also constant.

    The semantic match that finds this kind of pattern is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r@
    disable decl_init,const_decl_init;
    identifier I1, I2, x;
    @@
    struct I1 {
    ...
    const struct I2 *x;
    ...
    };
    @s@
    identifier r.I1, y;
    identifier r.x, E;
    @@
    struct I1 y = {
    .x = E,
    };
    @c@
    identifier r.I2;
    identifier s.E;
    @@
    const struct I2 E[] = ... ;
    @depends on !c@
    identifier r.I2;
    identifier s.E;
    @@
    + const
    struct I2 E[] = ...;
    //

    Signed-off-by: Németh Márton
    Cc: Julia Lawall
    Cc: cocci@diku.dk
    Signed-off-by: Greg Kroah-Hartman

    Németh Márton
     

24 Dec, 2009

1 commit

  • While converting emi62 to use request_firmware(), the driver was also
    changed to use the ihex helper functions. However, this broke the loading
    of the FPGA firmware because the code tries to access the addr field of
    the EOF record which works with a plain array that has an empty last
    record but not with the ihex helper functions where the end of the data is
    signaled with a NULL record pointer, resulting in:

    BUG: unable to handle kernel NULL pointer dereference at (null)
    IP: [] emi62_load_firmware+0x33c/0x740 [emi62]

    This can be fixed by changing the loop condition to test the return value
    of ihex_next_binrec() directly (like in emi26.c).

    Signed-off-by: Clemens Ladisch
    Reported-and-tested-by: Der Mickster
    Acked-by: David Woodhouse
    Cc: stable
    Signed-off-by: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Clemens Ladisch
     

18 Oct, 2008

1 commit


22 Jul, 2008

1 commit


10 Jul, 2008

1 commit


25 Apr, 2008

1 commit


26 Oct, 2007

1 commit


20 Oct, 2007

1 commit

  • * Convert files to UTF-8.

    * Also correct some people's names
    (one example is Eißfeldt, which was found in a source file.
    Given that the author used an ß at all in a source file
    indicates that the real name has in fact a 'ß' and not an 'ss',
    which is commonly used as a substitute for 'ß' when limited to
    7bit.)

    * Correct town names (Goettingen -> Göttingen)

    * Update Eberhard Mönkeberg's address (http://lkml.org/lkml/2007/1/8/313)

    Signed-off-by: Jan Engelhardt
    Signed-off-by: Adrian Bunk

    Jan Engelhardt
     

02 Dec, 2006

1 commit


13 May, 2006

1 commit

  • It's become apparent as machines get faster that the emagic kernel firmware
    loaders (based on the ezusb loader) have a reset race. a 400MHz TiBook
    never tripped it, but a 2GHz Pentium M seems to hit it about 30% of the
    time. The bug is seen as a hung USB box and the kernel error:

    drivers/usb/misc/emi62.c: emi62_load_firmware - error loading firmware:
    error = -110

    The patch below inserts a delay after deasserting reset to allow the box to
    settle before a new command is issued. This affects only device startup.

    Signed-off-by: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Monty
     

05 Jan, 2006

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds