31 Jul, 2013
1 commit
-
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones
09 Apr, 2013
5 commits
-
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.Signed-off-by: Sachin Kamat
Acked-by: Roger Quadros
Signed-off-by: Samuel Ortiz -
Allows the OMAP HS USB host controller to be specified
via device tree.Signed-off-by: Roger Quadros
Reviewed-by: Mark Rutland
Signed-off-by: Samuel Ortiz -
PHY reset GPIO handling will be done in the PHY driver
Signed-off-by: Roger Quadros
Acked-by: Felipe Balbi
Acked-by: Samuel Ortiz
Signed-off-by: Samuel Ortiz -
This is because we want to get rid of platform_data usage from probe().
The only information we need is PORT_MODE, and this can be supplied
to us by the user (i.e. omap-usb-host.c).We also move channel clock management from runtime PM handlers into
omap_tll_enable/disable().Signed-off-by: Roger Quadros
Signed-off-by: Samuel Ortiz -
EHCI driver would need to know the number of ports available
on the platform. We set the nports parameter of platform_data
based on IP version if it was not already provided.Signed-off-by: Roger Quadros
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz
08 Apr, 2013
1 commit
-
Use devm_gpio_request_one() to make cleanup paths more simple.
Signed-off-by: Jingoo Han
Signed-off-by: Samuel Ortiz
12 Mar, 2013
1 commit
-
The helper functions omap_usbhs_rev1_hostconfig()
and omap_usbhs_rev2_hostconfig() don't write into
the hostconfig register. Make sure that we write
the return value into the hostconfig register.Signed-off-by: Roger Quadros
Signed-off-by: Samuel Ortiz
13 Feb, 2013
11 commits
-
Fixes the below build warning when driver is built-in.
drivers/mfd/omap-usb-host.c:750:12: warning:
‘usbhs_omap_remove’ defined but not used [-Wunused-function]Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
clk_set_parent is expected to fail on OMAP3 platforms. We don't
consider that as fatal so don't spam console.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
We split initializing revision 1 and revision 2 into different
functions. Initialization is now done dynamically so that only
the number of ports available on the system are initialized.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
The driver does not have an interrupt handler and
we don't really need a spinlock, so get rid of it.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports
that are configured in HSIC mode.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
All ports have similarly named port clocks so we can
bunch them into a port data structure and use for loop
to enable/disable the clocks.Dynamically allocate and get clocks based on number of ports
available on the platformSigned-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Both OMAP4 and 5 exhibit the same revision ID in the REVISION register
but they have different number of ports i.e. 2 and 3 respectively.
So we can't rely on REVISION register for number of ports on OMAP5
and depend on platform data (or device tree) instead.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
The revision register should tell us how many ports are present.
Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Use devm_ variants of kzalloc and ioremap. Also clean up error path.
Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Get rid of the unnecessary missing platform data checks
in runtime_suspend/resume. We are already checking for missing
platform data in probe.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi -
Let's have a single platform data structure for the OMAP's High-Speed
USB host subsystem instead of having 3 separate ones i.e. one for
board data, one for USB Host (UHH) module and one for USB-TLL module.This makes the code much simpler and avoids creating multiple copies of
platform data.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
For the ehci-omap.c part:
Acked-by: Alan Stern
15 Dec, 2012
1 commit
-
Instead of using cpu_is_omap..() macros in the device driver we
rely on information provided in the platform data.The only information we need is whether the USB Host module has
a single ULPI bypass control bit for all ports or individual bypass
control bits for each port. OMAP3 REV2.1 and earlier have the former.Signed-off-by: Roger Quadros
Acked-by: Samuel Ortiz
[tony@atomide.com: updated to remove plat/cpu.h]
Signed-off-by: Tony Lindgren
13 Dec, 2012
1 commit
-
Pull ARM SoC Header cleanups from Olof Johansson:
"This is a collection of header file cleanups, mostly for OMAP and
AT91, that keeps moving the platforms in the direction of
multiplatform by removing the need for mach-dependent header files
used in drivers and other places."Fix up mostly trivial conflicts as per Olof.
* tag 'headers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (106 commits)
ARM: OMAP2+: Move iommu/iovmm headers to platform_data
ARM: OMAP2+: Make some definitions local
ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c
ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h
ARM: OMAP2+: Move iopgtable header to drivers/iommu/
ARM: OMAP: Merge iommu2.h into iommu.h
atmel: move ATMEL_MAX_UART to platform_data/atmel.h
ARM: OMAP: Remove omap_init_consistent_dma_size()
arm: at91: move at91rm9200 rtc header in drivers/rtc
arm: at91: move reset controller header to arm/arm/mach-at91
arm: at91: move pit define to the driver
arm: at91: move at91_shdwc.h to arch/arm/mach-at91
arm: at91: move board header to arch/arm/mach-at91
arn: at91: move at91_tc.h to arch/arm/mach-at91
arm: at91 move at91_aic.h to arch/arm/mach-at91
arm: at91 move board.h to arch/arm/mach-at91
arm: at91: move platfarm_data to include/linux/platform_data/atmel.h
arm: at91: drop machine defconfig
ARM: OMAP: Remove NEED_MACH_GPIO_H
ARM: OMAP: Remove unnecessary mach and plat includes
...
29 Nov, 2012
2 commits
-
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.Signed-off-by: Bill Pemberton
Cc: Srinidhi Kasagar
Cc: Peter Tyser
Cc: Daniel Walker
Cc: Bryan Huntsman
Acked-by: David Brown
Acked-by: Linus Walleij
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.Signed-off-by: Bill Pemberton
Cc: Srinidhi Kasagar
Cc: Peter Tyser
Cc: Daniel Walker
Cc: Bryan Huntsman
Acked-by: David Brown
Acked-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman
25 Oct, 2012
1 commit
-
In order to make single zImage work for ARM architecture,
we need to make sure we don't depend on private headers.Move USB platform_data to
and add a minimal drivers/mfd/usb-omap.h.Cc: Samuel Ortiz
Cc: Alan Stern
Cc: Greg Kroah-Hartman
Cc: Partha Basak
Cc: Keshava Munegowda
Cc: linux-usb@vger.kernel.org
Signed-off-by: Felipe Balbi
[tony@atomide.com: updated for local mfd/usb-omap.h]
Signed-off-by: Tony Lindgren
22 Sep, 2012
2 commits
-
The TLL specific code such as channels clocks enable/disable,
initialization functions are removed from the USBHS core
driver. The hwmod of the usb tll is retrieved and omap device
build is performed to created the platform device for the
usb tll component.Signed-off-by: Keshava Munegowda
Reviewed-by: Partha Basak
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz -
The usbhs driver invokes the enable/disable APIs of the
usb tll driver in the runtime resume/suspend callbacks
of the runtime get sync and put sync of the usbhs driver.Signed-off-by: Keshava Munegowda
Reviewed-by: Partha Basak
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz
09 Jul, 2012
1 commit
-
'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' (1fcb57d0) fixes
an issue where the ULPI PHYs were not held in reset while initializing
the EHCI controller. However, it also changes behavior in
omap-usb-host.c omap_usbhs_init by releasing reset while the
configuration in that function was done.This change caused a regression on BB-xM where USB would not function
if 'usb start' had been run from u-boot before booting. A change was
made to release reset a little bit earlier which fixed the issue on
BB-xM and did not cause any regressions on 3430 sdp, the board for
which the fix was originally made.This new fix, 'USB: EHCI: OMAP: Finish ehci omap phy reset cycle
before adding hcd.', (3aa2ae74) caused a regression on OMAP5.The original fix to hold the EHCI controller in reset during
initialization was correct, however it appears that changing
omap_usbhs_init to not hold the PHYs in reset during it's
configuration was incorrect. This patch first reverts both fixes, and
then changes ehci_hcd_omap_probe in ehci-omap.c to hold the PHYs in
reset as the original patch had done. It also is sure to incorporate
the _cansleep change that has been made in the meantime.I've tested this on Beagleboard xM, I'd really like to get an ack from
the 3430 sdp and OMAP5 guys before getting this merged.v3 - Brown paper bag its too early in the morning actually run
git commit amend fix
v2 - Put cansleep gpiolib call outside of spinlockAcked-by: Mantesh Sarashetti
Tested-by: Mantesh Sarashetti
Acked-by: Keshava Munegowda
Tested-by: Keshava Munegowda
Signed-off-by: Russ Dill
Signed-off-by: Samuel Ortiz
01 May, 2012
1 commit
-
'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for
linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h
which is required by omap-usb-host.c. Fix the build breakage by including
it directly.Acked-by: Keshava Munegowda
Acked-by: Kevin Hilman
Tested-by: Arend van Spriel
Signed-off-by: Russ Dill
Signed-off-by: Samuel Ortiz
17 Apr, 2012
1 commit
-
It is observed that the echi ports of 3430 sdp board
are not working due to the random timing of programming
the associated GPIOs of the ULPI PHYs of the EHCI for reset.
If the PHYs are reset at during usbhs core driver, host ports will
not work because EHCI driver is loaded after the resetting PHYs.
The PHYs should be in reset state while initializing the EHCI
controller.
The code which does the GPIO pins associated with the PHYs
are programmed to reset is moved from the USB host core driver
to EHCI driver.Signed-off-by: Keshava Munegowda
Reviewed-by: Partha Basak
Acked-by: Felipe Balbi
Tested-by: Igor Grinberg
Signed-off-by: Samuel Ortiz
07 Mar, 2012
2 commits
-
There could be possible race condition where the host dev's
are alloced and added to platform dev just before usbhs_init.
Just move usbhs_init before adding child dev.CC: Alan Stern
Signed-off-by: Govindraj.R
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz -
Remove the hardcoded magic values for dma mask and use the dma
mask api/macro available.Signed-off-by: Govindraj.R
Reviewed-by: Felipe Balbi
Signed-off-by: Samuel Ortiz
14 Jan, 2012
1 commit
-
* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6: (59 commits)
rtc: max8925: Add function to work as wakeup source
mfd: Add pm ops to max8925
mfd: Convert aat2870 to dev_pm_ops
mfd: Still check other interrupts if we get a wm831x touchscreen IRQ
mfd: Introduce missing kfree in 88pm860x probe routine
mfd: Add S5M series configuration
mfd: Add s5m series irq driver
mfd: Add S5M core driver
mfd: Improve mc13xxx dt binding document
mfd: Fix stmpe section mismatch
mfd: Fix stmpe build warning
mfd: Fix STMPE I2c build failure
mfd: Constify aat2870-core i2c_device_id table
gpio: Add support for stmpe variant 801
mfd: Add support for stmpe variant 801
mfd: Add support for stmpe variant 610
mfd: Add support for STMPE SPI interface
mfd: Separate out STMPE controller and interface specific code
misc: Remove max8997-muic sysfs attributes
mfd: Remove unused wm831x_irq_data_to_mask_reg()
...Fix up trivial conflict in drivers/leds/Kconfig due to addition of
LEDS_MAX8997 and LEDS_TCA6507 next to each other.
09 Jan, 2012
1 commit
-
Use gpio_request_one() instead of multiple gpiolib calls.
Signed-off-by: Axel Lin
Signed-off-by: Samuel Ortiz
16 Dec, 2011
2 commits
-
The usbhs core driver does not enable/disable the interface and
functional clocks directly, These clocks are handled by runtime pm,
hence instead of the clock enable/disable, the runtime pm APIS are
used. however,the optional clocks and port clocks are handled by
the usbhs core.Dependency:
This patch is dependent on this series:
[PATCH 0/5 v13 or latest version] omap: usb: host: Runtime PM preparation
for EHCI and OHCI drivers.Validation performed:
The global suspend/resume of EHCI and OHCI is validated on
OMAP3430 sdp board with this patch combined with the series:
[PATCH 0/5 v13 or latest version] omap: usb: host: Runtime PM preparation
for EHCI and OHCI drivers.Signed-off-by: Keshava Munegowda
Reviewed-by: Kevin Hilman
Reviewed-by: Partha Basak
Acked-by: Felipe Balbi
Acked-by: Samuel Ortiz
Signed-off-by: Paul Walmsley -
device name usbhs clocks are changed from
usbhs-omap.0 to usbhs_omap; this is because
in the hwmod registration the device name is set
as usbhs_omap; The redudant clock nodes are removed.Signed-off-by: Keshava Munegowda
Reviewed-by: Partha Basak
Signed-off-by: Paul Walmsley
06 Sep, 2011
2 commits
-
The patch fixes the build failure:
drivers/mfd/omap-usb-host.c:1034:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1034:1: warning: type defaults to 'int' in
declaration of 'EXPORT_SYMBOL_GPL'
drivers/mfd/omap-usb-host.c:1034:1: warning: parameter names (without
types) in function declaration
drivers/mfd/omap-usb-host.c:1040:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1040:1: warning: type defaults to 'int' in
declaration of 'EXPORT_SYMBOL_GPL'
drivers/mfd/omap-usb-host.c:1040:1: warning: parameter names (without
types) in function declaration
drivers/mfd/omap-usb-host.c:1045:13: error: 'THIS_MODULE' undeclared
here (not in a function)
drivers/mfd/omap-usb-host.c:1050:15: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1050:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1050:1: warning: type defaults to 'int' in
declaration of 'MODULE_AUTHOR'
drivers/mfd/omap-usb-host.c:1050:15: warning: function declaration isn't
a prototype
drivers/mfd/omap-usb-host.c:1051:14: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1051:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1051:1: warning: type defaults to 'int' in
declaration of 'MODULE_ALIAS'
drivers/mfd/omap-usb-host.c:1051:14: warning: function declaration isn't
a prototype
drivers/mfd/omap-usb-host.c:1052:16: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1052:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1052:1: warning: type defaults to 'int' in
declaration of 'MODULE_LICENSE'
drivers/mfd/omap-usb-host.c:1052:16: warning: function declaration isn't
a prototype
drivers/mfd/omap-usb-host.c:1053:20: error: expected declaration
specifiers or '...' before string constant
drivers/mfd/omap-usb-host.c:1053:1: warning: data definition has no type
or storage class
drivers/mfd/omap-usb-host.c:1053:1: warning: type defaults to 'int' in
declaration of 'MODULE_DESCRIPTION'
drivers/mfd/omap-usb-host.c:1053:20: warning: function declaration isn't
a prototype
make[2]: *** [drivers/mfd/omap-usb-host.o] Error 1
CC fs/proc/namespaces.o
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....Signed-off-by: Ming Lei
Signed-off-by: Samuel Ortiz -
This code section seems to have been accidentally copy pasted.
It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
register and prevents the TLL mode from working correctly.Cc: stable@kernel.org
Signed-off-by: Anand Gadiyar
Cc: Keshava Munegowda
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz
01 Aug, 2011
1 commit
-
usbhs_disable function was invoking clk_enable() instead of
clk_disable(), thus only increasing the clock usage counter and
preventing this particular clock from being ever turned off.
Because of this, the power domain of omap4 the USB Host subsystem
would never reach lower power states.This patch calls clk_disable()
in usbhs_disable functionSigned-off-by: Keshava Munegowda
Signed-off-by: Samuel Ortiz
05 Jul, 2011
1 commit
-
This reverts commit 7e6502d577106fb5b202bbaac64c5f1b065e6daa.
Oops are produced during initialization of ehci and ohci
drivers. This is because the run time pm apis are used by
the driver but the corresponding hwmod structures and
initialization is not merged. hence revering back the
commit id 7e6502d577106fb5b202bbaac64c5f1b065e6daaSigned-off-by: Keshava Munegowda
Reported-by: Luciano Coelho
Acked-by: Felipe Balbi
Signed-off-by: Samuel Ortiz
27 May, 2011
1 commit
-
The usbhs core driver does not enable/disable the interface and
functional clocks; These clocks are handled by hwmod and runtime pm,
hence insted of the clock enable/disable, the runtime pm APIS are
used. however,the port clocks and tll clocks are handled
by the usbhs core.Signed-off-by: Keshava Munegowda
Signed-off-by: Samuel Ortiz