Doug / smarc-fsl-linux-kernel

20 Nov, 2010

1 commit

18 Nov, 2010

1 commit

17 Nov, 2010

1 commit

12 Nov, 2010

1 commit

19 Aug, 2010

1 commit

  • 2244d07bf   net: simplify flags for tx timestamping ... Browse Code »

    This patch removes the abstraction introduced by the union skb_shared_tx in
    the shared skb data.

    The access of the different union elements at several places led to some
    confusion about accessing the shared tx_flags e.g. in skb_orphan_try().

    http://marc.info/?l=linux-netdev&m=128084897415886&w=2

    Signed-off-by: Oliver Hartkopp
    Signed-off-by: David S. Miller

    Oliver Hartkopp
     

13 Jul, 2010

1 commit

11 Jun, 2010

1 commit

10 Jun, 2010

1 commit

18 May, 2010

1 commit

  • 7fee226ad   net: add a noref bit on skb dst ... Browse Code »

    Use low order bit of skb->_skb_dst to tell dst is not refcounted.

    Change _skb_dst to _skb_refdst to make sure all uses are catched.

    skb_dst() returns the dst, regardless of noref bit set or not, but
    with a lockdep check to make sure a noref dst is not given if current
    user is not rcu protected.

    New skb_dst_set_noref() helper to set an notrefcounted dst on a skb.
    (with lockdep check)

    skb_dst_drop() drops a reference only if skb dst was refcounted.

    skb_dst_force() helper is used to force a refcount on dst, when skb
    is queued and not anymore RCU protected.

    Use skb_dst_force() in __sk_add_backlog(), __dev_xmit_skb() if
    !IFF_XMIT_DST_RELEASE or skb enqueued on qdisc queue, in
    sock_queue_rcv_skb(), in __nf_queue().

    Use skb_dst_force() in dev_requeue_skb().

    Note: dst_use_noref() still dirties dst, we might transform it
    later to do one dirtying per jiffies.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

12 Apr, 2010

1 commit

04 Apr, 2010

1 commit

  • 1f8438a85   icmp: Account for ICMP out errors ... Browse Code »

    When ip_append() fails because of socket limit or memory shortage,
    increment ICMP_MIB_OUTERRORS counter, so that "netstat -s" can report
    these errors.

    LANG=C netstat -s | grep "ICMP messages failed"
    0 ICMP messages failed

    For IPV6, implement ICMP6_MIB_OUTERRORS counter as well.

    # grep Icmp6OutErrors /proc/net/dev_snmp6/*
    /proc/net/dev_snmp6/eth0:Icmp6OutErrors 0
    /proc/net/dev_snmp6/lo:Icmp6OutErrors 0

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

23 Jan, 2010

1 commit

02 Nov, 2009

1 commit

05 Oct, 2009

1 commit

  • b3a5b6cc7   icmp: No need to call sk_write_space() ... Browse Code »

    We can make icmp messages tx completion callback a litle bit faster.

    Setting SOCK_USE_WRITE_QUEUE sk flag tells sock_wfree() to
    not call sk_write_space() on a socket we know no thread is posssibly
    waiting for write space. (on per cpu kernel internal icmp sockets only)

    This avoids the sock_def_write_space() call and
    read_lock(&sk->sk_callback_lock)/read_unlock(&sk->sk_callback_lock) calls
    as well.

    We avoid three atomic ops.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

15 Sep, 2009

1 commit

03 Jun, 2009

2 commits

  • adf30907d   net: skb->dst accessors ... Browse Code »

    Define three accessors to get/set dst attached to a skb

    struct dst_entry *skb_dst(const struct sk_buff *skb)

    void skb_dst_set(struct sk_buff *skb, struct dst_entry *dst)

    void skb_dst_drop(struct sk_buff *skb)
    This one should replace occurrences of :
    dst_release(skb->dst)
    skb->dst = NULL;

    Delete skb->dst field

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • 511c3f92a   net: skb->rtable accessor ... Browse Code »

    Define skb_rtable(const struct sk_buff *skb) accessor to get rtable from skb

    Delete skb->rtable field

    Setting rtable is not allowed, just set dst instead as rtable is an alias.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

23 Feb, 2009

1 commit

  • 959d27264   netns: Fix icmp shutdown. ... Browse Code »

    Recently I had a kernel panic in icmp_send during a network namespace
    cleanup. There were packets in the arp queue that failed to be sent
    and we attempted to generate an ICMP host unreachable message, but
    failed because icmp_sk_exit had already been called.

    The network devices are removed from a network namespace and their
    arp queues are flushed before we do attempt to shutdown subsystems
    so this error should have been impossible.

    It turns out icmp_init is using register_pernet_device instead
    of register_pernet_subsys. Which resulted in icmp being shut down
    while we still had the possibility of packets in flight, making
    a nasty NULL pointer deference in interrupt context possible.

    Changing this to register_pernet_subsys fixes the problem in
    my testing.

    Signed-off-by: Eric W. Biederman
    Acked-by: Denis V. Lunev
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

16 Feb, 2009

1 commit

26 Nov, 2008

1 commit

  • 52479b623   netns xfrm: lookup in netns ... Browse Code »

    Pass netns to xfrm_lookup()/__xfrm_lookup(). For that pass netns
    to flow_cache_lookup() and resolver callback.

    Take it from socket or netdevice. Stub DECnet to init_net.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     

25 Nov, 2008

1 commit

  • 2e77d89b2   net: avoid a pair of dst_hold()/dst_release() in ip_append_data() ... Browse Code »

    We can reduce pressure on dst entry refcount that slowdown UDP transmit
    path on SMP machines. This pressure is visible on RTP servers when
    delivering content to mediagateways, especially big ones, handling
    thousand of streams. Several cpus send UDP frames to the same
    destination, hence use the same dst entry.

    This patch makes ip_append_data() eventually steal the refcount its
    callers had to take on the dst entry.

    This doesnt avoid all refcounting, but still gives speedups on SMP,
    on UDP/RAW transmit path

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

31 Oct, 2008

1 commit

29 Oct, 2008

1 commit

14 Oct, 2008

1 commit

  • 113aa838e   net: Rationalise email address: Network Specific Parts ... Browse Code »

    Clean up the various different email addresses of mine listed in the code
    to a single current and valid address. As Dave says his network merges
    for 2.6.28 are now done this seems a good point to send them in where
    they won't risk disrupting real changes.

    Signed-off-by: Alan Cox
    Signed-off-by: David S. Miller

    Alan Cox
     

23 Aug, 2008

1 commit

  • fdc0bde90   icmp: icmp_sk() should not use smp_processor_id() in preemptible code ... Browse Code »

    Pass namespace into icmp_xmit_lock, obtain socket inside and return
    it as a result for caller.

    Thanks Alexey Dobryan for this report:

    Steps to reproduce:

    CONFIG_PREEMPT=y
    CONFIG_DEBUG_PREEMPT=y
    tracepath

    BUG: using smp_processor_id() in preemptible [00000000] code: tracepath/3205
    caller is icmp_sk+0x15/0x30
    Pid: 3205, comm: tracepath Not tainted 2.6.27-rc4 #1

    Call Trace:
    [] debug_smp_processor_id+0xe4/0xf0
    [] icmp_sk+0x15/0x30
    [] icmp_send+0x4b/0x3f0
    [] ? trace_hardirqs_on_caller+0xd5/0x160
    [] ? trace_hardirqs_on+0xd/0x10
    [] ? local_bh_enable_ip+0x95/0x110
    [] ? _spin_unlock_bh+0x39/0x40
    [] ? mark_held_locks+0x4c/0x90
    [] ? trace_hardirqs_on+0xd/0x10
    [] ? trace_hardirqs_on_caller+0xd5/0x160
    [] ip_fragment+0x8d4/0x900
    [] ? ip_finish_output2+0x0/0x290
    [] ? ip_finish_output+0x0/0x60
    [] ? dst_output+0x0/0x10
    [] ip_finish_output+0x4c/0x60
    [] ip_output+0xa3/0xf0
    [] ip_local_out+0x20/0x30
    [] ip_push_pending_frames+0x27f/0x400
    [] udp_push_pending_frames+0x233/0x3d0
    [] udp_sendmsg+0x321/0x6f0
    [] inet_sendmsg+0x45/0x80
    [] sock_sendmsg+0xdf/0x110
    [] ? autoremove_wake_function+0x0/0x40
    [] ? validate_chain+0x415/0x1010
    [] ? __do_fault+0x140/0x450
    [] ? __lock_acquire+0x260/0x590
    [] ? sockfd_lookup_light+0x45/0x80
    [] sys_sendto+0xea/0x120
    [] ? _spin_unlock_irqrestore+0x42/0x80
    [] ? __up_read+0x4c/0xb0
    [] ? up_read+0x26/0x30
    [] system_call_fastpath+0x16/0x1b

    icmp6_sk() is similar.

    Signed-off-by: Denis V. Lunev
    Signed-off-by: David S. Miller

    Denis V. Lunev
     

18 Jul, 2008

2 commits

15 Jul, 2008

6 commits

12 Jun, 2008

1 commit

29 Apr, 2008

1 commit

21 Apr, 2008

2 commits

14 Apr, 2008

2 commits