08 Jan, 2011
1 commit
-
* 'mce-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp:
EDAC, MCE: Fix NB error formatting
EDAC, MCE: Use BIT_64() to eliminate warnings on 32-bit
EDAC, MCE: Enable MCE decoding on F15h
EDAC, MCE: Allow F15h bank 6 MCE injection
EDAC, MCE: Shorten error report formatting
EDAC, MCE: Overhaul error fields extraction macros
EDAC, MCE: Add F15h FP MCE decoder
EDAC, MCE: Add F15 EX MCE decoder
EDAC, MCE: Add an F15h NB MCE decoder
EDAC, MCE: No F15h LS MCE decoder
EDAC, MCE: Add F15h CU MCE decoder
EDAC, MCE: Add F15h IC MCE decoder
EDAC, MCE: Add F15h DC MCE decoder
EDAC, MCE: Select extended error code mask
07 Jan, 2011
31 commits
-
Minor formatting fixup since the information which core was associated
with the MCE is not always valid.Signed-off-by: Borislav Petkov
-
Building for X86_32 produces shift count warnings, so use BIT_64() to
eliminate the warnings.drivers/edac/mce_amd.c:778: warning: left shift count >= width of type
drivers/edac/mce_amd.c:778: warning: left shift count >= width of typeSigned-off-by: Randy Dunlap
Cc: Doug Thompson
Cc: bluesmoke-devel@lists.sourceforge.net
Signed-off-by: Borislav Petkov -
Now that everything is inplace, enable MCE decoding on F15h. Make
initcall routine a bit more readable.Signed-off-by: Borislav Petkov
-
F15h adds a sixth MCE bank: adjust bank number check in the injection
code.Signed-off-by: Borislav Petkov
-
Shorten up MCi_STATUS flags and add BD's new deferred and poison types.
Also, simplify formatting.Signed-off-by: Borislav Petkov
-
Make macro names shorter thus making code shorter and more clear.
Signed-off-by: Borislav Petkov
-
Add decoder for FP MCEs.
Signed-off-by: Borislav Petkov
-
Integrate the single FIROB signature into an expanded table along with
the new BD MCE types.Signed-off-by: Borislav Petkov
-
by (almost) reusing the F10h one since the signatures are the same.
Signed-off-by: Borislav Petkov
-
F15h BD doesn't generate LS MCEs so warn about it.
Signed-off-by: Borislav Petkov
-
MCE bank 2 is redefined from a BU to a CU (Combined Unit) bank on F15h.
Add a decoder function for CU MCEs.Signed-off-by: Borislav Petkov
-
Add support for decoding F15h IC MCEs.
Signed-off-by: Borislav Petkov
-
Add a decoder for F15h DC MCEs to support the new types of DC MCEs
introduced by the BD microarchitecture.Signed-off-by: Borislav Petkov
-
F15h enlarges the extended error code of an MCE to a 5-bit field
(MCi_STATUS[20:16]). Add a mask variable which default 0xf is overridden
on F15h.Signed-off-by: Borislav Petkov
-
K8 does not allow for an atomic RMW to a cacheline as F10h does so
disable the error injection interface for it.Signed-off-by: Borislav Petkov
-
Make the ->{get|set}_sdram_scrub_rate return the actual scrub rate
bandwidth it succeeded setting and remove superfluous arg pointer used
for that. A negative value returned still means that an error occurred
while setting the scrubrate. Document this for future reference.Signed-off-by: Borislav Petkov
-
Now that all prerequisites are in place, drop the two-stage driver
instances initialization in favor of the following simple init sequence:1. Probe PCI device: we only test ECC capabilities here and if none exit
early.2. If the hw supports ECC and it is/can be enabled, we init the per-node
instance.Remove "amd64_" prefix from static functions touched, while at it.
There actually should be no visible functional change resulting from
this patch.Signed-off-by: Borislav Petkov
-
Rework the code to check the hardware ECC capabilities at PCI probing
time. We do all further initialization only if we actually can/have ECC
enabled.While at it:
0. Fix function naming.
1. Simplify/clarify debug output.
2. Remove amd64_ prefix from the static functions
3. Reorganize code.Signed-off-by: Borislav Petkov
-
This is in preparation for the init path reorganization where we want
only to1) test whether a particular node supports ECC
2) can it be enabledand only then do the necessary allocation/initialization. For that,
we need to decouple the ECC settings of the node from the instance's
descriptor.The should be no functional change introduced by this patch.
Signed-off-by: Borislav Petkov
-
PCI ECS is being enabled by default since 2.6.26 on AMD so this code is
just superfluous now, remove it.Signed-off-by: Borislav Petkov
-
AMD_NB pulls in the dependency on PCI. Clarify/fix help text while at it.
Signed-off-by: Borislav Petkov
-
Remove static allocation in favor of dynamically allocating space for as
many driver instances as northbridges present on the system.There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
-
Add a macro per printk level, shorten up error messages. Add relevant
information to KERN_INFO level. No functional change.Signed-off-by: Borislav Petkov
-
Rename variables representing PCI devices to their BKDG names for faster
search and shorter, clearer code.Signed-off-by: Borislav Petkov
-
Move the remaining per-family init code into the proper place and
simplify the rest of the initialization. Reorganize error handling in
amd64_init_one_instance().Signed-off-by: Borislav Petkov
-
Shorten code and clarify comments, return proper -E* values on error.
Signed-off-by: Borislav Petkov
-
Concentrate CPU family detection in the per-family init function.
Signed-off-by: Borislav Petkov
-
Run a per-family init function which does all the settings based on
the family this driver instance is running on. Move the scrubrate
calculation in it and simplify code.Signed-off-by: Borislav Petkov
-
... instead of computing it needlessly again.
Signed-off-by: Borislav Petkov
-
F11h doesn't support DRAM ECC so whack it away.
Signed-off-by: Borislav Petkov
-
…/git/tip/linux-2.6-tip
* 'x86-amd-nb-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
x86, cacheinfo: Cleanup L3 cache index disable support
x86, amd-nb: Cleanup AMD northbridge caching code
x86, amd-nb: Complete the rename of AMD NB and related code
09 Dec, 2010
3 commits
-
When matching error address to the range contained by one memory node,
we're in valid range when node interleaving1. is disabled, or
2. enabled and when the address bits we interleave on match the
interleave selector on this node (see the "Node Interleaving" section in
the BKDG for an enlightening example).Thus, when we early-exit, we need to reverse the compound logic
statement properly.Cc:
Signed-off-by: Borislav Petkov -
This corrects the misprint introduced when moving '#if
PAGE_SHIFT' from i7core_edac.c to edac_core.h (commit
e9144601d364d5b81f3e63949337f8507eb58dca)Cc: Mauro Carvalho Chehab
Signed-off-by: Andrei Konovalov
Signed-off-by: Borislav Petkov -
00740c58541b6087d78418cebca1fcb86dc6077d changed edac_core to
un-/register a workqueue item only if a lowlevel driver supplies a
polling routine. Normally, when we remove a polling low-level driver, we
go and cancel all the queued work. However, the workqueue unreg happens
based on the ->op_state setting, and edac_mc_del_mc() sets this to
OP_OFFLINE _before_ we cancel the work item, leading to NULL ptr oops on
the workqueue list.Fix it by putting the unreg stuff in proper order.
Cc: #36.x
Reported-and-tested-by: Tobias Karnat
LKML-Reference:
Signed-off-by: Borislav Petkov
22 Nov, 2010
2 commits
-
Otherwise, variable i will be -1 inside the latest iteration of the
while loop.Signed-off-by: Axel Lin
Signed-off-by: Borislav Petkov -
Change EDAC's Makefile to use -y instead of
-objs because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.[bp: Fixup commit message]
[bp: Fixup indentation]Signed-off-by: Tracey Dent
Signed-off-by: Borislav Petkov
18 Nov, 2010
2 commits
-
Support more than just the "Misc Control" part of the northbridges.
Support more flags by turning "gart_supported" into a single bit flag
that is stored in a flags member. Clean up related code by using a set
of functions (amd_nb_num(), amd_nb_has_feature() and node_to_amd_nb())
instead of accessing the NB data structures directly. Reorder the
initialization code and put the GART flush words caching in a separate
function.Signed-off-by: Hans Rosenfeld
Signed-off-by: Borislav Petkov -
Not only the naming of the files was confusing, it was even more so for
the function and variable names.Renamed the K8 NB and NUMA stuff that is also used on other AMD
platforms. This also renames the CONFIG_K8_NUMA option to
CONFIG_AMD_NUMA and the related file k8topology_64.c to
amdtopology_64.c. No functional changes intended.Signed-off-by: Hans Rosenfeld
Signed-off-by: Borislav Petkov
27 Oct, 2010
1 commit
-
* 'linux_next' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/i7core: (34 commits)
i7core_edac: return -ENODEV when devices were already probed
i7core_edac: properly terminate pci_dev_table
i7core_edac: Avoid PCI refcount to reach zero on successive load/reload
i7core_edac: Fix refcount error at PCI devices
i7core_edac: it is safe to i7core_unregister_mci() when mci=NULL
i7core_edac: Fix an oops at i7core probe
i7core_edac: Remove unused member channels in i7core_pvt
i7core_edac: Remove unused arg csrow from get_dimm_config
i7core_edac: Reduce args of i7core_register_mci
i7core_edac: Introduce i7core_unregister_mci
i7core_edac: Use saved pointers
i7core_edac: Check probe counter in i7core_remove
i7core_edac: Call pci_dev_put() when alloc_i7core_dev() failed
i7core_edac: Fix error path of i7core_register_mci
i7core_edac: Fix order of lines in i7core_register_mci
i7core_edac: Always do get/put for all devices
i7core_edac: Introduce i7core_pci_ctl_create/release
i7core_edac: Introduce free_i7core_dev
i7core_edac: Introduce alloc_i7core_dev
i7core_edac: Reduce args of i7core_get_onedevice
...