03 Sep, 2013
25 commits
-
Signed-off-by: Jan Vesely
Acked-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
This patch updates the firmware to address the thermal notification issue
Signed-off-by: Rasesh Mody
Signed-off-by: James Bottomley -
This is a new driver for ATTO Technology's ExpressSAS series of hardware RAID
adapters. It supports the following adapters:- ExpressSAS R60F
- ExpressSAS R680
- ExpressSAS R608
- ExpressSAS R644Signed-off-by: Bradley Grove
Signed-off-by: James Bottomley -
Smatch complains that the reg_IRQ[] array only has MAXIRQ (16) elements
so we are one space beyond the end of the array here.Signed-off-by: Dan Carpenter
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Return error from function qla4_8xxx_collect_md_data()
if minidump data collection fails.Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Signed-off-by: Santosh Vernekar
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Add pex-dma support for ISP8324 and ISP8042 to improve
the minidump capture time.Signed-off-by: Santosh Vernekar
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Enabling the data router support by default
can increase performance in certain situations.
It is safe to do so and tolerated in LPAR and under z/VM
in case there is no data router support in that environment.Signed-off-by: Steffen Maier
Reviewed-by: Martin Peschke
Signed-off-by: James Bottomley -
Get rid of unused function zfcp_fsf_get_req and corresponding
prototype definition.Commit a54ca0f62f953898b05549391ac2a8a4dad6482b in v2.6.28
"[SCSI] zfcp: Redesign of the debug tracing for HBA records."
accidentally introduced this code which was dead in the first place.Signed-off-by: Martin Peschke
Signed-off-by: Steffen Maier
Signed-off-by: James Bottomley -
strict_strtoul and friends are obsolete. Use kstrtoul functions
instead.Signed-off-by: Martin Peschke
Signed-off-by: Steffen Maier
Signed-off-by: James Bottomley -
minor cleanup for status read request
Signed-off-by: Martin Peschke
Signed-off-by: Steffen Maier
Signed-off-by: James Bottomley -
Added a driver module parameter max_msix_vectors. Using this module parameter
the maximum number of MSI-X vectors could be set.The number of MSI-X vectors used would be the minimum of MSI-X vectors
supported by the HBA, the number of CPU cores and the value set to
max_msix_vectors module parameter.The default value of this module parameter is set to 8. The default value of
this parameter is set to 8 inorder to reduce the amount of memory required for
Reply Descriptor Post queue. This is because with the higher MSI-X vectors,
some times kernel is not able to allocate the requested amount of memory and
crash is observed. To overcome this problem, the default value is set to 8.Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
While loopback diagnostic is in progress, disable the ACB which resets
all the active connections to target. Disable ACB would filter out all
the DHCP multicast and broadcast packets which otherwise cause the
diagnostic test to take longer time to complete or failures in some
other cases.Signed-off-by: Nilesh Javali
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
… LUN 0 configured expander
With some enclosures when LUN 0 is not created but LUN 1 or LUN X is created
then SCSI scan procedure calls target_alloc, slave_alloc call back functions
for LUN 0 and slave_destory() for same LUN 0.In these kind of cases within slave_destroy, pointer to scsi_target in
_sas_device structure is set to NULL, following which when slave_alloc for
LUN 1 is called then starget would not be set properly for this LUN.
So, scsi_target pointer pointing to NULL value would lead to a crash later
in the discovery procedure.To solve this issue set the sas_device's scsi_target pointer to scsi_device's
scsi_target if it is NULL earlier in slave_alloc callback function.Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@lsi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com> -
…removed but their transport layer entries are not removed
When Async scanning mode is enabled and device scanning is in progress then
devices should not be removed. But in actuality, devices are removed but
their transport layer entries are not removed. This causes error to add
the same device to the transport layer after host reset or diagnostic
reset.So, in this patch, modified the code in such a way that device is not removed
when Async scanning mode is enabled and device scanning is in progress.Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@lsi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com> -
Infinite loop can occur if IOCStatus is not equal to
MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions
_scsih_search_responding_sas_devices,
_scsih_search_responding_raid_devices and
_scsih_search_responding_expandersSo, Instead of checking for MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value,
in this patch code is modified to check for IOCStatus not equals to
MPI2_IOCSTATUS_SUCCESS to break the while loop.Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
The copyright in driver sources is updated for the year 2013.
Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
Change set in MPI2 Rev x specification and 2.00.26 header files
1. Added two new AbortType values for TargetModeAbort Request: one to abort
all IOs from a single initiator and other to abort only Command IUs.2. Added Use Slot Information during Port Enable Event Reply flag to the Flags
field of Manufacturing Page 7.3. Added OEM Identifier to BiosOptions bits of BIOS Page 1.
Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
The intent of this patch is to perform a graceful shutdown of target drives even if
volume doesn't exits. Changes done in this patch1. Removed the check for the presence of volumes before sending down
MPI2_RAID_ACTION_SYSTEM_SHUTDOWN_INITIATED. Therefore, this RAID action
would be sent if the card is IR Firmware.2. The MPI2_RAID_ACTION_SYSTEM_SHUTDOWN_INITIATED is sent even when the
system undergoes suspend (in addition to remove/shutdown which was already
present)Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
Added a check to identify if mpi_reply is NULL in mpt2sas_ctl_event_callback()
and return without proceeding if it is the case.Also modified the following functions to return void instead of 0 or 1
as returning those values from events perspective doesn't make sense.
* _base_async_event()
* mpt2sas_ctl_event_callback()
* mpt2sas_scsih_event_callback()Signed-off-by: Sreekanth Reddy
Signed-off-by: James Bottomley
26 Aug, 2013
15 commits
-
section Signed-off-by: John Kacur
On a 3.6-rt (real-time patch) kernel we are seeing the following BUG
However, it appears to be relevant for non-realtime (mainline) as well.[ 49.688847] hpsa 0000:03:00.0: hpsa0: at IRQ 67 using DAC
[ 49.749928] scsi0 : hpsa
[ 49.784437] BUG: using smp_processor_id() in preemptible [00000000
00000000] code: kworker/u:0/6
[ 49.784465] caller is enqueue_cmd_and_start_io+0x5a/0x100 [hpsa]
[ 49.784468] Pid: 6, comm: kworker/u:0 Not tainted
3.6.11.5-rt37.52.el6rt.x86_64.debug #1
[ 49.784471] Call Trace:
[ 49.784512] [] debug_smp_processor_id+0x123/0x150
[ 49.784520] [] enqueue_cmd_and_start_io+0x5a/0x100
[hpsa]
[ 49.784529] []
hpsa_scsi_do_simple_cmd_core+0xeb/0x110 [hpsa]
[ 49.784537] [] ? swiotlb_dma_mapping_error+0x18/0x30
[ 49.784544] [] ? swiotlb_dma_mapping_error+0x18/0x30
[ 49.784553] []
hpsa_scsi_do_simple_cmd_with_retry+0x91/0x280 [hpsa]
[ 49.784562] []
hpsa_scsi_do_report_luns.clone.2+0xd8/0x130 [hpsa]
[ 49.784571] []
hpsa_gather_lun_info.clone.3+0x3a/0x1a0 [hpsa]
[ 49.784580] [] hpsa_update_scsi_devices+0x11f/0x4f0
[hpsa]
[ 49.784592] [] ? sub_preempt_count+0xa9/0xe0
[ 49.784601] [] hpsa_scan_start+0xfd/0x150 [hpsa]
[ 49.784613] [] ? rt_spin_lock_slowunlock+0x78/0x90
[ 49.784626] [] do_scsi_scan_host+0x37/0xa0
[ 49.784632] [] do_scan_async+0x1a/0x30
[ 49.784643] [] async_run_entry_fn+0x9b/0x1d0
[ 49.784655] [] process_one_work+0x1f2/0x620
[ 49.784661] [] ? process_one_work+0x180/0x620
[ 49.784668] [] ? worker_thread+0x5e/0x3a0
[ 49.784674] [] ? async_schedule+0x20/0x20
[ 49.784681] [] worker_thread+0x133/0x3a0
[ 49.784688] [] ? manage_workers+0x190/0x190
[ 49.784696] [] kthread+0xa6/0xb0
[ 49.784707] [] kernel_thread_helper+0x4/0x10
[ 49.784715] [] ? finish_task_switch+0x8c/0x110
[ 49.784721] [] ? _raw_spin_unlock_irq+0x3b/0x70
[ 49.784727] [] ? retint_restore_args+0xe/0xe
[ 49.784734] [] ? kthreadd+0x1e0/0x1e0
[ 49.784739] [] ? gs_change+0xb/0xb-------------------
This is caused by
enqueue_cmd_and_start_io()->
set_performant_mode()->
smp_processor_id()
Which if you have debugging enabled calls debug_processor_id() and triggers the warning.The code here is
c->Header.ReplyQueue = smp_processor_id() % h->nreply_queues;Since it is not critical that the code complete on the same processor,
but the cpu is a hint used in generating the ReplyQueue and will still work if
the cpu migrates or is preempted, it is safe to use the raw_smp_processor_id()
to surpress the false positve warning.Signed-off-by: John Kacur
Acked-by: Stephen Cameron
Signed-off-by: James Bottomley -
To run discovery over iSER we need to advertize the CAP_TEXT_NEGO capability
towards user space. Also need to make sure the login RX buffer is posted when
SendTargets TEXT PDUs are sent. For that end, we use a setting of the
ISCSI_PARAM_DISCOVERY_SESS iscsi param as an indication that this is
discovery session.Signed-off-by: Or Gerlitz
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
PCI core will initialize device MSI/MSI-X capability in
pci_msi_init_pci_dev(). So device driver should use
pci_dev->msi_cap/msix_cap to determine whether the device
support MSI/MSI-X instead of using
pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
Access to PCIe device config space again will consume more time.Signed-off-by: Yijing Wang
Acked-by: lindar_liu
Signed-off-by: James Bottomley -
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Signed-off-by: James Bottomley -
If mpt3sas_base_map_resources takes an early error path then its
counterpart, mpt3sas_base_free_resources needs to be careful about
cleaning up:1 - _base_mask_interrupts and _base_make_ioc_ready require memory
mapped I/O registers, make sure that this is true.2 - _base_free_irq iterates over the adapter's reply_queue_list, so
move this list head initialization out of _base_enable_msix to
_scsih_probe so this will always be safe.3 - check that the controller PCI device and its BARs have been
enabled before disabling them.Signed-off-by: Joe Lawrence
Acked-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
If mpt2sas_base_map_resources takes an early error path then its
counterpart, mpt2sas_base_free_resources needs to be careful about
cleaning up:1 - _base_mask_interrupts and _base_make_ioc_ready require memory
mapped I/O registers, make sure that this is true.2 - _base_free_irq iterates over the adapter's reply_queue_list, so
move this list head initialization out of _base_enable_msix to
_scsih_probe so this will always be safe.3 - check that the controller PCI device and its BARs have been
enabled before disabling them.Signed-off-by: Joe Lawrence
Acked-by: Sreekanth Reddy
Signed-off-by: James Bottomley -
Generate a uevent when the following Unit Attention ASC/ASCQ
codes are received:2A/01 MODE PARAMETERS CHANGED
2A/09 CAPACITY DATA HAS CHANGED
38/07 THIN PROVISIONING SOFT THRESHOLD REACHED
3F/03 INQUIRY DATA HAS CHANGED
3F/0E REPORTED LUNS DATA HAS CHANGEDLog kernel messages when the following Unit Attention ASC/ASCQ
codes are received that are not as specific as those above:2A/xx PARAMETERS CHANGED
3F/xx TARGET OPERATING CONDITIONS HAVE CHANGEDAdded logic to set expecting_lun_change for other LUNs on the target
after REPORTED LUNS DATA HAS CHANGED is received, so that duplicate
uevents are not generated, and clear expecting_lun_change when a
REPORT LUNS command completes, in accordance with the SPC-3
specification regarding reporting of the 3F 0E ASC/ASCQ UA.[jejb: remove SPC3 test in scsi_report_lun_change and some docbook fixes and
unused variable fix, both reported by Fengguang Wu]
Signed-off-by: Ewan D. Milne
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Add the appropriate definitions and table entries for new adapter support.
Signed-off-by: Wen Xiong
Signed-off-by: James Bottomley -
Signed-off-by: Tomas Henzl
Acked-by: Stephen M. Cameron
Signed-off-by: James Bottomley -
When the driver calls scsi_done and after that frees it's internal
preallocated memory it can happen that a new job is enqueud before
the memory is freed. The allocation fails and the message
"cmd_alloc returned NULL" is shown.
Patch below fixes it by moving cmd->scsi_done after cmd_free.Signed-off-by: Tomas Henzl
Acked-by: Stephen M. Cameron
Signed-off-by: James Bottomley -
It seems the "phy_index++;" have been placed in wrong place, without it
the while circle up will do a infinite loop.Signed-off-by: Xinghai Yu
Acked-by: Lukasz Dorau
Signed-off-by: James Bottomley -
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.Signed-off-by: Wolfram Sang
Signed-off-by: Santosh Y
Signed-off-by: James Bottomley -
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.Signed-off-by: Wei Yongjun
Signed-off-by: Santosh Y
Signed-off-by: James Bottomley -
scsi_remove_host() sends SYNCHRONIZE CACHE commands for write cache
enabled scsi disk devices. So stopping controller working shouldn't
be done before scsi_remove_host().Signed-off-by: Akinobu Mita
Signed-off-by: Santosh Y
Signed-off-by: James Bottomley
