21 Jan, 2013
5 commits
-
Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes. This involved a lot
of logic in line6_variax_process_message() that has since been removed.Drop unused conditionals in line6_variax_process_message().
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman -
Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes. This involved a lot
of logic in line6_pod_process_message() that has since been removed.Drop unused conditionals in line6_pod_process_message() and reduce the
levels of indentation. Only two MIDI messages are still tracked: the
POD version message on startup and monitor level changes originating
from the device.Signed-off-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman -
The CONFIG_LINE6_USB_DUMP_PCM config option prints a hexdump of PCM
audio data as URBs are sent and received. The usbmon feature should be
used instead of manually dumping PCM URBs. There are a few advantages
to using usbmon:* Can be turned on/off at runtime
* Provides full USB-level traffic
* tcpdump and wireshark support for powerful analysis
* No driver-specific code is requiredThis is the last user of line6_write_hexdump() so we drop it too.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Greg Kroah-Hartman -
Formated pr_debug() calls
Signed-off-by: Sebastian Wankerl
Signed-off-by: Sebastian Ehrenfels
Signed-off-by: Greg Kroah-Hartman -
Enclose the macro into braces so that it can be closed by a semicolon
Signed-off-by: Sebastian Wankerl
Signed-off-by: Sebastian Ehrenfels
Signed-off-by: Greg Kroah-Hartman
19 Jan, 2013
35 commits
-
Fixed coding style error
Signed-off-by: Jake Champlin
Signed-off-by: Greg Kroah-Hartman -
[V2: no code changes, patchset now generated via git format-patch -M]
Fix unitialized variable in zcache which generates warning during build
Signed-off-by: Dan Magenheimer
Signed-off-by: Greg Kroah-Hartman -
In staging, re-enable config/build of zcache after ramster->zcache renaming.
Signed-off-by: Dan Magenheimer
Signed-off-by: Greg Kroah-Hartman -
[V2: no code changes, patchset now generated via git format-patch -M]
In staging/zcache, adjust config/build due to ramster->zcache renaming
Signed-off-by: Dan Magenheimer
Signed-off-by: Greg Kroah-Hartman -
[V2: no code changes, patchset now generated via git format-patch -M]
In staging, rename ramster to zcache
The original zcache in staging was a "demo" version, and this new zcache
is a significant rewrite. While certain disagreements were being resolved,
both "old zcache" and "new zcache" needed to reside in the staging tree
simultaneously. In order to minimize code change and churn, the newer
version of zcache was temporarily merged into the "ramster" staging driver
which, prior to that, had at one time heavily leveraged the older version
of zcache. So, recently, "new zcache" resided in the ramster directory.Got that? No? Sorry, temporary political compromises are rarely pretty.
The older version of zcache is no longer being maintained and has now
been removed from the staging tree. So now the newer version of zcache
can rightfully reclaim sole possession of the name "zcache".FYI, this [PATCH 2/5] is simply a "git mv" generated by "git format-patch -M".
Signed-off-by: Dan Magenheimer
Signed-off-by: Greg Kroah-Hartman -
[V2: no code changes, patchset now generated via git format-patch -M]
In staging, disable ramster build in anticipation of renaming to zcache
Signed-off-by: Dan Magenheimer
Signed-off-by: Greg Kroah-Hartman -
This function was originally in the addi-data "common" code and
required using pointer math to access the boardinfo data using
the void * 'dev->driver->board_name'. Now that the function is
local to this driver we can access the boardinfo directly and
remove the pointer math.Rename the function so it has namespace associated with this
driver.Also, for aesthetic reasons, globally rename the local variable used
for the boardinfo pointer from 'this_board' to 'board',Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
Currently this driver uses the struct addi_board from the addi-data
"common" code to define the boardinfo. This struct contains a lot
of information that is not used in this driver.Introduce a private struct in the driver that just contains the
needed information.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
Currently this driver uses the total number of channels, stored
in the boardinfo, in a number of the subdevice insn_* functions.
This information is already available in the subdevice as 's->n_chan'.
Use that instead of needing to get the board pointer first.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The comedi subdevice in this driver is a simple digital i/o
device.Currently, the code abuses the comedi API by redefining the
COMEDI_SUBD_SERIAL type as COMEDI_SUBD_TTLIO and using that
for the 's->type'. Remove the defines and use the proper type,
COMEDI_SUBD_DIO.The current code also sets the subdev_flags SDF_GROUND and SDF_COMMON
for the subdevice. These flags really only have meaning for analog
subdevices. Remove them.All the boards supported by this driver use the same functions for
the subdevice 'insn_*' operations. Remove this information from
the boardinfo and set the s->insn_* operations directly in the init.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The addi-data "common" code always allocated 7 subdevices. This
driver only uses 1. Change the allocation and remove the unused
subdevices.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
This information is not used in the driver. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The iobase address stored in devpriv->iobase is also stored in
dev->iobase. Use that instead.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
A lot of the comments in hwdrv_apci16xx.c have whitespace damage and
are simply unnecessary. Just remove them to make the code a bit more
readable.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have an eeprom. Knowing
this information allows simplifying the code that reads the PCI
bars to get the iobase addresses.The only 'iobase' actually used by this driver is found in PCI
bar 0. Don't bother reading the other PCI bars.Also, since 'dw_AiBase' is not ioremap'ed we can remove the check
and iounmap in the detach.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have any interrupt
capable devices. Remove the unused interrupt support code.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The 'reset' function for this driver doesn't do anything. Remove
it.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
Reading the eeprom on the boards supported by this driver is not
necessary. All the information required is in the boardinfo.Remove the eeprom support code since it's not really interesting
or useful.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have a timer subdevice.
Remove the subdevice init for it.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have digital outputs.
Remove the subdevice init for them.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have digital inputs.
Remove the subdevice init for them.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have analog outputs.
Remove the subdevice init for them.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The boards supported by this driver do not have analog inputs.
Remove the subdevice init for them.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
This driver is for two simple ttl digital output boards. One with
48 channels the other with 96. Using the addi-data "common" code
introduces a lot of bloat.Copy the code in addi_common.c to this driver and remove the #include
that caused addi_common.c to be compiled with this driver. This will
allow removing the bloat.Rename the auto_attach and detach functions so they have namespace
associated with this driver.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
Use the addi_watchdog module to provide support for the watchdog
subdevice.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
Many of the ADDI-DATA drivers have a "watchdog" subdevice that can
be used to monitor digital output activity. All the digital outputs
are released (set to 0) if the digital outputs are not accessed, or
the watchdog it not pinged, before the timeout of the watchdog
occurs. The only difference in the drivers for the watchdog subdevice
is the base address used to talk to the watchdog registers.Instead of duplicating the code needed to support this watchdog,
introduce a helper module, similar to the 8255 module. This module
will be select'ed by the drivers that can use it.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The board supported by this driver always has a digital output subdevice.
Remove the boardinfo for it and just open-code the relevant data in the
subdevice init.Remove the SDF_GROUND and SDF_COMMON from the subdevice 'subdev_flags'.
These flags only have meaning for analog input/output subdevices. Also,
remove the SDF_READABLE flag, it is not required by output only subdevices.Remove the subdevice 'len_chanlist' initialization. This variable only
has meaning for subdevices that support asynchronous commands.Remove the subdevice 'io_bits' initialization. Digital output subdevices
don't use this variable.Remove the subdevice function pointers that evaluate to NULL based on the
boardinfo data.Move the apci2200_do_insn_bits() function from the hwdrv_apci2200.c file
into the main driver file.For aesthetic reasons, rename the #define used for the register used to
read/write the digital outputs..Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The board supported by this driver always has a digital input subdevice.
Remove the boardinfo for it and just open-code the relevant data in the
subdevice init.Remove the SDF_GROUND and SDF_COMMON from the subdevice 'subdev_flags'.
These flags only have meaning for analog input/output subdevices.Remove the subdevice 'len_chanlist' initialization. This variable only
has meaning for subdevices that support asynchronous commands.Remove the subdevice 'io_bits' initialization. Digital input subdevices
don't use this variable.Remove the subdevice function pointers that evaluate to NULL based on the
boardinfo data.Move the apci2200_di_insn_bits() function from the hwdrv_apci2200.c file
into the main driver file.For aesthetic reasons, rename the #define used for the register used to
read the digital inputs.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
This board does not have any interrupt capable devices. Remove the
unused interrupt support code.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing it through devpriv->s_EeParameters.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
This driver only uses PCI bar 1 (dev->iobase), don't bother reading
the unused PCI bars.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The iobase address stored in devpriv->iobase is also stored in
dev->iobase. Use that instead.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
Remove the information from the boardinfo that was only needed to
work out the usage of the PCI bars.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
The board supported by this driver has a 93x76 eeprom. Knowing this
information allows simplifying the code that reads the PCI bars to
get the iobase addresses.Also, since the 'dw_AiBase' is not ioremap'ed we can remove the iounmap
in the detach.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman -
This is the only 'reset' function used by the driver, remove it
from the boardinfo and absorb the code from hwdrv_apci2200.c into
the driver.Rename the CamelCase function i_ADDI_Reset() to apci2200_reset().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Signed-off-by: Greg Kroah-Hartman
