Doug / smarc-fsl-linux-kernel

05 Apr, 2009

2 commits

  • 7d33ccbee   mfd: remove DS1WM clock handling ... Browse Code »

    This driver requests a clock that usually is supplied by the MFD in which
    the DS1WM is contained. Currently, it is impossible for a MFD to register
    their clocks with the generic clock API due to different implementations
    across architectures.
    For now, this patch removes the clock handling from DS1WM altogether,
    trusting that the MFD enable/disable functions will switch the clock if
    needed. The clock rate is obtained from a new parameter in driver_data.

    Signed-off-by: Philipp Zabel
    Signed-off-by: Samuel Ortiz

    Philipp Zabel
     
  • a23a17579   mfd: convert DS1WM to use MFD core ... Browse Code »

    This patch converts the DS1WM driver into an MFD cell. It also
    calculates the bus_shift parameter from the memory resource size.

    Signed-off-by: Philipp Zabel
    Signed-off-by: Samuel Ortiz

    Philipp Zabel
     

17 Oct, 2008

2 commits

  • cadd486cf   W1: ds1wm.c msleep for reset ... Browse Code »

    Like the previous w1_io.c reset coments and msleep patch, I don't have the
    hardware to verify the change, but I think it is safe. It also helps to
    see a comment like this in the code. "We'll wait a bit longer just to be
    sure." If they are going to calculate delaying 324.9us, but actually delay
    500us, why not just give up the CPU and sleep? This is designed for a
    battery powered ARM system, avoiding busywaiting has to be good for
    battery life.

    I sent a request for testers March 7, 2008 to the Linux kernel mailing
    list and two developers who have patches for ds1wm.c, but I didn't get
    any respons.

    Signed-off-by: David Fries
    Signed-off-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Fries
     
  • c30c9b151   W1: fix deadlocks and remove w1_control_thread ... Browse Code »

    w1_control_thread was removed which would wake up every second and process
    newly registered family codes and complete some final cleanup for a
    removed master. Those routines were moved to the threads that were
    previously requesting those operations. A new function
    w1_reconnect_slaves takes care of reconnecting existing slave devices when
    a new family code is registered or removed. The removal case was missing
    and would cause a deadlock waiting for the family code reference count to
    decrease, which will now happen. A problem with registering a family code
    was fixed. A slave device would be unattached if it wasn't yet claimed,
    then attached at the end of the list, two unclaimed slaves would cause an
    infinite loop.

    The struct w1_bus_master.search now takes a pointer to the struct
    w1_master device to avoid searching for it, which would have caused a
    lock ordering deadlock with the removal of w1_control_thread.

    Signed-off-by: David Fries
    Signed-off-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Fries
     

05 Mar, 2008

2 commits

  • daa49ff50   ds1wm: report bus reset error ... Browse Code »

    The patch replaces dev_dbg() by dev_err(), so the user could actually see the
    error, instead of wondering why w1 doesn't work. The root cause of the bus
    reset error isn't yet debugged though, but this sometimes happens on iPaq
    H5555.

    And while I'm at it, some cosmetic cleanups also made (few lines were using
    spaces instead of tabs).

    Signed-off-by: Anton Vorontsov
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anton Vorontsov
     
  • fbc357df2   ds1wm: should check for IS_ERR(clk) instead of NULL ... Browse Code »

    On the error condition clk_get() returns ERR_PTR(..), so checking for NULL
    doesn't work. ds1wm module causes a kernel oops when ds1wm clock isn't
    registered.

    This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
    for the return code.

    Signed-off-by: Anton Vorontsov
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anton Vorontsov
     

08 Feb, 2008

1 commit

  • 4aa323bd8   DS1WM: decouple host IRQ and INTR active state settings ... Browse Code »

    The DS1WM driver incorrectly infers the IAS bit (1-wire interrupt active
    high) from IRQ settings. There are devices that have IAS=0 but still need
    the IRQ to trigger on a rising edge. With this patch, machines with DS1WM
    that need IAS=1 have to set .active_high=1 in the ds1wm_platform_data.

    Signed-off-by: Philipp Zabel
    Acked-by: Evgeniy Polyakov
    Acked-by: Matt Reimer
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Philipp Zabel
     

19 Oct, 2007

1 commit

  • 898eb71cb   Add missing newlines to some uses of dev_<level> messages ... Browse Code »

    Found these while looking at printk uses.

    Add missing newlines to dev_ uses
    Add missing KERN_ prefixes to multiline dev_s
    Fixed a wierd->weird spelling typo
    Added a newline to a printk

    Signed-off-by: Joe Perches
    Cc: "Luck, Tony"
    Cc: Jens Axboe
    Cc: Mark M. Hoffman
    Cc: Roland Dreier
    Cc: Tilman Schmidt
    Cc: David Woodhouse
    Cc: Jeff Garzik
    Cc: Stephen Hemminger
    Cc: Greg KH
    Cc: Jeremy Fitzhardinge
    Cc: Geert Uytterhoeven
    Cc: Alessandro Zummo
    Cc: David Brownell
    Cc: James Smart
    Cc: Andrew Vasquez
    Cc: "Antonino A. Daplas"
    Cc: Evgeniy Polyakov
    Cc: Russell King
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     

27 Jul, 2007

1 commit

09 May, 2007

1 commit