01 Feb, 2006
7 commits
-
It was copy&pasted from tcp_v6_send_synack() which has
a DST leak recently fixed by Eric W. Biederman.So dccp_v6_send_response() needs the same fix too.
Signed-off-by: David S. Miller
-
This patch fix dst reference counting in tcp_v6_send_synack
Analysis:
Currently tcp_v6_send_synack is never called with a dst entry
so dst always comes in as NULL.ip6_dst_lookup calls ip6_route_output which calls dst_hold
before it returns the dst entry. Neither xfrm_lookup
nor tcp_make_synack consume the dst entry so we still have
a dst_entry with a bumped refrence count at the end of
this function.Therefore we need to call dst_release just before we return
just like tcp_v4_send_synack does.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
inet_bind_bucket_create was exported twice. Keep the export in the
file where inet_bind_bucket_create is defined.Signed-off-by: Sam Ravnborg
Signed-off-by: David S. Miller -
This is a simpler fix for the two races in bridge device removal.
The Xen race of delif and notify is managed now by a new deleted flag.
No need for barriers or other locking because of rtnl mutex.The del_timer_sync()'s are unnecessary, because br_stp_disable_port
delete's the timers, and they will finish running before RCU callback.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
ip_route_newports uses the struct flowi from the struct rtable returned
by ip_route_connect for the new route lookup and just replaces the port
numbers if they have changed. If an IPsec policy exists which doesn't match
port 0 the struct flowi won't have the proto field set and no xfrm lookup
is done for the changed ports.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Modern versions of gcc do not like case statements at the end of a block
statement: you need at least an empty statement. Using just a "break;"
is preferred for visual style.Signed-off-by: Linus Torvalds
31 Jan, 2006
5 commits
-
This fixes the accounting in H-TCP, the ccount variable is also
adjusted a few lines above this one.This line was not supposed to be there and wasn't there in the patches
originally submitted, the four patches submitted were merged to one
and in that merge the bug was introduced.Signed-Off-By: Baruch Even
Signed-off-by: David S. Miller -
This is easily triggerable by sending bogus packets,
allowing a malicious user to flood remote logs.Signed-off-by: Dave Jones
Signed-off-by: David S. Miller -
The number of HEARTBEAT chunks that an association may transmit is
limited by Association.Max.Retrans count; however, the code allows
us to send one extra heartbeat.This patch limits the number of heartbeats to the maximum count.
Signed-off-by: Vlad Yasevich
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
We currently count the initial INIT/COOKIE_ECHO chunk toward the
retransmit count and thus sends a total of sctp_max_retrans_init chunks.
The correct behavior is to retransmit the chunk sctp_max_retrans_init in
addition to sending the original.Signed-off-by: Vlad Yasevich
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
This patch, generated against 2.6.16-rc1-git4, corrects two typographical
errors in ieee80211_rx.c and adds the facility name to a bare printk.Signed-Off-By: Larry Finger
Signed-off-by: John W. Linville
28 Jan, 2006
2 commits
-
Limit the amount of output given to iwlist scan.
Signed-off-by: Hong Liu
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
The code for pulling the key to use for decrypt was correctly using
the host_mc_decrypt flag. The code that actually decrypted,
however, was based on host_decrypt. This patch changes this
behavior.Signed-off-by: Etay Bogner
Signed-off-by: James Ketrenos
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville
25 Jan, 2006
3 commits
-
The following patch fixes these problems in MLDv2:
1) Add/remove "delete" records for sending change reports when
addition of a filter results in that filter transitioning to/from
inactive. [same as recent IPv4 IGMPv3 fix]
2) Remove 2 redundant "group_type" checks (can't be IPV6_ADDR_ANY
within that loop, so checks are always true)
3) change an is_in() "return 0" to "return type == MLD2_MODE_IS_INCLUDE".
It should always be "0" to get here, but it improves code locality
to not assume it, and if some race allowed otherwise, doing
the check would return the correct result.Signed-off-by: David L Stevens
Signed-off-by: David S. Miller -
When returning a message to userspace in reply to a SADB_FLUSH or
SADB_X_SPDFLUSH message, the type was not set for the returned PFKEY
message. The patch below corrects this problem.Signed-off-by: Jerome Borsboom
Signed-off-by: David S. Miller -
This information is already available via /proc/net/bonding/*
therefore it doesn't make sense to require CAP_NET_ADMIN
privileges.Original patch by Laurent Deniel
Signed-off-by: Thomas Graf
Signed-off-by: David S. Miller
24 Jan, 2006
3 commits
-
On the error path if we allocated an fclone then we will free it in
the wrong pool.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller -
This fixes some whitespace issues in net/core/filter.c
Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller
20 Jan, 2006
1 commit
19 Jan, 2006
8 commits
-
EDAC requires a way to scrub memory if an ECC error is found and the chipset
does not do the work automatically. That means rewriting memory locations
atomically with respect to all CPUs _and_ bus masters. That means we can't
use atomic_add(foo, 0) as it gets optimised for non-SMPThis adds a function to include/asm-foo/atomic.h for the platforms currently
supported which implements a scrub of a mapped block.It also adjusts a few other files include order where atomic.h is included
before types.h as this now causes an error as atomic_scrub uses u32.Signed-off-by: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Allow mechanisms to return more varied errors on the context creation
downcall.Signed-off-by: J. Bruce Fields
Signed-off-by: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
We require the server's gssd to create a completed context before asking the
kernel to send a final context init reply. However, gssd could be buggy, or
under some bizarre circumstances we might purge the context from our cache
before we get the chance to use it here.Handle this case by returning GSS_S_NO_CONTEXT to the client.
Also move the relevant code here to a separate function rather than nesting
excessively.Signed-off-by: J. Bruce Fields
Signed-off-by: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Kerberos context initiation is handled in a single round trip, but other
mechanisms (including spkm3) may require more, so we need to handle the
GSS_S_CONTINUE case in svcauth_gss_accept. Send a null verifier.Signed-off-by: Andy Adamson
Signed-off-by: J. Bruce Fields
Signed-off-by: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
The server code currently keeps track of the destination address on every
request so that it can reply using the same address. However we forget to do
that in the case of a deferred request. Remedy this oversight. >From folks
at PolyServe.Signed-off-by: J. Bruce Fields
Signed-off-by: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
1) fix "mld_marksources()" to
a) send nothing when all queried sources are excluded
b) send full exclude report when source queried sources are
not excluded
c) don't schedule a timer when there's nothing to report2) fix "add_grec()" to send empty-source records when it should
The original check doesn't account for a non-empty source
list with all sources inactive; the new code keeps that
short-circuit case, and also generates the group header
with an empty list if needed.3) fix mca_crcount decrement to be after add_grec(), which needs
its original value4) add/remove delete records and prevent current advertisements
when an exclude-mode filter moves from "active" to "inactive"
or vice versa based on new filter additions.Items 1-3 are just IPv4 versions of the IPv6 bugs found
by Yan Zheng and fixed earlier. Item #4 is a related bug that
affects exclude-mode change records only (but not queries) and
also occurs in IPv6 (IPv6 version coming soon).Signed-off-by: David L Stevens
Signed-off-by: David S. Miller -
Don't assume 16.
Found by Ben Greear.
Signed-off-by: David S. Miller
18 Jan, 2006
11 commits
-
BUG: using smp_processor_id() in preemptible [00000001] code: rpc.statd/2408
And it _is_ a bug, but I guess we don't care enough to add preempt_disable().
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
This patch adds a tipc_ prefix to all externally visible symbols.
Signed-off-by: Per Liden
-
This is just a cosmetic change that moves the TIPC configuration
entry next to the other protocols that also have sub-options.
Makes the the networking options menu look a bit better.Signed-off-by: Per Liden
-
Signed-off-by: Per Liden
-
Signed-off-by: Per Liden
-
Signed-off-by: Per Liden
-
Added macros for min/default/max link priority in tipc_config.h.
Also renamed TIPC_NUM_LINK_PRI to TIPC_MEDIA_LINK_PRI since that
is a more accurate description of what it is used for.Signed-off-by: Per Liden
-
Signed-off-by: Jon Maloy
-
This replaces a memcmp() with is_zero_ether_addr().
Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller -
This replaces some tests with is_zero_ether_addr(), memcmp(one, two,
6) with compare_ether_addr(one, two), and 6 with ETH_ALEN where
appropriate.Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller -
Signed-off-by: Kris Katterjohn
Signed-off-by: David S. Miller
