06 Sep, 2012
1 commit
-
In most of the time, the driver needs to check if the cts flow control
is enabled. But now, the driver checks the ASYNC_CTS_FLOW flag manually,
which is not a grace way. So add a new wraper function to make the code
tidy and clean.Signed-off-by: Huang Shijie
Signed-off-by: Greg Kroah-Hartman
14 Aug, 2012
1 commit
-
Currently we have no way to assign tty->port while performing tty
installation. There are two ways to provide the link tty_struct =>
tty_port. Either by calling tty_port_install from tty->ops->install or
tty_port_register_device called instead of tty_register_device when
the device is being set up after connected.In this patch we modify most of the drivers to do the latter. When the
drivers use tty_register_device and we have tty_port already, we
switch to tty_port_register_device. So we have the tty_struct =>
tty_port link for free for those.Signed-off-by: Jiri Slaby
Acked-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
11 Aug, 2012
1 commit
-
The termios and other changes mean the other protections needed on the driver
tty arrays should be adequate. Turn it all back on.This contains pieces folded in from the fixes made to the original patches
| From: Geert Uytterhoeven (fix m68k)
| From: Paul Gortmaker (fix cris)
| From: Jiri Kosina (lockdep)
| From: Eric Dumazet (lockdep)Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
17 Jul, 2012
2 commits
-
This will let us sort out a whole pile of tty related races. The
alternative would be to keep points and refcount the termios objects.
However
1. They are tiny anyway
2. Many devices don't use the stored copies
3. We can remove a pty special caseSigned-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
I sent GregKH this after the pre-requisites. He dropped the pre-requesites
for good reason and unfortunately then applied this patch. Without this
reverted you get random kernel memory corruption which will make bisecting
anything between it and the properly applied patches a complete sod.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
07 Jul, 2012
1 commit
-
The termios and other changes mean the other protections needed on the driver
tty arrays should be adequate. Turn it all back on.This contains pieces folded in from the fixes made to the original patches
| From: Geert Uytterhoeven (fix m68k)
| From: Paul Gortmaker (fix cris)
| From: Jiri Kosina (lockdep)
| From: Eric Dumazet (lockdep)Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
13 Jun, 2012
1 commit
-
cy_pci_probe and cy_detect_isa reference cy_card[card_no] many times.
It makes the code hard to read. Let us add a local variable holding a
pointer to the card indexed by card_no and use that.Signed-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman
03 Jun, 2012
1 commit
-
This reverts the tty layer change to use per-tty locking, because it's
not correct yet, and fixing it will require some more deep surgery.The main revert is d29f3ef39be4 ("tty_lock: Localise the lock"), but
there are several smaller commits that built upon it, they also get
reverted here. The list of reverted commits is:fde86d310886 - tty: add lockdep annotations
8f6576ad476b - tty: fix ldisc lock inversion trace
d3ca8b64b97e - pty: Fix lock inversion
b1d679afd766 - tty: drop the pty lock during hangup
abcefe5fc357 - tty/amiserial: Add missing argument for tty_unlock()
fd11b42e3598 - cris: fix missing tty arg in wait_event_interruptible_tty call
d29f3ef39be4 - tty_lock: Localise the lockThe revert had a trivial conflict in the 68360serial.c staging driver
that got removed in the meantime.Signed-off-by: Linus Torvalds
05 May, 2012
1 commit
-
In each remaining case the tty_lock is associated with a specific tty. This
means we can now lock on a per tty basis. We do need tty_lock_pair() for
the pty case. Uglier but still a step in the right direction.[fixed up calls in 3 missing drivers - gregkh]
Signed-off-by: Alan Cox
Acked-by: Arnd Bergmann
Signed-off-by: Greg Kroah-Hartman
09 Mar, 2012
3 commits
-
Checking if tty->index is in bounds is not needed. The tty has the
index set in the initial open. This is done in get_tty_driver. And it
can be only in interval num).So remove the tests which check exactly this interval. Some are
left untouched as they check against the current backing device count.
(Leaving apart that the check is racy in most of the cases.)Signed-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman -
All num, magic and owner are set by alloc_tty_driver. No need to
re-set them on each allocation site.pti driver sets something different to what it passes to
alloc_tty_driver. It is not a bug, since we don't use the lines
parameter in any way. Anyway this is fixed, and now we do the right
thing.Signed-off-by: Jiri Slaby
Acked-by: Tilman Schmidt
Signed-off-by: Greg Kroah-Hartman -
TIOCSERGETLSR should be saved in a uint so the cast here to unsigned
long is a bug.Reported-by: Jiri Slaby
Signed-off-by: Dan Carpenter
Acked-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman
23 Sep, 2011
1 commit
-
Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).So now this flag is a NOOP and can be removed.
Signed-off-by: Yong Zhang
Acked-by: Tobias Klauser
Signed-off-by: Greg Kroah-Hartman
24 Aug, 2011
1 commit
-
It makes the code really ugly. And since it can be enabled only before
building and only in the source files, it can be barely used by users.
That said, I've not seen anybody to use it in the past few years.This crap is copied to some more drivers over the tty tree. Since I'm
not their maintainer, I'm not sure if I should remove them too?Signed-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman
27 May, 2011
1 commit
-
* 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6:
gfs2: Drop __TIME__ usage
isdn/diva: Drop __TIME__ usage
atm: Drop __TIME__ usage
dlm: Drop __TIME__ usage
wan/pc300: Drop __TIME__ usage
parport: Drop __TIME__ usage
hdlcdrv: Drop __TIME__ usage
baycom: Drop __TIME__ usage
pmcraid: Drop __DATE__ usage
edac: Drop __DATE__ usage
rio: Drop __DATE__ usage
scsi/wd33c93: Drop __TIME__ usage
scsi/in2000: Drop __TIME__ usage
aacraid: Drop __TIME__ usage
media/cx231xx: Drop __TIME__ usage
media/radio-maxiradio: Drop __TIME__ usage
nozomi: Drop __TIME__ usage
cyclades: Drop __TIME__ usage
20 Apr, 2011
2 commits
-
remove invalid location line in each file header after location
moved from driver/char to driver/ttySigned-off-by: Jovi Zhang
Signed-off-by: Greg Kroah-Hartman -
drivers/tty/cyclades.c:1454:2: warning: Value stored to 'channel' is never read
channel = info->line - card->first_line;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Fix it by moving it to the appropriate debug section where it is used.
Signed-off-by: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman
19 Apr, 2011
1 commit
-
The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.Acked-by: Greg Kroah-Hartman
Signed-off-by: Michal Marek
23 Feb, 2011
1 commit
-
As planned by Arnd Bergmann, this moves the following drivers from
drivers/char/ to drivers/tty/ as that's where they really belong:
amiserial
nozomi
synclink
rocket
cyclades
moxa
mxser
isicom
bfin_jtag_commCc: Arnd Bergmann
Cc: Alan Cox
Cc: Jiri Slaby
Signed-off-by: Greg Kroah-Hartman
