03 Apr, 2013

1 commit

  • of_get_mac_address() and of_get_phy_mode() are only provided if OF_NET
    is configured. While most callers check for the define, not all do, and those
    who do require #ifdef around the code. For those who don't, the missing check
    can result in errors such as

    arch/powerpc/sysdev/tsi108_dev.c:107:3: error: implicit declaration of
    function 'of_get_mac_address' [-Werror=implicit-function-declaration]
    arch/powerpc/sysdev/mv64x60_dev.c:253:2: error: implicit declaration of
    function 'of_get_mac_address' [-Werror=implicit-function-declaration]

    Provide empty functions if OF_NET is not configured.
    This is safe because all callers do check the return values.

    Cc: David Daney
    Signed-off-by: Guenter Roeck
    Acked-by: Rob Herring
    Signed-off-by: David S. Miller

    Guenter Roeck
     

27 Jul, 2011

1 commit


01 Nov, 2010

1 commit

  • There are two identical implementations of of_get_mac_address(), one
    each in arch/powerpc/kernel/prom_parse.c and
    arch/microblaze/kernel/prom_parse.c. Move this function to a new
    common file of_net.{c,h} and adjust all the callers to include the new
    header.

    Signed-off-by: David Daney
    [grant.likely@secretlab.ca: protect header with #ifdef]
    Signed-off-by: Grant Likely

    David Daney