05 Oct, 2013

1 commit

  • This reverts commit 07f9b61c3915e8eb156cb4461b3946736356ad02.

    07f9b61c was intended to be a cleanup that didn't change anything, but in
    fact, for systems without _CBA (which is almost everything), it broke
    extended config space for domain 0 and all config space for other domains.

    Reference: http://lkml.kernel.org/r/20131004011806.GE20450@dangermouse.emea.sgi.com
    Reported-by: Hedi Berriche
    Signed-off-by: Bjorn Helgaas

    Bjorn Helgaas
     

27 Jul, 2013

1 commit


12 Feb, 2013

1 commit

  • Add UV3 to exclusion list. Instead of adding every new series of
    SGI UV systems, just check oem_id to have a prefix of "SGI".

    Signed-off-by: Mike Travis
    Link: http://lkml.kernel.org/r/20130211194508.457937455@gulag1.americas.sgi.com
    Acked-by: Russ Anderson
    Reviewed-by: Dimitri Sivanich
    Cc: Jiang Liu
    Cc: Bjorn Helgaas
    Cc: Yinghai Lu
    Cc: Greg Kroah-Hartman
    Signed-off-by: H. Peter Anvin

    Mike Travis
     

04 Jan, 2013

1 commit

  • CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitconst,
    and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: Thomas Gleixner
    Cc: Ingo Molnar
    Cc: "H. Peter Anvin"
    Cc: Peter Zijlstra
    Cc: Daniel Drake
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

19 Sep, 2012

1 commit

  • Found by http://coccinelle.lip6.fr/

    Signed-off-by: Peter Senna Tschudin
    Cc: avi@redhat.com
    Cc: mtosatti@redhat.com
    Cc: a.p.zijlstra@chello.nl
    Cc: rusty@rustcorp.com.au
    Cc: masami.hiramatsu.pt@hitachi.com
    Cc: suresh.b.siddha@intel.com
    Cc: joerg.roedel@amd.com
    Cc: agordeev@redhat.com
    Cc: yinghai@kernel.org
    Cc: bhelgaas@google.com
    Cc: liuj97@gmail.com
    Link: http://lkml.kernel.org/r/1347986174-30287-7-git-send-email-peter.senna@gmail.com
    Signed-off-by: Ingo Molnar

    Peter Senna Tschudin
     

23 Jun, 2012

8 commits


03 Jun, 2011

1 commit


22 May, 2011

1 commit

  • On various newer Intel systems the PCI bus(ses) the non-core devices
    live on aren't getting announced by ACPI except through the bus range
    covered by mmconfig. At least the i7core-edac driver depends on these
    devices getting detected.

    Mauro, could you check whether with this change the Xeon 55xx hack in
    that driver can go away altogether, and with it the bogus exporting of
    pcibios_scan_specific_bus()?

    Signed-off-by: Jan Beulich
    Cc: Mauro Carvalho Chehab
    Cc: Aristeu Sergio
    Signed-off-by: Jesse Barnes

    Jan Beulich
     

18 Oct, 2010

1 commit

  • The end of an MMCONFIG region depends on the ending bus number, not on the
    number of buses the region covers. We previously computed the wrong ending
    address whenever the starting bus number was non-zero, e.g.,:

    MMCONFIG for [bus 00-1f] at [mem 0xe0000000-0xe1ffffff] (base 0xe0000000)
    MMCONFIG for [bus 20-3f] at [mem 0xe2000000-0xe1ffffff] (base 0xe0000000)

    The correct regions are:

    MMCONFIG for [bus 00-1f] at [mem 0xe0000000-0xe1ffffff] (base 0xe0000000)
    MMCONFIG for [bus 20-3f] at [mem 0xe2000000-0xe3ffffff] (base 0xe0000000)

    Signed-off-by: Bjorn Helgaas
    Signed-off-by: Jesse Barnes

    Bjorn Helgaas
     

19 May, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

26 Feb, 2010

1 commit

  • commit ff097ddd4 (x86/PCI: MMCONFIG: manage pci_mmcfg_region as a
    list, not a table) introduced a nasty memory corruption when
    pci_mmcfg_list is empty.

    pci_mmcfg_check_end_bus_number() dereferences pci_mmcfg_list.prev even
    when the list is empty. The following write hits some variable near to
    pci_mmcfg_list.

    Further down a similar problem exists, where cfg->list.next is
    dereferenced unconditionally and a comparison with some variable near
    to pci_mmcfg_list happens.

    Add a check for the last element into the for_each_entry() loop and
    remove all the other crappy logic which is just a leftover of the old
    array based code which was replaced by the list conversion.

    Reported-by: Ingo Molnar
    Signed-off-by: Thomas Gleixner
    Cc: Bjorn Helgaas
    Cc: Yinghai Lu
    Cc: stable@kernel.org
    Signed-off-by: Jesse Barnes

    Thomas Gleixner
     

25 Nov, 2009

17 commits


05 Nov, 2009

1 commit

  • The current whitelist requires a kernel change for every machine that has
    MMCONFIG regions above 4GB, even if BIOS provides a correct MCFG table.

    This patch expands the whitelist to include machines with a rev 1 or newer
    MCFG table and a DMI_BIOS_DATE of 2010 or later. That way, we only need
    kernel changes for new machines that provide incorrect MCFG tables.

    Signed-off-by: Bjorn Helgaas
    CC: Matthew Wilcox
    CC: John Keller
    CC: Yinghai Lu
    CC: Kenji Kaneshige
    CC: Andi Kleen
    Acked-by: Ingo Molnar
    Signed-off-by: Jesse Barnes

    Bjorn Helgaas
     

29 Aug, 2009

3 commits