27 Aug, 2013

1 commit


26 Jan, 2013

1 commit

  • The second argument of ACPI driver .remove() operation is only used
    by the ACPI processor driver and the value passed to that driver
    through it is always available from the given struct acpi_device
    object's removal_type field. For this reason, the second ACPI driver
    .remove() argument is in fact useless, so drop it.

    Signed-off-by: Rafael J. Wysocki
    Reviewed-by: Jiang Liu
    Acked-by: Toshi Kani
    Acked-by: Yinghai Lu

    Rafael J. Wysocki
     

10 Oct, 2012

1 commit


28 Jul, 2012

1 commit

  • Commit c5dec0182256361a3f823316e8fb85263f76efe7 (acpi_power_meter: Use struct
    dev_pm_ops for power management) introduced the following build warning. It is
    seen if CONFIG_PM_SLEEP is not defined.

    acpi_power_meter.c:930:12: warning: acpi_power_meter_resume defined but not used

    Fix it.

    Cc: Rafael J. Wysocki
    Signed-off-by: Guenter Roeck
    Acked-by: Rafael J. Wysocki

    Guenter Roeck
     

25 Jul, 2012

1 commit

  • Pull hwmon updates from Guenter Roeck:
    "New drivers for DA9052/53 PMIC as well as HIH-6130/HIH-6131 humidity
    and temperature sensors.

    Convert drivers to use devm_ functions and to use dev_pm_ops. Address
    a couple of Coverity errors/warnings as well as compile warnings.
    Some functional improvements in applesmc driver."

    * tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging: (72 commits)
    hwmon: (applesmc) Ignore some temperature registers
    hwmon: (applesmc) Allow negative temperature values
    hwmon: (s3c-hwmon) Use devm_kzalloc instead of kzalloc
    hwmon: (w83781d) Fix compile warning
    hwmon: (applesmc) Shorten minimum wait time
    hwmon: (exynos4_tmu) Use struct dev_pm_ops for power management
    hwmon: (gpio-fan) Use struct dev_pm_ops for power management
    hwmon: (abituguru3) Use struct dev_pm_ops for power management
    hwmon: (abituguru) Use struct dev_pm_ops for power management
    hwmon: (acpi_power_meter) Fix unintentional integer overflow
    hwmon: (acpi_power_meter) Cleanup and optimizations
    hwmon: Honeywell Humidicon HIH-6130/HIH-6131 humidity and temperature sensor driver
    hwmon: (applesmc) Skip sensor mapping
    hwmon: (ntc_thermistor) Ensure that data->name string is terminated
    hwmon: (w83l785ts) Convert to use devm_ functions
    hwmon: (w83l785ts) Simplify code and improve readability
    hwmon: (smsc47m192) Convert to use devm_ functions
    hwmon: (smsc47m1) Convert to use devm_ functions
    hwmon: (smsc47b397) Convert to use devm_ functions
    hwmon: (k8temp) Convert to use devm_ functions
    ...

    Linus Torvalds
     

22 Jul, 2012

2 commits

  • Expression with two integer variables is calculated as integer before it is
    converted to u64. This may result in an integer overflow. Fix by declaring
    trip point variables as s64 instead of int.

    This patch addresses Coverity #200596: Unintentional integer overflow.

    Signed-off-by: Guenter Roeck
    Acked-by: Jean Delvare

    Guenter Roeck
     
  • An unsigned value can not be smaller than 0. Remove the check for it.
    Use DIV_ROUND_CLOSEST for divide operations converting milli-degrees C into
    degrees C. Limit maximum accepted trip point temperature to INT_MAX.

    This patch fixes Coverity #115214: Unsigned compared against 0

    Signed-off-by: Guenter Roeck
    Acked-by: Jean Delvare

    Guenter Roeck
     

01 Jul, 2012

1 commit


21 May, 2012

5 commits


10 Apr, 2012

1 commit

  • In some configurations, BUG() does not result in an endless loop but returns
    to the caller. This results in the following compiler warning:

    drivers/hwmon/acpi_power_meter.c: In function 'show_str':
    drivers/hwmon/acpi_power_meter.c:380: warning: 'val' may be used uninitialized in this function

    Fix the warning by setting val to an empty string after BUG().

    Signed-off-by: Guenter Roeck
    Reviewed-by: Robert Coulson

    Guenter Roeck
     

02 Apr, 2012

1 commit

  • Similar to a30dcb4f which fixed asus_atk0110.ko, I recently received a
    bug report from someone hitting the same issue in acpi_power_meter.

    [ 13.963168] power_meter ACPI000D:00: Found ACPI power meter.
    [ 13.963900] BUG: key ffff8802161f3920 not in .data!
    [ 13.963904] ------------[ cut here ]------------
    [ 13.963915] WARNING: at kernel/lockdep.c:2986
    lockdep_init_map+0x52f/0x560()

    So let's fix that up for them by statically declaring the
    lockdep_class_key.

    Signed-off-by: Kyle McMartin
    Cc: stable@vger.kernel.org # 3.0+
    Signed-off-by: Guenter Roeck

    Kyle McMartin
     

13 Jan, 2012

1 commit


06 Jan, 2012

1 commit


26 May, 2011

1 commit

  • As discussed earlier, the ACPI power meter driver would better live
    in drivers/hwmon, as its only purpose is to create hwmon-style
    interfaces for ACPI 4.0 power meter devices. Users are more likely to
    look for it there, and less likely to accidentally hide it by
    unselecting its dependencies.

    Signed-off-by: Jean Delvare
    Acked-by: "Darrick J. Wong"
    Acked-by: Guenter Roeck
    Cc: Len Brown

    Jean Delvare