31 Aug, 2013

1 commit

  • Use the wrapper function for retrieving the platform data instead of
    accessing dev->platform_data directly. This is a cosmetic change
    to make the code simpler and enhance the readability.

    Signed-off-by: Jingoo Han
    Signed-off-by: David S. Miller

    Jingoo Han
     

20 Jun, 2013

1 commit

  • All drivers that select MII also need to select NET_CORE because MII
    depends on it. This is a bit ridiculous because NET_CORE is just a
    menu option that doesn't enable any code by itself.

    There is also no need for it to be a visible option, since its users
    all select it.

    Signed-off-by: Ben Hutchings
    Acked-by: Jeff Kirsher
    Signed-off-by: David S. Miller

    Ben Hutchings
     

28 May, 2013

1 commit

  • The driver core clears the driver data to NULL after device_release
    or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
    (device-core: Ensure drvdata = NULL when no driver is bound).
    Thus, it is not needed to manually clear the device driver data to NULL.

    Signed-off-by: Jingoo Han
    Acked-by: Nicolas Ferre
    Acked-by: Rob Herring
    Acked-by: Roland Stigge
    Acked-by: Mugunthan V N
    Reviewed-by: H Hartley Sweeten
    Tested-by: Roland Stigge
    Signed-off-by: David S. Miller

    Jingoo Han
     

30 Mar, 2013

1 commit

  • The CONFIG_ARCH_IXDP2X01 and CONFIG_MACH_IXDP2351 Kconfig macros are
    unused since the ixp23xx and ixp2000 platforms were removed in v3.5. So
    remove the last code still depending on these macros. And since
    CS89x0_NONISA_IRQ was only set if either of these two macros was defined
    we can also remove that macro and the code depending on it.

    Signed-off-by: Paul Bolle
    Signed-off-by: David S. Miller

    Paul Bolle
     

19 Mar, 2013

1 commit


10 Mar, 2013

1 commit

  • Emitting netdev_alloc_skb and netdev_alloc_skb_ip_align OOM
    messages is unnecessary as there is already a dump_stack
    after allocation failures.

    Other trivial changes around these removals:

    Convert a few comparisons of pointer to 0 to !pointer.
    Change flow to remove unnecessary label.
    Remove now unused variable.
    Hoist assignment from if.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

06 Mar, 2013

1 commit


07 Jan, 2013

1 commit

  • Use strlcpy where possible to ensure the string is \0 terminated.
    Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
    and custom defines.
    Use snprintf instead of sprint.
    Remove unnecessary inits of ->fw_version
    Remove unnecessary inits of drvinfo struct.

    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     

01 Sep, 2012

1 commit


19 May, 2012

5 commits


18 May, 2012

1 commit

  • The use of the inw/outw functions by the cs89x0 platform driver
    results in NULL pointer references on ARM platforms and
    platforms that do not provide ISA-style programmed I/O accessors.

    Using inw/outw also accesses the wrong address space on platforms
    that have a PCI I/O space that is not identity-mapped into the
    physical address space.

    Signed-off-by: Jaccon Bastiaansen
    Signed-off-by: David S. Miller

    Jaccon Bastiaansen
     

29 Mar, 2012

2 commits

  • …m/linux/kernel/git/dhowells/linux-asm_system

    Pull "Disintegrate and delete asm/system.h" from David Howells:
    "Here are a bunch of patches to disintegrate asm/system.h into a set of
    separate bits to relieve the problem of circular inclusion
    dependencies.

    I've built all the working defconfigs from all the arches that I can
    and made sure that they don't break.

    The reason for these patches is that I recently encountered a circular
    dependency problem that came about when I produced some patches to
    optimise get_order() by rewriting it to use ilog2().

    This uses bitops - and on the SH arch asm/bitops.h drags in
    asm-generic/get_order.h by a circuituous route involving asm/system.h.

    The main difficulty seems to be asm/system.h. It holds a number of
    low level bits with no/few dependencies that are commonly used (eg.
    memory barriers) and a number of bits with more dependencies that
    aren't used in many places (eg. switch_to()).

    These patches break asm/system.h up into the following core pieces:

    (1) asm/barrier.h

    Move memory barriers here. This already done for MIPS and Alpha.

    (2) asm/switch_to.h

    Move switch_to() and related stuff here.

    (3) asm/exec.h

    Move arch_align_stack() here. Other process execution related bits
    could perhaps go here from asm/processor.h.

    (4) asm/cmpxchg.h

    Move xchg() and cmpxchg() here as they're full word atomic ops and
    frequently used by atomic_xchg() and atomic_cmpxchg().

    (5) asm/bug.h

    Move die() and related bits.

    (6) asm/auxvec.h

    Move AT_VECTOR_SIZE_ARCH here.

    Other arch headers are created as needed on a per-arch basis."

    Fixed up some conflicts from other header file cleanups and moving code
    around that has happened in the meantime, so David's testing is somewhat
    weakened by that. We'll find out anything that got broken and fix it..

    * tag 'split-asm_system_h-for-linus-20120328' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-asm_system: (38 commits)
    Delete all instances of asm/system.h
    Remove all #inclusions of asm/system.h
    Add #includes needed to permit the removal of asm/system.h
    Move all declarations of free_initmem() to linux/mm.h
    Disintegrate asm/system.h for OpenRISC
    Split arch_align_stack() out from asm-generic/system.h
    Split the switch_to() wrapper out of asm-generic/system.h
    Move the asm-generic/system.h xchg() implementation to asm-generic/cmpxchg.h
    Create asm-generic/barrier.h
    Make asm-generic/cmpxchg.h #include asm-generic/cmpxchg-local.h
    Disintegrate asm/system.h for Xtensa
    Disintegrate asm/system.h for Unicore32 [based on ver #3, changed by gxt]
    Disintegrate asm/system.h for Tile
    Disintegrate asm/system.h for Sparc
    Disintegrate asm/system.h for SH
    Disintegrate asm/system.h for Score
    Disintegrate asm/system.h for S390
    Disintegrate asm/system.h for PowerPC
    Disintegrate asm/system.h for PA-RISC
    Disintegrate asm/system.h for MN10300
    ...

    Linus Torvalds
     
  • Remove all #inclusions of asm/system.h preparatory to splitting and killing
    it. Performed with the following command:

    perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`

    Signed-off-by: David Howells

    David Howells
     

28 Mar, 2012

1 commit

  • Pull "ARM: driver specific updates" from Arnd Bergmann:
    "These are all specific to some driver. They are typically the
    platform side of a change in the drivers directory, such as adding a
    new driver or extending the interface to the platform. In cases where
    there is no maintainer for the driver, or the maintainer prefers to
    have the platform changes in the same branch as the driver changes,
    the patches to the drivers are included as well.

    A much smaller set of driver updates that depend on other branches
    getting merged first will be sent later.

    The new export of tegra_chip_uid conflicts with other changes in
    fuse.c. In rtc-sa1100.c, the global removal of IRQF_DISABLED
    conflicts with the cleanup of the interrupt handling of that driver.

    Signed-off-by: Arnd Bergmann "

    Fixed up aforementioned trivial conflicts.

    * tag 'drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (94 commits)
    ARM: SAMSUNG: change the name from s3c-sdhci to exynos4-sdhci
    mmc: sdhci-s3c: add platform data for the second capability
    ARM: SAMSUNG: support the second capability for samsung-soc
    ARM: EXYNOS: add support DMA for EXYNOS4X12 SoC
    ARM: EXYNOS: Add apb_pclk clkdev entry for mdma1
    ARM: EXYNOS: Enable MDMA driver
    regulator: Remove bq24022 regulator driver
    rtc: sa1100: add OF support
    pxa: magician/hx4700: Convert to gpio-regulator from bq24022
    ARM: OMAP3+: SmartReflex: fix error handling
    ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API
    ARM: OMAP3+: SmartReflex: micro-optimization for sanity check
    ARM: OMAP3+: SmartReflex: misc cleanups
    ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument
    ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata()
    ARM: OMAP3+: hwmod: add SmartReflex IRQs
    ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need
    ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register
    ARM: OMAP3+: SmartReflex: Add a shutdown hook
    ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP
    ...

    Conflicts:
    arch/arm/mach-tegra/Makefile
    arch/arm/mach-tegra/fuse.c
    drivers/rtc/rtc-sa1100.c

    Linus Torvalds
     

29 Feb, 2012

1 commit


25 Feb, 2012

1 commit

  • Print MAC/dev_addr via printk extended format specifier %pM instead
    of custom code.

    Use memcpy to set the address to dev->dev_addr in set_mac_address,
    instead of mxing it up in a for loop with printing a debug msg.

    Check also if the given address is valid.

    Signed-off-by: Danny Kukawka
    Signed-off-by: David S. Miller

    Danny Kukawka
     

16 Feb, 2012

1 commit


07 Feb, 2012

1 commit


01 Feb, 2012

3 commits


02 Nov, 2011

1 commit

  • Macintosh CS89x0 based ethernet cards use a Crystal Semiconductor (Now
    Cirrus Logic) CS89x0 chip, so the mac89x0 driver should be in
    drivers/net/ethernet/cirrus instead of drivers/net/ethernet/apple.

    This also fixes a build problem, as the driver needs a header file from the
    cirrus directory:

    drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No such file or directory

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: David S. Miller

    Geert Uytterhoeven
     

19 Oct, 2011

1 commit

  • The cs89x0 driver was initial placed in the apple/ when it
    should have been placed in the cirrus/. This resolves the
    issue by moving the dirver and fixing up the respective
    Kconfig(s) and Makefile(s).

    Thanks to Sascha for reporting the issue.

    -v2 Fix a config error that was introduced with v1 by removing
    the dependency on MACE for NET_VENDOR_APPLE.

    CC: Russell Nelson
    CC: Andrew Morton
    Reported-by: Sascha Hauer
    Signed-off-by: Jeff Kirsher
    Signed-off-by: David S. Miller

    Jeff Kirsher
     

16 Sep, 2011

1 commit

  • MII Kconfig option is apart of the core networking drivers and
    by default NET_CORE is enabled so drivers selecting MII will
    have MII enabled as well. It was found using the randconfig
    option during testing, MII would be selected but NET_CORE
    could be disabled. This caused a dependency error.

    Resolved the dependency by selecting NET_CORE when MII is
    selected.

    Reported-by: Emil Tantilov
    Signed-off-by: Jeff Kirsher
    Tested-by: Aaron Brown
    Signed-off-by: David S. Miller

    Jeff Kirsher
     

27 Aug, 2011

1 commit

  • Based on finds for Stephen Rothwell, where current defconfig's
    enable a ethernet driver and it is not compiled due to the newly
    added NET_VENDOR_* component of Kconfig.

    This patch enables all the "new" Kconfig options so that current
    defconfig's will continue to compile the expected drivers. In
    addition, by enabling all the new Kconfig options does not add
    any un-expected options.

    CC: Stephen Rothwll
    Signed-off-by: Jeff Kirsher

    Jeff Kirsher
     

12 Aug, 2011

1 commit