04 Jul, 2013
1 commit
-
For the workqueue creation interfaces that do not expect format strings,
make sure they cannot accidently be parsed that way. Additionally, clean
up calls made with a single parameter that would be handled as a format
string. Many callers are passing potentially dynamic string content, so
use "%s" in those cases to avoid any potential accidents.Signed-off-by: Kees Cook
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
02 May, 2013
17 commits
-
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Signed-off-by: James Bottomley -
Command Window value from the CQE was used to calculate the
max_cmdsn for that session.The command window value extracted
for SKH-R adapter was not proper. The value was extracted from
BE adapter completion event. Fixed the issue by getting the
cmd_wnd value from SKH-R CQE.The exp_cmdsn and max_cmdsn values were not converted to BE format
before calling the __iscsi_complete_pdu(). Fixed the issue of converting
to BE format.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
The driver creates "NAPI" context per core which is fine,
however the above routine declares the ret variable as static!
Thus there is only one instance of this variable!
When this routine is called from more than one thread of execution,
than the result is unpredictable.static unsigned int ret;
.....ret = beiscsi_process_cq(pbe_eq);
< budget) {
....
}
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Before tyring to establish a CXN with the target, check if the adapter is in
a stable stateSigned-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Number of CID assigned to a function from adapter can be dynamic. The CID count
for each function was fixed number before. Code Fix done so that adapters with
fixed/dynamic CID count will work with the driver.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
When target send a NOP-IN with valid TTT, driver issues a NOP-OUT
and the task was not freed from driver. The task list available for
the session used to run out, and as no more task list were available
no more iSCSI commands were exchanged on that session.
This patches fixed the issue, by calling iscsi_put_task.Signed-off-by: Minh Tran
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Check the Logical Link status also as part of the port link status.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
This patch fixes the displaying of number of active
sessions in use.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
The mgmt_hba_attributes structure declared was not proper and
because of that the FW response returned for the MBX_CMD was not
matching. This issue went unnoticed as mgmt_hba_attribs structure
members were never used in the code path.This fix of displaying the FW version had to change the mgmt_hba_attrib
structure also. The latest driver will also work with the older FW as
the issue was in the driver declaration.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fix support for DEFQ extension which will be used by latest
adaptersSigned-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fixed the code flow based on the MACRO defined to check for
adapter.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Free CXN specific resource held by driver when login redirection
or connection retry happens. Login redirection was failing
because WRB/SGL were not allocated from the CID on which
doorbell was rung.Fixed the issue raised by MikeC
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
This patch limits the max number of msix vectors to 32.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
- Check Ready Bit before posting the BMBX Hi Address
- Fix the parameters passed to beiscsi_mccq_compl
in beiscsi_open_conn()
- Fix tag value check in beiscsi_ep_connect.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
When MBX command fails with insufficent buffer, check for the
response lenght returned. Return success if response length
is non-zero value which indicates valid data.Signed-off-by: Minh Tran
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
This patch sends uninitialize pattern to FW during driver unload
which is expected by FW for cleanupSigned-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
24 Apr, 2013
1 commit
-
Fix typo in printk and comments within various drivers.
Signed-off-by: Masanari Iida
Signed-off-by: Jiri Kosina
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Cc: Adam Radford
Cc: "James E.J. Bottomley"
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2012
19 commits
-
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Driver periodically checks adapter state,is up fine or not.
Based on the value updates the internal structures of driver.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
The MBX timeout value set to 100 and if adapter doesn;t
return response in that time driver will return from waiting
for completion with an error to the caller. In the earlier code
driver use to wait until MBX response comes from adapter.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fix issue of displaying adapter family through the sysfs
entry for each Scsi_Host created for the adapter.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
The completion events returned by adapter differs based on the
adapter. This fix checks for the adapter type and process the
completion event.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
For updating session context on adapter, V2 version is to
be used with the latest adapter. This fix checks for the adapter type
and uses correct version of session context.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Latest adapters use the V2 version of WRB. This fix checks for the
adapter type and uses appropriate version of WRB.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
For latest adapters, V2 version of cq_create MBX_CMD is to be used. When
driver is loaded depending on the adapter type appropriate cq_create command
will be called.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fix the max EQ created when driver is loaded. Max EQ for
for new adapters will be 64.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fix support for Skyhawk-R adapter by populating the pci_id_table
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fix return value and typo in the message displayed.
Fix the goto label when wrb_hanlde allocation fails.
Fix the error message display in beiscsi_alloc_pduSigned-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Kernel used to panic while running IO is disable mode, as there
was an issue with getting the correct EQ on which completion has come.
Fix done is create workqueue per hba and work item for each EQ created.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
The maximum EQ that can be created for a function is 8. Check the
CPU online count and create only 8 EQ if CPU_Count >= 8Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
In contorl path of the driver the task was mapped using
pci_map_single which was not unmapped when the completion
for the task had come.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Display the event string along with the opcode and CID on which
an event has occured.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fixed soft_reset problem which driver modified
all 32bit before a write on second pass.Signed-off-by: Minh Tran
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
15 Sep, 2012
1 commit
-
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Signed-off-by: James Bottomley