17 Sep, 2013
1 commit
-
Make sure that format strings cannot leak into printk() calls from the
msgbuf string.Signed-off-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman
31 Aug, 2013
1 commit
-
This patchs adds a TODO for the driver.
Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
28 Aug, 2013
3 commits
-
This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h. A previous patch replaced all
dgnc_driver_kzmalloc function calls with kzalloc.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch replaces dgnc_driver_kzmalloc with kzalloc.
A patch that follows removes the dgnc_driver_kzmalloc
function.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch edits the type casts neo_uart_struct and
cls_uart_struct. A previous patch added the marker __iomem
to these structs. This patch ensures that the change to
the marker is consistent. This also removes these
sparse warnings:warning: incorrect type in assignment (different address spaces)
expected struct neo_uart_struct [noderef] *ch_neo_uart
got struct neo_uart_struct *
warning: incorrect type in assignment (different address spaces)
expected struct cls_uart_struct [noderef] *ch_cls_uart
got struct cls_uart_struct *Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
27 Aug, 2013
6 commits
-
This patch edits the vaddr variable in dgnc_tty_init.
The variable gets set to board_t->re_map_membase. A
previous patch changed the re_map_membase variable's
marker and type. This patch makes sure that the
changes are consistent and that it doesn't cause
sparse warnings.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch adds a marker to neo_read_eeprom function's
base parameter.It removes these warnings found in neo.c:
warning: incorrect type in argument 1 (different address spaces)
expected unsigned char *base
got unsigned char [noderef] [usertype] *re_map_membase
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] *addr
got unsigned char *These warnings happen because this function gets
called with a board_t->re_map_base variable. A previous
patch added the __iomem marker to this variable. This
patch ensures that the changes are consistent.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch changes cls_vpd function's re_map_vpdbase variable
type and marker.It removes these warnings found in cls.c:
warning: incorrect type in assignment (different address spaces)
expected unsigned char [usertype] *re_map_vpdbase
got void [noderef] *
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char [usertype] *
warning: incorrect type in argument 1 (different address spaces)
expected void volatile [noderef] *addr
got unsigned char [usertype] *re_map_vpdbaseThe variables passed to readb needs to be of type u8
with a __iomem marker. re_map_vpdbase is passed into
readb in the code.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch changes the board_t->re_map_membase variable
type and marker.It removes these warnings found in the neo.c,
driver.c and cls.c files:warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char volatile *
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] *addr
got unsigned char volatile *The variables passed to readb and writeb need to
be of type u8 with a __iomem marker. These warnings
were popping up everytime the readb and writeb
functions were called with a
board_t->re_map_membase variable.The change made to the driver.h file adds the marker
and changes the variable type.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes these warnings found in the neo.c file:
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char volatile *
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] *addr
got unsigned char volatile *The variables passed to readb and writeb need to
be of type u8 with a __iomem marker. These warnings
were popping up everytime the readb and writeb
functions were called with a neo_uart_struct variable.The change made to the driver.h file adds the marker
to the neo_uart_struct and the changes in neo.h
changes the variables' types.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes these sparse warnings found in the cls.c file:
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] *addr
got unsigned char volatile *
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] *addr
got unsigned char volatile *The variables passed to readb and writeb need to
be of type u8 with a __iomem marker. These warnings
were popping up everytime the readb and writeb
functions were called with a cls_uart_struct variable.The change made to the driver.h file adds the marker
to the cls_uart_struct and the changes in cls.h
changes its variables' types.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
26 Aug, 2013
1 commit
-
DGNC is based on PCI, so need add related dependency, or when compiled
with PCI disabled, it will be fail.The related error (randconfig for PCI disabled under s390):
drivers/staging/dgnc/dgnc_cls.c:1394:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
drivers/staging/dgnc/dgnc_cls.c:1407:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]Cc: Lidza Louina
Signed-off-by: Chen Gang
Signed-off-by: Greg Kroah-Hartman
23 Aug, 2013
2 commits
-
This patch removes the dgnc_mbuf function. This function was causing the
errors:drivers/staging/dgnc/dgnc_driver.c: In function 'dgnc_mbuf.constprop.0':
drivers/staging/dgnc/dgnc_driver.c:945:1: warning: the frame size of 1032
bytes is larger than 1024 bytes [-Wframe-larger-than=]drivers/staging/dgnc/dgnc_tty.c: In function 'dgnc_sniff_nowait_nolock':
drivers/staging/dgnc/dgnc_tty.c:614:1: warning: the frame size of 1056
bytes is larger than 1024 bytes [-Wframe-larger-than=]This patch removes it so the kernel won't be making noise when its
device is found on the system.Reported-by: Fengguang Wu
Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
With 'allyesconfig', we get following error without this.
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_cleanup_board’:
drivers/staging/dgnc/dgnc_driver.c:459:3: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
kfree(brd->msgbuf_head);
^
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_driver_kzmalloc’:
drivers/staging/dgnc/dgnc_driver.c:905:2: error: implicit declaration of function ‘kmalloc’ [-Werror=implicit-function-declaration]
void *p = kmalloc(size, priority);Signed-off-by: Tushar Behera
Cc: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
22 Aug, 2013
22 commits
-
This patch fixes the error "code indent should use
tabs where possible" in dgnc_tty.c.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the error "code indent should use
tabs where possible" in dgnc_sysfs.c.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the error "code indent should use
tabs where possible" in dgnc_neo.c.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.h.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.c.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the error: open brace '{'
following struct go on the same line.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the error: "foo* bar" should be "foo *bar".
Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes the code supporting CVS
from its files.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dpacompat.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the digi.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_tty.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_trace.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_sysfs.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the sysfs.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the neo.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_neo.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_mgmt.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the kcompat.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the driver.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_driver.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_cls.h file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch removes trailing whitespace in
the dgnc_cls.c file.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
21 Aug, 2013
2 commits
-
This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman -
This patch fixes a warning associated with assigining
a pointer in the dgnc_mbuf function.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
16 Aug, 2013
1 commit
-
This patch removes the dgnc_proc.c and dgnc_proc.h files and all
references to proc functions in dgnc_driver.c. This also removes proc.h
from the include headers in driver.c, mgmt.c and sysfs.c and proc.o
from the Makefile.Drivers now use sysfs instead of proc.
Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman
15 Aug, 2013
1 commit
-
This patch removes the use of read_cnt, real_raw, buf and rawreadok. The
variable buf is never used in the code. The variables rawreadok read_cnt
and real_raw don't exist in the new API. Reading the data raw is no
longer supported by the tty layer.Signed-off-by: Lidza Louina
Signed-off-by: Greg Kroah-Hartman