26 Jul, 2013

1 commit


21 Aug, 2012

1 commit

  • flush[_delayed]_work_sync() are now spurious. Mark them deprecated
    and convert all users to flush[_delayed]_work().

    If you're cc'd and wondering what's going on: Now all workqueues are
    non-reentrant and the regular flushes guarantee that the work item is
    not pending or running on any CPU on return, so there's no reason to
    use the sync flushes at all and they're going away.

    This patch doesn't make any functional difference.

    Signed-off-by: Tejun Heo
    Cc: Russell King
    Cc: Paul Mundt
    Cc: Ian Campbell
    Cc: Jens Axboe
    Cc: Mattia Dongili
    Cc: Kent Yoder
    Cc: David Airlie
    Cc: Jiri Kosina
    Cc: Karsten Keil
    Cc: Bryan Wu
    Cc: Benjamin Herrenschmidt
    Cc: Alasdair Kergon
    Cc: Mauro Carvalho Chehab
    Cc: Florian Tobias Schandinat
    Cc: David Woodhouse
    Cc: "David S. Miller"
    Cc: linux-wireless@vger.kernel.org
    Cc: Anton Vorontsov
    Cc: Sangbeom Kim
    Cc: "James E.J. Bottomley"
    Cc: Greg Kroah-Hartman
    Cc: Eric Van Hensbergen
    Cc: Takashi Iwai
    Cc: Steven Whitehouse
    Cc: Petr Vandrovec
    Cc: Mark Fasheh
    Cc: Christoph Hellwig
    Cc: Avi Kivity

    Tejun Heo
     

02 May, 2012

1 commit


13 Jan, 2012

1 commit


19 Nov, 2011

1 commit

  • This converts the drivers in drivers/usb/* to use the
    module_usb_driver() macro which makes the code smaller and a bit
    simpler.

    Added bonus is that it removes some unneeded kernel log messages about
    drivers loading and/or unloading.

    Cc: Simon Arlott
    Cc: Duncan Sands
    Cc: Matthieu CASTET
    Cc: Stanislaw Gruszka
    Cc: Pete Zaitcev
    Cc: Oliver Neukum
    Cc: Juergen Stuber
    Cc: Cesar Miquel
    Cc: Matthew Dharm
    Cc: Matthew Wilcox
    Cc: Sarah Sharp
    Cc: Kuninori Morimoto
    Cc: Felipe Balbi
    Cc: Lucas De Marchi
    Cc: Michael Hund
    Cc: Zack Parsons
    Cc: Melchior FRANZ
    Cc: Tomoki Sekiyama
    Cc: Dan Carpenter
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

24 Dec, 2010

2 commits

  • flush_scheduled_work() is being deprecated. Directly flush or cancel
    work items instead.

    * u_ether, isp1301_omap, speedtch conversions are straight-forward.

    * ochi-hcd should only flush when quirk_nec() is true as otherwise the
    work wouldn't have been initialized.

    * In oti6858, cancel_delayed_work() + flush_scheduled_work() ->
    cancel_delayed_work_sync().

    Signed-off-by: Tejun Heo
    Acked-by: Greg Kroah-Hartman
    Cc: David Brownell
    Cc: Duncan Sands
    Cc: linux-usb@vger.kernel.org

    Tejun Heo
     
  • speedtch directly uses the internal timer and work members of a struct
    delayed_work. Use a separate work item and timer instead.

    * Nicolas Kaiser discovered that timer init was missing. Fixed.

    Signed-off-by: Tejun Heo
    Acked-by: Greg Kroah-Hartman
    Tested-by: Nicolas Kaiser
    Cc: Duncan Sands
    Cc: linux-usb@vger.kernel.org

    Tejun Heo
     

11 Aug, 2010

2 commits


09 Jul, 2010

1 commit


25 May, 2010

1 commit

  • Instead of using own implementation which potentialy has bugs involve
    hex_to_bin() function. It requires to have hex_to_bin() implementation
    introduced by starter patch in series.

    Signed-off-by: Andy Shevchenko
    Cc: Duncan Sands
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Shevchenko
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

23 Oct, 2008

1 commit

  • This patch (as1150) fixes a problem in the speedtch driver. When it
    resets the modem during probe it will be unbound from the other
    interfaces it has claimed, because it doesn't define a pre_reset and a
    post_reset method.

    The patch defines "do-nothing" methods. This fixes Bugzilla #11767.

    Signed-off-by: Alan Stern
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Alan Stern
     

22 Jul, 2008

1 commit


15 Oct, 2007

1 commit


13 Oct, 2007

1 commit


20 Jul, 2007

1 commit


08 Feb, 2007

1 commit


05 Dec, 2006

1 commit


02 Dec, 2006

1 commit


22 Nov, 2006

1 commit


18 Oct, 2006

1 commit

  • The speedtouch modem setup code was reverse engineered many years
    ago from a prehistoric windows driver. Less ancient windows drivers,
    even those from a few years ago, perform extra initialization steps
    which this patch adds to the linux driver. David Woodhouse observed
    that this initialization along with the firmware bin/sachu3/zzzlp2.eni
    from the driver at
    http://www.speedtouch.co.uk/downloads/330/301/UK3012%20Extended.zip
    improves line sync speeds by about 20%. He provided the original
    patch, which I've modified to use symbolic names (BMaxDSL, ModemMode,
    ModemOption) rather than magic numbers. These names may not seem like
    much of an improvement (after all, what is "ModemOption" exactly?),
    but they do have one big advantage: they are the names used in the
    windows registry. I've made them available as module parameters.
    Thanks are due to Aurelio Arroyo, who noticed the relationship
    between these magic numbers and the entries in Phonebook.ini.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

09 May, 2006

1 commit

  • The maximum possible bandwidth for a speedtouch modem is about 7Mbaud.
    You can only get this by using isochronous urbs (enable_isoc=1) and
    altsetting 3. With the current default altsetting of 2, the modem
    maxes out at about 4Mbaud. So change the default altsetting to 3
    when using isochronous urbs. It would be nice to base the altsetting
    on the detected line speed, but that's hard given the current design.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     

01 Feb, 2006

7 commits

  • Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • While the usbatm core has had some support for using isoc urbs
    for some time, there was no way for users to turn it on. While
    use of isoc transfer should still be considered experimental, it
    now works well enough to let users turn it on. Minidrivers signal
    to the core that they want to use isoc transfer by setting the new
    UDSL_USE_ISOC flag. The speedtch minidriver gets a new module
    parameter enable_isoc (defaults to false), plus some logic that
    checks for the existence of an isoc receive endpoint (not all
    speedtouch modems have one).

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • Change the module parameters rcv_buf_size and snd_buf_size to
    specify buffer sizes in bytes rather than ATM cells. Since
    there is some danger that users may not notice this change,
    the parameters are renamed to rcv_buf_bytes etc. The transmit
    buffer needs to be a multiple of the ATM cell size in length,
    while the receive buffer should be a multiple of the endpoint
    maxpacket size (this wasn't enforced before, which causes trouble
    with isochronous transfers), so enforce these restrictions. Now
    that the usbatm probe method inspects the endpoint maxpacket size,
    minidriver bind routines need to set the correct alternate setting
    for the interface in their bind routine. This is the reason for
    the speedtch changes.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • Convert kmalloc + memset to kzalloc.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • Remove the unused .owner field in struct usbatm_driver.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • Have minidrivers and the core signal special requirements
    using a flags field in struct usbatm_data. For the moment
    this is only used to replace the need_heavy_init bind
    parameter, but there'll be new flags in later patches.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • Formatting, changes to variable names, comments, log level changes,
    printk rate limiting.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     

11 Jan, 2006

1 commit

  • ICC likes to complain about storage class not being first, GCC doesn't
    care much (except for cases like "inline static").
    have a hard time seeing how it could break anything.

    Thanks to Gabriel A. Devenyi for pointing out
    http://linuxicc.sourceforge.net/ which is what made me create this patch.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     

05 Jan, 2006

1 commit


26 Jul, 2005

1 commit


20 Jul, 2005

1 commit


13 Jul, 2005

3 commits

  • We map states 0x00 and 0x10 to the ATM_PHY_SIG_LOST flag. The current logic fails to
    resync the line if we get state 0x10 followed by 0x00, since we only resync the line
    when the state is 0x00 and the flag changed. Doubly fixed by (1) always resyncing the
    line when the state is 0x00 even if the state didn't change, and (2) keeping track of
    the last state, not just the flag. We do (2) as well as (1) in order to get better log
    messages.

    This is a tweaked version of the original patch by Aurelio Arroyo.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • No functional change, but less likely to break in the future.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     
  • Spotted by David Woodhouse.

    Signed-off-by: Duncan Sands
    Signed-off-by: Greg Kroah-Hartman

    Duncan Sands
     

28 Jun, 2005

2 commits