29 May, 2013

1 commit


07 Dec, 2012

2 commits


06 Oct, 2012

1 commit

  • A simplified version of the semantic patch that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @r1@
    statement S;
    position p,p1;
    @@
    S@p1;@p

    @script:python r2@
    p << r1.p;
    p1 << r1.p1;
    @@
    if p[0].line != p1[0].line_end:
    cocci.include_match(False)
    @@
    position r1.p;
    @@
    -;@p
    //

    Signed-off-by: Peter Senna Tschudin
    Signed-off-by: Takashi Iwai

    Peter Senna Tschudin
     

29 Aug, 2012

1 commit

  • v2: Fixed result still wrong in the case of 512 KiB DRAM. Oops.

    Applicable to 3.5.3 mainline.

    In emu8000.c, size_dram determines the amount of memory on the sound card by
    doing write/readback tests starting at 512 KiB and incrementing by 512 KiB.
    On success, detected_size is updated to the successful address and testing
    continues. On failure, the loop is immediately exited. The resulting
    detected_size is 512 KiB too small except in two special cases:

    1. If there is no memory, the initial 0 value of detected_size is used, which
    is correct.
    2. If the address space wraps around, detected_size is updated before the
    bailout, so the result is correct.

    The patch corrects all cases and was tested with an AWE64 Gold. Before:
    EMU8000 [0x620]: 3584 Kb on-board memory detected
    asfxload 4GMGSMT.SF2 (4174814 B) fails.
    After:
    EMU8000 [0x620]: 4096 Kb on-board memory detected
    asfxload 4GMGSMT.SF2 succeeds.

    I do not have a card with 512 KiB to test with, but by forcibly enabling the
    added conditional I verified on the AWE64 Gold that it detects 512 KiB
    (successfully reading from the first memory location) and does not hang the
    card.

    C.f. Bug 46451 https://bugzilla.kernel.org/show_bug.cgi?id=46451

    Signed-off-by: David Flater
    Signed-off-by: Takashi Iwai

    David Flater
     

06 Feb, 2012

1 commit


19 Dec, 2011

1 commit

  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

4 commits


22 Sep, 2011

1 commit

  • Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang
    Acked-by: Peter Ujfalusi
    Acked-by: Mark Brown
    Signed-off-by: Takashi Iwai

    Yong Zhang
     

14 Sep, 2011

1 commit

  • The semantics of snd_mpu401_uart_new()'s interrupt parameters are
    somewhat counterintuitive: To prevent the function from allocating its
    own interrupt, either the irq number must be invalid, or the irq_flags
    parameter must be zero. At the same time, the irq parameter being
    invalid specifies that the mpu401 code has to work without an interrupt
    allocated by the caller. This implies that, if there is an interrupt
    and it is allocated by the caller, the irq parameter must be set to
    a valid-looking number which then isn't actually used.

    With the removal of IRQF_DISABLED, zero becomes a valid irq_flags value,
    which forces us to handle the parameters differently.

    This patch introduces a new flag MPU401_INFO_IRQ_HOOK for when the
    device interrupt is handled by the caller, and makes the allocation of
    the interrupt to depend only on the irq parameter. As suggested by
    Takashi, the irq_flags parameter was dropped because, when used, it had
    the constant value IRQF_DISABLED.

    Signed-off-by: Clemens Ladisch
    Signed-off-by: Takashi Iwai

    Clemens Ladisch
     

31 Mar, 2011

1 commit


07 Sep, 2010

1 commit


29 Jul, 2010

1 commit


10 May, 2010

1 commit

  • The ESS ES968 chip is nothing more then a PnP companion
    for a non-PnP audio chip. It was paired with non-PnP ESS' chips:
    ES688 and ES1688. The ESS' audio chips are handled by the es1688
    driver in native mode. The PnP cards are handled by the ES968
    driver in SB compatible mode.

    Move the ES968 chip handling to the es1688 driver so the driver
    can handle both PnP and non-PnP cards. The es968 is removed.

    Also, a new PnP id is added for the card I acquired (the change
    was tested on this card).

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

26 Apr, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

05 Mar, 2010

1 commit

  • While trying to compile jazz16 isa sound driver on alpha (2.6.33+git), I
    found a compile failure in jazz16.c (udelay is unknown). Fix it by
    including delay.h.

    Signed-foo-by: Meelis Roos
    Signed-off-by: Takashi Iwai

    Meelis Roos
     

16 Feb, 2010

1 commit


08 Jan, 2010

1 commit

  • The patch "sbawe: fix memory detection" fixed detection
    for memoryless SB32 cards but broke detection of memory
    above 512KB. This patch fixes the regression.

    The patch has been tested on the SB32 card (CT3670) with
    0MB, 2MB and 8MB memory installed.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Jaroslav Kysela

    Krzysztof Helt
     

25 Dec, 2009

1 commit


22 Dec, 2009

1 commit


21 Dec, 2009

2 commits

  • This is one of Sound Blaster Pro compatible chipsets which is supported
    by Linux OSS driver and was missing native supoort for ALSA.

    The Jazz16 audio codec is Crystal CS4216 which is capable
    of playback and recording up to 48 kHz stereo.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     
  • Memory amount is increased before a successful write-read
    sequence is done. Thus, 512 kB of onboard memory is detected
    on memoryless cards like SB32.

    Move the increasing of memory counter after successful read
    is done.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

14 Dec, 2009

1 commit


05 Nov, 2009

1 commit

  • To avoid confusion in control names for the standard analog PC Beep generator
    using a small Internal PC Speaker, rename all related "PC Speaker" and "PC
    Beep" controls to "Beep" only. This name is more universal and can be also
    used on more platforms without confusion.

    Introduce also "Internal Speaker" in ControlNames.txt for systems with
    full-featured build-in internal speaker.

    Signed-off-by: Jaroslav Kysela
    Signed-off-by: Takashi Iwai

    Jaroslav Kysela
     

29 May, 2009

1 commit


14 Apr, 2009

1 commit


24 Mar, 2009

1 commit


23 Feb, 2009

1 commit

  • - add 8kHz / 20 kHz low-pass filter switch control
    - add ALS4000 Mono capture route control
    - add annotations to specs pages
    - improve ALS4000 PM saved regs selection (remove SB dummy register,
    add missing ones)
    - add some missing ALS4000 register defines
    - constify two variables

    Signed-off-by: Andreas Mohr
    Signed-off-by: Takashi Iwai

    Andreas Mohr
     

12 Jan, 2009

2 commits


11 Dec, 2008

1 commit


03 Nov, 2008

1 commit


13 Aug, 2008

1 commit


15 Jul, 2008

2 commits


23 Jun, 2008

1 commit