21 Mar, 2010
8 commits
-
Convert from reader/writer lock to RCU and spinlock for addrconf
hash list.Adds an additional helper macro for hlist_for_each_entry_continue_rcu
to handle the continue case.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Using hash list macros, simplifies code and helps later RCU.
This patch includes some initialization that is not strictly necessary,
since an empty hlist node/list is all zero; and list is in BSS
and node is allocated with kzalloc.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use list macros instead of open coded linked list.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
This patch fixes a bug that allows to lose events when reliable
event delivery mode is used, ie. if NETLINK_BROADCAST_SEND_ERROR
and NETLINK_RECV_NO_ENOBUFS socket options are set.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: David S. Miller -
Currently, ENOBUFS errors are reported to the socket via
netlink_set_err() even if NETLINK_RECV_NO_ENOBUFS is set. However,
that should not happen. This fixes this problem and it changes the
prototype of netlink_set_err() to return the number of sockets that
have set the NETLINK_RECV_NO_ENOBUFS socket option. This return
value is used in the next patch in these bugfix series.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: David S. Miller -
Under NET_DMA, data transfer can grind to a halt when userland issues a
large read on a socket with a high RCVLOWAT (i.e., 512 KB for both).
This appears to be because the NET_DMA design queues up lots of memcpy
operations, but doesn't issue or wait for them (and thus free the
associated skbs) until it is time for tcp_recvmesg() to return.
The socket hangs when its TCP window goes to zero before enough data is
available to satisfy the read.Periodically issue asynchronous memcpy operations, and free skbs for ones
that have completed, to prevent sockets from going into zero-window mode.Signed-off-by: Steven J. Magnani
Signed-off-by: David S. Miller
20 Mar, 2010
13 commits
-
This patch fixes a unaligned access in nla_get_be64() that was
introduced by myself in a17c859849402315613a0015ac8fbf101acf0cc1.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: David S. Miller -
A packet is marked as lost in case packets == 0, although nothing should be done.
This results in a too early retransmitted packet during recovery in some cases.
This small patch fixes this issue by returning immediately.Signed-off-by: Lennart Schulte
Signed-off-by: Arnd Hannemann
Signed-off-by: David S. Miller -
mfc_parent of cache entries is used to index into the vif_table and is
initialised from mfcctl->mfcc_parent. This can take values of to 2^16-1,
while the vif_table has only MAXVIFS (32) entries. The same problem
affects ip6mr.Refuse invalid values to fix a potential out-of-bounds access. Unlike
the other validity checks, this is checked in ipmr_mfc_add() instead of
the setsockopt handler since its unused in the delete path and might be
uninitialized.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
There is no need to adjust the next rx descriptor after each packet,
so do it only once at the end of the routine.Signed-off-by: Eric Dumazet
Signed-off-by: Yegor Yefremov -
Signed-off-by: Carolyn Wyborny
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Clean up some text output formatting.
Signed-off-by: Greg Rose
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
The recovery from PF reset works better when you shorten up the delay
until the watchdog task executes.Signed-off-by: Greg Rose
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
The counters in the 82599 Virtual Function are not clear on read. They
accumulate to the maximum value and then roll over. They are also not
cleared when the VF executes a soft reset, so it is possible they are
non-zero when the driver loads and starts. This has all been accounted
for in the code that keeps the stats up to date but there is one case
that is not. When the PF driver is reset the counters in the VF are
all reset to zero. This adds an additional accounting overhead into
the VF driver when the PF is reset under its feet. This patch adds
additional counters that are used by the VF driver to accumulate and
save stats after a PF reset has been detected. Prior to this patch
displaying the stats in the VF after the PF has reset would show
bogus data.Signed-off-by: Greg Rose
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
As per Simon Horman's feedback set IXGBE_RSC_CB(skb)->dma to zero
after unmapping HWRSC DMA address to avoid double freeing.Signed-off-by: Mallikarjuna R Chilakala
Acked-by: Peter P Waskiewicz Jr
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Currently netdev_features_change is called before fcoe tx queues
setup is done, so this patch moves calling of netdev_features_change
after tx queues setup is done in ixgbe_init_interrupt_scheme, so
that real_num_tx_queues is updated correctly on each fcoe enable
or disable.This allows additional fcoe queues updated correctly in vlan driver
for their correct queue selection.Signed-off-by: Vasu Dev
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
This adds RFC5082 checks for TTL on received ICMP packets.
It adds some security against spoofed ICMP packets
disrupting GTSM protected sessions.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
As the only path leading to ip6_dst_check makes an indirect call
through dst->ops, dst cannot be NULL in ip6_dst_check.This patch removes this check in case it misleads people who
come across this code.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
Xfrm_dst keeps a reference to ipv4 rtable entries on each
cached bundle. The only way to renew xfrm_dst when the underlying
route has changed, is to implement dst_check for this. This is
what ipv6 side does too.The problems started after 87c1e12b5eeb7b30b4b41291bef8e0b41fc3dde9
("ipsec: Fix bogus bundle flowi") which fixed a bug causing xfrm_dst
to not get reused, until that all lookups always generated new
xfrm_dst with new route reference and path mtu worked. But after the
fix, the old routes started to get reused even after they were expired
causing pmtu to break (well it would occationally work if the rtable
gc had run recently and marked the route obsolete causing dst_check to
get called).Signed-off-by: Timo Teras
Acked-by: Herbert Xu
Signed-off-by: David S. Miller
19 Mar, 2010
19 commits
-
TX checksum offload does not work properly when transmitting
UDP packets with 0, 1 or 2 bytes of data. This patch works
around the problem by calculating checksums for these packets
in the driver.Signed-off-by: Steve Glendinning
Signed-off-by: David S. Miller -
Advanced Power Management is disabled for 82599 KX4 connections by
clearing GRC.APME bit, causing it to not wake the system from an
improper system shutdown. By default GRC.APME is enabled and software
is not supposed to clear these settings during adapter probe.Signed-off-by: Mallikarjuna R Chilakala
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Fix 82599 link issues during driver load and unload test using multi-speed
10G & 1G fiber modules. When connected back to back sometime 82599 multispeed
fiber modules would link at 1G speed instead of 10G highest speed, due to a
race condition in autotry process involving Tx laser flapping. Move autotry
autoneg-37 tx laser flapping process from multispeed module init setup
to driver unload. This will alert the link partner to restart its
autotry process when it tries to establish the link with the link partnerSigned-off-by: Mallikarjuna R Chilakala
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
1) Change enic driver description to "Cisco VIC Ethernet NIC Driver"
2) Fix tab space
3) Update MAINTAINERS listSigned-off-by: Scott Feldman
Signed-off-by: Vasanthy Kolluri
Signed-off-by: Roopa Prabhu
Signed-off-by: David S. Miller -
Add wrapper functions vnic_dev_notify_setcmd and vnic_dev_notify_unsetcmd
for firmware notify commands.Signed-off-by: Scott Feldman
Signed-off-by: Vasanthy Kolluri
Signed-off-by: Roopa Prabhu
Signed-off-by: David S. Miller -
Hardware does not honor vlan filters from the host and so the driver does
not need to advertise this.Signed-off-by: Scott Feldman
Signed-off-by: Vasanthy Kolluri
Signed-off-by: Roopa Prabhu
Signed-off-by: David S. Miller -
The timeout for hardware Tx and Rx queue disable operations is increased to
work-around an erratum for "unnamed" chipset where a DMA completion may take
upto 10ms. We have to wait atleast this long for hardware to signal that Tx
and Rx queues are quiesced.Signed-off-by: Scott Feldman
Signed-off-by: Vasanthy Kolluri
Signed-off-by: Roopa Prabhu
Signed-off-by: David S. Miller -
The last bit written to a completion descriptor by hardware is the color
bit. Driver must read all other descriptor fields only after reading the
color bit to avoid reading stale descriptor fields. There is a rmb() after
reading the color bit to avoid any compiler/cpu reordering of the reads.
The color bit is the generation bit that toggles each pass through the
completion descriptor ring.Signed-off-by: Scott Feldman
Signed-off-by: Vasanthy Kolluri
Signed-off-by: Roopa Prabhu
Signed-off-by: David S. Miller -
When doing "ifenslave -d bond0 eth0", there is chance to get NULL
dereference in netif_receive_skb(), because dev->master suddenly becomes
NULL after we tested it.We should use ACCESS_ONCE() to avoid this (or rcu_dereference())
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
Advance driver version number after some bug fix.
Signed-off-by: Guo-Fu Tseng
Signed-off-by: David S. Miller -
Temporary stop the RX IRQ, and disable (sync) tasklet or napi.
And restore it after finished the vlgrp pointer assignment.Signed-off-by: Guo-Fu Tseng
Cc: stable@kernel.org
Signed-off-by: David S. Miller -
Fix memory leak while receiving 8021q tagged packet which is not
registered by user.Signed-off-by: Guo-Fu Tseng
Cc: stable@kernel.org
Signed-off-by: David S. Miller -
Kernel NULL pointer dereference when setting mode for IFF_MULTICAST.
Tested on SDP OMAP4430 board.ks8851 spi1.0: message enable is 0
ks8851 spi1.0: revision 0, MAC f2:f4:2f:56:37:de, IRQ 194
Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = c0004000
[00000000] *pgd=00000000
Internal error: Oops: 5 [#1] PREEMPT SMP
last sysfs file:
Modules linked in:
CPU: 0 Not tainted (2.6.34-rc1-01039-g38d7ed1-dirty #3)
PC is at ks8851_set_rx_mode+0x88/0x124
LR is at bitrev32+0x24/0x2cBacktrace:
[] ? (ks8851_set_rx_mode+0x0/0x124)
[] (__dev_set_rx_mode+0x0/0x90)
[] (dev_mc_add+0x0/0x78)
[] (igmp_group_added+0x0/0x64)
[] (ip_mc_inc_group+0x0/0x150)
[] (ip_mc_up+0x0/0x64)
[] (inetdev_event+0x0/0x3d4)
[] (notifier_call_chain+0x0/0x78)
[] (__raw_notifier_call_chain+0x0/0x24)
[] (raw_notifier_call_chain+0x0/0x28)
[] (call_netdevice_notifiers+0x0/0x24)
[] (__dev_notify_flags+0x0/0x68)
[] (dev_change_flags+0x0/0x4c)
[] (ip_auto_config+0x0/0xf1c)
[] (do_one_initcall+0x0/0x1bc)
[] (kernel_init+0x0/0x234)
Code: e15130bc e1833012 e14130bc e5943000 (e5934000)
---[ end trace ed0fb00a94142792 ]---
Kernel panic - not syncing: Fatal exception in interruptSigned-off-by: Abraham Arce
Signed-off-by: David S. Miller -
From: Alexandra.Kossovsky@oktetlabs.ru
Fixes kernel bugzilla #15541
Signed-off-by: David S. Miller
-
Remove unused #include ('s) in
drivers/net/ksz884x.cSigned-off-by: Huang Weiyi
Signed-off-by: David S. Miller -
It's not desired for underlaying devices to change type. At the time,
there is for example possible to have bond with changed type from
Ethernet to Infiniband as a port of a bridge. This patch fixes this.Signed-off-by: Jiri Pirko
Signed-off-by: Jay Vosburgh
Signed-off-by: David S. Miller -
This patch adds the possibility to refuse the bonding type change for
other subsystems (such as for example bridge, vlan, etc.)Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller -
Since generally there could be more netdevices changing type other
than bonding, making this event type name "bonding-unrelated"Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
