28 Apr, 2009
1 commit
-
* In blk_rq_timed_out_timer(), else { if } to else if
* In blk_add_timer(), simplify if/else block
[ Impact: cleanup ]
Signed-off-by: Tejun Heo
24 Apr, 2009
1 commit
-
Very rarely under stress testing of dm, oopses are occuring as
something tampers with an old stack frame. This has been traced back
to blk_abort_queue() leaving a timeout_list pointing to the stack.
The reason is that sometimes blk_abort_request() won't delete the
timer (if the request is marked as complete but before the timer has
been removed, a small race window). Fix this by splicing back from
the ususally empty list to the q->timeout_list.Signed-off-by: Hannes Reinecke
Signed-off-by: Jens Axboe
22 Apr, 2009
1 commit
-
There's nothing to do for those devices, since the timeout handling is
based on requests.Signed-off-by: Jens Axboe
18 Feb, 2009
1 commit
-
blk_abort_queue() iterates the timeout list and aborts each request on the
list, but if the driver error handling readds a request to the timeout list
during this processing, we could be looping forever. Fix this by splicing
current entries to a local list and run over that list instead.Signed-off-by: Jens Axboe
29 Dec, 2008
3 commits
-
For sync IO, we'll often do them serialized. This means we'll be touching
the queue timer for every IO, as opposed to only occasionally like we
do for queued IO. Instead of deleting the timer when the last request
is removed, just let continue running. If a new request comes up soon
we then don't have to readd the timer again. If no new requests arrive,
the timer will expire without side effect later.This improves high iops sync IO by ~1%.
Signed-off-by: Jens Axboe
-
Signed-off-by: Jens Axboe
-
Now the rq->deadline can't be zero if the request is in the
timeout_list, so there is no need to have next_set. There is no need to
access a request's deadline field if blk_rq_timed_out is called on it.Signed-off-by: Malahal Naineni
Signed-off-by: Jens Axboe
06 Nov, 2008
1 commit
-
This patch (as1159b) changes the timeout routines in the block core to
use round_jiffies_up(). There's no point in rounding the timer
deadline down, since if it expires too early we will have to restart
it.The patch also removes some unnecessary tests when a request is
removed from the queue's timer list.Signed-off-by: Alan Stern
Signed-off-by: Jens Axboe
09 Oct, 2008
4 commits
-
We cannot abort a request if we raced with the timeout handler already,
or with the IO completion. So make blk_abort_request() mark the request
as complete, and only continue if we succeeded.Found and suggested by Mike Anderson
Signed-off-by: Jens Axboe
-
Only works for the generic request timer handling. Allows one to
sporadically ignore request completions, thus exercising the timeout
handling.Signed-off-by: Jens Axboe
-
Signed-off-by: Mike Anderson
Signed-off-by: Jens Axboe -
Right now SCSI and others do their own command timeout handling.
Move those bits to the block layer.Instead of having a timer per command, we try to be a bit more clever
and simply have one per-queue. This avoids the overhead of having to
tear down and setup a timer for each command, so it will result in a lot
less timer fiddling.Signed-off-by: Mike Anderson
Signed-off-by: Jens Axboe
