14 Feb, 2008

1 commit

  • On alpha, ia64 and ppc64 only relocations to local data can go into
    read-only sections. The vast majority of module parameters use the global
    generic param_set_*/param_get_* functions, so the 'const' attribute for
    struct kernel_param is not only useless, but it also causes compile
    failures due to 'section type conflict' in those rare cases where
    param_set/get are local functions.

    This fixes http://bugzilla.kernel.org/show_bug.cgi?id=8964

    Signed-off-by: Ivan Kokshaysky
    Cc: Richard Henderson
    Cc: "Luck, Tony"
    Cc: Anton Blanchard
    Cc: Paul Mackerras
    Cc: Adrian Bunk
    Cc: Kamalesh Babulal
    Cc: Rusty Russell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ivan Kokshaysky
     

29 Jan, 2008

1 commit


17 Oct, 2007

1 commit


20 Feb, 2007

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial: (25 commits)
    Documentation/kernel-docs.txt update.
    arch/cris: typo in KERN_INFO
    Storage class should be before const qualifier
    kernel/printk.c: comment fix
    update I/O sched Kconfig help texts - CFQ is now default, not AS.
    Remove duplicate listing of Cris arch from README
    kbuild: more doc. cleanups
    doc: make doc. for maxcpus= more visible
    drivers/net/eexpress.c: remove duplicate comment
    add a help text for BLK_DEV_GENERIC
    correct a dead URL in the IP_MULTICAST help text
    fix the BAYCOM_SER_HDX help text
    fix SCSI_SCAN_ASYNC help text
    trivial documentation patch for platform.txt
    Fix typos concerning hierarchy
    Fix comment typo "spin_lock_irqrestore".
    Fix misspellings of "agressive".
    drivers/scsi/a100u2w.c: trivial typo patch
    Correct trivial typo in log2.h.
    Remove useless FIND_FIRST_BIT() macro from cardbus.c.
    ...

    Linus Torvalds
     

18 Feb, 2007

1 commit


17 Feb, 2007

1 commit


08 Dec, 2006

1 commit

  • One of the mistakes a module_param() user can make is to supply default
    value of module parameter as the last argument. module_param() accepts
    permissions instead. If default value is, say, 3 (-------wx), parameter
    becomes world-writeable.

    So far, the only remedy was to apply grep(1) and read drivers submitted
    to -mm. BTDT.

    With this patch applied, compiler will finally do some job.

    *) bounds checking on permissions
    *) world-writeable bit checking on permissions
    *) compile breakage if checks trigger

    First version of this check (only "& 2" part) directly caught 4 out of 7
    places during my last grep.

    Subject: Neverending module_param() bugs
    [X] drivers/acpi/sbs.c:101:module_param(capacity_mode, int, CAPACITY_UNIT);
    [X] drivers/acpi/sbs.c:102:module_param(update_mode, int, UPDATE_MODE);
    [ ] drivers/acpi/sbs.c:103:module_param(update_info_mode, int, UPDATE_INFO_MODE);
    [ ] drivers/acpi/sbs.c:104:module_param(update_time, int, UPDATE_TIME);
    [ ] drivers/acpi/sbs.c:105:module_param(update_time2, int, UPDATE_TIME2);
    [X] drivers/char/watchdog/sbc8360.c:203:module_param(timeout, int, 27);
    [X] drivers/media/video/tuner-simple.c:13:module_param(offset, int, 0666);

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     

26 Mar, 2006

1 commit


07 Jan, 2006

1 commit

  • Now when kbuild passes KBUILD_MODNAME with "" do not __stringify it when
    used. Remove __stringnify for all users.
    This also fixes the output of:

    $ ls -l /sys/module/
    drwxr-xr-x 4 root root 0 2006-01-05 14:24 pcmcia
    drwxr-xr-x 4 root root 0 2006-01-05 14:24 pcmcia_core
    drwxr-xr-x 3 root root 0 2006-01-05 14:24 "processor"
    drwxr-xr-x 3 root root 0 2006-01-05 14:24 "psmouse"

    The quoting of the module names will be gone again.
    Thanks to GregKH + Kay Sievers for reproting this.

    Signed-off-by: Sam Ravnborg

    Sam Ravnborg
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds