30 Mar, 2009
1 commit
-
The uuid table handling should not be part of a semi-generic uuid library
but in the XFS code using it, so move those bits to xfs_mount.c and
refactor the whole glob to make it a proper abstraction.Signed-off-by: Christoph Hellwig
Reviewed-by: Felix Blyakher
15 Mar, 2009
1 commit
-
xfs_mount.h, which it depends on.
Reported-by: Stephen Rothwell
Reviewed-by: Christoph Hellwig
Reviewed-by: Alex Elder
Signed-off-by: Felix Blyakher
07 Mar, 2009
1 commit
-
Fix this sparse warnings:
fs/xfs/linux-2.6/xfs_ioctl.c:72:1: warning: symbol 'xfs_find_handle' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:249:1: warning: symbol 'xfs_open_by_handle' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:361:1: warning: symbol 'xfs_readlink_by_handle' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:496:1: warning: symbol 'xfs_attrmulti_attr_get' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:525:1: warning: symbol 'xfs_attrmulti_attr_set' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:555:1: warning: symbol 'xfs_attrmulti_attr_remove' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:657:1: warning: symbol 'xfs_ioc_space' was not declared. Should it be static?
fs/xfs/linux-2.6/xfs_ioctl.c:1340:1: warning: symbol 'xfs_file_ioctl' was not declared. Should it be static?
fs/xfs/support/debug.c:65:1: warning: symbol 'xfs_fs_vcmn_err' was not declared. Should it be static?
fs/xfs/support/debug.c:112:1: warning: symbol 'xfs_hex_dump' was not declared. Should it be static?Signed-off-by: Hannes Eder
Reviewed-by: Christoph Hellwig
Signed-off-by: Felix Blyakher
22 Dec, 2008
1 commit
-
xfs_fs_vcmn_err can be called under a spinlock, but does a sleeping memory
allocation to create buffer for it's internal sprintf. Fortunately it's
the only caller of icmn_err, so we can merge the two and have one single
static buffer and spinlock protecting it. While we're at it make sure
we proper __attribute__ format annotations so that the compiler can detect
mismatched format strings.Reported-by: Alexander Beregalov
Signed-off-by: Christoph Hellwig
Reviewed-by: Eric Sandeen
Signed-off-by: Lachlan McIlroy
05 Dec, 2008
1 commit
-
entries_size is probably left over from when we used to pass the
size to kmem_free().Signed-off-by: Lachlan McIlroy
Reviewed-by: Christoph Hellwig
Reviewed-by: Eric Sandeen
30 Oct, 2008
1 commit
-
SGI-PV: 987246
SGI-Modid: xfs-linux-melb:xfs-kern:32233a
Signed-off-by: Barry Naujok
Signed-off-by: Eric Sandeen
Signed-off-by: Lachlan McIlroy
28 Jul, 2008
2 commits
-
Currently the xfs module init/exit code is a mess. It's farmed out over a
lot of function with very little error checking. This patch makes sure we
propagate all initialization failures properly and clean up after them.
Various runtime initializations are replaced with compile-time
initializations where possible to make this easier. The exit path is
similarly consolidated.There's now split out function to create/destroy the kmem zones and
alloc/free the trace buffers. I've also changed the ktrace allocations to
KM_MAYFAIL and handled errors resulting from that.And yes, we really should replace the XFS_*_TRACE ifdefs with a single
XFS_TRACE..SGI-PV: 976035
SGI-Modid: xfs-linux-melb:xfs-kern:31354a
Signed-off-by: Christoph Hellwig
Signed-off-by: Niv Sardi
Signed-off-by: Lachlan McIlroy -
kmem_free() function takes (ptr, size) arguments but doesn't actually use
second one.This patch removes size argument from all callsites.
SGI-PV: 981498
SGI-Modid: xfs-linux-melb:xfs-kern:31050aSigned-off-by: Denys Vlasenko
Signed-off-by: David Chinner
Signed-off-by: Lachlan McIlroy
30 Apr, 2008
1 commit
-
Noted-by: Stephen Rothwell
Signed-off-by: Dave Chinner
Signed-off-by: Linus Torvalds
18 Apr, 2008
2 commits
-
Now that the ktrace_enter() code is using atomics, the non-power-of-2
buffer sizes - which require modulus operations to get the index - are
showing up as using substantial CPU in the profiles.Force the buffer sizes to be rounded up to the nearest power of two and
use masking rather than modulus operations to convert the index counter to
the buffer index. This reduces ktrace_enter overhead to 8% of a CPU time,
and again almost halves the trace intensive test runtime.SGI-PV: 977546
SGI-Modid: xfs-linux-melb:xfs-kern:30538aSigned-off-by: David Chinner
Signed-off-by: Christoph Hellwig
Signed-off-by: Lachlan McIlroy -
ktrace_enter() is consuming vast amounts of CPU time due to the use of a
single global lock for protecting buffer index increments. Change it to
use per-buffer atomic counters - this reduces ktrace_enter() overhead
during a trace intensive test on a 4p machine from 58% of all CPU time to
12% and halves test runtime.SGI-PV: 977546
SGI-Modid: xfs-linux-melb:xfs-kern:30537aSigned-off-by: David Chinner
Signed-off-by: Christoph Hellwig
Signed-off-by: Lachlan McIlroy
07 Feb, 2008
4 commits
-
SGI-PV: 971186
SGI-Modid: xfs-linux-melb:xfs-kern:30459aSigned-off-by: Lachlan McIlroy
Signed-off-by: Denis Cheng -
No need for xfs to have its own hex dumping routine now that the kernel
has one.SGI-PV: 971186
SGI-Modid: xfs-linux-melb:xfs-kern:29847aSigned-off-by: Eric Sandeen
Signed-off-by: Lachlan McIlroy
Signed-off-by: Tim Shimmin -
remove spinlock init abstraction macro in spin.h, remove the callers, and
remove the file. Move no-op spinlock_destroy to xfs_linux.h Cleanup
spinlock locals in xfs_mount.cSGI-PV: 970382
SGI-Modid: xfs-linux-melb:xfs-kern:29751aSigned-off-by: Eric Sandeen
Signed-off-by: Donald Douwsma
Signed-off-by: Lachlan McIlroy
Signed-off-by: Tim Shimmin -
SGI-PV: 970382
SGI-Modid: xfs-linux-melb:xfs-kern:29747aSigned-off-by: Eric Sandeen
Signed-off-by: Donald Douwsma
Signed-off-by: Tim Shimmin
15 Oct, 2007
1 commit
-
Kill uio related functions and defines now that they're unused.
SGI-PV: 968563
SGI-Modid: xfs-linux-melb:xfs-kern:29480aSigned-off-by: Christoph Hellwig
Signed-off-by: David Chinner
Signed-off-by: Tim Shimmin
05 Sep, 2007
1 commit
-
- remove the != 0 inside the unlikely in ASSERT_ALWAYS because sparse now
complains about comparisons between pointers and 0
- add a standalone ASSERT implementation because defining it to
ASSERT_ALWAYS means the string is expanded before the token passing
stringification. This way we get the actual content of the
assertion in the assfail message and don't overflow sparse's
stringification buffer leading to sparse error messages.SGI-PV: 968555
SGI-Modid: xfs-linux-melb:xfs-kern:29310aSigned-off-by: Christoph Hellwig
Signed-off-by: David Chinner
Signed-off-by: Tim Shimmin
08 May, 2007
1 commit
-
Patch provided by Joe Perches
SGI-PV: 961696
SGI-Modid: xfs-linux-melb:xfs-kern:28209aSigned-off-by: Joe Perches
Signed-off-by: Lachlan McIlroy
Signed-off-by: Tim Shimmin
10 Feb, 2007
3 commits
-
SGI-PV: 954580
SGI-Modid: xfs-linux-melb:xfs-kern:27701aSigned-off-by: Lachlan McIlroy
Signed-off-by: Christoph Hellwig
Signed-off-by: Tim Shimmin -
gcc-4.1 and more recent aggressively inline static functions which
increases XFS stack usage by ~15% in critical paths. Prevent this from
occurring by adding noinline to the STATIC definition.Also uninline some functions that are too large to be inlined and were
causing problems with CONFIG_FORCED_INLINING=y.Finally, clean up all the different users of inline, __inline and
__inline__ and put them under one STATIC_INLINE macro. For debug kernels
the STATIC_INLINE macro uninlines those functions.SGI-PV: 957159
SGI-Modid: xfs-linux-melb:xfs-kern:27585aSigned-off-by: David Chinner
Signed-off-by: David Chatterton
Signed-off-by: Tim Shimmin -
The message buffer used by cmn_err() is only 256 bytes and some CXFS
messages were exceeding this length. Since we were using vsprintf() and
not checking for buffer overruns we were clobbering memory beyond the
buffer. The size of the buffer has been increased to 1024 bytes so we can
capture these larger messages and we are now using vsnprintf() to prevent
overrunning the buffer size.SGI-PV: 958599
SGI-Modid: xfs-linux-melb:xfs-kern:27561aSigned-off-by: Lachlan McIlroy
Signed-off-by: Geoffrey Wehrman
Signed-off-by: Tim Shimmin
11 Nov, 2006
2 commits
-
SGI-PV: 957004
SGI-Modid: xfs-linux-melb:xfs-kern:27231aSigned-off-by: Vlad Apostolov
Signed-off-by: Tim Shimmin -
CONFIG_XFS_TRACE is on
SGI-PV: 956618
SGI-Modid: xfs-linux-melb:xfs-kern:27196aSigned-off-by: Vlad Apostolov
Signed-off-by: Tim Shimmin
04 Oct, 2006
1 commit
-
This patch converts two if () BUG(); construct to BUG_ON();
which occupies less space, uses unlikely and is safer when
BUG() is disabled.Signed-off-by: Eric Sesterhenn
Signed-off-by: Adrian Bunk
28 Sep, 2006
1 commit
-
one page.
SGI-PV: 955302
SGI-Modid: xfs-linux-melb:xfs-kern:26800aSigned-off-by: Nathan Scott
Signed-off-by: Tim Shimmin
09 Jun, 2006
1 commit
-
interface.
SGI-PV: 953338
SGI-Modid: xfs-linux-melb:xfs-kern:26103aSigned-off-by: Nathan Scott
22 Mar, 2006
1 commit
-
Engelhardt.
SGI-PV: 947038
SGI-Modid: xfs-linux-melb:xfs-kern:25529aSigned-off-by: Nathan Scott
14 Mar, 2006
1 commit
-
swapped with be32_to_cpu.
SGI-PV: 943272
SGI-Modid: xfs-linux-melb:xfs-kern:25232aSigned-off-by: Christoph Hellwig
Signed-off-by: Nathan Scott
12 Jan, 2006
1 commit
-
equivalents.
SGI-PV: 907752
SGI-Modid: xfs-linux-melb:xfs-kern:24961aSigned-off-by: Nathan Scott
11 Jan, 2006
2 commits
-
SGI-PV: 943272
SGI-Modid: xfs-linux-melb:xfs-kern:203709aSigned-off-by: Christoph Hellwig
Signed-off-by: Nathan Scott -
spotting these.
SGI-PV: 946028
SGI-Modid: xfs-linux-melb:xfs-kern:202617aSigned-off-by: Christoph Hellwig
Signed-off-by: Nathan Scott
10 Jan, 2006
1 commit
-
This patch switches XFS over to use the new mutex code directly as
opposed to the previous workaround patch I posted earlier that avoided
the namespace clash by forcing it back to semaphores. This falls in the
'works for me' category.Signed-off-by: Jes Sorensen
Signed-off-by: Ingo Molnar
04 Nov, 2005
1 commit
-
Signed-off-by: Nathan Scott
02 Nov, 2005
3 commits
-
SGI-PV: 943556
SGI-Modid: xfs-linux:xfs-kern:200113aSigned-off-by: Christoph Hellwig
Signed-off-by: Nathan Scott -
boilerplate.
SGI-PV: 913862
SGI-Modid: xfs-linux:xfs-kern:23903aSigned-off-by: Nathan Scott
-
SGI-PV: 942243
SGI-Modid: xfs-linux:xfs-kern:198658aSigned-off-by: Christoph Hellwig
Signed-off-by: Nathan Scott
10 Sep, 2005
1 commit
-
This converts the final 20 DEFINE_SPINLOCK holdouts. (another 580 places
are already using DEFINE_SPINLOCK). Build tested on x86.Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
05 Sep, 2005
1 commit
-
SGI-PV: 904196
SGI-Modid: xfs-linux-melb:xfs-kern:23719aSigned-off-by: Nathan Scott
21 Jun, 2005
1 commit
-
SGI-PV: 938063
SGI-Modid: xfs-linux:xfs-kern:194416aSigned-off-by: Christoph Hellwig
Signed-off-by: Nathan Scott
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!