15 Oct, 2007

11 commits

  • Now that nobody's using it, remove xfs_physmem & friends.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29325a

    Signed-off-by: Eric Sandeen
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Eric Sandeen
     
  • Remove scaling of inode "clusters" based on machine memory; small cluster
    cut-point was an unrealistic 32MB and was probably never tested.

    Removes another user of xfs_physmem.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29324a

    Signed-off-by: Eric Sandeen
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Eric Sandeen
     
  • Remove sizing of logbuf size & count based on physical memory; this was
    never a very good gauge as it's looking at global memory, but deciding on
    sizing per-filesystem; no account is made of the total number of
    filesystems, for example.

    For now just take the largest "default" case, as was set for machines with
    >400MB - 8 x 32k buffers. This can always be tuned higher or lower with
    mount options if necessary. Removes one more user of xfs_physmem.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29323a

    Signed-off-by: Eric Sandeen
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Eric Sandeen
     
  • m_nreadaheads in the mount struct is never used; remove it and the various
    macros assigned to it. Also remove a couple other unused macros in the
    same areas.

    Removes one user of xfs_physmem.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29322a

    Signed-off-by: Eric Sandeen
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Eric Sandeen
     
  • SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29321a

    Signed-off-by: Christoph Hellwig
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Christoph Hellwig
     
  • The BMBT_*BITLEN are currently defined in a complicated way depending on
    XFS_NATIVE_HOST. But if all the macros are expanded they (obviously)
    expand to the same value for both cases.

    This patch defines the macros in the most simple way and updates the
    comment describing them to remove outdated bits.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29320a

    Signed-off-by: Christoph Hellwig
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Christoph Hellwig
     
  • xfs_bmbt_set_all/xfs_bmbt_disk_set_all are identical to
    xfs_bmbt_set_allf/xfs_bmbt_disk_set_allf except that the former take a
    xfs_bmbt_irec_t and the latter take the individual extent fields as scalar
    values.

    This patch reimplements xfs_bmbt_set_all/xfs_bmbt_disk_set_all as trivial
    wrappers around xfs_bmbt_set_allf/xfs_bmbt_disk_set_allf and cleans up the
    variable naming in xfs_bmbt_set_allf/xfs_bmbt_disk_set_allf to have some
    meaning instead of one char variable names.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29319a

    Signed-off-by: Christoph Hellwig
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Christoph Hellwig
     
  • currently xfs_bmbt_rec_t is used both for ondisk extents as well as
    host-endian ones. This patch adds a new xfs_bmbt_rec_host_t for the native
    endian ones and cleans up the fallout. There have been various endianess
    issues in the tracing / debug printf code that are fixed by this patch.

    SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29318a

    Signed-off-by: Christoph Hellwig
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Christoph Hellwig
     
  • SGI-PV: 968563
    SGI-Modid: xfs-linux-melb:xfs-kern:29317a

    Signed-off-by: Christoph Hellwig
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Christoph Hellwig
     
  • SGI-PV: 967674
    SGI-Modid: xfs-linux-melb:xfs-kern:29211a

    Signed-off-by: Vlad Apostolov
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Vlad Apostolov
     
  • If the underlying block device suddenly stops supporting barriers, we need
    to handle the -EOPNOTSUPP error in a sane manner rather than shutting
    down the filesystem. If we get this error, clear the barrier flag, reissue
    the I/O, and tell the world bad things are occurring.

    SGI-PV: 964544
    SGI-Modid: xfs-linux-melb:xfs-kern:28568a

    Signed-off-by: David Chinner
    Signed-off-by: Christoph Hellwig
    Signed-off-by: Tim Shimmin

    David Chinner
     

11 Oct, 2007

1 commit


10 Oct, 2007

4 commits


09 Oct, 2007

10 commits

  • The PCI controller IO base was not set in the au1000 pci code.

    Signed-off-by: Felix Fietkau
    Signed-off-by: John Crispin
    Signed-off-by: Florian Fainelli
    Signed-off-by: Ralf Baechle

    Florian Fainelli
     
  • This patch fixes a wrong ifdef in the board setup code, leading to the GPIO
    pin not being pulled high, and thus the USB switch not being powered at all.

    This finishes the rename of CONFIG_USB_OHCI to CONFIG_USB_OHCI_HCD, which
    started in 2005 (before 2.6.12-rc2), then probably because things were
    working anyway for most people got forgotten.

    [Ralf: Paolo's original patch didn't fix the module case, Florian's patch
    only fixed MTX1 etc. so this is a combined patch plus some cleanups.]

    Cc: Giuseppe Patanè
    Cc: Ralf Baechle
    Signed-off-by: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Felix Fietkau
    Signed-off-by: John Crispin
    Signed-off-by: Florian Fainelli
    Signed-off-by: Ralf Baechle

    Florian Fainelli
     
  • Signed-off-by: Giuseppe Sacco
    Signed-off-by: Ralf Baechle

    Giuseppe Sacco
     
  • When building a custom keymap, after setting GENERATE_KEYMAP := 1 in
    drivers/char/Makefile, the kernel build fails like this:

    CC drivers/char/vt.o
    make[2]: *** No rule to make target `drivers/char/%.map', needed by `drivers/char/defkeymap.c'. Stop.
    make[1]: *** [drivers/char] Error 2
    make: *** [drivers] Error 2

    This was caused by commit af8b128719f5248e542036ea994610a29d0642a6, which
    deleted a necessary colon from the Makefile rule that generates the keymap,
    since that rule contains both a target and a target-pattern. The following
    patch puts the colon back:

    Signed-off-by: Maarten Bressers
    Cc: Yoichi Yuasa
    Cc: Ralf Baechle
    Cc: Sam Ravnborg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Maarten Bressers
     
  • Fix against access random data bytes outside the dev->chanmap array.
    Thanks to Oliver Neukum for pointing me to this issue.

    Signed-off-by: Karsten Keil
    Signed-off-by: Linus Torvalds

    Karsten Keil
     
  • * 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6:
    [IPv6]: Fix ICMPv6 redirect handling with target multicast address
    [PKT_SCHED] cls_u32: error code isn't been propogated properly
    [ROSE]: Fix rose.ko oops on unload
    [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed

    Linus Torvalds
     
  • When IOCB_FLAG_RESFD flag is set and iocb->aio_resfd is incorrect,
    statement 'goto out_put_req' is executed. At label 'out_put_req',
    aio_put_req(..) is called, which requires 'req->ki_filp' set.

    Signed-off-by: Yan Zheng
    Cc: Zach Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yan Zheng
     
  • find_lock_page increases page's usage count, we should decrease it
    before return VM_FAULT_SIGBUS

    Signed-off-by: Yan Zheng
    Cc: Nick Piggin
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yan Zheng
     
  • The test for VM_CAN_NONLINEAR always fails

    Signed-off-by: Yan Zheng
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yan Zheng
     
  • All the current page_mkwrite() implementations also set the page dirty. Which
    results in the set_page_dirty_balance() call to _not_ call balance, because the
    page is already found dirty.

    This allows us to dirty a _lot_ of pages without ever hitting
    balance_dirty_pages(). Not good (tm).

    Force a balance call if ->page_mkwrite() was successful.

    Signed-off-by: Peter Zijlstra
    Signed-off-by: Linus Torvalds

    Peter Zijlstra
     

08 Oct, 2007

14 commits

  • When the ICMPv6 Target address is multicast, Linux processes the
    redirect instead of dropping it. The problem is in this code in
    ndisc_redirect_rcv():

    if (ipv6_addr_equal(dest, target)) {
    on_link = 1;
    } else if (!(ipv6_addr_type(target) & IPV6_ADDR_LINKLOCAL)) {
    ND_PRINTK2(KERN_WARNING
    "ICMPv6 Redirect: target address is not
    link-local.\n");
    return;
    }

    This second check will succeed if the Target address is, for example,
    FF02::1 because it has link-local scope. Instead, it should be checking
    if it's a unicast link-local address, as stated in RFC 2461/4861 Section
    8.1:

    - The ICMP Target Address is either a link-local address (when
    redirected to a router) or the same as the ICMP Destination
    Address (when redirected to the on-link destination).

    I know this doesn't explicitly say unicast link-local address, but it's
    implied.

    This bug is preventing Linux kernels from achieving IPv6 Logo Phase II
    certification because of a recent error that was found in the TAHI test
    suite - Neighbor Disovery suite test 206 (v6LC.2.3.6_G) had the
    multicast address in the Destination field instead of Target field, so
    we were passing the test. This won't be the case anymore.

    The patch below fixes this problem, and also fixes ndisc_send_redirect()
    to not send an invalid redirect with a multicast address in the Target
    field. I re-ran the TAHI Neighbor Discovery section to make sure Linux
    passes all 245 tests now.

    Signed-off-by: Brian Haley
    Acked-by: David L Stevens
    Signed-off-by: David S. Miller

    Brian Haley
     
  • Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     
  • Commit a3d384029aa304f8f3f5355d35f0ae274454f7cd aka
    "[AX.25]: Fix unchecked rose_add_loopback_neigh uses"
    transformed rose_loopback_neigh var into statically allocated one.
    However, on unload it will be kfree's which can't work.

    Steps to reproduce:

    modprobe rose
    rmmod rose

    BUG: unable to handle kernel NULL pointer dereference at virtual address 00000008
    printing eip:
    c014c664
    *pde = 00000000
    Oops: 0000 [#1]
    PREEMPT DEBUG_PAGEALLOC
    Modules linked in: rose ax25 fan ufs loop usbhid rtc snd_intel8x0 snd_ac97_codec ehci_hcd ac97_bus uhci_hcd thermal usbcore button processor evdev sr_mod cdrom
    CPU: 0
    EIP: 0060:[] Not tainted VLI
    EFLAGS: 00210086 (2.6.23-rc9 #3)
    EIP is at kfree+0x48/0xa1
    eax: 00000556 ebx: c1734aa0 ecx: f6a5e000 edx: f7082000
    esi: 00000000 edi: f9a55d20 ebp: 00200287 esp: f6a5ef28
    ds: 007b es: 007b fs: 0000 gs: 0033 ss: 0068
    Process rmmod (pid: 1823, ti=f6a5e000 task=f7082000 task.ti=f6a5e000)
    Stack: f9a55d20 f9a5200c 00000000 00000000 00000000 f6a5e000 f9a5200c f9a55a00
    00000000 bf818cf0 f9a51f3f f9a55a00 00000000 c0132c60 65736f72 00000000
    f69f9630 f69f9528 c014244a f6a4e900 00200246 f7082000 c01025e6 00000000
    Call Trace:
    [] rose_rt_free+0x1d/0x49 [rose]
    [] rose_rt_free+0x1d/0x49 [rose]
    [] rose_exit+0x4c/0xd5 [rose]
    [] sys_delete_module+0x15e/0x186
    [] remove_vma+0x40/0x45
    [] sysenter_past_esp+0x8f/0x99
    [] trace_hardirqs_on+0x118/0x13b
    [] sysenter_past_esp+0x5f/0x99
    =======================
    Code: 05 03 1d 80 db 5b c0 8b 03 25 00 40 02 00 3d 00 40 02 00 75 03 8b 5b 0c 8b 73 10 8b 44 24 18 89 44 24 04 9c 5d fa e8 77 df fd ff 56 08 89 f8 e8 84 f4 fd ff e8 bd 32 06 00 3b 5c 86 60 75 0f
    EIP: [] kfree+0x48/0xa1 SS:ESP 0068:f6a5ef28

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     
  • When only GSO skb was partially ACKed, no hints are reset,
    therefore fastpath_cnt_hint must be tweaked too or else it can
    corrupt fackets_out. The corruption to occur, one must have
    non-trivial ACK/SACK sequence, so this bug is not very often
    that harmful. There's a fackets_out state reset in TCP because
    fackets_out is known to be inaccurate and that fixes the issue
    eventually anyway.

    In case there was also at least one skb that got fully ACKed,
    the fastpath_skb_hint is set to NULL which causes a recount for
    fastpath_cnt_hint (the old value won't be accessed anymore),
    thus it can safely be decremented without additional checking.

    Reported by Cedric Le Goater

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: David S. Miller

    Ilpo Järvinen
     
  • We should only reparent to a class former class devices that
    form the base of class hierarchy. Nested devices should still
    grow from their real parents.

    Signed-off-by: Dmitry Torokhov
    Tested-by: Andrey Borzenkov
    Tested-by: Anssi Hannula
    Signed-off-by: Linus Torvalds

    Dmitry Torokhov
     
  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
    firewire: point to migration document

    Linus Torvalds
     
  • Add the manufacturer and card id of teltonica pcmcia modems to serial_cs.c

    Signed-off-by: Attila Kinali
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Attila Kinali
     
  • Document sequence of keypresses that actually works. Yes, this changed
    year-or-so ago.

    Signed-off-by: Pavel Machek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Pavel Machek
     
  • Async signals should not be reported as sent by current in audit log. As
    it is, we call audit_signal_info() too early in check_kill_permission().
    Note that check_kill_permission() has that test already - it needs to know
    if it should apply current-based permission checks. So the solution is to
    move the call of audit_signal_info() between those.

    Bogosity in question is easily reproduced - add a rule watching for e.g.
    kill(2) from specific process (so that audit_signal_info() would not
    short-circuit to nothing), say load_policy, watch the bogus OBJ_PID entry
    in audit logs claiming that write(2) on selinuxfs file issued by
    load_policy(8) had somehow managed to send a signal to syslogd...

    Signed-off-by: Al Viro
    Acked-by: Steve Grubb
    Acked-by: Eric Paris
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Al Viro
     
  • Modulat lguest started giving linking errors

    MODPOST 1 modules
    ERROR: "kasprintf" [drivers/lguest/lg.ko] undefined!

    Signed-off-by: Alexey Dobriyan
    Cc: Rusty Russell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     
  • Provide some documentation for CONFIG_LOCK_STAT.

    Signed-off-by: Peter Zijlstra
    Acked-by: Ingo Molnar
    Cc: "Randy.Dunlap"
    Cc: Rob Landley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Zijlstra
     
  • VIA C3 Ezra-T has RevisionID equal to 1, but it needs RevisionKey to be 0
    or CPU will ignore new frequency and will continue to work at old
    frequency. New "revid_errata" option will force RevisionKey to be set to
    0, whatever RevisionID is.

    Additionaly "Longhaul" will not silently ignore unsuccessful transition.
    It will try to check if "revid_errata" or "disable_acpi_c3" options need to
    be enabled for this processor/system.

    Same for Longhaul ver. 2 support. It will be disabled if none of above
    options will work.

    Best case scenario (with patch apllied and v2 enabled):
    longhaul: VIA C3 'Ezra' [C5C] CPU detected. Longhaul v2 supported.
    longhaul: Using northbridge support.
    longhaul: VRM 8.5
    longhaul: Max VID=1.350 Min VID=1.050, 13 possible voltage scales
    longhaul: f: 300000 kHz, index: 0, vid: 1050 mV
    [...]
    longhaul: Voltage scaling enabled.
    Worst case scenario:
    longhaul: VIA C3 'Ezra-T' [C5M] CPU detected. Powersaver supported.
    longhaul: Using northbridge support.
    longhaul: Using ACPI support.
    longhaul: VRM 8.5
    longhaul: Claims to support voltage scaling but min & max are both 1.250. Voltage scaling disabled
    longhaul: Failed to set requested frequency!
    longhaul: Enabling "Ignore Revision ID" option.
    longhaul: Failed to set requested frequency!
    longhaul: Disabling ACPI C3 support.
    longhaul: Disabling "Ignore Revision ID" option.
    longhaul: Failed to set requested frequency!
    longhaul: Enabling "Ignore Revision ID" option.

    [akpm@linux-foundation.org: coding-style cleanups]
    Signed-off-by: Rafal Bilski
    Signed-off-by: Dave Jones
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Rafal Bilski
     
  • When using /proc/timer_stats on ppc64 I noticed the events/sec field wasnt
    accurate. Sometimes the integer part was incorrect due to rounding (we
    werent taking the fractional seconds into consideration).

    The fraction part is also wrong, we need to pad the printf statement and
    take the bottom three digits of 1000 times the value.

    Signed-off-by: Anton Blanchard
    Acked-by: Ingo Molnar
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anton Blanchard
     
  • It turns out that there are a few other five-second timers in the
    kernel, and if the timers get in sync, the load-average can get
    artificially inflated by events that just happen to coincide.

    So just offset the load average calculation it by a timer tick.

    Noticed by Anders Boström, for whom the coincidence started triggering
    on one of his machines with the JBD jiffies rounding code (JBD is one of
    the subsystems that also end up using a 5-second timer by default).

    Tested-by: Anders Boström
    Cc: Chuck Ebbert
    Cc: Arjan van de Ven
    Cc: Andrew Morton
    Signed-off-by: Linus Torvalds

    Linus Torvalds