06 Aug, 2010

1 commit

  • of_device is just an alias for platform_device, so remove it entirely. Also
    replace to_of_device() with to_platform_device() and update comment blocks.

    This patch was initially generated from the following semantic patch, and then
    edited by hand to pick up the bits that coccinelle didn't catch.

    @@
    @@
    -struct of_device
    +struct platform_device

    Signed-off-by: Grant Likely
    Reviewed-by: David S. Miller

    Grant Likely
     

24 Jul, 2010

1 commit

  • Both of_bus_type and of_platform_bus_type are just #define aliases
    for the platform bus. This patch removes all references to them and
    switches to the of_register_platform_driver()/of_unregister_platform_driver()
    API for registering.

    Subsequent patches will convert each user of of_register_platform_driver()
    into plain platform_drivers without the of_platform_driver shim. At which
    point the of_register_platform_driver()/of_unregister_platform_driver()
    functions can be removed.

    Signed-off-by: Grant Likely
    Acked-by: David S. Miller

    Grant Likely
     

29 Jun, 2010

1 commit

  • This patch moves SPARC architecture specific data members out of
    struct of_device and into the pdev_archdata structure. The reason
    for this change is to unify the struct of_device definition amongst
    all the architectures. It also remvoes the .sysdata, .slot, .portid
    and .clock_freq properties because they aren't actually used by
    anything.

    A subsequent patch will replace struct of_device entirely with struct
    platform_device and the of_platform support code will share common
    routines with the platform bus (but the bus instances themselves can
    remain separate).

    This patch also adds 'struct resources *resource' and num_resources
    to match the fields defined in struct platform_device. After this
    change, 'struct platform_device' can be used as a drop-in replacement
    for 'struct of_platform'.

    This change is in preparation for merging the of_platform_bus_type
    with the platform_bus_type.

    Signed-off-by: Grant Likely
    Acked-by: David S. Miller
    Cc: Stephen Rothwell

    Grant Likely
     

22 May, 2010

1 commit

  • .name, .match_table and .owner are duplicated in both of_platform_driver
    and device_driver. This patch is a removes the extra copies from struct
    of_platform_driver and converts all users to the device_driver members.

    This patch is a pretty mechanical change. The usage model doesn't change
    and if any drivers have been missed, or if anything has been fixed up
    incorrectly, then it will fail with a compile time error, and the fixup
    will be trivial. This patch looks big and scary because it touches so
    many files, but it should be pretty safe.

    Signed-off-by: Grant Likely
    Acked-by: Sean MacLennan

    Grant Likely
     

19 May, 2010

1 commit


25 Nov, 2009

1 commit

  • RSC and LOM devices have fixed speed settings.

    We already had some code to match and handle "rsc" named devices on
    E250 systems, but we also have to handle 'rsc-console', 'rsc-control',
    and 'lom-console'.

    Also, in order to get this right regardless of what 'output-device'
    happens to be, explicitly pass the UART device node pointer to this
    routine.

    Signed-off-by: David S. Miller

    David S. Miller
     

20 Sep, 2009

1 commit


23 Jun, 2009

1 commit

  • In zs_console_putchar() occurs:

    if (zs_transmit_drain(zport, irq))
    write_zsdata(zport, ch);

    However if in zs_transmit_drain() no empty Tx Buffer occurs, limit reaches
    -1 => true, and the write still occurs.

    This patch changes postfix to prefix decrements in this and similar
    functions to prevent similar mistakes in the future. This decreases the
    iterations with one but the chosen loop count was arbitrary anyway.

    In sunhv limit reaches -1, not 0, so the test is off by one.

    Signed-off-by: Roel Kluin
    Acked-by: David S. Miller
    Acked-by: Maciej W. Rozycki
    Signed-off-by: Andrew Morton
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Roel Kluin
     

31 Aug, 2008

1 commit


12 Aug, 2008

1 commit


21 Jul, 2008

1 commit

  • Today's linux-next build (sparc64 defconfig) failed like this:

    drivers/serial/sunhv.c: In function `receive_chars':
    drivers/serial/sunhv.c:188: error: structure has no member named `tty'
    drivers/serial/sunsu.c: In function `receive_chars':
    drivers/serial/sunsu.c:314: error: structure has no member named `tty'
    drivers/serial/sunsab.c: In function `receive_chars':
    drivers/serial/sunsab.c:121: error: structure has no member named `tty'

    I applied the following patch (which, again, may not be correct).

    Signed-off-by: Stephen Rothwell
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Stephen Rothwell
     

21 May, 2008

1 commit


02 May, 2008

1 commit

  • They were all "serial" so if multiple of these drivers registered,
    we'd trigger sysfs directory creation errors:

    [ 1.695793] proc_dir_entry 'serial' already registered
    [ 1.695839] Call Trace:
    [ 1.831891] [00000000004f2534] create_proc_entry+0x7c/0x98
    [ 1.833608] [00000000004f3a58] proc_tty_register_driver+0x40/0x70
    [ 1.833663] [0000000000594700] tty_register_driver+0x1fc/0x208
    [ 1.835371] [00000000005aade4] uart_register_driver+0x134/0x16c
    [ 1.841762] [00000000005ac274] sunserial_register_minors+0x34/0x68
    [ 1.841818] [00000000007db2a4] sunsu_init+0xf8/0x150
    [ 1.867697] [00000000007c62a4] kernel_init+0x190/0x330
    [ 1.939147] [0000000000426cf8] kernel_thread+0x38/0x48
    [ 1.939198] [00000000006a0d90] rest_init+0x18/0x5c

    Signed-off-by: David S. Miller

    David S. Miller
     

12 Dec, 2007

1 commit

  • This patch against 2.6.23 sparc-2.6.git contains a number of minor
    cleanups of the sparc serial drivers. Initially I fixed this build
    warning:

    WARNING: vmlinux.o(.text+0x107a2c): Section mismatch: reference to .init.text:add_preferred_console (between 'sunserial_console_match' and 'sunserial_console_termios')

    which is done by declaring sunserial_console_match() as __init. This
    resulted in build warnings on sunserial_current_minor. To resolve
    these the variable was changed so it is no longer global, and to hide
    operations on it inside 2 new functions. These functions handle the
    UART minor handling code that is common to all sparc serial drivers.

    These changes allowed to clean up the uart counters in all the sparc
    serial drivers, and the administration of minor device numbers.

    Lastly, sunserial_console_termios() does not need to be exported since
    it is only called from non-modular code.

    Sadly, the following build warning still exists:

    WARNING: vmlinux.o(__ksymtab+0x2910): Section mismatch: reference to .init.text:sunserial_console_match (between '__ksymtab_sunserial_console_match' and '__ksymtab_sunserial_unregister_minors')

    This could be resolved by not exporting sunserial_console_match(), but
    this is not possible at the moment because it is being called from
    modular code. On the other hand, this is a bogus warning since it
    comes from a ksymtab section.

    Signed-off-by: Martin Habets
    Signed-off-by: David S. Miller

    Martin Habets
     

21 Jul, 2007

1 commit

  • The current scheme works on static interpretation of text names, which
    is wrong.

    The output-device setting, for example, must be resolved via an alias
    or similar to a full path name to the console device.

    Paths also contain an optional set of 'options', which starts with a
    colon at the end of the path. The option area is used to specify
    which of two serial ports ('a' or 'b') the path refers to when a
    device node drives multiple ports. 'a' is assumed if the option
    specification is missing.

    This was caught by the UltraSPARC-T1 simulator. The 'output-device'
    property was set to 'ttya' and we didn't pick upon the fact that this
    is an OBP alias set to '/virtual-devices/console'. Instead we saw it
    as the first serial console device, instead of the hypervisor console.

    The infrastructure is now there to take advantage of this to resolve
    the console correctly even in multi-head situations in fbcon too.

    Thanks to Greg Onufer for the bug report.

    Signed-off-by: David S. Miller

    David S. Miller
     

17 Jul, 2007

1 commit


16 Jul, 2007

1 commit


16 May, 2007

1 commit

  • Hypervisor interfaces need to be negotiated in order to use
    some API calls reliably. So add a small set of interfaces
    to request API versions and query current settings.

    This allows us to fix some bugs in the hypervisor console:

    1) If we can negotiate API group CORE of at least major 1
    minor 1 we can use con_read and con_write which can improve
    console performance quite a bit.

    2) When we do a console write request, we should hold the
    spinlock around the whole request, not a byte at a time.
    What would happen is that it's easy for output from
    different cpus to get mixed with each other.

    3) Use consistent udelay() based polling, udelay(1) each
    loop with a limit of 1000 polls to handle stuck hypervisor
    console.

    Signed-off-by: David S. Miller

    David S. Miller
     

14 May, 2007

1 commit


09 Dec, 2006

1 commit

  • This is the grungy swap all the occurrences in the right places patch that
    goes with the updates. At this point we have the same functionality as
    before (except that sgttyb() returns speeds not zero) and are ready to
    begin turning new stuff on providing nobody reports lots of bugs

    If you are a tty driver author converting an out of tree driver the only
    impact should be termios->ktermios name changes for the speed/property
    setting functions from your upper layers.

    If you are implementing your own TCGETS function before then your driver
    was broken already and its about to get a whole lot more painful for you so
    please fix it 8)

    Also fill in c_ispeed/ospeed on init for most devices, although the current
    code will do this for you anyway but I'd like eventually to lose that extra
    paranoia

    [akpm@osdl.org: bluetooth fix]
    [mp3@de.ibm.com: sclp fix]
    [mp3@de.ibm.com: warning fix for tty3270]
    [hugh@veritas.com: fix tty_ioctl powerpc build]
    [jdike@addtoit.com: uml: fix ->set_termios declaration]
    Signed-off-by: Alan Cox
    Signed-off-by: Martin Peschke
    Acked-by: Peter Oberparleiter
    Cc: Cornelia Huck
    Signed-off-by: Hugh Dickins
    Signed-off-by: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

01 Jul, 2006

1 commit


27 Jun, 2006

1 commit


24 Jun, 2006

1 commit


20 Mar, 2006

8 commits