23 Apr, 2013
1 commit
-
If we're not maxed out then oz_get_pd_list() leaves part of the "list"
struct uninitialized. We should clear this so that no stack information
is leaked to userspace.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
16 Feb, 2013
11 commits
-
This patch marks function parameters that are used read only
as well as readonly structs (and corresponding pointers) as const.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
oz_cdev_heartbeat is empty and unused -> safe to remove.
Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
sparse complains about the following functions
ozhcd.c:330:20: warning: symbol 'oz_uncancel_urb' was not declared. Should it be static?
ozhcd.c:420:6: warning: symbol 'oz_complete_buffered_urb' was not declared. Should it be static?
ozmain.c:25:6: warning: symbol 'g_net_dev' was not declared. Should it be static?
ozevent.c:95:5: warning: symbol 'oz_events_open' was not declared. Should it be static?
ozevent.c:110:5: warning: symbol 'oz_events_release' was not declared. Should it be static?
ozevent.c:121:9: warning: symbol 'oz_events_read' was not declared. Should it be static?
ozevent.c:160:30: warning: symbol 'oz_events_fops' was not declared. Should it be static?
ozcdev.c:47:14: warning: symbol 'g_oz_class' was not declared. Should it be static?
ozcdev.c:74:5: warning: symbol 'oz_cdev_open' was not declared. Should it be static?
ozcdev.c:86:5: warning: symbol 'oz_cdev_release' was not declared. Should it be static?
ozcdev.c:94:9: warning: symbol 'oz_cdev_read' was not declared. Should it be static?
ozcdev.c:146:9: warning: symbol 'oz_cdev_write' was not declared. Should it be static?
ozcdev.c:236:6: warning: symbol 'oz_cdev_ioctl' was not declared. Should it be static?
ozcdev.c:300:14: warning: symbol 'oz_cdev_poll' was not declared. Should it be static?
ozcdev.c:321:30: warning: symbol 'oz_fops' was not declared. Should it be static?
ozproto.c:958:6: warning: context imbalance in 'oz_polling_lock_bh' - wrong count at exit
ozproto.c:964:6: warning: context imbalance in 'oz_polling_unlock_bh' - unexpected unlock
ozusbsvc1.c:308:6: warning: symbol 'oz_usb_handle_ep_data' was not declared. Should it be static?
ozpd.c:410:6: warning: symbol 'oz_set_more_bit' was not declared. Should it be static?
ozpd.c:418:6: warning: symbol 'oz_set_last_pkt_nb' was not declared. Should it be static?-> add static keyword to silence the warning and make sparse happy.
Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
ozcdev.c and ozhcd.c should include their own header file, so sparse
knows which functions are declared and which not.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the warning "Using plain integer as NULL pointer",
generated by sparse, by replacing the offending 0s with NULL.If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.Signed-off-by: Peter Huewe
Reviewed-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
30 Jan, 2013
1 commit
-
The patch ae926051d7eb: "staging: ozwpan: Added USB HCD
implementation" from Feb 20, 2012, leads to the following warning:
drivers/staging/ozwpan/ozhcd.c:1094 oz_hcd_heartbeat()
warn: what is this condition about? 'ep->buffered_units * 50'Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman
26 Jan, 2013
2 commits
-
As part of transition caused due to acquisition of Ozmo Devices by Atmel,
my email address is changed.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
Removed myself (ckelly@ozmodevices.com) as maintainer of ozwpan.
Removed my email address from the TODO file.Signed-off-by: Greg Kroah-Hartman
22 Nov, 2012
4 commits
-
kfree on NULL pointer is a no-op.
Signed-off-by: Sachin Kamat
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
kfree on NULL pointer is a no-op.
Signed-off-by: Sachin Kamat
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
kfree on NULL pointer is a no-op.
Signed-off-by: Sachin Kamat
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
oz_events_clear() is referenced only when CONFIG_DEBUG_FS is defined.
Move the definition too under this flag.Signed-off-by: Sachin Kamat
Acked-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman
01 Nov, 2012
1 commit
-
Some driver uses tasklet_disable in device remove/release process,
tasklet_disable will inc tasklet->count and return. If the tasklet
is not handled yet under some softirq pressure, the tasklet will be
placed on the tasklet_vec, never have a chance to be excuted. This might
lead to a heavy loaded ksoftirqd, wakeup with pending_softirq, but
tasklet is disabled. tasklet_kill should be used in this case.Signed-off-by: Xiaotian Feng
Cc: Rupesh Gujare
Cc: Chris Kelly
Signed-off-by: Greg Kroah-Hartman
19 Sep, 2012
1 commit
-
Generated by: scripts/coccinelle/null/badzero.cocci
Signed-off-by: Fengguang Wu
Signed-off-by: Greg Kroah-Hartman
17 Sep, 2012
1 commit
-
This pulls in the staging tree fixes in 3.6-rc6 into our branch to resolve the
merge issues.Signed-off-by: Greg Kroah-Hartman
06 Sep, 2012
1 commit
-
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)Signed-off-by: Wei Yongjun
Signed-off-by: Greg Kroah-Hartman
05 Sep, 2012
3 commits
-
Remove pointless conditional before kfree_skb().
Signed-off-by: Wei Yongjun
Acked-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
Fix spelling typo in staging/ozwpan
Signed-off-by: Masanari Iida
Signed-off-by: Greg Kroah-Hartman -
"addr" is a pointer so it's either 4 or 8 bytes, but actually we want
to compare 6 bytes (ETH_ALEN).As network stack already provides helper function
is_zero_ether_addr() we use that instead of memcmpSigned-off-by: Tomas Winkler
Acked-by: Dan Carpenter
Acked-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman
14 Aug, 2012
5 commits
-
Bump version numbers to keep in sync with internal
version information.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
Set audio latency. This fixes issue where audio clips heard during
link outage.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
This fixes issue where wrong retrun value was received
by userland application after writing data to raw hid device.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
This patch fixes issue caused due to different HZ
value on system which do not have HZ=1000Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
For interrupt end point buffer frames, if urb is not available
& give back as soon as urb is received from usb core.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman
27 Jun, 2012
2 commits
-
Update TODO file.
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
Destroy device node & unregister device class from sysfs while unloading
driverSigned-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman
21 Jun, 2012
6 commits
-
Set packet priority to AC_VO for audio data.
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
Register ozmo_wpan class with sysfs & support for udev
to create device node.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
In case of trigeered ISOC mode set last_pkt_nb only when
we are ready to send data.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
Pass right flag as memory is assigned in process
context.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
ioctl numbers were not in order, rearranging them in ascending order.
Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman -
This patch implements ISOC frame transfer while PD is in
triggered mode.Signed-off-by: Rupesh Gujare
Signed-off-by: Greg Kroah-Hartman
03 May, 2012
1 commit
-
This resolves the conflict in:
drivers/staging/vt6656/ioctl.cSigned-off-by: Greg Kroah-Hartman