04 Nov, 2007
1 commit
-
The regression was caused by:
commit[a32ea1e1f925399e0d81ca3f7394a44a6dafa12c] Fix read/truncate raceThis causes ntfs_readpage() to be called for a zero i_size inode, which
failed when the file was compressed and non-resident.Thanks a lot to Mike Galbraith for reporting the issue and tracking down
the commit that caused the regression.Looking into it I found three bugs which the patch fixes.
Signed-off-by: Anton Altaparmakov
Tested-by: Mike Galbraith
Signed-off-by: Linus Torvalds
13 Oct, 2007
1 commit
-
Big thanks go to Mathias Kolehmainen for reporting the bug, providing
debug output and testing the patches I sent him to get it working.The fix was to stop calling ntfs_attr_set() at mount time as that causes
balance_dirty_pages_ratelimited() to be called which on systems with
little memory actually tries to go and balance the dirty pages which tries
to take the s_umount semaphore but because we are still in fill_super()
across which the VFS holds s_umount for writing this results in a
deadlock.We now do the dirty work by hand by submitting individual buffers. This
has the annoying "feature" that mounting can take a few seconds if the
journal is large as we have clear it all. One day someone should improve
on this by deferring the journal clearing to a helper kernel thread so it
can be done in the background but I don't have time for this at the moment
and the current solution works fine so I am leaving it like this for now.Signed-off-by: Anton Altaparmakov
Signed-off-by: Linus Torvalds
08 May, 2007
1 commit
-
Ensure pages are uptodate after returning from read_cache_page, which allows
us to cut out most of the filesystem-internal PageUptodate calls.I didn't have a great look down the call chains, but this appears to fixes 7
possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in
ecryptfs, 1 in jffs2, and a possible cleared data overwritten with readpage in
block2mtd. All depending on whether the filler is async and/or can return
with a !uptodate page.Signed-off-by: Nick Piggin
Cc: Hugh Dickins
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
13 Feb, 2007
1 commit
-
Replace the incorrect debugging check of "#ifdef NTFS_DEBUG" with
just "#ifdef DEBUG".Signed-off-by: Robert P. J. Day
Acked-by: Anton Altaparmakov
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
08 Dec, 2006
1 commit
-
SLAB_NOFS is an alias of GFP_NOFS.
Signed-off-by: Christoph Lameter
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
01 Oct, 2006
1 commit
-
Conversion of booleans to: generic-boolean.patch (2006-08-23)
Signed-off-by: Richard Knutsson
Signed-off-by: Anton Altaparmakov
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
23 Jun, 2006
1 commit
-
Add read_mapping_page() which is used for callers that pass
mapping->a_ops->readpage as the filler for read_cache_page. This removes
some duplication from filesystem code.Signed-off-by: Pekka Enberg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
23 Mar, 2006
3 commits
-
from read inode and new inode code paths.
Signed-off-by: Anton Altaparmakov
-
Signed-off-by: Anton Altaparmakov
-
continued the attribute lookup loop instead of aborting it.
Signed-off-by: Anton Altaparmakov
10 Jan, 2006
1 commit
-
This patch converts the inode semaphore to a mutex. I have tested it on
XFS and compiled as much as one can consider on an ia64. Anyway your
luck with it might be different.Modified-by: Ingo Molnar
(finished the conversion)
Signed-off-by: Jes Sorensen
Signed-off-by: Ingo Molnar
24 Oct, 2005
1 commit
-
Signed-off-by: Anton Altaparmakov
19 Oct, 2005
1 commit
-
Minor tidying.
Signed-off-by: Anton Altaparmakov
11 Oct, 2005
1 commit
-
and cond_resched() in the main loop as we could be dirtying a lot of
pages and this ensures we play nice with the VM and the system as a
whole.Signed-off-by: Anton Altaparmakov
04 Oct, 2005
6 commits
-
extend the allocation of an attributes. Optionally, the data size,
but not the initialized size can be extended, too.Signed-off-by: Anton Altaparmakov
-
which is zero for a resident attribute but should no longer be zero
once the attribute is non-resident as it then has real clusters
allocated.Signed-off-by: Anton Altaparmakov
-
as an extra parameter. This is needed since we need to know the size
before we can map the mft record and our callers always know it. The
reason we cannot simply read the size from the vfs inode i_size is
that this is not necessarily uptodate. This happens when
ntfs_attr_make_non_resident() is called in the ->truncate call path.Signed-off-by: Anton Altaparmakov
-
specifying whether the cluster are being allocated to extend an
attribute or to fill a hole.
- Change ntfs_attr_make_non_resident() to call ntfs_cluster_alloc()
with @is_extension set to TRUE and remove the runlist terminator
fixup code as this is now done by ntfs_cluster_alloc().Signed-off-by: Anton Altaparmakov
-
search context as argument. This allows calling it with the mft
record mapped. Update all callers.Signed-off-by: Anton Altaparmakov
-
search context. This allows calling it with the mft record mapped.
Signed-off-by: Anton Altaparmakov
09 Sep, 2005
3 commits
-
Also, add BUG() checks to ntfs_attr_make_non_resident() and
ntfs_attr_set() to ensure that these functions are never called
for compressed or encrypted attributes.Signed-off-by: Anton Altaparmakov
-
- Fix a bug in ntfs_map_runlist_nolock() where we forgot to protect
access to the allocated size in the ntfs inode with the size lock.
- Fix ntfs_attr_vcn_to_lcn_nolock() and ntfs_attr_find_vcn_nolock() to
return LCN_ENOENT when there is no runlist and the allocated size is
zero.
- Fix load_attribute_list() to handle the case of a NULL runlist.Signed-off-by: Anton Altaparmakov
-
Signed-off-by: Anton Altaparmakov
26 Jun, 2005
4 commits
-
Signed-off-by: Anton Altaparmakov
-
if the requested vcn is inside it. Otherwise we get into problems
when we try to map an out of bounds vcn because we then try to map
the already mapped runlist fragment which causes
ntfs_mapping_pairs_decompress() to fail and return error. Update
ntfs_attr_find_vcn_nolock() accordingly.Signed-off-by: Anton Altaparmakov
-
and ntfs_mapping_pairs_build() to allow the runlist encoding to be
partial which is desirable when filling holes in sparse attributes.
Update all callers.Signed-off-by: Anton Altaparmakov
-
LCN_ENOENT in ntfs_attr_make_non_resident(). Otherwise the runlist
code gets confused.Signed-off-by: Anton Altaparmakov
27 May, 2005
1 commit
-
possible (fs/ntfs/{attrib.c,index.c,super.c}). Thanks to Al Viro and
Pekka Enberg.Signed-off-by: Anton Altaparmakov
05 May, 2005
9 commits
-
Signed-off-by: Anton Altaparmakov
-
- Add ifdef NTFS_RW around write specific code if fs/ntfs/runlist.[hc] and
fs/ntfs/attrib.[hc].
- Minor bugfix to fs/ntfs/attrib.c::ntfs_attr_make_non_resident() where the
runlist was not freed in all error cases.
- Add fs/ntfs/runlist.[hc]::ntfs_rl_find_vcn_nolock().Signed-off-by: Anton Altaparmakov
-
Signed-off-by: Anton Altaparmakov
-
and handle the case where an attribute is converted from resident
to non-resident by a concurrent file write.
- Reorder some operations when converting an attribute from resident
to non-resident (fs/ntfs/attrib.c) so it is safe wrt concurrent
->readpage and ->writepage.Signed-off-by: Anton Altaparmakov
-
Signed-off-by: Anton Altaparmakov
-
dropping the read lock and taking the write lock we were not checking
whether someone else did not already do the work we wanted to do.
- Rename ntfs_find_vcn_nolock() to ntfs_attr_find_vcn_nolock().
- Tidy up some comments in fs/ntfs/runlist.c.
- Add LCN_ENOMEM and LCN_EIO definitions to fs/ntfs/runlist.h.Signed-off-by: Anton Altaparmakov
-
write code.
Signed-off-by: Anton Altaparmakov
-
non-resident in fs/ntfs/attrib.c::ntfs_attr_can_be_non_resident().
Signed-off-by: Anton Altaparmakov
-
helper ntfs_map_runlist_nolock() which is used by ntfs_map_runlist().
This allows us to map runlist fragments with the runlist lock already
held without having to drop and reacquire it around the call. Adapt
all callers.
- Change ntfs_find_vcn() to ntfs_find_vcn_nolock() which takes a locked
runlist. This allows us to find runlist elements with the runlist
lock already held without having to drop and reacquire it around the
call. Adapt all callers.Signed-off-by: Anton Altaparmakov
04 May, 2005
1 commit
-
Signed-off-by: Anton Altaparmakov
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
