20 Jul, 2007
1 commit
-
Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).
Here is a short excerpt of the semantic patch performing
this transformation:@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@x =
- kmalloc
+ kzalloc
(E1,E2)
... when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);@@
expression E1,E2,E3;
@@- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau
Cc: Richard Henderson
Cc: Ivan Kokshaysky
Acked-by: Russell King
Cc: Bryan Wu
Acked-by: Jiri Slaby
Cc: Dave Airlie
Acked-by: Roland Dreier
Cc: Jiri Kosina
Acked-by: Dmitry Torokhov
Cc: Benjamin Herrenschmidt
Acked-by: Mauro Carvalho Chehab
Acked-by: Pierre Ossman
Cc: Jeff Garzik
Cc: "David S. Miller"
Acked-by: Greg KH
Cc: James Bottomley
Cc: "Antonino A. Daplas"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 Jul, 2007
4 commits
-
* 'bsg' of git://git.kernel.dk/data/git/linux-2.6-block:
bsg: fix missing space in version print
Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG
bsg: Kconfig updates
bsg: minor cleanup
bsg: device hash table cleanup
bsg: fix initialization error handling bugs
bsg: mark FUJITA Tomonori as bsg maintainer
bsg: convert to dynamic major
bsg: address various review comments -
Put WARN_ON and fixed all callers of unregister_blkdev(). Now we can make
unregister_blkdev return void.Cc: Jens Axboe
Signed-off-by: Akinobu Mita
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
When unregister_blkdev() has failed, something wrong happened. This patch
adds WARN_ON to notify of such badness.Cc: Jens Axboe
Signed-off-by: Akinobu Mita
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
kmalloc_node() and kmem_cache_alloc_node() were not available in a zeroing
variant in the past. But with __GFP_ZERO it is possible now to do zeroing
while allocating.Use __GFP_ZERO to remove the explicit clearing of memory via memset whereever
we can.Signed-off-by: Christoph Lameter
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
17 Jul, 2007
9 commits
-
Tomo introduced a bug in his commit, removing the space between
"driver" and "version" in the init printk.Signed-off-by: Jens Axboe
-
- add the detailed explanation.
- remove 'default y'.
- make 'EXPERIMENTAL' keyword visible to the user in menu.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
- fix MODULE_DESCRIPTION typo.
- unify MODULE_DESCRIPTION and bsg_version.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
- kill unused bsg_list_idx macro.
- add bsg_dev_idx_hash() that returns an appropriate hlist_head.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This fixes the following bugs and cleans up the initialization code:
- cdev_del is missing.
- unregister_chrdev_region should be used instead of unregister_chrdev.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
240 was hardcoded, that was clearly a dumb mistake. Convert bsg
to use alloc_chrdev_region() to retrieve a dynamic major.Signed-off-by: Jens Axboe
-
This address most of the comments made by Andrew. The two remaining
are conversion to idr, and dynamic major.Signed-off-by: Jens Axboe
-
The SCSI code can be compiled modular, but BLK_DEV_BSG currently cannot,
and depends on the SCSI layer. So make sure that it depends on the SCSI
layer being compiled in, not just available as a module.Noticed by Jeff Garzik and S.Çağlar Onur.
Cc: Jeff Garzik
Cc: Jens Axboe
Cc: S.Çağlar Onur
Signed-off-by: Linus Torvalds -
We had a merge issue with the "dentry" field going away from the
kobject, and being replaced by a sysfs_dirent field (named "sd")
instead. That broke the BSG compile.Cc: Jens Axboe
Cc: FUJITA Tomonori
Cc: James Bottomley
Signed-off-by: Linus Torvalds
16 Jul, 2007
22 commits
-
This updates bsg entry in Kconfig:
- bsg supports sg v4
- bsg depends on SCSI
- it might be better to mark it experimental for a whileSigned-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This enables bsg to handle SCSI transport-level request like SAS
management protocol (SMP).- add BSG_SUB_PROTOCOL_{SCSI_CMD, SCSI_TMF, SCSI_TRANSPORT} definitions.
- SCSI transport-level requests skip blk_verify_command().Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
bsg uses the rq->next_rq pointer for a bidi request.
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This adds a struct request pointer to the request structure for the
second data phase (bidi for now). A request queue supporting bidi
requests sets QUEUE_FLAG_BIDI. This prevents sending bidi requests to
a non-bidi queue.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
The previous commit introduced a deadlock in discarding commands,
because we forget to unlock the bd spinlock.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This patch fixes a bug that read() returns ENODATA even with a
blocking file descriptor when there are no commands pending.This also includes some cleanups.
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This fixes the following minor issues:
- add EXPORT_SYMBOL_GPL for bsg_register_queue and
bsg_unregister_queue.- shut up gcc warnings
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This patch addresses on two issues on bsg device allocation.
- the current maxium number of bsg devices is 256. It's too small if
we allocate bsg devices to all SCSI devices, transport entities, etc.
This increses the maxium number to 32768 (taken from the sg driver).- SCSI devices are dynamically added and removed. Currently, bsg can't
handle it well since bsd_device->minor is simply increased.This is dependent on the patchset that I posted yesterday:
http://marc.info/?l=linux-scsi&m=117440208726755&w=2
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This patch binds bsg to all SCSI devices (their request queues) like
the current sg driver does. We can send SCSI commands to non disk and
cdrom scsi devices like OSD via bsg.This patch removes bsg_register_queue from blk_register_queue so bsg
devices aren't bound to non SCSI block devices. If they want bsg, I'll
send a patch to do that.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This patch binds bsg devices to request_queue instead of gendisk. Any
objects (like transport entities) can define own request_handler and
create own bsg device.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
bsg uses scsi_cmd_ioctl() for some SCSI/sg ioctl
commands. scsi_cmd_ioctl() gets a request queue from a gendisk
arguement. This prevents bsg being bound to SCSI devices that don't
have a gendisk (like OSD). This adds a request_queue argument to
scsi_cmd_ioctl(). The SCSI/sg ioctl commands doesn't use a gendisk so
it's safe for any SCSI devices to use scsi_cmd_ioctl().Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
Signed-off-by: Jens Axboe
-
Just get rid of the preallocated command map, use the slab cache
to get/free commands instead.Original patch from FUJITA Tomonori ,
changed by me to not use a mempool.Signed-off-by: Jens Axboe
-
Signed-off-by: Jens Axboe
-
Signed-off-by: Jens Axboe
-
This adds SG_IO support to SG v4.
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This patch replaces SG v3 in bsg with SG v4 (except for SG_IO).
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to
be exported.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This just kills linux/config.h and dprintk warnings.
Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
This converts block/scsi_ioctl.c use blk_rq_unmap_user new
API. blk_unmap_sghdr_rq is too simple and it might be better to remove
it.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe -
Signed-off-by: Jens Axboe
10 Jul, 2007
4 commits
-
elevator
Signed-off-by: Matthias Kaehlcke
Signed-off-by: Andrew Morton
Signed-off-by: Jens Axboe -
instead of going through all options.
Signed-off-by: Jan Engelhardt
Signed-off-by: Andrew Morton
Signed-off-by: Jens Axboe -
With the cfq_queue hash removal, we inadvertently got rid of the
async queue sharing. This was not intentional, in fact CFQ purposely
shares the async queue per priority level to get good merging for
async writes.So put some logic in cfq_get_queue() to track the shared queues.
Signed-off-by: Jens Axboe
-
Barrier bios are completed twice - once after the barrier write itself
is done and again after the whole sequence is complete.
flush_dry_bio_endio() is for the first completion. It doesn't really
complete the bio. It rewinds bvec and resets bio so that it can be
completed again when the whole barrier sequence is complete.The bvec rewinding code has the following problems.
1. The rewinding code is wrong because filesystems may pass bvec with
non zero bv_offset.2. The block layer doesn't guarantee anything about the state of
bvec array on request completion. bv_offset and len are updated
iff __end_that_request_first() completes the bvec partially.Because of #2, #1 doesn't really matter (nobody cares whether bvec is
re-wound correctly or not) but then again by not doing unwinding at
all, we'll always give back the same bvec to the caller as full bvec
completion doesn't alter bvecs and the final completion is always full
completion.Drop unnecessary rewinding code.
This is spotted by Neil Brown.
Signed-off-by: Tejun Heo
Cc: Neil Brown
Signed-off-by: Jens Axboe