08 Jul, 2013
1 commit
-
Fix to return -ENOMEM in the alloc_page() error handling
case instead of 0, as done elsewhere in this function.Signed-off-by: Wei Yongjun
Signed-off-by: Matthew Garrett
18 Mar, 2013
1 commit
-
If krealloc() returns NULL, it *doesn't* free the original. So any code
of the form 'foo = krealloc(foo, …);' is almost certainly a bug.Signed-off-by: David Woodhouse
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Cc: Joey Lee
Cc: Matthew Garrett
Cc: Peter Feuerer
Cc: Corentin Chary
Cc: Cezary Jackiewicz
Cc: Robert Gerlach
Cc: Ike Panhc
Cc: Henrique de Moraes Holschuh
Signed-off-by: Greg Kroah-Hartman
18 Aug, 2012
1 commit
-
Fixed the typo introduced from the below commit
5f1e88f dell-laptop: Add 6 machines to touchpad led quirkReported-by: Carlos Alberto Lopez Perez
Signed-off-by: AceLan Kao
Signed-off-by: Matthew Garrett
28 Jul, 2012
1 commit
-
Add the following machines into quirk,
Isnpiron 5420, Isnpiron 5520, Isnpiron 5720,
Isnpiron 7420, Isnpiron 7520, Isnpiron 7720Signed-off-by: AceLan Kao
Signed-off-by: Matthew Garrett
02 Jun, 2012
1 commit
-
The interface just doesn't work on some machines, and Dell haven't been
able to tell us either which machines those are or what we should be
doing instead. This would be fine, except it results in userspace ending
up confused and general sadness. So let's just rip it out for now.Signed-off-by: Matthew Garrett
01 Jun, 2012
4 commits
-
Add Dell Vostro 3450 quirk to support touchpad LED.
CC: Mariusz Fik
Signed-off-by: AceLan Kao
Signed-off-by: Matthew Garrett -
As long as there is no other non-const variable marked __initdata in the
same compilation unit it doesn't hurt. If there were one however
compilation would fail witherror: $variablename causes a section type conflict
because a section containing const variables is marked read only and so
cannot contain non-const variables.Signed-off-by: Uwe Kleine-König
Cc: Matthew Garrett
Cc: Henrique de Moraes Holschuh
Cc: platform-driver-x86@vger.kernel.org
Cc: ibm-acpi-devel@lists.sourceforge.net
Signed-off-by: Matthew Garrett -
Add "Vostro 3360", "Vostro 3460", and "Vostro 3560" into quirks,
so that they could have touchpad LED function work.Signed-off-by: AceLan Kao
Signed-off-by: Matthew Garrett -
Add Vostro 3350 into quirks so that the touchpad LED works.
Signed-off-by: Ang Way Chuang
Signed-off-by: Matthew Garrett
17 Apr, 2012
1 commit
-
Add missing DMI_NONE entry to end of the quirks list so
dmi_check_system() won't read past the end of the list.Signed-off-by: Martin Nyhus
Signed-off-by: Matthew Garrett
21 Mar, 2012
4 commits
-
Touchpad LED will not turn on after S3, it will make the touchpad status
doesn't consist with the LED.
By adding one flag to let the LED device restore it's status.Signed-off-by: AceLan Kao
Signed-off-by: Matthew Garrett -
Add "Vostro 3555", "Inspiron N311z", and "Inspiron M5110" into quirks,
so that they could have touchpad LED function work.Signed-off-by: AceLan Kao
Signed-off-by: Matthew Garrett -
Use MODULE_DEVCE_TABLE instead of rolling MODULE_ALIAS by hand.
Signed-off-by: Dmitry Torokhov
Signed-off-by: Matthew Garrett -
Signed-off-by: Marcos Paulo de Souza
Signed-off-by: Matthew Garrett
17 Nov, 2011
1 commit
-
Fix build warnings:
drivers/platform/x86/dell-laptop.c:592:13: warning: function declaration isn't a prototype
drivers/platform/x86/dell-laptop.c:599:13: warning: function declaration isn't a prototypeSigned-off-by: Randy Dunlap
Cc: Matthew Garrett
Signed-off-by: Linus Torvalds
24 Oct, 2011
1 commit
-
This patch supports Dell laptop with Synaptics and Alps touchpad chip
that with LED to indicate the functionality of touchpad is disabled or
enabled.The command for touchpad LED is 0x97, and the data 1 means turn on the
touchpad LED, 2 means turn it off.BTW, I add dell_quirks to white list those machines that supports this
behavior, so that the code won't affect those who don't have a touchpad LED
machine.We can easily to turn it on/off by
echo 1 > /sys/class/leds/dell-laptop::touchpad/brightness
echo 0 > /sys/class/leds/dell-laptop::touchpad/brightnessSigned-off-by: AceLan Kao
Signed-off-by: Matthew Garrett
06 Aug, 2011
1 commit
-
DEFINE_MUTEX() will automatically initialize buffer_mutex,
no need to call mutex_init() in dell_init().Signed-off-by: Axel Lin
Signed-off-by: Matthew Garrett
11 Jul, 2011
2 commits
-
Using buffer->output[1] without mutex_lock()
Signed-off-by: Jose Alonso
Signed-off-by: Matthew Garrett -
This reverts commit a3d77411e8b2ad661958c1fbee65beb476ec6d70,
as it causes a mess in the wireless rfkill status on some models.
It is probably a bad idea to toggle the rfkill for all dell models
without the respect to the claim that it is hardware-controlled.Cc: stable@kernel.org
Signed-off-by: Keng-Yu Lin
Signed-off-by: Matthew Garrett
28 May, 2011
1 commit
-
Add pr_fmt.
Remove hard coded prefixes and use pr_.Signed-off-by: Joe Perches
Signed-off-by: Matthew Garrett
23 Mar, 2011
1 commit
-
There may be multiple ways of controlling the backlight on a given
machine. Allow drivers to expose the type of interface they are
providing, making it possible for userspace to make appropriate policy
decisions.Signed-off-by: Matthew Garrett
Cc: Richard Purdie
Cc: Chris Wilson
Cc: David Airlie
Cc: Alex Deucher
Cc: Ben Skeggs
Cc: Zhang Rui
Cc: Len Brown
Cc: Jesse Barnes
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
22 Feb, 2011
1 commit
-
It is found on Dell Inspiron 1018 that the firmware reports that the hardware
killswitch is not supported. This makes the rfkill key not functional.This patch forces the driver to toggle the firmware rfkill status in the case
that the hardware killswitch is indicated as unsupported by the firmware.Signed-off-by: Keng-Yu Lin
Tested-by: Alessio Igor Bogani
Signed-off-by: Matthew Garrett
16 Nov, 2010
1 commit
-
backlight_device_register has been expecting a const "ops" argument, and using
it as such, since 9905a43b2d563e6f89e4c63c4278ada03f2ebb14. Let's make the
remaining backlight_ops instances const.Inspired by hunks of the grsecurity patch, updated for newer kernels.
Signed-off-by: Lionel Debroux
Acked-by: Ingo Molnar
Signed-off-by: Jiri Kosina
21 Oct, 2010
1 commit
-
Export the status of RF killswitch through debugfs.
The killswitch status is obtained by the SMI to BIOS. Exporting this status
through debugfs can help identify the issue with the misbehaving firmware.Signed-off-by: Keng-Yu Lin
Signed-off-by: Matthew Garrett
16 Aug, 2010
1 commit
-
Like others in the Mini series, the Dell Mini 1012 does not support
the smbios hook required by dell-laptop.Signed-off-by: Victor van den Elzen
Cc: stable
Signed-off-by: Matthew Garrett
03 Aug, 2010
2 commits
-
Make dell_laptop_i8042_filter() static as it's used only in dell-laptop.c
Signed-off-by: Axel Lin
Signed-off-by: Matthew Garrett -
This is to support Precision M4500 and others.
Signed-off-by: Rezwanul Kabir
Signed-off-by: Matthew Garrett
30 Mar, 2010
1 commit
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
17 Mar, 2010
1 commit
-
Values such as max_brightness should be set before backlights are
registered, but the current API doesn't allow that. Add a parameter to
backlight_device_register and update drivers to ensure that they
set this correctly.Signed-off-by: Matthew Garrett
Signed-off-by: Richard Purdie
01 Mar, 2010
2 commits
-
Make sure that work is cancelled after removing the i8042 filter, and
unregister the platform device rather than deleting it.Signed-off-by: Matthew Garrett
Cc: Dmitry Torokhov -
The following build bug (x86, allyesconfig):
arch/x86/oprofile/built-in.o:(.data+0x250): multiple definition of `buffer_mutex'
Was triggered in -tip testing, caused by this upstream commit:
116ee77: dell-laptop: Use buffer with 32-bit physical address
There's multiple buffer_mutex's in the kernel. Make this new one
static.Signed-off-by: Ingo Molnar
26 Feb, 2010
8 commits
-
The Latitude C640 has another variation of dell in its DMI vendor entry.
Add it to the whitelist in order to enjoy the sweet fruits of software
backlight toggling.Signed-off-by: Erik Andren
-
Right now, we assume that the hardware rfkill switch on Dells toggles all
radio devices. In fact, this can be configured in the BIOS and so right
now we may mark a device as hardware killed even when it isn't. Add code
to query the devices controlled by the switch, and use this when
determining the hardware kill state of a radio.Signed-off-by: Matthew Garrett
-
Calls to communicate with system firmware via a SMI (using dcdbas)
need to use a buffer that has a physical address of 4GB or less.
Currently the dell-laptop driver does not guarantee this, and when the
buffer address is higher than 4GB, the address is truncated to 32 bits
and the SMI handler writes to the wrong memory address.Signed-off-by: Stuart Hayes
Acked-by: Matthew Garrett -
The Mini family doesn't support smbios 17,11 although it reports it does.
Signed-off-by: Mario Limonciello
Signed-off-by: Tim Gardner -
The "hardware" switch is tied directly to a BIOS interface that will
connect and disconnect the hardware from the bus.If you use the software interface to request the BIOS to make these
changes, the HW switch will be in an inconsistent state and LEDs may not
reflect the state of the HW.Signed-off-by: Mario Limonciello
-
da_tokens was not being freed by dell-laptop on unload. Fix that.
Signed-off-by: Matthew Garrett
-
dell-laptop currently fails to clean up its platform device correctly.
Make sure that it's unregistered.Signed-off-by: Matthew Garrett
-
The rfkill interface on Dells only sends a notification that the switch
has been changed via the keyboard controller. Add a filter so we can
pick these notifications up and update the rfkill state appropriately.Signed-off-by: Matthew Garrett