24 Nov, 2012
1 commit
-
I forgot this again... codec->in_pm is in #ifdef CONFIG_PM
Reported-by: Markus Trippelsdorf
Signed-off-by: Takashi Iwai
23 Nov, 2012
1 commit
-
Jeffrey Barish reported an obvious bug in the pcm part of the usb-audio
driver which causes the code to not initialize the sync endpoint from
configure_endpoint().Reported-by: Jeffrey Barish
Signed-off-by: Daniel Mack
Cc: stable@kernel.org [3.5+]
Signed-off-by: Takashi Iwai
21 Nov, 2012
9 commits
-
If this array is not cleared, the jack related code later might
fail to create "Internal Speaker Phantom Jack" on Dell Inspiron 3420 and
Dell Vostro 2420.BugLink: https://bugs.launchpad.net/bugs/1076840
Cc: stable@vger.kernel.org (3.6+)
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
We found a new codec ID 292, and that just a simple quirk would enable
sound output/input on this ALC292 chip.BugLink: https://bugs.launchpad.net/bugs/1081466
Cc: stable@vger.kernel.org
Tested-by: Acelan Kao
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai -
ASoC: Fixes for v3.7
The biggest batch of fixes here is the Kirkwood DMA fixes, plus a couple
of other small fixes. -
…git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into tmp
-
Don't even momentarily set the pause status when starting the channel;
if we do, we should check the busy bit to ensure that we comply with
the spec. In any case, it isn't necessary; we will not active on a
START event so there is no need to pause the DMA.Signed-off-by: Russell King
Signed-off-by: Mark Brown -
Stress testing the driver with multiple start/stop events causes
kirkwood-dma to report underrun errors (which used to cause the kernel
to lock up solidly). This is because kirkwood-i2s is not respecting
the restrictions imposed on clearing the 'pause' bit. Follow what the
spec says; the busy bit must be read as being clear twice before the
pause bit can be released. This solves the underruns.However, it has been noticed that the busy bit occasionally does not
clear itself, hence the waiting is bounded to 5ms maximum to avoid a
new reason for the kernel to lockup.Signed-off-by: Russell King
Signed-off-by: Mark Brown -
This is part of a patch found in Rabeeh Khoury's git tree for the
cubox, which is further attributed to Sebastian Hesselbrath.Rather than masking the KIRKWOOD_DCO_SPCR_STATUS register contents
against the registers virtual address, let's actually use the bit
definition for the locked status, as required in the documentation.Signed-off-by: Russell King
Signed-off-by: Mark Brown -
Ignoring the real cause of the interrupt is not a good idea; this
behaviour has been observed to bring Dove platforms to silently
lockup. Instead, on error fall through to the normal interrupt
processing.This is especially important on Dove platforms as errors are
handled separately, and allows us to clear down the real cause of
the interrupt.Signed-off-by: Russell King
Signed-off-by: Mark Brown -
This is part of a patch found in Rabeeh Khoury's git tree for the
cubox.You can not use virt_to_phys() on the address returned from
dma_alloc_coherent(); it may not be part of the kernel direct-mapped
memory. Fix this to use the DMA address instead.Signed-off-by: Russell King
Signed-off-by: Mark Brown
20 Nov, 2012
1 commit
-
We've got a report that the runtime PM may make the codec the
unresponsive on AMD platforms. Since the feature has been tested only
on the recent Intel platforms, it's safer to limit the support to such
devices for now.This patch adds a new DCAPS bit flag indicating the runtime PM
support, and mark it for Intel controllers.Reported-and-tested-by: Julian Wollrath
Signed-off-by: Takashi Iwai
19 Nov, 2012
3 commits
-
When the bus reset is performed during the suspend/resume (including
the power-saving too), it calls snd_hda_suspend() and
snd_hda_resume() again, and deadlocks eventually.For avoiding the recursive call, add a new flag indicating that the PM
is being performed, and don't go to the bus reset mode when it's on.Reported-and-tested-by: Julian Wollrath
Signed-off-by: Takashi Iwai -
Merge a regression fix for USB MIDI on non-standard usb-audio drivers
by Clemens. -
Commit 88a8516a2128 (ALSA: usbaudio: implement USB autosuspend) added
autosuspend code to all files making up the snd-usb-audio driver.
However, midi.c is part of snd-usb-lib and is also used by other
drivers, not all of which support autosuspend. Thus, calls to
usb_autopm_get_interface() could fail, and this unexpected error would
result in the MIDI output being completely unusable.Make it work by ignoring the error that is expected with drivers that do
not support autosuspend.Reported-by: Colin Fletcher
Reported-by: Devin Venable
Reported-by: Dr Nick Bailey
Reported-by: Jannis Achstetter
Reported-by: Rui Nuno Capela
Cc: Oliver Neukum
Cc: 2.6.39+
Signed-off-by: Clemens Ladisch
16 Nov, 2012
2 commits
-
Signed-off-by: Dimitris Papastamos
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org -
It seems git has been getting confused by the very similar contexts
for the speaker DAIs and has been applying patches to the wrong places
causing all sorts of confusion. Fix this up by hand.Reported-by: Charles Keepax
Signed-off-by: Mark Brown
14 Nov, 2012
2 commits
-
The recent change for USB-audio disconnection race fixes introduced a
mutex deadlock again. There is a circular dependency between
chip->shutdown_rwsem and pcm->open_mutex, depicted like below, when a
device is opened during the disconnection operation:A. snd_usb_audio_disconnect() ->
card.c::register_mutex ->
chip->shutdown_rwsem (write) ->
snd_card_disconnect() ->
pcm.c::register_mutex ->
pcm->open_mutexB. snd_pcm_open() ->
pcm->open_mutex ->
snd_usb_pcm_open() ->
chip->shutdown_rwsem (read)Since the chip->shutdown_rwsem protection in the case A is required
only for turning on the chip->shutdown flag and it doesn't have to be
taken for the whole operation, we can reduce its window in
snd_usb_audio_disconnect().Reported-by: Jiri Slaby
Cc:
Signed-off-by: Takashi Iwai -
There is a precedence bug because | has higher precedence than ?:. This
code was cut and pasted and I fixed a similar bug a few days ago.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
13 Nov, 2012
4 commits
-
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR "0 | (val & STR_MOST)" is a no-op.I have re-written it to be more clear.
Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai -
ASoC: Fixes for v3.7
A few small fixes plus a large but simple change for WM5102 which writes
out a bunch of register updates to the device when we enable the clock
as recommended following chip evaluation. -
In case of probe deferral, the allocated GPIO line is not freed, which
prevents it from being claimed and properly asserted in later attempts.Fix this by using devm_gpio_request().
Signed-off-by: Daniel Mack
Reported-by: Michael Hirsch
Cc: Alexander Sverdlin
Signed-off-by: Mark Brown -
…' and 'fix/wm8978' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into tmp
12 Nov, 2012
1 commit
-
This is another variant of iMac 9,1 with a different codec SSID.
Reported-and-tested-by: Everaldo Canuto
Cc: [v3.3+]
Signed-off-by: Takashi Iwai
10 Nov, 2012
2 commits
-
snd_soc_put_volsw_sx function fails to update second control
if first control is updated by snd_soc_update_bits_locked.Signed-off-by: Mukund Navada
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org -
DAPM shutdown incorrectly uses "list" field of codec struct while
iterating over probed components (codec_dev_list). "list" field
refers to codecs registered in the system, "card_list" field is
used for probed components.Signed-off-by: Misael Lopez Cruz
Signed-off-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
08 Nov, 2012
5 commits
-
There are uncovered cases whether the card refcount introduced by the
commit a0830dbd isn't properly increased or decreased:
- OSS PCM and mixer success paths
- When lookup function gets NULLThis patch fixes these places.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=50251
Cc:
Signed-off-by: Takashi Iwai -
Signed-off-by: Kailang Yang
Cc:
Signed-off-by: Takashi Iwai -
alc269_toggle_power_output() was only use in ALC269VB. I rename it to
alc269vb_toggle_power_output().Signed-off-by: Kailang Yang
Cc:
Signed-off-by: Takashi Iwai -
There are bug reports of a crash with USB-audio devices when PCM
prepare is performed immediately after the stream is stopped via
trigger callback. It turned out that the problem is that we don't
wait until all URBs are killed.This patch adds a new function to synchronize the pending stop
operation on an endpoint, and calls in the prepare callback for
avoiding the crash above.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=49181
Reported-and-tested-by: Artem S. Tashkinov
Cc: [v3.6]
Signed-off-by: Takashi Iwai -
The RayDAT reports the sync status of its inputs in consecutive bit
positions, so all we do in hdspm_s1_sync_check is to iterate over idx:status = hdspm_read(hdspm, HDSPM_RD_STATUS_1);
lock = (status & (0x1<<private_value:
HDSPM_SYNC_CHECK("WC SyncCheck", 0),
HDSPM_SYNC_CHECK("AES SyncCheck", 1),
HDSPM_SYNC_CHECK("SPDIF SyncCheck", 2),
HDSPM_SYNC_CHECK("ADAT1 SyncCheck", 3),
HDSPM_SYNC_CHECK("ADAT2 SyncCheck", 4),
HDSPM_SYNC_CHECK("ADAT3 SyncCheck", 5),
HDSPM_SYNC_CHECK("ADAT4 SyncCheck", 6),
HDSPM_SYNC_CHECK("TCO SyncCheck", 7),
HDSPM_SYNC_CHECK("SYNC IN SyncCheck", 8),The patch corrects the indicated sync flags by passing the proper index
value to hdspm_s1_sync_check().Signed-off-by: Adrian Knoth
Signed-off-by: Takashi Iwai
07 Nov, 2012
5 commits
-
Fix the return value of cs42l52_set_fmt() when clock inversion is
not allowed and also remove the useless variable ret.dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)[We had been assigning to ret but then ignoring the value we assgined
-- broonie]Signed-off-by: Wei Yongjun
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org -
Signed-off-by: Charles Keepax
Signed-off-by: Mark Brown -
To parse properly the subwoofer outputs on ASUS G75 laptop with VT1802
codec, correct the default configurations of speaker pins 0x24 and
0x33.Reported-by: Massimo Del Fedele
Signed-off-by: Takashi Iwai -
VT1802 codec provides the invalid connection lists of NID 0x24 and
0x33 containing the routes to a non-exist widget 0x3e. This confuses
the auto-parser. Fix it up in the driver by overriding these
connections.Reported-by: Massimo Del Fedele
Cc:
Signed-off-by: Takashi Iwai -
In via_auto_fill_adc_nids(), the parser tries to fill dac_nids[] at
the point of the current line-out (i). When no valid path is found
for this output, this results in dac = 0, thus it creates a hole in
dac_nids[]. This confuses is_empty_dac() and trims the detected DAC
in later reference.This patch fixes the bug by appending DAC properly to dac_nids[] in
via_auto_fill_adc_nids().Reported-by: Massimo Del Fedele
Cc:
Signed-off-by: Takashi Iwai
06 Nov, 2012
1 commit
-
When MCLK is supplied externally and BCLK and LRC are configured as outputs
(codec is master), the PLL values are only calculated correctly on the first
transmission. On subsequent transmissions, at differenct sample rates, the
wrong PLL values are used. Test for f_opclk instead of f_pllout to determine
if the PLL values are needed.Signed-off-by: Eric Millbrandt
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
05 Nov, 2012
3 commits
-
Several bug reports suggest that the forcibly resetting IEC958 status
bits is required for AD codecs to get the SPDIF output working
properly after changing streams.Original fix credit to Javeed Shaikh.
BugLink: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/359361
Reported-by: Robin Kreis
Cc:
Signed-off-by: Takashi Iwai -
Add generic ESS vendor ID to pm_whitelist. This should fix suspend on
all Maestro-2 and Maestro-2E based PCI cards.
Tested on Terratec DMX and SF64-PCE2.Signed-off-by: Ondrej Zary
Signed-off-by: Takashi Iwai -
Mark structures that won't change const.
Signed-off-by: Daniel J Blueman
Signed-off-by: Takashi Iwai
