13 Sep, 2006
2 commits
-
Fixup for lockdep enabled kernels: Annotate an on-stack completion.
Signed-off-by: Stefan Richter
Acked-by: Ingo Molnar
Cc: James Bottomley
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
0x848a in ID word 0 indicates CFA device iff the ID data is obtained from
IDENTIFY DEVICE. For ATAPI devices, 0x848a in ID work 0 indicates valid
ATAPI device. Fix sanity check in ata_dev_read_id() such that ATAPI
devices reporting 0x848a in ID word 0 is not handled as error.The problem is identified by J.A. Magallon with HL-DT-ST DVDRAM GSA-4120B.
Signed-off-by: Tejun Helo
Cc: J.A. Magallon
Acked-by: Jeff Garzik
Acked-by: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Sep, 2006
4 commits
-
* 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev:
[PATCH] ata_piix: add map 01b for ICH7M
[libata] sata_mv: errata check buglet fix -
There are two changes here. The first reverses the broken PCI_DEVICE
conversion back to the old format. The second adds a missing PCI ID so
you can actually boot 2.6.18 on 2 month old VIA motherboards (right now
only 2.6.18-mm works).CC'd to Jeff to check the PCI ident but its a) in several distro kernels
and b) in 2.6.18-mm [twice ??]Signed-off-by: Alan Cox
Cc: Jeff Garzik
Signed-off-by: Linus Torvalds -
Although the document says otherwise, some ich7m uses map 01b. This
patch adds separate map DB for ICH7M and adds map entry for 01b.This was spotted on an ASUS laptop by Jonathan Dieter.
Signed-off-by: Tejun Heo
Cc: Jonathan Dieter
Signed-off-by: Jeff Garzik -
Fix a buglet; the errata check below this code is assuming the value in
the sstatus variable is what was pulled out of the SCR_STATUS register.
However, the status checks in the timeout loop clobber everything
but the first 4 bits of sstatus, so the errata checks are invalid.This patch changes it to not clobber SStatus.
Signed-off-by: Andres Salomon
Signed-off-by: Jeff Garzik
28 Aug, 2006
1 commit
-
idescsi_pc_intr() uses local_irq_enable() in IRQ context: annotate it.
(this has no effect on kernels with lockdep disabled. On kernels with lockdep
enabled this means that we wont actually disable interrupts, and the warning
message will go away as well.)Signed-off-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
27 Aug, 2006
1 commit
26 Aug, 2006
5 commits
-
The callers of scsi_send_eh_cmnd are setting the cmnd buffer,
and then scsi_send_eh_cmnd is copying that updated buffer to
the old_cmnd variable. Then after the command runs, we end up
copying that old_cmnd var which has the new cmnd to the scsi
command buffer. When this command gets recent, all types of fun
things happen like getting TUR or START_STOP commands with
data and scatterlists.This patch made against scsi-rc-fixes, has the callers of
scsi_send_eh_cmnd pass in the command so scsi_send_eh_cmnd
can do the right thing. This should go into 2.6.18 since this
fixes a regression added when we removed some of the scsi_cmnd
fields and replaced them with local variables.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
Software must explicitely re-enable extended firmware tracing
after any ISP abort condition.Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
Original code attempts to retry PLOGIs to fcports that are
FCP_TARGETs only. If the driver never performed a successful
PLOGI/PRLI, the port-type would never be assigned, and the
relogin logic would silently drop the request (and thus the port
would not be recognized and registered).The fix is relatively straightforward, drop the FCP_TARGET-only
check.Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
There's a problem where sg is executing a ->nopage operation on a
compound page, it actually calls get_page() on the first page in the
compound rather than the page which is being mapped. The fix is to
select the correct page by indexing into the compound.Signed-off-by: James Bottomley
24 Aug, 2006
5 commits
-
…it/jgarzik/libata-dev
-
vt6420 has super-fragile SCR registers which can hang the whole
machine if accessed with the wrong timings. This patch makes sata_via
use SCR registers only during probing and with the same timings as
before (pre new EH), which is proven to work.Signed-off-by: Tejun Heo
Signed-off-by: Jeff Garzik -
This patch implements force_pcs module parameter for ata_piix. If 1,
PCS is ignored, 2 honored. As there seem to be quite a few ICHs w/
impaired PCS, this option will be useful for cases where the default
setting doesn't work.Signed-off-by: Tejun Heo
Signed-off-by: Jeff Garzik -
There have been a number of reports regarding some ICH5s failing to
detect devices since the PCS handling update. Analysis shows that
these problems are caused by bogus PCS values from those controllers.Before the PCS update, the driver didn't honor PCS regs exactly and
probed them in many cases PCS reports no device. Now that PCS is
honored exactly, these hardware problems are visible.This patch makes ICH5 ignore PCS.
Signed-off-by: Tejun Heo
Signed-off-by: Jeff Garzik -
Noted by Alexey Dobriyan.
Signed-off-by: David S. Miller
22 Aug, 2006
1 commit
-
Move out PCS handling from piix_sata_prereset() into
piix_sata_present_mask() and use it from newly implemented
piix_sata_softreset(). Class codes for devices which are indicated to
be absent by PCS are cleared to ATA_DEV_NONE. This fixes ghost device
problem reported on ICH6 and 7.This patch moves PCS handling from prereset to softreset, which makes
two behavior changes.* perform softreset even when PCS indicates no device
* PCS handling is repeated before retrying softresets due to reset
failures.Both behavior changes are intended and more consistent with how other
drivers behave.Signed-off-by: Tejun Heo
Signed-off-by: Jeff Garzik
20 Aug, 2006
4 commits
-
Change version number to 8.1.9
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Stall error handler if attempting resets/aborts while an rport is blocked.
This avoids device offline scenarios due to errors in the error handler.Background:
Although the transport is using the scsi_timed_out functionality to
restart the timeout if the rport is blocked, if the timeout has already
fired before the block occurs, the eh handler still runs and can take
the device offline. Ultimately, this window cannot be resolved without
significant work in the error handler thread. Christoph noted the first
level of these issues when he noted the poor error response handling
by the error thread.We found, under heavy load and error testing, that time window from when
the scsi_times_out() adds the io to the queue to when the scsi_error_handler
gets around to servicing it, can be in the several seconds range. In most
cases, these test conditions are highly unusual, but possible.
As a result, we're stalling the error handler in this race window so that
we can avoid the device_offline transitions.Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Misc Bug Fixes:
- Cap MBX_DOWN_LINK command timeout to 60 seconds
- Fix double free of ndlp object
- Don't free mbox structures on error. The completion handlers expect to do so.
- Clear host attention work items when going offline
- Fixed discovery issues in multi-initiator environments.Signed-off-by: James Smart
Signed-off-by: James Bottomley
11 Aug, 2006
1 commit
10 Aug, 2006
2 commits
-
Hi,
Reading the Intel VSC and AHCI it seems like writing 0x302 is incorrect.
The only valid values are 4, 1 and 0. Writing 4 disables the
PHY.Signed-off-by: Martin Hicks
Signed-off-by: Jeff Garzik -
pdc_adma was overlooked and broken by the irq-pio patch:
Only HSM_ST_LAST interrupts should be delivered to this LLDD.Adding ATA_FLAG_PIO_POLLING to pdc_adma fixes the problem (temporarily),
before we convert the irq handler of pdc_adma to handle all interrupts.Signed-off-by: Albert Lee
Signed-off-by: Jeff Garzik
09 Aug, 2006
2 commits
-
SCSI EH locks door if sdev->locked is set. Sometimes door lock
command fails continuously (e.g. when medium is not present) and as
libata uses EH to acquire sense data, this easily creates a loop where
a failed lock door invokes EH and EH issues lock door on completion.This patch clears sdev->locked on door lock failure to break this
loop. This problem has been spotted and diagnosed by Unicorn Chang
.Signed-off-by: Tejun Heo
Signed-off-by: Jeff Garzik -
Fix a sata debug print statement that still uses an old variable name.
Signed-off-by: Keith Owens
Signed-off-by: Jeff Garzik
07 Aug, 2006
12 commits
-
SCSI folk forgot to fix up all the uses of 'buffer' before deleting
this struct member. Do it for them to rescue the resulting build
failures.Signed-off-by: Russell King
-
The NCR5380-based SCSI cards need the SCSI SPI transport selected
to build correctly.Signed-off-by: Russell King
-
The hptiop just got merged with a horrible amount of really bad ioctl
code that is against the standards for new scsi drivers. This patch
backs it out (and fixes a small bug where scsi_add_host is called to
early). We can re-add proper APIs once we agree on them.Signed-off-by: Christoph Hellwig
Signed-off-by: James Bottomley -
Conflicts:
arch/ia64/hp/sim/simscsi.c
Stylistic differences in two separate fixes for buffer->request_buffer
problem.Signed-off-by: James Bottomley
-
Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
Currently it is impossible to reset provided by Qlogic QLA2xxx driver
SCSI devices externally using corresponding sg devices, particularly via
sg_reset utility, because qla2xxx driver in qla2xxx_eh_device_reset()
function checks if the input scsi_cmnd has its private data (CMD_SP())
attached. Then the found pointer isn't used anywhere inside of
qla2xxx_eh_device_reset(). If the RESET request comes from sg device, it
doesn't have such private data.The attached patch removes check for non-NULL CMD_SP() from
qla2xxx_eh_device_reset(), hence allows to reset QLA2xxx's devices using
corresponding sg devices.AV: change applies to bus/host reset handlers as well.
Signed-off-by: Vladislav Bolkhovitin
Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
Signed-off-by: Andrew Vasquez
Signed-off-by: James Bottomley -
Change version number to 8.1.8
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
ID String and Message fixes
- Fix switch symbolic name registration to match cross-OS values
- Replace printk's with more standard lpfc_printf_log calls
- Make all lpfc_printf_log message numbers uniqueSigned-off-by: James Smart
Signed-off-by: James Bottomley -
Short bug fixes:
- Fix iocbq list corruption due to missing list_del's in ct handling
- Missing unlock in lpfc_sli_next_iotag()
- Fix initialization of can_queue value
- Differentiate sysfs mailbox errors with different codes.Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Fix race condition between lpfc_sli_issue_mbox and lpfc_online
Signed-off-by: James Smart
Signed-off-by: James Bottomley
