10 May, 2013
15 commits
-
This fixes a bug where the iscsi class/driver did not do a put_device
when a sess/conn device was found. This also simplifies the interface
by not having to pass in some arguments that were duplicated and did
not need to be exported.Reported-by: Zhao Hongjiang
Signed-off-by: Mike Christie
Acked-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
These enums have been separate since the dawn of SAS, mainly because the
latter is a procotol only enum and the former includes additional state
for libsas. The dichotomy causes endless confusion about which one you
should use where and leads to pointless warnings like this:drivers/scsi/mvsas/mv_sas.c: In function 'mvs_update_phyinfo':
drivers/scsi/mvsas/mv_sas.c:1162:34: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]Fix by eliminating one of them. The one kept is effectively the sas.h
one, but call it sas_device_type and make sure the enums are all
properly namespaced with the SAS_ prefix.Signed-off-by: James Bottomley
-
Modified thermal configuration to happen after interrupt registration
Added SAS controller configuration during initialization
Added error handling logic to handle I_T_Nexus errors and variants[jejb: fix up tabs and spaces issues]
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Handled NCQ errors in the low level driver as the FW
is not providing the faulty tag for NCQ errors for libsas
to recover.[jejb: fix checkpatch issues]
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Individual WWN read operations based on controller.
PM8081 - Read WWN from Flash VPD.
PM8088/89 - Read WWN from EEPROM.
PM8001 - Read WWN from NVM.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Changed name in driver to pm80xx. Updated debug messages.
Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Performing pci_free_consistent in tasklet had result in a core dump. So
allocated a new memory region for it. Fix for passing proper address
and operation in firmware flash update.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Additional bar shift for new SPC firmware, applicable to device
id 0x8081 only.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Implementation of SPCv/ve specific hardware functionality and
macros. Changing common functionalities wrt SPCv/ve operations.
Conditional checks for SPC specific operations.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Implementation of interrupt handlers and tasklets to support
upto 64 interrupt for the device.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Update of function prototype for common function to SPC and SPCv/ve.
Multiple queues implementation for IO.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Memory allocation and configuration of multiple inbound and
outbound queues.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
Updated pci id table with device, vendor, subdevice and subvendor ids
for 8081, 8088, 8089 SAS/SATA controllers. Added SPCv/ve related macros.
Updated macros, hba info structure and other structures for SPCv/ve.
Update of structure and variable names for SPC hardware functionalities.Signed-off-by: Sakthivel K
Signed-off-by: Anand Kumar S
Acked-by: Jack Wang
Reviewed-by: Hannes Reinecke
Signed-off-by: James Bottomley -
lpfc uses the generic checksum as well as the T10DIF one from the lib/
directory, so make sure they're selected.Reported-by: Randy Dunlap
Signed-off-by: James Bottomley -
scsi_send_eh_cmnd() is calling queuecommand() directly, so
it needs to check the return value here.
The only valid return codes for queuecommand() are 'busy'
states, so we need to wait for a bit to allow the LLDD
to recover.Based on an earlier patch from Wen Xiong.
[jejb: fix confusion between msec and jiffies values and other issues]
[bvanassche: correct stall_for interval]
Cc: Wen Xiong
Cc: Brian King
Signed-off-by: Hannes Reinecke
Signed-off-by: James Bottomley
03 May, 2013
25 commits
-
Increment 'ha->iocb_cnt' before adding mbox_iocb to iocb queue.
Signed-off-by: Vikas Chaudhary
Signed-off-by: James Bottomley -
This patch corrects the expected data transfer size of the
command UPIU. The current implementation of cmd->transfersize
is wrong as it probably equal to sector size. With this
implementation the transfer size is updated correctlyReported-by: KOBAYASHI Yoshitake
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Maya Erez
Signed-off-by: Santosh Yaraganavi
Signed-off-by: Vinayak Holikatti
Signed-off-by: James Bottomley -
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Reviewed-by: Sujit Reddy Thumma
Tested-by: Maya Erez
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
Signed-off-by: James Bottomley -
Some arrays synchronize their full non volatile cache when the sd driver sends
a SYNCHRONIZE CACHE command. Unfortunately, they can have Terrabytes of this
and we send a SYNCHRONIZE CACHE for every barrier if an array reports it has a
writeback cache. This leads to massive slowdowns on journalled filesystems.The fix is to allow userspace to turn off the writeback cache setting as a
temporary measure (i.e. without doing the MODE SELECT to write it back to the
device), so even though the device reported it has a writeback cache, the
user, knowing that the cache is non volatile and all they care about is
filesystem correctness, can turn that bit off in the kernel and avoid the
performance ruinous (and safety irrelevant) SYNCHRONIZE CACHE commands.The way you do this is add a 'temporary' prefix when performing the usual
cache setting operations, soecho temporary write through > /sys/class/scsi_disk//cache_type
Reported-by: Ric Wheeler
Cc:
Signed-off-by: James Bottomley -
Signed-off-by: Fengguang Wu
Signed-off-by: Saurav Kashyap
Signed-off-by: James Bottomley -
Found by 0 day test project
Reported-by: Fengguang Wu
Signed-off-by: Armen Baloyan
Signed-off-by: Saurav Kashyap
Signed-off-by: James Bottomley -
provisioning map (map_storep) is a bitmap accessed by bitops.
So the allocation size should be a multiple of sizeof(unsigned long) and
also the bitmap should be cleared by using bitmap_clear() instead of
memset().Otherwise it will cause problem on big-endian architecture if the number of
bits is not a multiple of BITS_PER_LONG.I tried testing the logical block provisioning support in scsi_debug,
but it didn't work as I expected.For example, load scsi_debug module with UNMAP command supported
and fill the storage with random data.# modprobe scsi_debug lbpu=1
# dd if=/dev/urandom of=/dev/sdbThen, try to unmap LBA 0, but Get LBA status reports:
# sg_unmap --lba=0 --num=1 /dev/sdb
# sg_get_lba_status --lba=0 /dev/sdb
descriptor LBA: 0x0000000000000000 blocks: 16384 mappedThis is unexpected result. Because UNMAP command to LBA 0 finished
without any errors, but Get LBA status shows that LBA 0 is still mapped.This problem is due to the wrong translation between LBA and index of
provisioning map. Fix it by using correct translation functions.Signed-off-by: Akinobu Mita
Acked-by: Martin K. Petersen
Signed-off-by: James Bottomley -
The function unmap_region() clears memory region specified as the logical
block address and the number of logical blocks in ramdisk storage
(fake_storep) if lbpu and lbprz module parameters are enabled.In the while loop of unmap_region(), it advances optimal unmap granularity
in logical blocks. But it only clears one logical block at LBA 'block' per
loop iteration. And furthermore, the 'block' is not pointing to a logical
block address which should be cleared, it is a index of probisioning map
(map_storep).Signed-off-by: Akinobu Mita
Acked-by: Martin K. Petersen
Signed-off-by: James Bottomley -
scsi_debug prohibits setting scsi_debug_unmap_alignment to be greater
than scsi_debug_unmap_granularity. But setting them to be the same value
is not prohibited. In this case, the only difference with
scsi_debug_unmap_alignment == 0 is the logical blocks from 0 to
scsi_debug_unmap_alignment - 1 cannot be unmapped. But the difference is
not properly handled in the current code.So this prohibits such unusual setting.
Signed-off-by: Akinobu Mita
Acked-by: Martin K. Petersen
Signed-off-by: James Bottomley -
If the logical block provisioning is not enabled, map_region() and
unmap_region() have no effect and they don't need to be called.So this makes map_region() and unmap_region() to be called only
when scsi_debug_lbp() returns true, i.e. logical block provisioning is
enabled.While I'm at it, this also removes meaningless non-zero check for
scsi_debug_unmap_granularity.Because scsi_debug_unmap_granularity cannot be zero with usual setting:
scsi_debug_unmap_granularity is 1 by default, and it can be changed to
zero with explicit module parameter setting only when the logical block
provisioning is disabled. But it is only meaningful module parameter
when the logical block provisioning is enabled.Signed-off-by: Akinobu Mita
Acked-by: Martin K. Petersen
Signed-off-by: James Bottomley -
It appears to me that there is a problem with handling of type 1 protection
information.It is considering a logical block reference tag of 0xffffffff to be an error,
but it is actually valid any time ((lba & 0xffffffff) == 0xffffffff) [for
example, 2TiB-1, 4TiB-1, 6TiB-1, etc.].I'm going by what's written in 4.18.3 of SBC3, where there doesn't appear
to be any invalid value for the reference tag.Signed-off-by: Jeremy Higdon
Acked-by: Martin K. Petersen
Signed-off-by: James Bottomley -
Driver passed the wrong IOADL address to IOA adapter. The patch
fixes the issue.Signed-off-by: Wen Xiong
Acked-by: Brian King
Signed-off-by: James Bottomley -
Fix to return -ENOMEM in the create workqueue error case
instead of 0, as done elsewhere in this function.Signed-off-by: Wei Yongjun
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
…LOGI sequence timeout
Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com> -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley -
Signed-off-by: James Smart
Signed-off-by: James Bottomley
