26 Feb, 2013
1 commit
-
There is one kconfig fix in the rc-fixes branch that I forgot to submit
for 3.8, so let's add it to the kconfig branch for 3.9-rc1.
16 Jan, 2013
1 commit
-
If menuconfig have Save/Load button like alternative
.config editors, xconfig, nconfig, etc.We will have
a obvious benefit when use menuconfig just like
when we use others, we can Save/Load our .config quickly
and conveniently.This patch add the Save/Load button for menuconfig.
[remove trailing space while at it for below line:
"*) Formerly when I used Page Down and Page Up, the cursor would be set"
]Changes:
V1-V2:
1:use PATH_MAX instead of hard code suggested by Yann E. MORIN
2:drop the spurious empty-line removal suggested by Yann E. MORIN
V2-V3:
1:ajust buttons position well centered reported by Yann E. MORINSigned-off-by: Wang YanQing
Reviewed-by: "Yann E. MORIN"
Tested-by: "Yann E. MORIN"
Signed-off-by: "Yann E. MORIN"
28 Dec, 2012
1 commit
-
dialog.h has two line the same below:
extern char dialog_input_result[];
This patch remove one of them.Signed-off-by: Wang YanQing
Reviewed-by: "Yann E. MORIN"
Tested-by: "Yann E. MORIN"
Signed-off-by: "Yann E. MORIN"
26 Dec, 2012
1 commit
-
This patch add support navigate input position *inside* the input
field with LEFT/RIGHT, so it is possible to modify the text in place.Signed-off-by: Wang YanQing
Tested-by: "Yann E. MORIN"
Signed-off-by: "Yann E. MORIN"
20 Nov, 2012
1 commit
-
The ncurses library allows for extended colors. The support for extended
colors support depends on wide-character support. ncurses headers
enable extended colors (NCURSES_EXT_COLORS) only when wide-character
support is enabled (NCURSES_WIDECHAR).The "make menuconfig" uses wide-character ncursesw library, which can be
compiled with wide-character support, but does not define NCURSES_WIDECHAR
and it's using headers without wide-character (and extended colors) support.This fixes problems with colors on systems with enabled extended colors
(like PLD Linux). Without this patch "make menuconfig" is hard to use.Signed-off-by: Krzysztof Mazur
Signed-off-by: Michal Marek
12 Oct, 2012
1 commit
-
Pull kconfig changes from Michal Marek:
"kconfig in v3.7 is going to
- initialize ncurses only once in menuconfig
- be able to jump to a search result in menuconfig
- change the misnomer oldnoconfig to a more meaningful name
olddefconfig, keeping the old name as alias"* 'kconfig' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old name as an alias
menuconfig: Assign jump keys per-page instead of globally
menuconfig: Do not open code textbox scroll up/down
menuconfig: Add jump keys to search results
menuconfig: Extend dialog_textbox so that it can return to a scrolled position
menuconfig: Extend dialog_textbox so that it can exit on arbitrary keypresses
menuconfig: Remove superfluous conditionnal
kconfig: document oldnoconfig to what it really does in conf.c
kconfig/mconf.c: revision of curses initialization.
03 Oct, 2012
1 commit
-
The correct syntax for gcc -x is "gcc -x assembler", not
"gcc -xassembler". Even though the latter happens to work, the former
is what is documented in the manual page and thus what gcc wrappers
such as icecream do expect.This isn't a cosmetic change. The missing space prevents icecream from
recognizing compilation tasks it can't handle, leading to silent kernel
miscompilations.Besides me, credits go to Michael Matz and Dirk Mueller for
investigating the miscompilation issue and tracking it down to this
incorrect -x parameter syntax.Signed-off-by: Jean Delvare
Acked-by: Ingo Molnar
Cc: stable@vger.kernel.org
Cc: Bernhard Walle
Cc: Michal Marek
Cc: Ralf Baechle
Signed-off-by: Michal Marek
28 Sep, 2012
5 commits
-
At the moment, keys 1-9 are assigned to the first 9 search results. This patch
makes them assigned to the first 9 results per-page instead. We are much less
likely to run out of keys that way.Signed-off-by: Benjamin Poirier
Signed-off-by: Michal Marek -
We don't need to explicitely use ncurses' scroll(). ncurses performs
vertical-motion optimization at wrefresh() time.Using strace I confirmed that with the following patch curses still sends only
the new line of text to the terminal when scrolling up/down one line at a
time.Signed-off-by: Benjamin Poirier
Signed-off-by: Michal Marek -
We can now display other UI elements (menus) "on top" of a textbox and then
seemingly come back to it in the same state it was left.Signed-off-by: Benjamin Poirier
Signed-off-by: Michal Marek -
The caller will be able to perform actions based on hotkeys in the displayed
text.Signed-off-by: Benjamin Poirier
Signed-off-by: Michal Marek -
Because end_reached is set to 0 before the loop, the test "!end_reached" is
always true and can be removed. This structure was perhaps copied from the
similar one in back_lines().Signed-off-by: Benjamin Poirier
Signed-off-by: Michal Marek
30 Aug, 2012
1 commit
-
Since commit d0e1e09568 initscr() is called twice in mconf.
Do it only in init_dialog() in util.c and there also save the
cursor position for the signal handler in mconf.c.Signed-off-by: Dirk Gouders
Signed-off-by: Michal Marek
26 Jul, 2012
1 commit
-
They function just like they do in less(1).
Signed-off-by: Benjamin Poirier
Signed-off-by: Michal Marek
05 Jul, 2012
2 commits
-
Import libraries on Cygwin and MinGW/MSYS use the .dll.a suffix, so
checking this suffix is necessary to make sure ncurses will still be
found when built without static libraries.Signed-off-by: Yaakov Selkowitz
Signed-off-by: Michal Marek -
Commit 8c41e5e363db55d91aa3b1cdce4ab02ad9821de7 added a check for
ncursesw/curses.h for the case where ncurses and ncursesw are build
separately but only one is installed. But if both are installed,
the headers ncurses/curses.h and ncursesw/curses.h differ, and since
libncursesw will be found first, so should ncursesw/curses.h.Signed-off-by: Yaakov Selkowitz
Signed-off-by: Michal Marek
30 Aug, 2011
1 commit
-
Some variables were being set but never used, which was triggering
warnings in GCC >= 4.6.Signed-off-by: Lucas De Marchi
Signed-off-by: Arnaud Lacombe
20 Sep, 2010
1 commit
-
In 60f33b8 (kconfig: get rid of stray a.o, support ncursesw, 2006-01-15),
support to link menuconfig with ncursesw library was added. To compute
the linker command option -l, we check "libncursesw.{so,a,dylib}" to allow
ncursesw to be used as a replacement ncurses. However, when checking what
header file to include, we do not check /usr/include/ncursesw directory.Add /usr/include/ncursesw to the list of directories that are checked.
With this patch, on my Debian Lenny box with libncursesw5-dev package but
not libncurses5-dev package, I can say "make menuconfig".Signed-off-by: Junio C Hamano
Acked-by: Sam Ravnborg
Signed-off-by: Michal Marek
03 Jun, 2010
2 commits
-
Truncate list items to fit in a single line, otherwise those items
which have long prompts will cover some other items.This follows the behavior of menubox.
Signed-off-by: Li Zefan
Signed-off-by: Michal Marek -
Run:
make ARCH=arm menuconfigAnd then select "System Type" -> "ARM system type". The kconfig
"choice" menu at this point looks empty.It's because config ARCH_S3C2410 has a long prompt:
config ARCH_S3C2410
bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
...menuconfig centers the checklist according to this prompt without
considering the width of the list, and then things get wrong.Reported-by: Nobin Mathew
Signed-off-by: Li Zefan
Signed-off-by: Michal Marek
14 Apr, 2010
2 commits
-
Usage:
Press to show all config symbols which have prompts.Quote Tim Bird:
| I've been bitten by this numerous times. I most often
| use ftrace on ARM, but when I go back to x86, I almost
| always go through a sequence of searching for the
| function graph tracer in the menus, then realizing it's
| completely missing until I disable CC_OPTIMIZE_FOR_SIZE.
|
| Is there any way to have the menu item appear, but be
| unsettable unless the SIZE option is disabled? I'm
| not a Kconfig guru...I myself found this useful too. For example, I need to test
ftrace/tracing and want to be sure all the tracing features are
enabled, so I enter the "Tracers" menu, and press to
see if there is any config hidden.I also noticed gconfig and xconfig have a button "Show all options",
but that's a bit too much, and I think normally what we are not
interested in those configs which have no prompt thus can't be
changed by users.Exmaple:
--- Tracers
-*- Kernel Function Tracer
- - Kernel Function Graph Tracer
[*] Interrupts-off Latency Tracer
- - Preemption-off Latency Tracer
[*] Sysprof TracerHere you can see 2 tracers are not selectable, and then can find
out how to make them selectable.Signed-off-by: Li Zefan
Signed-off-by: Michal Marek -
- fix a typo in documentation
- fix a typo in a printk on error
- fix comments in dialog_inputbox()Signed-off-by: Li Zefan
Signed-off-by: Michal Marek
18 Jul, 2009
1 commit
-
Fix build on non GNU based platforms.
Cc: Roman Zippel
Signed-off-by: Sam Ravnborg
10 Jun, 2009
1 commit
-
Implement support for comment entries within choice groups. Comment entries
are displayed visually distinct from normal configs, and selecting them is
a no-op.Signed-off-by: Peter Korsgaard
Cc: Roman Zippel
Signed-off-by: Sam Ravnborg
04 Dec, 2008
1 commit
-
As noted by Bernhard - fix it up.
Cc: Bernhard Reutner-Fischer
Signed-off-by: Sam Ravnborg
02 May, 2008
1 commit
-
OS-X shell did not like 'echo -e' so implement
suggestion from Al Viro to use a more portable construct.Signed-off-by: Sam Ravnborg
Cc: Al Viro
Acked-By: Timur Tabi
29 Apr, 2008
1 commit
-
Fix reversal of dlg.border.atr and dlg.dialog.atr for draw_box()
Makes the inputbox look like expectedSigned-off-by: Roel Kluin
Signed-off-by: Sam Ravnborg
29 Jan, 2008
3 commits
-
Gettext support for lxdialog.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Kconfig is powerfull tool. So powerfull that more and more software
projects are using it for configuration. So instead of fixing some of
them one by one, lets fix it in kernel and wait for sync.This work was originaly done for PTXdist - GPL licensed build system for
userlands and cross-compilers, but it will not hurt kernel kconfig
either. PTXdist menuconfig now works on Windows linked with PDCurses and
compiled using MinGW - there is no termios and signals.* Do not include and (comes from times when
lxdialog was separate process)
* Do not mess with termios directly and let curses tell screen size.
Comment to commit c8dc68ad0fbd934e78e913b8a8d7b45945db4930 says
check for screen size could be removed later, but because it didn't
happen for more than year I left it here as well.
* Save cursor position added by SamSigned-off-by: Ladislav Michl
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
With this patch when ncurses-devel (or whatever it is named)
is missing trying to run menuconfig will result in this:$ make menuconfig
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/kxgettext.o
*** Unable to find the ncurses libraries or the
*** required header files.
*** 'make menuconfig' requires the ncurses libraries.
***
*** Install ncurses (ncurses-devel) and try again.
***
make[1]: *** [scripts/kconfig/dochecklxdialog] Error 1
make: *** [menuconfig] Error 2Much better than before where we just listed some build errors.
The other *config targets will work indepenednt on ncurses
being present or not.Includes improvements suggested by: Frans Pop
Signed-off-by: Sam Ravnborg
Cc: Frans Pop
17 Jul, 2007
1 commit
-
The "==" operator is not in POSIX, so use -eq instead.
Signed-off-by: Mike Frysinger
Signed-off-by: Sam Ravnborg
19 May, 2007
1 commit
-
The check-lxdialog.sh script searches for "libFOO.so" which fails on OS X, due
to their special naming of libraries like "libfoo.dylib". This patch turns
the curses lib search into extensible loops and adds dylib as a valid
extension.Signed-off-by: Mike Frysinger
Signed-off-by: Sam Ravnborg
03 May, 2007
2 commits
-
When loading an alternate configuration use that file as
current configuration filename.
Make the filename visible in the dialog.
Default continue to be .config.Inspired by patch from: Cyrill Gorcunov
Signed-off-by: Sam Ravnborg
Cc: Cyrill Gorcunov -
The index() function is obsolete, use strchr() instead.
Signed-off-by: Mike Frysinger
Signed-off-by: Sam Ravnborg
26 Nov, 2006
1 commit
-
On Mon, 13 Nov 2006, Phil Oester wrote:
> In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
> color scheme was changed to bluetitle. This breaks the highlighting
> of the selected item for me with TERM=vt100. The only way I can see
> which item is selected is via:
>
> make MENUCONFIG_COLOR=mono menuconfig
>
> Which restores the pre-2.6.19 white on black highlighting.Fix.
Cc: Phil Oester
Signed-off-by: Roman Zippel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Oct, 2006
1 commit
-
scripts/kconfig/lxdialog/util.c fails to build because it uses
true/false without including stdbool.h:kronos:~/src/linux-2.6$ make O=../linux-build-git menuconfig
GEN /home/kronos/src/linux-build/Makefile
HOSTCC scripts/kconfig/lxdialog/util.o
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_classic_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: 'true' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: (Each undeclared identifier is reported only once
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: for each function it appears in.)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:70: error: 'false' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_blackbg_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:101: error: 'true' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:102: error: 'false' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_bluetitle_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:144: error: 'true' undeclared (first use in this function)
make[2]: *** [scripts/kconfig/lxdialog/util.o] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [menuconfig] Error 2Add to dialog.h to fix the breakage.
Signed-off-by: Luca Tettamanti
Cc: Sam Ravnborg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
30 Sep, 2006
4 commits
-
Menulines that were wider than the available
line width is now properly null terminated.While at it renamed the variable choice => line_y
so it better reflect the usage in do_print_item().Signed-off-by: Sam Ravnborg
-
In all dialogs now properly catch KEY_RESIZE and take proper action.
In mconf try to behave sensibly when a dialog routine returns
-ERRDISPLAYTOOSMALL.The original check for a screnn size of 80x19 is kept for now.
It may make sense to remove it later, but thats anyway what
much text is adjusted for.Signed-off-by: Sam Ravnborg
-
is used to step one back in the dialogs.
When lxdialog became built-in pressing once would cause one step back
and pressing would cause two steps back.
This patch - based on concept from Roman Zippel -
makes one a noop and pressing will cause one step backward.In addition the final yes/no dialog now has the option to go back to the
the kernel configuration. So if you get too far out you can now go back
to configuring the kernel without saving and starting all over again.Signed-off-by: Sam Ravnborg
-
lxdialog was previously called as an external program causing screen
to flicker when used. With this patch lxdialog is now built-in.
It is loosly based om previous work by: Petr BaudisFollowing is a list of changes:
o Moved build of dialog routings to kconfig Makefile
o menubox + checklist uses a new item list to hold all menu items
o in util.c implmented helper function to deal with item list
o menubox now uses parameters to save scroll state (avoids temp file)
o textbox now get text to be displayed as parameter and not a file
o make sure to properly delete subwin's before main windows
o killed unused files: lxdialog.c msgbox.c
o modified return value for ESC to match direct calling
o in a few places the code has been adjusted to 80 char wide
o in textbox a small refactoring was made to make code remotely readable
o in mconf removed all unused stuff (functions/variables)Following is a list of know short comings:
a) pressing ESC twice will be interpreted as two ESC presses
b) resize does not work. menuconfig needs to be restarted to be adjustedSigned-off-by: Sam Ravnborg
