17 Oct, 2008

27 commits

  • identify_ramdisk_image() returns 0 (not -1) if a gzipped ramdisk is found:

    if (buf[0] == 037 && ((buf[1] == 0213) || (buf[1] == 0236))) {
    printk(KERN_NOTICE
    "RAMDISK: Compressed image found at block %d\n",
    start_block);
    nblocks = 0;
    ^^^^^^^^^^^
    goto done;
    }

    ...

    done:
    sys_lseek(fd, start_block * BLOCK_SIZE, 0);
    kfree(buf);
    return nblocks;
    ^^^^^^^^^^^^^^

    Hence correct the typo in the comment, which has existed since the
    addition of compressed ramdisk support in 1.3.48.

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Geert Uytterhoeven
     
  • It seems this is the right way around because otherwise the len usage in
    the outer loop would be pretty pointless.

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ilpo Järvinen
     
  • First a file hello.c is created, then the file hello2.c is compiled.
    Change this to hello.c

    Signed-off-by: Frans Meulenbroeks
    Signed-off-by: Rob Landley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    frans
     
  • EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL.
    Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.

    eeepc-laptop.c:(.text+0xd5a7b): undefined reference to `rfkill_allocate'
    eeepc-laptop.c:(.text+0xd5b04): undefined reference to `rfkill_register'
    eeepc-laptop.c:(.text+0xd5b48): undefined reference to `rfkill_allocate'
    eeepc-laptop.c:(.text+0xd5bd4): undefined reference to `rfkill_register'
    eeepc-laptop.c:(.text+0xd5ece): undefined reference to `rfkill_unregister'
    eeepc-laptop.c:(.text+0xd5ef6): undefined reference to `rfkill_unregister'
    make[1]: *** [.tmp_vmlinux1] Error 1

    Signed-off-by: Randy Dunlap
    Cc: Corentin Chary
    Cc: Matthew Garrett
    Cc: Henrique de Moraes Holschuh
    Cc: Karol Kozimor
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
    (d)) but is perhaps more readable.

    An extract of the semantic patch that makes this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @haskernel@
    @@

    #include

    @depends on haskernel@
    expression n,d;
    @@

    (
    - (n + d - 1) / d
    + DIV_ROUND_UP(n,d)
    |
    - (n + (d - 1)) / d
    + DIV_ROUND_UP(n,d)
    )

    @depends on haskernel@
    expression n,d;
    @@

    - DIV_ROUND_UP((n),d)
    + DIV_ROUND_UP(n,d)

    @depends on haskernel@
    expression n,d;
    @@

    - DIV_ROUND_UP(n,(d))
    + DIV_ROUND_UP(n,d)
    //

    Signed-off-by: Julia Lawall
    Cc: Jack Steiner
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     
  • This macro appears to have been unused for ages, and there are no
    invocations of it anywhere in the source tree.

    Signed-off-by: Robert P. J. Day
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Robert P. J. Day
     
  • Remove a CVS keyword that wasn't updated for a long time from a comment.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • Remove a CVS keyword that wasn't updated for a long time from a comment.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • __FUNCTION__ is gcc-specific, use __func__

    Signed-off-by: Harvey Harrison
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • __FUNCTION__ is gcc-specific, use __func__

    Signed-off-by: Harvey Harrison
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • Signed-off-by: Harvey Harrison
    Acked-by: Andres Salomon
    Cc: David Woodhouse
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • Remove the dead CONFIG_TTY_LOG (no kconfig option).

    Reported-by: Robert P. J. Day
    Signed-off-by: Adrian Bunk
    Cc: Jeff Dike
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • As pm_trace uses the system's hardware clock to save its magic value,
    users of that option should be warned that using this debug option will
    result in an incorrect system time after resume.

    Signed-off-by: Frans Pop
    Acked-by: Pavel Machek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Frans Pop
     
  • We currently use a PM notifier to disable user mode helpers before suspend
    and hibernation and to re-enable them during resume. However, this is not
    an ideal solution, because if any drivers want to upload firmware into
    memory before suspend, they have to use a PM notifier for this purpose and
    there is no guarantee that the ordering of PM notifiers will be as
    expected (ie. the notifier that disables user mode helpers has to be run
    after the driver's notifier used for uploading the firmware).

    For this reason, it seems better to move the disabling and enabling of
    user mode helpers to separate functions that will be called by the PM core
    as necessary.

    [akpm@linux-foundation.org: remove unneeded ifdefs]
    Signed-off-by: Rafael J. Wysocki
    Cc: Alan Stern
    Acked-by: Pavel Machek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Rafael J. Wysocki
     
  • arch/alpha/kernel/smp.c:153: error: implicit declaration of function 'notify_cpu_starting'

    Signed-off-by: Alexey Dobriyan
    Cc: Richard Henderson
    Cc: Ivan Kokshaysky
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     
  • Remove a dead URL.

    Cc: Yoshinori Sato
    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • Remove a CVS keyword that wasn't updated for a long time from a comment.

    Signed-off-by: Adrian Bunk
    Cc: Yoshinori Sato

    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • CONFIG_GENERIC_BUG support.

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Yoshinori Sato
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoshinori Sato
     
  • - Update selection
    - Update common timer handler
    - Add support functions

    Signed-off-by: Yoshinori Sato
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoshinori Sato
     
  • New timer handler files.

    Signed-off-by: Yoshinori Sato
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoshinori Sato
     
  • Delete old timer handler.

    Signed-off-by: Yoshinori Sato
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoshinori Sato
     
  • There are off-by-one errors in decompress_exec() when calculating the length of
    optional "original file name" and "comment" fields: the "ret" index is not
    incremented when terminating '\0' character is reached. The check of the buffer
    overflow (after an "extra-field" length was taken into account) is also fixed.

    I've encountered this off-by-one error when tried to reuse
    gzip-header-parsing part of the decompress_exec() function. There was an
    "original file name" field in the payload (with miscalculated length) and
    zlib_inflate() returned Z_DATA_ERROR. But after the fix similar to this
    one all worked fine.

    Signed-off-by: Volodymyr G Lukiianyk
    Acked-by: Greg Ungerer
    Acked-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Volodymyr G. Lukiianyk
     
  • The 'filp' argument to do_generic_file_read() is never NULL.

    Signed-off-by: Krishna Kumar
    Reviewed-by: KOSAKI Motohiro
    Cc: Christoph Hellwig
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krishna Kumar
     
  • The page fault path for normal pages, if the fault is neither a no-page
    fault nor a write-protect fault, will update the DIRTY and ACCESSED bits
    in the page table appropriately.

    The hugepage fault path, however, does not do this, handling only no-page
    or write-protect type faults. It assumes that either the ACCESSED and
    DIRTY bits are irrelevant for hugepages (usually true, since they are
    never swapped) or that they are handled by the arch code.

    This is inconvenient for some software-loaded TLB architectures, where the
    _PAGE_ACCESSED (_PAGE_DIRTY) bits need to be set to enable read (write)
    access to the page at the TLB miss. This could be worked around in the
    arch TLB miss code, but the TLB miss fast path can be made simple more
    easily if the hugetlb_fault() path handles this, as the normal page fault
    path does.

    Signed-off-by: David Gibson
    Cc: William Lee Irwin III
    Cc: Hugh Dickins
    Cc: Adam Litke
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Gibson
     
  • Local variable `i' is a) misleadingly-named for an `enum zone_type' and b)
    used for indexing zones as well as nodes as well as node_maps.

    Make it an `int'.

    Reported-by: Frans Pop
    Cc: Mel Gorman
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • This patch adds an additional field to the mm_owner callbacks. This field
    is required to get to the mm that changed. Hold mmap_sem in write mode
    before calling the mm_owner_changed callback

    [hugh@veritas.com: fix mmap_sem deadlock]
    Signed-off-by: Balbir Singh
    Cc: Sudhir Kumar
    Cc: YAMAMOTO Takashi
    Cc: Paul Menage
    Cc: Li Zefan
    Cc: Pavel Emelianov
    Cc: Balbir Singh
    Cc: KAMEZAWA Hiroyuki
    Cc: David Rientjes
    Cc: Vivek Goyal
    Signed-off-by: Hugh Dickins
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Balbir Singh
     
  • A series of patches introduce a generic header file for the software
    IO/TLB implementation in lib/swiotlb.c. Currently each architecture using
    this code defines the prototypes itself. The prototypes are moved to
    include/linux/swiotlb.h and this file is included in architecture specific
    code for X86 and IA64.

    This patch:

    Create include/linux/swiotlb.h file which contains all function prototypes
    for the lib/swiotlb.c file.

    (akpm: the dependent patches will be trickled through arch trees)

    Signed-off-by: Joerg Roedel
    Cc: Ingo Molnar
    Cc: Thomas Gleixner
    Cc: "Luck, Tony"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joerg Roedel
     

16 Oct, 2008

5 commits

  • As policy->governor is already set to CPUFREQ_DEFAULT_GOVERNOR in the
    (always built-in) cpufreq core, we do not need to set it in the drivers.
    This fixes the sparc64 allmodconfig build failure.

    Also, remove a totally useles setting of ->policy in cpufreq-pxa3xx.c.

    Signed-off-by: Dominik Brodowski
    Acked-by: David S. Miller
    Signed-off-by: Linus Torvalds

    Dominik Brodowski
     
  • * 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-linus:
    MIPS: Kill unused inclusions
    MIPS: IP32: Add platform device for CMOS RTC; remove dead code
    RTC: M48T35: new RTC driver
    MIPS: IP27: Switch over to RTC class driver
    MIPS: DS1286: New RTC driver
    MIPS: IP22/28: Switch over to RTC class driver
    MIPS: PCI: Scan busses when they are registered
    MIPS: WGT634U: Add reset button support
    MIPS: BCM47xx: Use the new SSB GPIO API
    MIPS: BCM47xx: Remove references to BCM947XX
    MIPS: WGT634U: Add machine detection message
    MIPS: Align .data.cacheline_aligned based on CONFIG_MIPS_L1_CACHE_SHIFT
    MIPS: show_cpuinfo prints the type of the calling CPU
    MIPS: Fix wrong branch target in new spin_lock code.
    MIPS: Have a heart for a lonely, lost header file ...

    Linus Torvalds
     
  • proc_clear_tty() gets called with interrupts off (while holding the task list
    lock) from sys_setid. This means that it needs the _irqsave version of the
    locking primitives.

    Reported-by: Marcin Slusarz
    Tested-by: Marcin Slusarz
    Signed-off-by: Arjan van de Ven
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     
  • The metronome driver produces warnings when built on x86-64 as it assumes that
    size_t is an int. Use %Zd instead.

    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • When we skip unrecognized options in xfs_fs_remount we should just break
    out of the switch and not return because otherwise we may skip clearing
    the xfs-internal read-only flag. This will only show up on some
    operations like touch because most read-only checks are done by the VFS
    which thinks this filesystem is r/w. Eventually we should replace the
    XFS read-only flag with a helper that always checks the VFS flag to make
    sure they can never get out of sync.

    Bug reported and fix verified by Marcel Beister on #xfs.
    Bug fix verified by updated xfstests/189.

    Signed-off-by: Christoph Hellwig
    Acked-by: Eric Sandeen
    Signed-off-by: Timothy Shimmin
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

15 Oct, 2008

8 commits