14 Jun, 2012
19 commits
-
Suggested-by: Shuah Khan
Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Acked-by: Colin Cross
Signed-off-by: Greg Kroah-Hartman -
Since we use multiple regions, the messages are somewhat annoying.
We do print total mapped memory already, so no need to print the
information for each region in the library routines.Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Acked-by: Colin Cross
Signed-off-by: Greg Kroah-Hartman -
The console log size is configurable via ramoops.console_size
module option, and the log itself is available via
/console-ramoops file.Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
This will help make code clearer when we'll add support for other
message types.The patch also changes return value from -EINVAL to 0 in case of
end-of-records. The exact value doesn't matter for pstore (it should
be just
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
This will help make code clearer when we'll add support for other
message types.This also makes probe() much shorter and understandable, plus
makes mem/record size checking a bit easier.Implementation detail: we now use a paddr pointer, this will
be used for allocating persistent ram zones for other message
types.Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
We're about to add support for other message types, so let's rename
some variables to not be confused later.Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
Pstore doesn't support logging kernel messages in run-time, it only
dumps dmesg when kernel oopses/panics. This makes pstore useless for
debugging hangs caused by HW issues or improper use of HW (e.g.
weird device inserted -> driver tried to write a reserved bits ->
SoC hanged. In that case we don't get any messages in the pstore.Therefore, let's add a runtime logging support: PSTORE_TYPE_CONSOLE.
Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Acked-by: Colin Cross
Signed-off-by: Greg Kroah-Hartman -
We need this for the pstore fixes that went into the staging-linus branch, so
that things apply properly for the pstore/android code merge.Signed-off-by: Greg Kroah-Hartman
-
There's no reason to extern it. The patch fixes the annoying sparse
warning:CHECK fs/pstore/inode.c
fs/pstore/inode.c:264:5: warning: symbol 'pstore_fill_super' was not
declared. Should it be static?Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
Otherwise, unlinked file will reappear on the next boot.
Reported-by: Kees Cook
Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
A handy function that we will use outside of ram_core soon. But
so far just factor it out and start using it in post_init().Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
Otherwise, the files will survive just one reboot, and on a subsequent
boot they will disappear.Signed-off-by: Anton Vorontsov
Signed-off-by: Greg Kroah-Hartman -
Without the update, we'll only see the new dmesg buffer after the
reboot, but previously we could see it right away. Making an oops
visible in pstore filesystem before reboot is a somewhat dubious
feature, but removing it wasn't an intentional change, so let's
restore it.For this we have to make persistent_ram_save_old() safe for calling
multiple times, and also extern it.Signed-off-by: Anton Vorontsov
Acked-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman -
All of the config options for comedi depend on COMEDI being
selected. Wrap everything in an 'if COMEDI/endif' block and
remove all the individual 'depends on COMEDI' in the Kconfig.Also, remove the redundant && ISA/PCI/PCMCIA/USB for the if
blocks with those driver types.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Chris Yungmann
Signed-off-by: Greg Kroah-Hartman -
Added a do ... while (0) to a multi statement macro and reformatted a similar macro.
Signed-off-by: William Blair
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Signed-off-by: Greg Kroah-Hartman
13 Jun, 2012
21 commits
-
This symbol is not defined in the kernel. It appears to be left
over from the 2.4 kernel.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
indentation of parameter description,
fix parameter name (@dev -> @indio_dev) in comments,
IIO device info structure -> IIO device structureSigned-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
v2:
* "used in in-kernel" (Jonathan Cameron)Signed-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
v2: address comments by Jonathan Cameron
* add more output power down modes
* spelling of etc.Signed-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map()
warn: value 2 can't fit into 1 'out'Signed-off-by: Michael Hennerich
Reported-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
v5:
* fix warnings (Jonathan Cameron)v4:
* remove unused indio_dev pointer in mcp4725_data (Jonathan Cameron)
* use u16 instead of unsigned short in mcp4725_data (Jonathan Cameron)
* #include mcp4725.h from linux/iio/dac/v3:
* move from staging to drivers/iio
* switch to chan_spec
* dev_get_drvdata() -> dev_to_iio_dev()
* annotate probe() and remove() with __devinit and __devexitv2 (based on comments from Jonathan Cameron and Lars-Peter Clausen):
* did NOT switch to chan_spec yet
* rebase to staging-next tree, update iio header locations
* dropped dac.h #include, not needed
* strict_strtol() -> kstrtol()
* call iio_device_unregister() in remove()
* everything in one patchSigned-off-by: Peter Meerwald
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
GCC complains that we use an uninitialized variable if the user passes
an invalid parameter to adf4350_read(). I decided that we should return
-EINVAL instead in that case.However, when I looked up at adf4350_write() it returned -ENODEV for
that condition. In the end, I decided the -EINVAL was the right thing
and I change adf4350_write() to match.Signed-off-by: Dan Carpenter
Acked-by: Michael Hennerich
Signed-off-by: Greg Kroah-Hartman -
Sparse complains about this:
drivers/iio/frequency/adf4350.c:58:29: warning: Initializer entry defined twice
drivers/iio/frequency/adf4350.c:59:10: also defined hereIt looks like '|' was intended here instead of ','.
Signed-off-by: Dan Carpenter
Acked-by: Michael Hennerich
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Acked-by: Roland Stigge
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Peter Meerwald
Acked-by: Roland Stigge
Acked-by: Jonathan Cameron
Signed-off-by: Greg Kroah-Hartman -
There was a return path which got missed accidentally.
Signed-off-by: Dan Carpenter
Acked-by: Michael Hennerich
Signed-off-by: Greg Kroah-Hartman -
Access the individual comedi_subdevices using a pointer instead
of directly accessing as an array. This is how the rest of the
comedi core accesses them.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
comedi_alloc_subdevices can fail with -EINVAL or -ENOMEM. When it
does fail make sure to pass the proper error code back.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
These comments are redundant. The function name 'comedi_alloc_subdevices'
provides this information.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
Remove all the "allocation failed" debug messages that are displayed
when the comedi_alloc_subdevices call fails.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbot
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
It's possible for the kcalloc in comedi_alloc_subdevices to fail.
Only set the dev->n_subdevices variable if the allocation is
successful.Since the core sets dev->n_subdevices, remove all the places in the
drivers where this variable was getting set.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
It's possible for a couple of the comedi drivers to incorrectly call
comedi_alloc_subdevices with num_subdevices = 0. Add a sanity check
before doing the kcalloc.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman -
The n_subdevices variable of struct comedi_device is an int type.
Change the type of the comedi_alloc_subdevices 'num_subdevices' from
an unsigned int to an int to match it.Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Frank Mori Hess
Signed-off-by: Greg Kroah-Hartman
