13 Nov, 2013

1 commit

  • There are new Sparse warnings:

    >> kernel/locking/lockdep.c:1235:15: sparse: symbol '__lockdep_count_forward_deps' was not declared. Should it be static?
    >> kernel/locking/lockdep.c:1261:15: sparse: symbol '__lockdep_count_backward_deps' was not declared. Should it be static?

    Please consider folding the attached diff :-)

    Signed-off-by: Fengguang Wu
    Signed-off-by: Peter Zijlstra
    Link: http://lkml.kernel.org/r/527d1787.ThzXGoUspZWehFDl\%fengguang.wu@intel.com
    Signed-off-by: Ingo Molnar

    Fengguang Wu
     

11 Nov, 2013

2 commits

  • > kernel/locking/lockdep_proc.c: In function 'seq_lock_time':
    > >> kernel/locking/lockdep_proc.c:424:23: warning: comparison of distinct pointer types lacks a cast [enabled by default]
    >
    > 418 static void seq_lock_time(struct seq_file *m, struct lock_time *lt)
    > 419 {
    > 420 seq_printf(m, "%14lu", lt->nr);
    > 421 seq_time(m, lt->min);
    > 422 seq_time(m, lt->max);
    > 423 seq_time(m, lt->total);
    > > 424 seq_time(m, lt->nr ? do_div(lt->total, lt->nr) : 0);
    > 425 }

    My compiler refuses to actually say that; but it looks wrong in that
    do_div() returns the remainder, not the divisor.

    Reported-by: Fengguang Wu
    Tested-by: Fengguang Wu
    Signed-off-by: Peter Zijlstra
    Cc: Davidlohr Bueso
    Link: http://lkml.kernel.org/r/20131106164230.GE16117@laptop.programming.kicks-ass.net
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     
  • Fix this docbook error:

    >> docproc: kernel/mutex.c: No such file or directory

    by updating the stale references to kernel/mutex.c.

    Reported-by: fengguang.wu@intel.com
    Signed-off-by: Peter Zijlstra
    Link: http://lkml.kernel.org/n/tip-34pikw1tlsskj65rrt5iusrq@git.kernel.org
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     

06 Nov, 2013

8 commits