Doug / smarc-fsl-linux-kernel

15 May, 2012

3 commits

  • 2a0ec1d9e   xfs: move xfs_get_extsz_hint() and kill xfs_rw.h ... Browse Code »

    The only thing left in xfs_rw.h is a function prototype for an inode
    function. Move that to xfs_inode.h, and kill xfs_rw.h.

    Also move the function implementing the prototype from xfs_rw.c to
    xfs_inode.c so we only have one function left in xfs_rw.c

    Signed-off-by: Dave Chinner
    Reviewed-by: Mark Tinguely
    Reviewed-by: Christoph Hellwig
    Signed-off-by: Ben Myers

    Dave Chinner
     
  • 60a34607b   xfs: move xfsagino_t to xfs_types.h ... Browse Code »

    Untangle the header file includes a bit by moving the definition of
    xfs_agino_t to xfs_types.h. This removes the dependency that xfs_ag.h has on
    xfs_inum.h, meaning we don't need to include xfs_inum.h everywhere we include
    xfs_ag.h.

    Signed-off-by: Dave Chinner
    Reviewed-by: Mark Tinguely
    Signed-off-by: Ben Myers

    Dave Chinner
     
  • e70b73f84   xfs: clean up buffer get/read call API ... Browse Code »

    The xfs_buf_get/read API is not consistent in the units it uses, and
    does not use appropriate or consistent units/types for the
    variables.

    Convert the API to use disk addresses and block counts for all
    buffer get and read calls. Use consistent naming for all the
    functions and their declarations, and convert the internal functions
    to use disk addresses and block counts to avoid need to convert them
    from one type to another and back again.

    Fix all the callers to use disk addresses and block counts. In many
    cases, this removes an additional conversion from the function call
    as the callers already have a block count.

    Signed-off-by: Dave Chinner
    Reviewed-by: Christoph Hellwig
    Reviewed-by: Mark Tinguely
    Signed-off-by: Ben Myers

    Dave Chinner
     

23 Mar, 2012

1 commit

  • 5575acc78   xfs: fix deadlock in xfs_rtfree_extent ... Browse Code »

    To fix the deadlock caused by repeatedly calling xfs_rtfree_extent

    - removed xfs_ilock() and xfs_trans_ijoin() from xfs_rtfree_extent(),
    instead added asserts that the inode is locked and has an inode_item
    attached to it.
    - in xfs_bunmapi() when dealing with an inode with the rt flag
    call xfs_ilock() and xfs_trans_ijoin() so that the
    reference count is bumped on the inode and attached it to the
    transaction before calling into xfs_bmap_del_extent, similar to
    what we do in xfs_bmap_rtalloc.

    Signed-off-by: Kamal Dasu
    Reviewed-by: Christoph Hellwig
    Signed-off-by: Ben Myers

    Kamal Dasu
     

12 Oct, 2011

3 commits

  • ddc3415ab   xfs: simplify xfs_trans_ijoin* again ... Browse Code »

    There is no reason to keep a reference to the inode even if we unlock
    it during transaction commit because we never drop a reference between
    the ijoin and commit. Also use this fact to merge xfs_trans_ijoin_ref
    back into xfs_trans_ijoin - the third argument decides if an unlock
    is needed now.

    I'm actually starting to wonder if allowing inodes to be unlocked
    at transaction commit really is worth the effort. The only real
    benefit is that they can be unlocked earlier when commiting a
    synchronous transactions, but that could be solved by doing the
    log force manually after the unlock, too.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Christoph Hellwig
     
  • c0dc7828a   xfs: rename xfs_bmapi to xfs_bmapi_write ... Browse Code »

    Now that all the read-only users of xfs_bmapi have been converted to
    use xfs_bmapi_read(), we can remove all the read-only handling cases
    from xfs_bmapi().

    Once this is done, rename xfs_bmapi to xfs_bmapi_write to reflect
    the fact it is for allocation only. This enables us to kill the
    XFS_BMAPI_WRITE flag as well.

    Also clean up xfs_bmapi_write to the style used in the newly added
    xfs_bmapi_read/delay functions.

    Signed-off-by: Dave Chinner
    Signed-off-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Dave Chinner
     
  • 5b777ad51   xfs: remove xfs_bmapi_single() ... Browse Code »

    Now we have xfs_bmapi_read, there is no need for xfs_bmapi_single().
    Change the remaining caller over and kill the function.

    Signed-off-by: Dave Chinner
    Signed-off-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Dave Chinner
     

26 Jul, 2011

2 commits

07 Mar, 2011

1 commit

23 Feb, 2011

1 commit

  • 1050c71e2   xfs: stop using xfs_trans_iget in the RT allocator ... Browse Code »

    During mount we establish references to the RT inodes, which we keep for
    the lifetime of the filesystem. Instead of using xfs_trans_iget to grab
    additional references when adding RT inodes to transactions use the
    combination of xfs_ilock and xfs_trans_ijoin_ref, which archives the same
    end result with less overhead.

    Signed-off-by: Christoph Hellwig
    Reviewed-by: Dave Chinner
    Signed-off-by: Alex Elder

    Christoph Hellwig
     

08 Feb, 2011

2 commits

  • 9681153b4   xfs: add lockdep annotations for the rt inodes ... Browse Code »

    The rt bitmap and summary inodes do not participate in the normal inode
    locking protocol. Instead the rt bitmap inode can be locked in any
    transaction involving rt allocations, and the both of the rt inodes can
    be locked at the same time. Add specific lockdep subclasses for the rt
    inodes to prevent lockdep from blowing up.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Christoph Hellwig
     
  • 04e99455e   xfs: only lock the rt bitmap inode once per allocation ... Browse Code »

    Currently both xfs_rtpick_extent and xfs_rtallocate_extent call
    xfs_trans_iget to grab and lock the rt bitmap inode, which results in a
    deadlock since the removal of the lock recursion counters in commit

    "xfs: simplify inode to transaction joining"

    Fix this by acquiring and locking the inode in xfs_bmap_rtalloc before
    calling into xfs_rtpick_extent and xfs_rtallocate_extent.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Christoph Hellwig
     

19 Oct, 2010

1 commit

  • 1922c949c   xfs: use unhashed buffers for size checks ... Browse Code »

    When we are checking we can access the last block of each device, we
    do not need to use cached buffers as they will be tossed away
    immediately. Use uncached buffers for size checks so that all IO
    prior to full in-memory structure initialisation does not use the
    buffer cache.

    Signed-off-by: Dave Chinner
    Reviewed-by: Christoph Hellwig
    Reviewed-by: Alex Elder

    Dave Chinner
     

27 Jul, 2010

3 commits

  • b4e9181e7   xfs: remove unused delta tracking code in xfs_bmapi ... Browse Code »

    This code was introduced four years ago in commit
    3e57ecf640428c01ba1ed8c8fc538447ada1715b without any review and has
    been unused since. Remove it just as the rest of the code introduced
    in that commit to reduce that stack usage and complexity in this central
    piece of code.

    Signed-off-by: Christoph Hellwig
    Reviewed-by: Dave Chinner

    Christoph Hellwig
     
  • 3400777ff   xfs: remove unneeded #include statements ... Browse Code »

    Signed-off-by: Christoph Hellwig
    Reviewed-by: Dave Chinner

    Christoph Hellwig
     
  • 288699fec   xfs: drop dmapi hooks ... Browse Code »

    Dmapi support was never merged upstream, but we still have a lot of hooks
    bloating XFS for it, all over the fast pathes of the filesystem.

    This patch drops over 700 lines of dmapi overhead. If we'll ever get HSM
    support in mainline at least the namespace events can be done much saner
    in the VFS instead of the individual filesystem, so it's not like this
    is much help for future work.

    Signed-off-by: Christoph Hellwig
    Reviewed-by: Dave Chinner

    Christoph Hellwig
     

24 Jun, 2010

1 commit

  • 7b6259e7a   xfs: remove block number from inode lookup code ... Browse Code »

    The block number comes from bulkstat based inode lookups to shortcut
    the mapping calculations. We ar enot able to trust anything from
    bulkstat, so drop the block number as well so that the correct
    lookups and mappings are always done.

    Signed-off-by: Dave Chinner
    Reviewed-by: Christoph Hellwig

    Dave Chinner
     

29 May, 2010

1 commit

  • 657a4cffd   xfs: replace E2BIG with EFBIG where appropriate ... Browse Code »

    Many places in the xfs code return E2BIG when they really mean
    EFBIG; trying to grow past 16T on a 32 bit machine, for example,
    says "Argument list too long" rather than "File too large" which is
    not particularly helpful.

    Some of these don't make perfect sense as EFBIG either, but still
    better than E2BIG IMHO.

    Signed-off-by: Eric Sandeen
    Reviewed-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Eric Sandeen
     

16 Jan, 2010

1 commit

  • 3daeb42c1   xfs: fix missing error check in xfs_rtfree_range ... Browse Code »

    When xfs_rtfind_forw() returns an error, the block is returned
    uninitialised. xfs_rtfree_range() is not checking the error return,
    so could be using an uninitialised block number for modifying bitmap
    summary info.

    The problem was found by gcc when compiling the *userspace* libxfs
    code - it is an copy of the kernel code with the exact same bug.
    gcc gives an uninitialised variable warning on the userspace code
    but not on the kernel code. You gotta love the consistency (Mmmm,
    slightly chewy today!).

    Signed-off-by: Dave Chinner
    Signed-off-by: Alex Elder

    Dave Chinner
     

15 Dec, 2009

1 commit

  • 0b1b213fc   xfs: event tracing support ... Browse Code »

    Convert the old xfs tracing support that could only be used with the
    out of tree kdb and xfsidbg patches to use the generic event tracer.

    To use it make sure CONFIG_EVENT_TRACING is enabled and then enable
    all xfs trace channels by:

    echo 1 > /sys/kernel/debug/tracing/events/xfs/enable

    or alternatively enable single events by just doing the same in one
    event subdirectory, e.g.

    echo 1 > /sys/kernel/debug/tracing/events/xfs/xfs_ihold/enable

    or set more complex filters, etc. In Documentation/trace/events.txt
    all this is desctribed in more detail. To reads the events do a

    cat /sys/kernel/debug/tracing/trace

    Compared to the last posting this patch converts the tracing mostly to
    the one tracepoint per callsite model that other users of the new
    tracing facility also employ. This allows a very fine-grained control
    of the tracing, a cleaner output of the traces and also enables the
    perf tool to use each tracepoint as a virtual performance counter,
    allowing us to e.g. count how often certain workloads git various
    spots in XFS. Take a look at

    http://lwn.net/Articles/346470/

    for some examples.

    Also the btree tracing isn't included at all yet, as it will require
    additional core tracing features not in mainline yet, I plan to
    deliver it later.

    And the really nice thing about this patch is that it actually removes
    many lines of code while adding this nice functionality:

    fs/xfs/Makefile | 8
    fs/xfs/linux-2.6/xfs_acl.c | 1
    fs/xfs/linux-2.6/xfs_aops.c | 52 -
    fs/xfs/linux-2.6/xfs_aops.h | 2
    fs/xfs/linux-2.6/xfs_buf.c | 117 +--
    fs/xfs/linux-2.6/xfs_buf.h | 33
    fs/xfs/linux-2.6/xfs_fs_subr.c | 3
    fs/xfs/linux-2.6/xfs_ioctl.c | 1
    fs/xfs/linux-2.6/xfs_ioctl32.c | 1
    fs/xfs/linux-2.6/xfs_iops.c | 1
    fs/xfs/linux-2.6/xfs_linux.h | 1
    fs/xfs/linux-2.6/xfs_lrw.c | 87 --
    fs/xfs/linux-2.6/xfs_lrw.h | 45 -
    fs/xfs/linux-2.6/xfs_super.c | 104 ---
    fs/xfs/linux-2.6/xfs_super.h | 7
    fs/xfs/linux-2.6/xfs_sync.c | 1
    fs/xfs/linux-2.6/xfs_trace.c | 75 ++
    fs/xfs/linux-2.6/xfs_trace.h | 1369 +++++++++++++++++++++++++++++++++++++++++
    fs/xfs/linux-2.6/xfs_vnode.h | 4
    fs/xfs/quota/xfs_dquot.c | 110 ---
    fs/xfs/quota/xfs_dquot.h | 21
    fs/xfs/quota/xfs_qm.c | 40 -
    fs/xfs/quota/xfs_qm_syscalls.c | 4
    fs/xfs/support/ktrace.c | 323 ---------
    fs/xfs/support/ktrace.h | 85 --
    fs/xfs/xfs.h | 16
    fs/xfs/xfs_ag.h | 14
    fs/xfs/xfs_alloc.c | 230 +-----
    fs/xfs/xfs_alloc.h | 27
    fs/xfs/xfs_alloc_btree.c | 1
    fs/xfs/xfs_attr.c | 107 ---
    fs/xfs/xfs_attr.h | 10
    fs/xfs/xfs_attr_leaf.c | 14
    fs/xfs/xfs_attr_sf.h | 40 -
    fs/xfs/xfs_bmap.c | 507 +++------------
    fs/xfs/xfs_bmap.h | 49 -
    fs/xfs/xfs_bmap_btree.c | 6
    fs/xfs/xfs_btree.c | 5
    fs/xfs/xfs_btree_trace.h | 17
    fs/xfs/xfs_buf_item.c | 87 --
    fs/xfs/xfs_buf_item.h | 20
    fs/xfs/xfs_da_btree.c | 3
    fs/xfs/xfs_da_btree.h | 7
    fs/xfs/xfs_dfrag.c | 2
    fs/xfs/xfs_dir2.c | 8
    fs/xfs/xfs_dir2_block.c | 20
    fs/xfs/xfs_dir2_leaf.c | 21
    fs/xfs/xfs_dir2_node.c | 27
    fs/xfs/xfs_dir2_sf.c | 26
    fs/xfs/xfs_dir2_trace.c | 216 ------
    fs/xfs/xfs_dir2_trace.h | 72 --
    fs/xfs/xfs_filestream.c | 8
    fs/xfs/xfs_fsops.c | 2
    fs/xfs/xfs_iget.c | 111 ---
    fs/xfs/xfs_inode.c | 67 --
    fs/xfs/xfs_inode.h | 76 --
    fs/xfs/xfs_inode_item.c | 5
    fs/xfs/xfs_iomap.c | 85 --
    fs/xfs/xfs_iomap.h | 8
    fs/xfs/xfs_log.c | 181 +----
    fs/xfs/xfs_log_priv.h | 20
    fs/xfs/xfs_log_recover.c | 1
    fs/xfs/xfs_mount.c | 2
    fs/xfs/xfs_quota.h | 8
    fs/xfs/xfs_rename.c | 1
    fs/xfs/xfs_rtalloc.c | 1
    fs/xfs/xfs_rw.c | 3
    fs/xfs/xfs_trans.h | 47 +
    fs/xfs/xfs_trans_buf.c | 62 -
    fs/xfs/xfs_vnodeops.c | 8
    70 files changed, 2151 insertions(+), 2592 deletions(-)

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Alex Elder

    Christoph Hellwig
     

04 Feb, 2009

1 commit

16 Jan, 2009

1 commit

02 Dec, 2008

1 commit

  • 743bb4650   [XFS] Move copy_from_user calls out of ioctl helpers into ioctl switch. ... Browse Code »

    Moving the copy_from_user out of some of the ioctl helpers will
    make it easier for the compat ioctl switch to copy in the right
    struct, then just pass to the underlying helper.

    Also, move common access checks into the helpers themselves,
    and out of the native ioctl switch code, to reduce code
    duplication between native & compat ioctl callers.

    Signed-off-by: Eric Sandeen
    Reviewed-by: Christoph Hellwig
    Signed-off-by: Lachlan McIlroy

    sandeen@sandeen.net
     

01 Dec, 2008

1 commit

  • 0924b585f   [XFS] fix uninitialised variable bug in dquot release. ... Browse Code »

    gcc is warning about an uninitialised variable in xfs_growfs_rt().
    This is a false positive. Fix it by changing the scope of the
    transaction pointer to wholly within the internal loop inside
    the function.

    While there, preemptively change xfs_growfs_rt_alloc() in the
    same way as it has exactly the same structure as xfs_growfs_rt()
    but gcc is not warning about it. Yet.

    Signed-off-by: Dave Chinner
    Reviewed-by: Christoph Hellwig
    Signed-off-by: Niv Sardi

    Dave Chinner
     

13 Aug, 2008

1 commit

28 Jul, 2008

1 commit

  • f0e2d93c2   [XFS] Remove unused arg from kmem_free() ... Browse Code »

    kmem_free() function takes (ptr, size) arguments but doesn't actually use
    second one.

    This patch removes size argument from all callsites.

    SGI-PV: 981498
    SGI-Modid: xfs-linux-melb:xfs-kern:31050a

    Signed-off-by: Denys Vlasenko
    Signed-off-by: David Chinner
    Signed-off-by: Lachlan McIlroy

    Denys Vlasenko
     

18 Apr, 2008

2 commits

  • e5720eec0   [XFS] Propagate errors from xfs_trans_commit(). ... Browse Code »

    xfs_trans_commit() can return errors when there are problems in the
    transaction subsystem. They are indicative that the entire transaction may
    be incomplete, and hence the error should be propagated as there is a good
    possibility that there is something fatally wrong in the filesystem. Catch
    and propagate or warn about commit errors in the places where they are
    currently ignored.

    SGI-PV: 980084
    SGI-Modid: xfs-linux-melb:xfs-kern:30795a

    Signed-off-by: David Chinner
    Signed-off-by: Niv Sardi
    Signed-off-by: Lachlan McIlroy

    David Chinner
     
  • 433550990   [XFS] remove most calls to VN_RELE ... Browse Code »

    Most VN_RELE calls either directly contain a XFS_ITOV or have the
    corresponding xfs_inode already in scope. Use the IRELE helper instead of
    VN_RELE to clarify the code. With a little more work we can kill VN_RELE
    altogether and define IRELE in terms of iput directly.

    SGI-PV: 976035
    SGI-Modid: xfs-linux-melb:xfs-kern:30710a

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Lachlan McIlroy

    Christoph Hellwig
     

26 Feb, 2008

1 commit

07 Feb, 2008

1 commit

14 Jul, 2007

1 commit

  • 4cc929ee3   [XFS] Don't grow filesystems past the size they can index. ... Browse Code »

    When growing a filesystem we don't check to see if the new size overflows
    the page cache index range, so we can do silly things like grow a
    filesystem page 16TB on a 32bit. Check new filesystem sizes against the
    limits the kernel can support.

    SGI-PV: 957886
    SGI-Modid: xfs-linux-melb:xfs-kern:28563a

    Signed-Off-By: Nathan Scott
    Signed-off-by: David Chinner
    Signed-off-by: Tim Shimmin

    Nathan Scott
     

08 May, 2007

1 commit

10 Feb, 2007

2 commits

28 Sep, 2006

2 commits

28 Jun, 2006

1 commit

20 Jun, 2006

1 commit

09 Jun, 2006

1 commit