30 Mar, 2010
1 commit
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
19 Nov, 2009
1 commit
-
For consistency drop & in front of every proc_handler. Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.Cc: Alexey Dobriyan
Cc: Ingo Molnar
Cc: Joe Perches
Signed-off-by: Eric W. Biederman
12 Nov, 2009
1 commit
-
Now that sys_sysctl is a generic wrapper around /proc/sys .ctl_name
and .strategy members of sysctl tables are dead code. Remove them.Cc: Tony Luck
Cc: Fenghua Yu
Signed-off-by: Eric W. Biederman
14 Apr, 2009
3 commits
-
Introduce xpc_arch_ops and eliminate numerous individual global definitions.
Signed-off-by: Robin Holt
Cc: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
sgi-xpc has a window of failure where an open message can be sent and a
subsequent data message can get lost. We have added a new message
(opencomplete) which closes that window.Signed-off-by: Robin Holt
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
The heartbeat timeout functionality in sgi-xpc is currently not trained to
the connection time. If a connection is made and the code is in the last
polling window prior to doing a timeout, the next polling window will see
the heartbeat as unchanged and initiate a no-heartbeat disconnect.Signed-off-by: Robin Holt
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
03 Apr, 2009
1 commit
-
Add support to the GRU driver for message queue interrupts.
Signed-off-by: Jack Steiner
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Jan, 2009
1 commit
-
Impact: use new cpumask API.
Convert misc driver functions to use struct cpumask.
To Do:
- Convert iucv_buffer_cpumask to cpumask_var_t.Signed-off-by: Rusty Russell
Signed-off-by: Mike Travis
Acked-by: Dean Nelson
Cc: Robert Richter
Cc: oprofile-list@lists.sf.net
Cc: Jeremy Fitzhardinge
Cc: Chris Wright
Cc: virtualization@lists.osdl.org
Cc: xen-devel@lists.xensource.com
Cc: Ursula Braun
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org
07 Jan, 2009
1 commit
-
CC: Jack Steiner
Signed-off-by: Kay Sievers
Signed-off-by: Greg Kroah-Hartman
31 Oct, 2008
1 commit
-
For the time being build for ia64-sn2 alone when CONFIG_IA64_GENERIC is
specified.This eliminates a dependency of the XP/XPC drivers on having the GRU
driver insmod'd in order to insmod them, when running on an ia64-sn2
system.On such a system the GRU driver serves no useful purpose.
Signed-off-by: Dean Nelson
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
31 Jul, 2008
19 commits
-
Setup the notify GRU message queue that is used for sending user messages
on UV systems.Signed-off-by: Dean Nelson
Cc: Jack Steiner
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Setup the activate GRU message queue that is used for partition activation
and channel connection on UV systems.Signed-off-by: Dean Nelson
Cc: Jack Steiner
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Cleanup naming of partition defines.
Signed-off-by: Dean Nelson
Cc: Jack Steiner
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Move xpc_check_remote_hb() so it can support both SN2 and UV.
Signed-off-by: Dean Nelson
Cc: Jack Steiner
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Add UV support to xpc_remote_memcpy(), which involves interfacing to the
GRU driver.Signed-off-by: Dean Nelson
Cc: Jack Steiner
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Get XPC/XPNET to build on x86_64. Trying to modprobe them up on a non-UV
or sn2 system will result in a -ENODEV.Signed-off-by: Dean Nelson
Cc: Jack Steiner
Cc: "Luck, Tony"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Rename XPC's reserved page's timestamp member to reflect the units of time
involved.Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Make the remote copy buffer an sn2 only item.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Move the allocation of XPC's msgqueues to xpc_sn2.c.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Replace the AMO_t typedef by a direct reference to 'struct amo'.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Tie current IPI references to either XPC's notify IRQ or channel control
flags.Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Move additional sn2 specific code into xpc_sn2.c.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Isolate architecture specific code related to XPC's activate IRQ.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Move xpc_allocate() functionality into xpc_send()/xpc_send_notify() so
xpc_allocate() no longer needs to be called by XPNET.Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Change XPC's reserved page timestamp to be based on jiffies.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Isolate the xpc_vars structure of XPC's reserved page to sn2 only.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Isolate the xpc_vars_part structure of XPC's reserved page to sn2 only.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Prepare XPC's reserved page header to work for either sn2 or uv.
Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Support runtime selection of the max number of partitions based on the
hardware being run on.Signed-off-by: Dean Nelson
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
26 Jul, 2008
1 commit
-
* Replace previous instances of the cpumask_of_cpu_ptr* macros
with a the new (lvalue capable) generic cpumask_of_cpu().Signed-off-by: Mike Travis
Cc: Andrew Morton
Cc: Jack Steiner
Cc: Rusty Russell
Signed-off-by: Ingo Molnar
19 Jul, 2008
1 commit
-
* Optimize various places where a pointer to the cpumask_of_cpu value
will result in reducing stack pressure.Signed-off-by: Mike Travis
Signed-off-by: Ingo Molnar
13 May, 2008
2 commits
-
In preparation for supporting greater than 64 partitions replace partid_t by
short in drivers/misc/sgi-xp.Signed-off-by: Dean Nelson
Acked-by: Robin Holt
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Make XP return values more generic to XP and not so tied to XPC by changing
enum xpc_retval to xp_retval, along with changing return value prefixes from
xpc to xp. Also, cleanup a comment block that referenced some of these return
values as well as the handling of BTE related return values.Signed-off-by: Dean Nelson
Acked-by: Robin Holt
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
23 Apr, 2008
3 commits
-
Addressed issues raised by scripts/checkpatch.pl. Removed unnecessary curly
braces. Eliminated uses of volatiles and use of kernel_thread() and daemonize().Signed-off-by: Dean Nelson
Signed-off-by: Tony Luck -
Ran patches through scripts/Lindent (part 2).
Signed-off-by: Dean Nelson
Signed-off-by: Tony Luck -
Move XPC and XPNET from arch/ia64/sn/kernel to drivers/misc/sgi-xp.
Signed-off-by: Dean Nelson
Signed-off-by: Tony Luck