Doug / smarc-fsl-linux-kernel

07 Jul, 2010

1 commit

07 Apr, 2010

1 commit

05 Apr, 2010

2 commits

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

15 Mar, 2010

1 commit

28 Jan, 2010

1 commit

16 Jan, 2010

2 commits

16 Dec, 2009

1 commit

19 Sep, 2009

1 commit

30 Aug, 2009

1 commit

  • bc76f90b8   ACPI battery: work around negative s16 battery current on Acer ... Browse Code »

    Acer Aspire 8930G laptops (and possibly others) report the battery current
    as a 16-bit signed negative when it is charging. It also reports it as
    0x10000 when the current is 0. This patch adds a quirk for this which
    takes the absolute value of the reported current cast to an s16. This is
    a DSDT bug present in the latest BIOS revision (the EC register is 16 bits
    signed and the DSDT attempts to take the 16-bit two's complement of this,
    which works for discharge but not charge. It also breaks zero values
    because a 32-bit register is used and the high bits aren't thrown away).

    I've enabled this for all Acer systems which report in mA units. This
    should be safe since it won't break compliant systems unless they report a
    current above 32A, which is insane. The patch also detects the valid
    32-bit value -1, which indicates unknown status, and does not attempt the
    fix in that case (note that this does not conflict with 16-bit -1, which
    is 65535 as read normally and gets translated to 1mA).

    Signed-off-by: Hector Martin
    Acked-by: Alexey Starikovskiy
    Signed-off-by: Andrew Morton
    Signed-off-by: Len Brown

    Hector Martin
     

29 Aug, 2009

1 commit

  • a192a9580   ACPI: Move definition of PREFIX from acpi_bus.h to internal..h ... Browse Code »

    Linux/ACPI core files using internal.h all PREFIX "ACPI: ",
    however, not all ACPI drivers use/want it -- and they
    should not have to #undef PREFIX to define their own.

    Add GPL commment to internal.h while we are there.

    This does not change any actual console output,
    asside from a whitespace fix.

    Signed-off-by: Len Brown

    Len Brown
     

18 Jun, 2009

2 commits

12 Apr, 2009

1 commit

  • b0cbc861a   Revert "ACPI battery: fix async boot oops" ... Browse Code »

    This reverts commit 5d38258ec026921a7b266f4047ebeaa75db358e5, since the
    underlying problem got fixed properly in the previous commit ("async:
    Fix module loading async-work regression").

    Cc: Arkadiusz Miskiewicz
    Cc: Vegard Nossum
    Cc: Len Brown
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

08 Apr, 2009

1 commit

  • 5d38258ec   ACPI battery: fix async boot oops ... Browse Code »

    > BUG: unable to handle kernel NULL pointer dereference at (null)

    What happens is that the battery module's init sections are being freed
    before the async callback (which was marked __init) has run. This theory
    is supported by the fact that the bad RIP value is a vmalloc address.

    The immediate fix is to make this a non-init call.

    (A better long-term fix is of course to wait with init-section unloading
    until a module's async initcalls have been run, which would allow us to
    discard this function which is still only run once, after all. Perhaps a
    new async_initcall() function for the async/module API, if this is needed
    for other modules in the future?)

    Reported-by: Arkadiusz Miskiewicz
    Signed-off-by: Vegard Nossum
    Tested-by: Alessandro Suardi
    Tested-by: Rafael J. Wysocki
    Signed-off-by: Len Brown

    Vegard Nossum
     

05 Apr, 2009

4 commits

04 Apr, 2009

1 commit

31 Mar, 2009

1 commit

  • 99b762338   proc 2/2: remove struct proc_dir_entry::owner ... Browse Code »

    Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
    as correctly noted at bug #12454. Someone can lookup entry with NULL
    ->owner, thus not pinning enything, and release it later resulting
    in module refcount underflow.

    We can keep ->owner and supply it at registration time like ->proc_fops
    and ->data.

    But this leaves ->owner as easy-manipulative field (just one C assignment)
    and somebody will forget to unpin previous/pin current module when
    switching ->owner. ->proc_fops is declared as "const" which should give
    some thoughts.

    ->read_proc/->write_proc were just fixed to not require ->owner for
    protection.

    rmmod'ed directories will be empty and return "." and ".." -- no harm.
    And directories with tricky enough readdir and lookup shouldn't be modular.
    We definitely don't want such modular code.

    Removing ->owner will also make PDE smaller.

    So, let's nuke it.

    Kudos to Jeff Layton for reminding about this, let's say, oversight.

    http://bugzilla.kernel.org/show_bug.cgi?id=12454

    Signed-off-by: Alexey Dobriyan

    Alexey Dobriyan
     

28 Mar, 2009

1 commit

22 Feb, 2009

1 commit

  • 56f382a08   battery: don't assume we are fully charged when not charging or discharging ... Browse Code »

    On hardware like the T61 it can take a couple of seconds for the battery
    to start charging after the power is connected, and we incorrectly tell
    userspace that we are fully charged, and then go back to charging.

    Only mark a battery as fully charged when the preset charge matches either
    the last full charge, or the design charge.

    http://bugzilla.kernel.org/show_bug.cgi?id=12632

    Signed-off-by: Richard Hughes
    Acked-by: Alexey Starikovskiy
    Acked-by: Henrique de Moraes Holschuh
    Signed-off-by: Len Brown

    Richard Hughes
     

23 Dec, 2008

1 commit

06 Dec, 2008

1 commit

  • f10a3a32a   Revert "ACPI: battery: Convert discharge energy rate to current properly" ... Browse Code »

    This reverts commit 558073dd56707864f09d563b64e7c37c021e89d2, along with
    the failed try to fix the regression it caused ("ACPI: Fix ACPI battery
    regression introduced by commit 558073"), which just made things worse.

    Commit aaad077638be1a25871bcae5e43952d6b63abfca (that failed "Fix ACPI
    battery regression") got the voltage conversion confused, and fixed the
    problem with Rafael's battery monitor apparently just by mistake.

    So revert them both, getting us back to the 2.6.27 state in this, and
    let's revisit it when people understand what's going on.

    Noted-by: Paul Martin
    Requested-by: Rafael J. Wysocki
    Cc: Len Brown
    Cc: Alexey Starikovskiy
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

05 Dec, 2008

1 commit

  • aaad07763   ACPI: Fix ACPI battery regression introduced by commit 558073 ... Browse Code »

    Commit 558073dd56707864f09d563b64e7c37c021e89d2 ("ACPI: battery: Convert
    discharge energy rate to current properly") caused the battery subsystem
    to report wrong values of the remaining time on battery power and the
    time until fully charged on Toshiba Portege R500 (and presumably on
    other boxes too).

    Fix the issue by correcting the conversion from mW to mA.

    Signed-off-by: Rafael J. Wysocki
    Signed-off-by: Linus Torvalds

    Rafael J. Wysocki
     

27 Nov, 2008

1 commit

  • 558073dd5   ACPI: battery: Convert discharge energy rate to current properly ... Browse Code »

    ACPI battery interface reports its state either in mW or in mA, and
    discharge rate in your case is reported in mW. power_supply interface
    does not have such a parameter, so current_now parameter is used
    for all cases. But in case of mW, reported discharge should
    be converted into mA.

    Signed-off-by: Alexey Starikovskiy
    Tested-by: Ferenc Wagner
    Signed-off-by: Len Brown

    Alexey Starikovskiy
     

12 Nov, 2008

1 commit

08 Nov, 2008

1 commit

07 Nov, 2008

1 commit

  • 0794469da   ACPI: struct device - replace bus_id with dev_name(), dev_set_name() ... Browse Code »

    This patch is part of a larger patch series which will remove
    the "char bus_id[20]" name string from struct device. The device
    name is managed in the kobject anyway, and without any size
    limitation, and just needlessly copied into "struct device".

    To set and read the device name dev_name(dev) and dev_set_name(dev)
    must be used. If your code uses static kobjects, which it shouldn't
    do, "const char *init_name" can be used to statically provide the
    name the registered device should have. At registration time, the
    init_name field is cleared, to enforce the use of dev_name(dev) to
    access the device name at a later time.

    We need to get rid of all occurrences of bus_id in the entire tree
    to be able to enable the new interface. Please apply this patch,
    and possibly convert any remaining remaining occurrences of bus_id.

    We want to submit a patch to -next, which will remove bus_id from
    "struct device", to find the remaining pieces to convert, and finally
    switch over to the new api, which will remove the 20 bytes array
    and does no longer have a size limitation.

    Acked-by: Greg Kroah-Hartman
    Signed-Off-By: Kay Sievers
    Signed-off-by: Len Brown

    Kay Sievers
     

23 Oct, 2008

1 commit

20 Oct, 2008

1 commit

  • 01e8ef11b   x86: sysfs: kill owner field from attribute ... Browse Code »

    Tejun's commit 7b595756ec1f49e0049a9e01a1298d53a7faaa15 made sysfs
    attribute->owner unnecessary. But the field was left in the structure to
    ease the merge. It's been over a year since that change and it is now
    time to start killing attribute->owner along with its users - one arch at
    a time!

    This patch is attempt #1 to get rid of attribute->owner only for
    CONFIG_X86_64 or CONFIG_X86_32 . We will deal with other arches later on
    as and when possible - avr32 will be the next since that is something I
    can test. Compile (make allyesconfig / make allmodconfig / custom config)
    and boot tested.

    akpm: the idea is that we put the declaration of sttribute.owner inside
    `#ifndef CONFIG_X86'. But that proved to be too ambitious for now because
    new usages kept on turning up in subsystem trees.

    [akpm: remove the ifdef for now]
    Signed-off-by: Parag Warudkar
    Cc: Greg KH
    Cc: Ingo Molnar
    Cc: Tejun Heo
    Cc: Len Brown
    Cc: Jens Axboe
    Cc: Jean Delvare
    Cc: Roland Dreier
    Cc: David Brownell
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Parag Warudkar
     

11 Oct, 2008

1 commit

29 Apr, 2008

1 commit

  • cf7acfab0   acpi: use non-racy method for proc entries creation ... Browse Code »

    Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data
    be setup before gluing PDE to main tree.

    Add correct ->owner to proc_fops to fix reading/module unloading race.

    Signed-off-by: Denis V. Lunev
    Cc: Len Brown
    Cc: Alexey Dobriyan
    Cc: "Eric W. Biederman"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Denis V. Lunev
     

18 Mar, 2008

1 commit

  • b8a1bdb14   ACPI: battery: Don't return -EFAIL on broken packages. ... Browse Code »

    Acer BIOS has a bug which is exposed when a dead battery is present.

    The package template that is used to describe battery status is
    over-written with sane values when the battery is live.
    But when the batter is dead, a bogus reference in the template
    is used. In this case, Linux returns a fault, when instead
    it should simply return that it doesn't know the missing value.

    http://bugzilla.kernel.org/show_bug.cgi?id=8573
    http://bugzilla.kernel.org/show_bug.cgi?id=10202

    Signed-off-by: Alexey Starikovskiy
    Signed-off-by: Len Brown

    Alexey Starikovskiy
     

06 Feb, 2008

1 commit

02 Jan, 2008

1 commit

07 Dec, 2007

1 commit