24 Sep, 2010

1 commit


25 Aug, 2010

2 commits


24 Aug, 2010

2 commits

  • The machines I have appear to provide their return value in the arguments
    structure, not the output structure. Rework the driver to use that again
    in order to get rfkill working again.

    Signed-off-by: Matthew Garrett

    Matthew Garrett
     
  • Don't ask how ACPI_TOSHIBA got enabled on in desktop system's .config -
    I don't know. But it has silently been there until I tried 2.6.36-rc2,
    where it broke the build because I don't have LED support turned on.
    Attached patch fixes things up.

    (I had to change BACKLIGHT_CLASS_DEVICE to "depends" because otherwise
    I get unsightly core dumps out of scripts/kconfig/conf).

    jon

    --
    toshiba: make sure we pull in LED support

    The Toshiba extras driver uses the LED module, so make sure we have it
    configure in.

    Signed-off-by: Jonathan Corbet
    Signed-off-by: Matthew Garrett

    Jonathan Corbet
     

16 Aug, 2010

9 commits

  • Like others in the Mini series, the Dell Mini 1012 does not support
    the smbios hook required by dell-laptop.

    Signed-off-by: Victor van den Elzen
    Cc: stable
    Signed-off-by: Matthew Garrett

    Victor van den Elzen
     
  • On the T410s and most likely other current models, Fn-F6 is labeled as
    Camera/Headphone key. Report key presses as KEY_CAMERA.

    Signed-off-by: Jens Taprogge
    Acked-by: Jerone Young
    Acked-by: Henrique de Moraes Holschuh
    Signed-off-by: Matthew Garrett

    Jens Taprogge
     
  • Use the quirks engine to select model-specific keymaps, which makes
    it much easier to extend should we need it.

    Keycodes are based on the tables at
    http://www.thinkwiki.org/wiki/Default_meanings_of_special_keys.

    Signed-off-by: Henrique de Moraes Holschuh
    Signed-off-by: Matthew Garrett

    Henrique de Moraes Holschuh
     
  • Use a safer coding style for the hotkey keymap. This does not fix any
    problems, as the current code is correct. But it might help avoid
    mistakes in the future.

    Signed-off-by: Henrique de Moraes Holschuh
    Signed-off-by: Matthew Garrett

    Henrique de Moraes Holschuh
     
  • acpi_video_backlight_support() already tells us if ACPI is handling
    backlight control through the generic ACPI handle. It is better to just
    trust it.

    While at it, adjust down a printk priority, and test earlier for
    brightness_enable=0.

    Signed-off-by: Henrique de Moraes Holschuh
    Signed-off-by: Matthew Garrett

    Henrique de Moraes Holschuh
     
  • The Linux ACPI core locates the ACPI video devices for us and marks them
    with ACPI_VIDEO_HID. Use that information to locate the video device
    instead of a half-baked hunt for _BCL.

    This uncouples the detection of the number of backlight brightness
    levels on ThinkPads from the ACPI paths in vid_handle.

    With this change, the driver should be able to always detect whether the
    ThinkPad uses a 8-level or 16-level brightness scale even on newer
    models for which the vid_handle paths have not been updated yet.

    It will skip deactivated devices in the ACPI device tree, which is a
    change in behaviour.

    Signed-off-by: Henrique de Moraes Holschuh
    Signed-off-by: Matthew Garrett

    Henrique de Moraes Holschuh
     
  • There is a potential NULL dereference of "limits." We can just return
    NULL earlier to avoid it. The caller already handles NULL returns.

    Signed-off-by: Dan Carpenter
    Reviewed-by: Jesse Barnes
    Signed-off-by: Matthew Garrett

    Dan Carpenter
     
  • The assignment of ret to -EIO appears to only make sense if the branch that
    it is aligned with is executed, so move it into that branch.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r disable braces4@
    position p1,p2;
    statement S1,S2;
    @@

    (
    if (...) { ... }
    |
    if (...) S1@p1 S2@p2
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    if (p1[0].column == p2[0].column):
    cocci.print_main("branch",p1)
    cocci.print_secs("after",p2)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Matthew Garrett

    Julia Lawall
     
  • IRQ and resource[] may not have correct values until
    after PCI hotplug setup occurs at pci_enable_device() time.

    The semantic match that finds this problem is as follows:

    //
    @@
    identifier x;
    identifier request ~= "pci_request.*|pci_resource.*";
    @@

    (
    * x->irq
    |
    * x->resource
    |
    * request(x, ...)
    )
    ...
    *pci_enable_device(x)
    //

    Signed-off-by: Kulikov Vasiliy
    Reviewed-by: Jesse Barnes
    Signed-off-by: Matthew Garrett

    Kulikov Vasiliy
     

12 Aug, 2010

2 commits


11 Aug, 2010

1 commit


03 Aug, 2010

23 commits