24 Sep, 2010
1 commit
-
Change the code so that it will use the correct size for keymap entries.
Do it in a way that makes it harder to screw it up in the future.Reported-by: Jaime Velasco Juan
Signed-off-by: Henrique de Moraes Holschuh
Signed-off-by: Matthew Garrett
25 Aug, 2010
2 commits
-
We should pass the data to the data register.
Signed-off-by: Jianwei Yang
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
It looks like there is an off-by-one error in one of your changes to
drivers/staging/rar_register/rar_register.c:Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
24 Aug, 2010
2 commits
-
The machines I have appear to provide their return value in the arguments
structure, not the output structure. Rework the driver to use that again
in order to get rfkill working again.Signed-off-by: Matthew Garrett
-
Don't ask how ACPI_TOSHIBA got enabled on in desktop system's .config -
I don't know. But it has silently been there until I tried 2.6.36-rc2,
where it broke the build because I don't have LED support turned on.
Attached patch fixes things up.(I had to change BACKLIGHT_CLASS_DEVICE to "depends" because otherwise
I get unsightly core dumps out of scripts/kconfig/conf).jon
--
toshiba: make sure we pull in LED supportThe Toshiba extras driver uses the LED module, so make sure we have it
configure in.Signed-off-by: Jonathan Corbet
Signed-off-by: Matthew Garrett
16 Aug, 2010
9 commits
-
Like others in the Mini series, the Dell Mini 1012 does not support
the smbios hook required by dell-laptop.Signed-off-by: Victor van den Elzen
Cc: stable
Signed-off-by: Matthew Garrett -
On the T410s and most likely other current models, Fn-F6 is labeled as
Camera/Headphone key. Report key presses as KEY_CAMERA.Signed-off-by: Jens Taprogge
Acked-by: Jerone Young
Acked-by: Henrique de Moraes Holschuh
Signed-off-by: Matthew Garrett -
Use the quirks engine to select model-specific keymaps, which makes
it much easier to extend should we need it.Keycodes are based on the tables at
http://www.thinkwiki.org/wiki/Default_meanings_of_special_keys.Signed-off-by: Henrique de Moraes Holschuh
Signed-off-by: Matthew Garrett -
Use a safer coding style for the hotkey keymap. This does not fix any
problems, as the current code is correct. But it might help avoid
mistakes in the future.Signed-off-by: Henrique de Moraes Holschuh
Signed-off-by: Matthew Garrett -
acpi_video_backlight_support() already tells us if ACPI is handling
backlight control through the generic ACPI handle. It is better to just
trust it.While at it, adjust down a printk priority, and test earlier for
brightness_enable=0.Signed-off-by: Henrique de Moraes Holschuh
Signed-off-by: Matthew Garrett -
The Linux ACPI core locates the ACPI video devices for us and marks them
with ACPI_VIDEO_HID. Use that information to locate the video device
instead of a half-baked hunt for _BCL.This uncouples the detection of the number of backlight brightness
levels on ThinkPads from the ACPI paths in vid_handle.With this change, the driver should be able to always detect whether the
ThinkPad uses a 8-level or 16-level brightness scale even on newer
models for which the vid_handle paths have not been updated yet.It will skip deactivated devices in the ACPI device tree, which is a
change in behaviour.Signed-off-by: Henrique de Moraes Holschuh
Signed-off-by: Matthew Garrett -
There is a potential NULL dereference of "limits." We can just return
NULL earlier to avoid it. The caller already handles NULL returns.Signed-off-by: Dan Carpenter
Reviewed-by: Jesse Barnes
Signed-off-by: Matthew Garrett -
The assignment of ret to -EIO appears to only make sense if the branch that
it is aligned with is executed, so move it into that branch.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)//
@r disable braces4@
position p1,p2;
statement S1,S2;
@@(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)@script:python@
p1 << r.p1;
p2 << r.p2;
@@if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
//Signed-off-by: Julia Lawall
Signed-off-by: Matthew Garrett -
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.The semantic match that finds this problem is as follows:
//
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...
*pci_enable_device(x)
//Signed-off-by: Kulikov Vasiliy
Reviewed-by: Jesse Barnes
Signed-off-by: Matthew Garrett
12 Aug, 2010
2 commits
-
Signed-off-by: David Woodhouse
-
Signed-off-by: David Woodhouse
11 Aug, 2010
1 commit
-
Signed-off-by: David Woodhouse
03 Aug, 2010
23 commits
-
We don't need a dev_warn when we exceed a thermal or power limit as
we'll handle it appropriately by clamping down on the CPU, GPU or both
as needed.Signed-off-by: Jesse Barnes
Signed-off-by: Matthew Garrett -
Size for PMIC read/write command is byte, while it is DWORD for other
IPC commands.Signed-off-by: Hong Liu
Signed-off-by: ALan Cox
Signed-off-by: Matthew Garrett -
Signed-off-by: Hong Liu
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
Data is 2-byte per entry for PMIC read-modify-update command.
Signed-off-by: Hong Liu
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
Don't pass more bytes in the command length field than we filled.
Signed-off-by: Andy Ross
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
some messages take 4 bytes, but only fill 3 bytes....
this patch makes sure that whatever we send to the SCU is zeroed firstSigned-off-by: Arjan van de Ven
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
The stack buffer for IPC messages was 16 bytes, limiting messages to a
size of 4 (each message is 32 bit).
However, the touch screen driver is trying to send messages of size 5....(AC: Set to 20 bytes having checked the max size allowed)
Signed-off-by: Arjan van de Ven
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
This provides an architecture level board identify function to replace the
cpuid direct usageSigned-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
Delete unused constants IPC_CMD_INDIRECT_RD and IPC_CMD_INDIRECT_WR
Remove multiple inclusion of header file "asm/mrst.h"Signed-off-by: Sreedhara DS
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
The firmware of production devices does not support this interface so this
is dead code.Signed-off-by: Sreedhara DS
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
Changes to work on bothMmoorestown and Medfield
New pci id added for Medfield
Return type of ipc_data_readl chnaged from u8 to u32Signed-off-by: Sreedhara DS
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
Intel SCU message formats depend upon the processor type. Replace the
module option with automatic detection of the processor type.Signed-off-by: Sreedhara DS
Signed-off-by: Matthew Garrett -
My .config contains ACER_WMI=m. On SPARC. That does not make sense.
Restrict the x86 platform driver menu to x86.Signed-off-by: Jan Engelhardt
Signed-off-by: Matthew Garrett -
Signed-off-by: Thomas Renninger
CC: linux-acpi@vger.kernel.or
CC: platform-driver-x86@vger.kernel.org
CC: mjg@redhat.com
Signed-off-by: Matthew Garrett -
This should have been an "and". Additionally checking for !obj
is even better.Signed-off-by: Thomas Renninger
CC: linux-acpi@vger.kernel.or
CC: platform-driver-x86@vger.kernel.org
CC: mjg@redhat.com
Signed-off-by: Matthew Garrett -
Make dell_laptop_i8042_filter() static as it's used only in dell-laptop.c
Signed-off-by: Axel Lin
Signed-off-by: Matthew Garrett -
This patch includes below fixes:
1. return -ENOMEM instead of 0 if input_allocate_device fail.
2. fix wrong goto if sparse_keymap_setup fail.
3. fix wrong goto if input_register_device fail.Signed-off-by: Axel Lin
Signed-off-by: Matthew Garrett -
backlight is needlessly defined global.
This patch makes the symbol static.Signed-off-by: Axel Lin
Acked-by: Anisse Astier
Signed-off-by: Matthew Garrett -
Add support for Toshiba Illumination. This is a set of LEDs installed on
some Toshiba laptops. It is controlled through ACPI, the commands has been
found through reverse engineering. It has been tested on a Toshiba Qosmio
G50-122.Signed-off-by: Pierre Ducroquet
Signed-off-by: Matthew Garrett -
compal-laptop uses power_supply interfaces so it should depend
on POWER_SUPPLY.ERROR: "power_supply_register" [drivers/platform/x86/compal-laptop.ko] undefined!
ERROR: "power_supply_unregister" [drivers/platform/x86/compal-laptop.ko] undefined!Signed-off-by: Randy Dunlap
Cc: Cezary Jackiewicz
Cc: Matthew Garrett
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Matthew Garrett -
Moorestown has PMIC chip which contains GPIO blocks. The PMIC chip is
connected to Langwell by SPI interface. So this GPIO driver will be regarded
as SPI GPIO expander though the actual GPIO access is through IPC and SRAM.
The SPI master contoller will probe this device driver by parsing SPIB table.Cleaned up for new IPC, GPE removed and some printk and other tidying by
Alan Cox. Fixes for points noted by Matthew GarrettSigned-off-by: Alek Du
Signed-off-by: Alan Cox
Signed-off-by: Matthew Garrett -
The .add function must not be declared __init.
Signed-off-by: Thomas Renninger
CC: Alexey Starikovskiy
CC: Len Brown
CC: linux-kernel@vger.kernel.org
CC: linux-acpi@vger.kernel.org
CC: platform-driver-x86@vger.kernel.org
Signed-off-by: Matthew Garrett -
There is a general interface for that now (provided by
other patches in this patch series):
/sys/kernel/debug/ec/*/ioSigned-off-by: Thomas Renninger
CC: Alexey Starikovskiy
CC: Len Brown
CC: linux-kernel@vger.kernel.org
CC: linux-acpi@vger.kernel.org
CC: platform-driver-x86@vger.kernel.org
CC: Henrique de Moraes Holschuh
CC: ibm-acpi-devel@lists.sourceforge.net
Signed-off-by: Matthew Garrett