21 Aug, 2010
1 commit
-
gcc-4.0.2:
drivers/scsi/qla4xxx/ql4_os.c: In function 'qla4_8xxx_error_recovery':
drivers/scsi/qla4xxx/ql4_glbl.h:135: sorry, unimplemented: inlining failed in call to 'qla4_8xxx_set_drv_active': function body not available
drivers/scsi/qla4xxx/ql4_os.c:2377: sorry, unimplemented: called from here
drivers/scsi/qla4xxx/ql4_glbl.h:135: sorry, unimplemented: inlining failed in call to 'qla4_8xxx_set_drv_active': function body not available
drivers/scsi/qla4xxx/ql4_os.c:2393: sorry, unimplemented: called from hereCc: Ravi Anand
Cc: Vikas Chaudhary
Cc: James Bottomley
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Aug, 2010
1 commit
-
Fix following warning:
drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_get_flash_info':
drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: 'mid' may be used uninitialized in this function
drivers/scsi/qla4xxx/ql4_nx.c:1952: note: 'mid' was declared here
drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: 'fid' may be used uninitialized in this function
drivers/scsi/qla4xxx/ql4_nx.c:1952: note: 'fid' was declared hereSigned-off-by: Vikas Chaudhary
Reported-by: Stephen Rothwell
Signed-off-by: James Bottomley
07 Aug, 2010
8 commits
-
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Signed-off-by: James Bottomley -
Added support for PCI error handling
Signed-off-by: Lalit Chandivade
Signed-off-by: Vikas Chaudhary
Signed-off-by: Poornima Vonti
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Outstanding mailbox commands, have no way to recover on f/w hung, and we
timeout on waiting for mbx response. This in turn affects the recovery process
as follows:
- We might already be in dpc while waiting for mbx to complete, so recovery for
that pci function will never get invoked. Reset Timeout (10 sec) is far less
than mbx timeout (30 sec).
- Other mbx cmds will get stuck due to serial mbx access.Solution is to identify fw-hung scenario and handle outstanding mbx commands to
have an early-exit instead of waiting for response.
Other mbx commands waiting for access will also do an early-exit if fw-hung is
still applicable.Signed-off-by: Nilesh Javali
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Also, changed boundary checking from size of total
structure to verification that we received the amount of
data needed to cache inernally. This change will provide
compatibility with mbx_sys_info structure sizes in both
older and newer firmware versions.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
If BIOS is enabled then drivers init firmware fails since
BIOS has done the init once.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
05 Aug, 2010
1 commit
-
* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (48 commits)
Documentation: update broken web addresses.
fix comment typo "choosed" -> "chosen"
hostap:hostap_hw.c Fix typo in comment
Fix spelling contorller -> controller in comments
Kconfig.debug: FAIL_IO_TIMEOUT: typo Faul -> Fault
fs/Kconfig: Fix typo Userpace -> Userspace
Removing dead MACH_U300_BS26
drivers/infiniband: Remove unnecessary casts of private_data
fs/ocfs2: Remove unnecessary casts of private_data
libfc: use ARRAY_SIZE
scsi: bfa: use ARRAY_SIZE
drm: i915: use ARRAY_SIZE
drm: drm_edid: use ARRAY_SIZE
synclink: use ARRAY_SIZE
block: cciss: use ARRAY_SIZE
comment typo fixes: charater => character
fix comment typos concerning "challenge"
arm: plat-spear: fix typo in kerneldoc
reiserfs: typo comment fix
update email address
...
28 Jul, 2010
11 commits
-
wait for session to come online in eh_device_reset_handler
and eh_target_reset_handlerSigned-off-by: Mike Christie
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Karen Higgins
Signed-off-by: Ravi Anand
Signed-off-by: James Bottomley -
Handle one H/W Interrupt at a time to prevent holding off H/W lock
for longer period of time.Signed-off-by: Ravi Anand
Signed-off-by: Vikas Chaudhary
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Fixed the DMA allocated memory freeing which wasn't taken care
in many cases.Signed-off-by: Prasanna Mumbai
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Handle fw_state "auto discovery in progress" correctly
to avoid marking adapter as offline.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Once the device goes *missing*, driver blocks the session
ie iscsi_block_session() to stall the I/O. So after device
comes back *online*, driver needs to unblock the session ie
iscsi_unblock_session(), else I/Os will fail even if
ddb_state is ONLINE.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
If fw ddb state is ACTIVE mark driver ddb stat as ONLINE and
unblock iscsi session.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
17 Jun, 2010
1 commit
-
Signed-off-by: Uwe Kleine-König
Signed-off-by: Jiri Kosina
18 May, 2010
1 commit
-
Signed-off-by: James Bottomley
03 May, 2010
8 commits
-
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
* Handles SCSI command aborts.
* Serialization srb between error handler and command
completion path.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
used cmd->host_scribble to store iocb command handle.
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Per RFC 3720, Login Response Status Code 0x02 should not be retried.
Condensed connection error checking code to a single routine, and
added check for status class 0x02.Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Updated firmware ready timeout algorithm to prevent
long delays and use jiffies to time out instead of
counter. Also use msleep_interruptible instead of msleep.Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Link Down -> Mark all devices missing
Previously, the driver took no action on a Link Down,
and waited for the I/O on a dead connection to timeout
in the firmware before marking the DDB missing.Link Up -> Mark all devices online
F/W will do auto login to all the devices only once.
After that its the responsibility of the driver to
relogin to devices whenever there is :
* Any sort of connection failure or
* KATO expires indicating target has logged out or
* I/O times out etc.Signed-off-by: Vikas Chaudhary
Signed-off-by: Karen Higgins
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
23 Apr, 2010
1 commit
-
Fix operator precedence warning (from sparse), which results in the
data value always being 0:drivers/scsi/qla4xxx/ql4_mbx.c:470:66: warning: right shift by bigger than source value
Signed-off-by: Randy Dunlap
Acked-by: Ravi Anand
Cc: David C Somayajulu
Cc: Karen Higgins
Cc: Vikas Chaudhary
Signed-off-by: Linus Torvalds
30 Mar, 2010
1 commit
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
18 Feb, 2010
1 commit
-
If the nvram is invalid qla4xxx tries to set Asuint32_t
based on the card type. If the card type is not listed
then Asuint32_t is going to be gargabe. This just fixes
that if/elseif by adding a else to catch the case for
new hardware that might not be listed yet.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
21 Sep, 2009
1 commit
-
Signed-off-by: Anand Gadiyar
Signed-off-by: Jiri Kosina
05 Sep, 2009
1 commit
-
The residual variable is only valid for udnerrun so do
not print it out for the overrun case.Signed-off-by: Karen Higgins
[Mike Christie: Fix coding style issues in patch]
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
30 Jul, 2009
3 commits
-
Removed unnecessary hiwat code to free up the number available IOCBs.
Eliminates unnecessary eh_ escalations due to inability to obtain IOCB
pkt for marker.v2.
- Remove define not used anymore and fix req_q_coun accounting.Signed-off-by: Karen Higgins
[michaelc: ported patch from qlogic.com driver to upstream]
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
eh_device_reset may be called from scsi error handler or sg_reset, etc.
When called from sg_reset, there will not be an associated srb. The
driver should lookup the corresponding device handle given information
from the supplied cmd structure and should not assume that there exists
an srb.Signed-off-by: Karen Higgins
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Fixed driver bug where adapter recovery did not complete if there were
outstanding commands detected on that host adapter.Signed-off-by: Karen Higgins
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley