29 Mar, 2012

1 commit


09 Mar, 2012

2 commits

  • Checking if tty->index is in bounds is not needed. The tty has the
    index set in the initial open. This is done in get_tty_driver. And it
    can be only in interval num).

    So remove the tests which check exactly this interval. Some are
    left untouched as they check against the current backing device count.
    (Leaving apart that the check is racy in most of the cases.)

    Signed-off-by: Jiri Slaby
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • All num, magic and owner are set by alloc_tty_driver. No need to
    re-set them on each allocation site.

    pti driver sets something different to what it passes to
    alloc_tty_driver. It is not a bug, since we don't use the lines
    parameter in any way. Anyway this is fixed, and now we do the right
    thing.

    Signed-off-by: Jiri Slaby
    Acked-by: Tilman Schmidt
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

13 Jan, 2012

1 commit


30 Sep, 2011

1 commit

  • My main concern here was the line that said:
    copy_count = min_t(unsigned short,count,SCABUFSIZE);
    "count" is an unsigned int here so the cast to unsigned short
    truncates the upper bits. So if count is 0x10000 then copy_count is
    0 and the loop never exits.

    "count" comes from skb->len in hdlcdev_xmit().

    The other min_t() changes are just cleanups.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Greg Kroah-Hartman

    Dan Carpenter
     

31 Mar, 2011

1 commit


23 Feb, 2011

1 commit