10 Sep, 2013

5 commits


09 Sep, 2013

2 commits


11 Jul, 2013

3 commits


28 Jun, 2013

1 commit

  • Commit 9ddec56131 (cifs: move handling of signed connections into
    separate function) broke signing on SMB2/3 connections. While the code
    to enable signing on the connections was very similar between the two,
    the bits that get set in the sec_mode are different.

    Declare a couple of new smb_version_values fields and set them
    appropriately for SMB1 and SMB2/3. Then change cifs_enable_signing to
    use those instead.

    Reported-by: Shirish Pargaonkar
    Signed-off-by: Jeff Layton
    Tested-by: Shirish Pargaonkar
    Signed-off-by: Steve French

    Jeff Layton
     

27 Jun, 2013

2 commits

  • Fix build warning in Shirish's recent SMB3 signing patch
    which occurs when SMB2 support is disabled in Kconfig.

    fs/built-in.o: In function `cifs_setup_session':
    >> (.text+0xa1767): undefined reference to `generate_smb3signingkey'

    Pointed out by: automated 0-DAY kernel build testing backend
    Intel Open Source Technology Center

    CC: Shirish Pargaonkar
    Signed-off-by: Steve French

    Steve French
     
  • Cut and paste likely introduced accidentally inserted spurious #define
    in d60622eb5a23904facf4a4efac60f5bfa810d7d4 causes no harm but looks weird

    Signed-off-by: Steve French

    Steve French
     

24 Jun, 2013

2 commits


05 May, 2013

1 commit

  • It's not obvious from reading the macro names that these macros
    are for debugging. Convert the names to a single more typical
    kernel style cifs_dbg macro.

    cERROR(1, ...) -> cifs_dbg(VFS, ...)
    cFYI(1, ...) -> cifs_dbg(FYI, ...)
    cFYI(DBG2, ...) -> cifs_dbg(NOISY, ...)

    Move the terminating format newline from the macro to the call site.

    Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
    "CIFS VFS: " prefix for VFS messages.

    Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)

    $ size fs/cifs/cifs.ko*
    text data bss dec hex filename
    265245 2525 132 267902 4167e fs/cifs/cifs.ko.new
    268359 2525 132 271016 422a8 fs/cifs/cifs.ko.old

    Other miscellaneous changes around these conversions:

    o Miscellaneous typo fixes
    o Add terminating \n's to almost all formats and remove them
    from the macros to be more kernel style like. A few formats
    previously had defective \n's
    o Remove unnecessary OOM messages as kmalloc() calls dump_stack
    o Coalesce formats to make grep easier,
    added missing spaces when coalescing formats
    o Use %s, __func__ instead of embedded function name
    o Removed unnecessary "cifs: " prefixes
    o Convert kzalloc with multiply to kcalloc
    o Remove unused cifswarn macro

    Signed-off-by: Joe Perches
    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Joe Perches
     

07 Mar, 2013

1 commit


02 Jan, 2013

1 commit


10 Dec, 2012

1 commit

  • Restructure code to make SMB2 vs. SMB3 signing a protocol
    specific op. SMB3 signing (AES_CMAC) is not enabled yet,
    but this restructuring at least makes sure we don't send
    an smb2 signature on an smb3 signed connection. A followon
    patch will add AES_CMAC and enable smb3 signing.

    Signed-off-by: Steve French
    Acked-by: Jeff Layton

    Steve French
     

06 Dec, 2012

2 commits


02 Oct, 2012

1 commit


27 Sep, 2012

1 commit


25 Sep, 2012

17 commits