Doug / smarc-fsl-linux-kernel

10 Jul, 2009

1 commit

31 Mar, 2009

1 commit

  • 99b762338   proc 2/2: remove struct proc_dir_entry::owner ... Browse Code »

    Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
    as correctly noted at bug #12454. Someone can lookup entry with NULL
    ->owner, thus not pinning enything, and release it later resulting
    in module refcount underflow.

    We can keep ->owner and supply it at registration time like ->proc_fops
    and ->data.

    But this leaves ->owner as easy-manipulative field (just one C assignment)
    and somebody will forget to unpin previous/pin current module when
    switching ->owner. ->proc_fops is declared as "const" which should give
    some thoughts.

    ->read_proc/->write_proc were just fixed to not require ->owner for
    protection.

    rmmod'ed directories will be empty and return "." and ".." -- no harm.
    And directories with tricky enough readdir and lookup shouldn't be modular.
    We definitely don't want such modular code.

    Removing ->owner will also make PDE smaller.

    So, let's nuke it.

    Kudos to Jeff Layton for reminding about this, let's say, oversight.

    http://bugzilla.kernel.org/show_bug.cgi?id=12454

    Signed-off-by: Alexey Dobriyan

    Alexey Dobriyan
     

12 Mar, 2009

1 commit

  • b298f2235   [CIFS] Send SMB flush in cifs_fsync ... Browse Code »

    In contrast to the now-obsolete smbfs, cifs does not send SMB_COM_FLUSH
    in response to an explicit fsync(2) to guarantee that all volatile data
    is written to stable storage on the server side, provided the server
    honors the request (which, to my knowledge, is true for Windows and
    Samba with 'strict sync' enabled).
    This patch modifies the cifs_fsync implementation to restore the
    fsync-behavior of smbfs by triggering SMB_COM_FLUSH after sending
    outstanding data on the client side to the server.

    Signed-off-by: Horst Reiterer
    Acked-by: Jeff Layton
    Signed-off-by: Steve French

    Steve French
     

17 Nov, 2008

2 commits

15 Nov, 2008

2 commits

  • 14fbf50d6   cifs: reinstate sharing of SMB sessions sans races ... Browse Code »

    We do this by abandoning the global list of SMB sessions and instead
    moving to a per-server list. This entails adding a new list head to the
    TCP_Server_Info struct. The refcounting for the cifsSesInfo is moved to
    a non-atomic variable. We have to protect it by a lock anyway, so there's
    no benefit to making it an atomic. The list and refcount are protected
    by the global cifs_tcp_ses_lock.

    The patch also adds a new routines to find and put SMB sessions and
    that properly take and put references under the lock.

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff Layton
     
  • e7ddee903   cifs: disable sharing session and tcon and add new TCP sharing code ... Browse Code »

    The code that allows these structs to be shared is extremely racy.
    Disable the sharing of SMB and tcon structs for now until we can
    come up with a way to do this that's race free.

    We want to continue to share TCP sessions, however since they are
    required for multiuser mounts. For that, implement a new (hopefully
    race-free) scheme. Add a new global list of TCP sessions, and take
    care to get a reference to it whenever we're dealing with one.

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff Layton
     

14 Nov, 2008

1 commit

09 Aug, 2008

1 commit

24 Jul, 2008

3 commits

29 Apr, 2008

1 commit

18 Feb, 2008

1 commit

13 Feb, 2008

1 commit

08 Feb, 2008

1 commit

05 Oct, 2007

1 commit

  • a013689dd   [CIFS] Fix cifsd so shuts down when signing fails during mount ... Browse Code »

    Fixes two problems:
    1) we dropped down to negotiating lanman if we did not recognize the
    mechanism (krb5 e.g.)
    2) we did not stop cifsd (thus will fail when doing rmod cifs with
    slab free errors) when we fail tcon but have a bad session (which is
    the case in which signing is required but we don't allow signing on
    the client)

    It also turns on extended security flag in the header when passing
    "sec=krb5" on mount command (although kerberos support is not done of
    course)

    Acked-by: Jeff Layton
    CC: Shaggy
    Signed-off-by: Steve French

    Steve French
     

15 Sep, 2007

2 commits

13 Jul, 2007

1 commit

  • 50c2f7538   [CIFS] whitespace/formatting fixes ... Browse Code »

    This should be the last big batch of whitespace/formatting fixes.
    checkpatch warnings for the cifs directory are down about 90% and
    many of the remaining ones are harder to remove or make the code
    harder to read.

    Signed-off-by: Steve French

    Steve French
     

29 Jun, 2007

1 commit

25 Jun, 2007

1 commit

06 Jun, 2007

1 commit

22 Jan, 2007

1 commit

06 Jun, 2006

1 commit

05 Jun, 2006

1 commit

03 Jun, 2006

1 commit

02 Jun, 2006

1 commit

01 Jun, 2006

1 commit

13 Dec, 2005

1 commit

04 Dec, 2005

2 commits

12 Oct, 2005

2 commits

11 Oct, 2005

2 commits

08 Oct, 2005

1 commit

21 Aug, 2005

1 commit

24 Jun, 2005

1 commit

29 Apr, 2005

1 commit