15 May, 2013
1 commit
-
Implement labeled NFS on the server: encoding and decoding, and writing
and reading, of file labels.Enabled with CONFIG_NFSD_V4_SECURITY_LABEL.
Signed-off-by: Matthew N. Dodd
Signed-off-by: Miguel Rodel Felipe
Signed-off-by: Phua Eu Gene
Signed-off-by: Khin Mi Mi Aung
Signed-off-by: J. Bruce Fields
08 Apr, 2013
1 commit
-
Closed stateid's are kept around a little while to handle close replays
in the 4.0 case. So we stash them in the last-used stateid in the
oo_last_closed_stateid field of the open owner. We can free that in
encode_seqid_op_tail once the seqid on the open owner is next
incremented. But we don't want to do that on the close itself; so we
set NFS4_OO_PURGE_CLOSE flag set on the open owner, skip freeing it the
first time through encode_seqid_op_tail, then when we see that flag set
next time we free it.This is unnecessarily baroque.
Instead, just move the logic that increments the seqid out of the xdr
code and into the operation code itself.The justification given for the current placement is that we need to
wait till the last minute to be sure we know whether the status is a
sequence-id-mutating error or not, but examination of the code shows
that can't actually happen.Reported-by: Yanchuan Nian
Tested-by: Yanchuan Nian
Signed-off-by: J. Bruce Fields
03 Apr, 2013
2 commits
-
lk_rflags is never used anywhere, and rflags is not defined in struct
nfsd4_lock.Signed-off-by: Yanchuan Nian
Signed-off-by: J. Bruce Fields -
If a client sets an owner (or group_owner or acl) attribute on open for
create, and the mapping of that owner to an id fails, then we return
BAD_OWNER. But BAD_OWNER is a seqid-mutating error, so we can't
shortcut the open processing that case: we have to at least look up the
owner so we can find the seqid to bump.Signed-off-by: J. Bruce Fields
24 Jan, 2013
1 commit
-
It seems slightly simpler to make nfsd4_encode_fattr rather than its
callers responsible for advancing the write pointer on success.(Also: the count == 0 check in the verify case looks superfluous.
Running out of buffer space is really the only reason fattr encoding
should fail with eresource.)Signed-off-by: J. Bruce Fields
18 Dec, 2012
1 commit
-
To ensure ordering of read data with any following operations, turn off
zero copy if the read is not the final operation in the compound.Signed-off-by: J. Bruce Fields
26 Nov, 2012
2 commits
-
Our server rejects compounds containing more than one write operation.
It's unclear whether this is really permitted by the spec; with 4.0,
it's possibly OK, with 4.1 (which has clearer limits on compound
parameters), it's probably not OK. No client that we're aware of has
ever done this, but in theory it could be useful.The source of the limitation: we need an array of iovecs to pass to the
write operation. In the worst case that array of iovecs could have
hundreds of elements (the maximum rwsize divided by the page size), so
it's too big to put on the stack, or in each compound op. So we instead
keep a single such array in the compound argument.We fill in that array at the time we decode the xdr operation.
But we decode every op in the compound before executing any of them. So
once we've used that array we can't decode another write.If we instead delay filling in that array till the time we actually
perform the write, we can reuse it.Another option might be to switch to decoding compound ops one at a
time. I considered doing that, but it has a number of other side
effects, and I'd rather fix just this one problem for now.Signed-off-by: J. Bruce Fields
-
In preparation for moving some of this elsewhere.
Signed-off-by: J. Bruce Fields
15 Nov, 2012
1 commit
-
This patch replaces init_net by SVC_NET(), where possible and also passes
proper context to nested functions where required.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: J. Bruce Fields
08 Nov, 2012
1 commit
-
This operation is mandatory for servers to implement.
Signed-off-by: J. Bruce Fields
01 Jun, 2012
1 commit
-
In each of these cases there's a simple unambiguous correct choice, and
no actual bug.Signed-off-by: J. Bruce Fields
21 Mar, 2012
1 commit
-
Clean up due to code review.
The nfs4_verifier's data field is not guaranteed to be u32-aligned.
Casting an array of chars to a u32 * is considered generally
hazardous.We can fix most of this by using a __be32 array to generate the
verifier's contents and then byte-copying it into the verifier field.However, there is one spot where there is a backwards compatibility
constraint: the do_nfsd_create() call expects a verifier which is
32-bit aligned. Fix this spot by forcing the alignment of the create
verifier in the nfsd4_open args structure.Also, sizeof(nfs4_verifer) is the size of the in-core verifier data
structure, but NFS4_VERIFIER_SIZE is the number of octets in an XDR'd
verifier. The two are not interchangeable, even if they happen to
have the same value.Signed-off-by: Chuck Lever
Signed-off-by: J. Bruce Fields
18 Feb, 2012
3 commits
-
Respect client request for not getting a delegation in NFSv4.1
Appropriately return delegation "type" NFS4_OPEN_DELEGATE_NONE_EXT
and WND4_NOT_WANTED reason.[nfsd41: add missing break when encoding op_why_no_deleg]
Signed-off-by: Benny Halevy
Signed-off-by: J. Bruce Fields -
When I initially wrote it, I didn't understand how lists worked so I
wrote something that didn't use them. I think making a list of stateids
to test is a more straightforward implementation, especially compared to
especially compared to decoding stateids while simultaneously encoding
a reply to the client.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
Signed-off-by: Benny Halevy
Signed-off-by: J. Bruce Fields
16 Feb, 2012
3 commits
-
Signed-off-by: Tigran Mkrtchyan
Signed-off-by: J. Bruce Fields -
Signed-off-by: Tigran Mkrtchyan
Signed-off-by: J. Bruce Fields -
Signed-off-by: Tigran Mkrtchyan
Signed-off-by: J. Bruce Fields
15 Feb, 2012
1 commit
-
Combine two booleans into a single flag field, move the smaller fields
to the end.(In practice this doesn't make the struct any smaller. But we'll be
adding another flag here soon.)Remove some debugging code that doesn't look useful, while we're in the
neighborhood.Signed-off-by: J. Bruce Fields
24 Oct, 2011
1 commit
-
According to rfc5661 18.50, implement DESTROY_CLIENTID operation.
Signed-off-by: Mi Jinlong
Signed-off-by: J. Bruce Fields
18 Oct, 2011
4 commits
-
If we create the object and then return failure to the client, we're
left with an unexpected file in the filesystem.I'm trying to eliminate such cases but not 100% sure I have so an
assertion might be helpful for now.Signed-off-by: J. Bruce Fields
-
As with the nfs4_file, we'd prefer to find out about any failure before
creating a new file rather than after.Signed-off-by: J. Bruce Fields
-
Creating a new file is an irrevocable step--once it's visible in the
filesystem, other processes may have seen it and done something with it,
and unlinking it wouldn't simply undo the effects of the create.Therefore, in the case where OPEN creates a new file, we shouldn't do
the create until we know that the rest of the OPEN processing will
succeed.For example, we should preallocate a struct file in case we need it
until waiting to allocate it till process_open2(), which is already too
late.Signed-off-by: J. Bruce Fields
-
If process_open1() creates a new open owner, but the open later fails,
the current code will leave the open owner around. It won't be on the
close_lru list, and the client isn't expected to send a CLOSE, so it
will hang around as long as the client does.Similarly, if process_open1() removes an existing open owner from the
close lru, anticipating that an open owner that previously had no
associated stateid's now will, but the open subsequently fails, then
we'll again be left with the same leak.Fix both problems.
Reported-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields
12 Oct, 2011
1 commit
-
Again, these checks are better in the xdr code.
Signed-off-by: J. Bruce Fields
27 Sep, 2011
1 commit
-
Test_stateid is 4.1-only and only allowed after a sequence operation, so
this check is unnecessary.Cc: Bryan Schumaker
Signed-off-by: J. Bruce Fields
16 Sep, 2011
1 commit
-
For checking the size of reply before calling a operation,
we need try to get maxsize of the operation's reply.v3: using new method as Bruce said,
"we could handle operations in two different ways:
- For operations that actually change something (write, rename,
open, close, ...), do it the way we're doing it now: be
very careful to estimate the size of the response before even
processing the operation.
- For operations that don't change anything (read, getattr, ...)
just go ahead and do the operation. If you realize after the
fact that the response is too large, then return the error at
that point.So we'd add another flag to op_flags: say, OP_MODIFIES_SOMETHING. And for
operations with OP_MODIFIES_SOMETHING set, we'd do the first thing. For
operations without it set, we'd do the second."Signed-off-by: Mi Jinlong
[bfields@redhat.com: crash, don't attempt to handle, undefined op_rsize_bop]
Signed-off-by: J. Bruce Fields
07 Sep, 2011
1 commit
-
The stateowner has some fields that only make sense for openowners, and
some that only make sense for lockowners, and I find it a lot clearer if
those are separated out.Signed-off-by: J. Bruce Fields
01 Sep, 2011
3 commits
-
This is used only as a local variable.
Signed-off-by: J. Bruce Fields
-
Maybe we'll bring it back some day, but we don't have much real use for
it now.Signed-off-by: J. Bruce Fields
-
Now that the replay owner is in the cstate we can remove it from a lot
of other individual operations and further simplify
nfs4_preprocess_seqid_op().Signed-off-by: J. Bruce Fields
28 Aug, 2011
1 commit
-
This flag doesn't really buy us anything.
Signed-off-by: J. Bruce Fields
18 Jul, 2011
2 commits
-
It's sort of ridiculous that we've never had a working reply cache for
NFSv4.On the other hand, we may still not: our current reply cache is likely
not very good, especially in the TCP case (which is the only case that
matters for v4). What we really need here is some serious testing.Anyway, here's a start.
Signed-off-by: J. Bruce Fields
-
This simplifies cleanup a bit.
Signed-off-by: J. Bruce Fields
16 Jul, 2011
2 commits
-
This operation is used by the client to check the validity of a list of
stateids.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
This operation is used by the client to tell the server to free a
stateid.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields
12 Jan, 2011
2 commits
-
Implement the SEQ4_STATUS_CB_PATH_DOWN flag.
Signed-off-by: J. Bruce Fields
-
Basic xdr and processing for BIND_CONN_TO_SESSION. This adds a
connection to the list of connections associated with a session.Signed-off-by: J. Bruce Fields
18 Dec, 2010
1 commit
-
Implementation of this operation is mandatory for NFSv4.1.
Signed-off-by: J. Bruce Fields
09 Dec, 2010
1 commit
-
If vfs_getattr in fill_post_wcc returns an error, we don't
set fh_post_change.
For NFSv4, this can result in set_change_info triggering a BUG_ON.
i.e. fh_post_saved being zero isn't really a bug.So:
- instead of BUGging when fh_post_saved is zero, just clear ->atomic.
- if vfs_getattr fails in fill_post_wcc, take a copy of i_ctime anyway.
This will be used i seg_change_info, but not overly trusted.
- While we are there, remove the pointless 'if' statements in set_change_info.
There is no harm setting all the values.Signed-off-by: NeilBrown
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields
