Doug / smarc-fsl-linux-kernel

07 Jun, 2012

1 commit

  • 2c208890c   wireless: Remove casts to same type ... Browse Code »

    Adding casts of objects to the same type is unnecessary
    and confusing for a human reader.

    For example, this cast:

    int y;
    int *p = (int *)&y;

    I used the coccinelle script below to find and remove these
    unnecessary casts. I manually removed the conversions this
    script produces of casts with __force, __iomem and __user.

    @@
    type T;
    T *p;
    @@

    - (T *)p
    + p

    Neatened the mwifiex_deauthenticate_infra function which
    was doing odd things with array pointers and not using
    is_zero_ether_addr.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

24 Apr, 2012

2 commits

10 Mar, 2012

1 commit

07 Mar, 2012

1 commit

  • a9b89e256   rtlwifi: rtl8192ce: Fix loss of receive performance ... Browse Code »

    Driver rtl8192ce when used with the RTL8188CE device would start at about
    20 Mbps on a 54 Mbps connection, but quickly drop to 1 Mbps. One of the
    symptoms is that the AP would need to retransmit each packet 4 of 5 times
    before the driver would acknowledge it. Recovery is possible only by
    unloading and reloading the driver. This problem was reported at
    https://bugzilla.redhat.com/show_bug.cgi?id=770207.

    The problem is due to a missing update of the gain setting.

    Signed-off-by: Jingjun Wu
    Signed-off-by: Larry Finger
    Cc: Stable
    Signed-off-by: John W. Linville

    Jingjun Wu
     

06 Mar, 2012

1 commit

  • ebecdcc12   rtlwifi: rtl8192c: Prevent sleeping from invalid context in rtl8192cu ... Browse Code »

    When driver rtl8192cu is used with the debug level set to 3 or greater,
    the result is "sleeping function called from invalid context" due to
    an rcu_read_lock() call in the DM refresh routine in driver rtl8192c.
    This lock is not necessary as the USB driver does not use the struct
    being protected, thus the lock is set only when a PCI interface is
    active.

    This bug is reported in https://bugzilla.kernel.org/show_bug.cgi?id=42775.

    Reported-by: Ronald Wahl
    Tested-by: Ronald Wahl
    Signed-off-by: Larry Finger
    Cc: Stable
    Cc: Ronald Wahl
    Signed-off-by: John W. Linville

    Larry Finger
     

13 Feb, 2012

1 commit

  • 23677ce31   drivers/net: Remove boolean comparisons to true/false ... Browse Code »

    Booleans should not be compared to true or false
    but be directly tested or tested with !.

    Done via cocci script:

    @@
    bool t;
    @@
    - t == true
    + t
    @@
    bool t;
    @@
    - t != true
    + !t
    @@
    bool t;
    @@
    - t == false
    + !t
    @@
    bool t;
    @@
    - t != false
    + t

    Signed-off-by: Joe Perches
    Reviewed-by: Jeff Kirsher
    Signed-off-by: David S. Miller

    Joe Perches
     

25 Jan, 2012

2 commits

  • fc6168563   rtl8192c_common: Update copyright dates ... Browse Code »

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     
  • f30d7507a   rtlwifi: Convert RT_TRACE macro to use ##__VA_ARGS__ ... Browse Code »

    Consolidate printks to avoid possible message interleaving
    and reduce the object size.

    Remove unnecessary RT_TRACE parentheses.

    Miscellaneous typo and grammar fixes.
    Add missing newlines to formats.
    Remove duplicate KERN_DEBUG prefixes.
    Coalesce formats.
    Align arguments.

    $ size drivers/net/wireless/rtlwifi/built-in.o*
    text data bss dec hex filename
    594841 55333 129680 779854 be64e drivers/net/wireless/rtlwifi/built-in.o.new
    607022 55333 138720 801075 c3933 drivers/net/wireless/rtlwifi/built-in.o.old

    Signed-off-by: Joe Perches
    Acked-by: Larry Finger
    Signed-off-by: John W. Linville

    Joe Perches
     

01 Nov, 2011

1 commit

  • ee40fa065   drivers/net: Add export.h to files using EXPORT_SYMBOL/THIS_MODULE ... Browse Code »

    These were getting the macros from an implicit module.h
    include via device.h, but we are planning to clean that up.

    Signed-off-by: Paul Gortmaker

    drivers/net: Add export.h to wireless/brcm80211/brcmfmac/bcmsdh.c

    This relatively recently added file uses EXPORT_SYMBOL and hence
    needs export.h included so that it is compatible with the module.h
    split up work.

    Signed-off-by: Paul Gortmaker

    Paul Gortmaker
     

21 Jun, 2011

1 commit

11 Jun, 2011

1 commit

  • 7101f4043   rtlwifi: Fix warnings on parisc arch ... Browse Code »

    In "Build regressions/improvements in v3.0-rc2", Geert Uytterhoeven
    reports a number of warnings that occur for parisc builds of rtlwifi
    and dependents.

    Reported-by: Geert Uytterhoeven
    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

27 Apr, 2011

4 commits

15 Apr, 2011

1 commit

  • 9f219bd24   rtlwifi: Fix unitialized variable warnings ... Browse Code »

    In http://lkml.indiana.edu/hypermail/linux/kernel/1104.1/01955.html, Geerti
    Uytterhoeven reports the following warnings for the rtlwifi drivers.

    src/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c: warning:
    'cck_index' may be used uninitialized in this function: => 637
    src/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c: warning:
    'cck_index_old' may be used uninitialized in this function: => 637
    src/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c: warning:
    'box_extreg' may be used uninitialized in this function: => 303
    src/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c: warning:
    'box_reg' may be used uninitialized in this function: => 303
    src/drivers/net/wireless/rtlwifi/rtl8192ce/rf.c: warning:
    'chnlgroup' may be used uninitialized in this function: => 205
    src/drivers/net/wireless/rtlwifi/rtl8192ce/rf.c: warning:
    'u4_regvalue' may be used uninitialized in this function: => 450
    src/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c: warning:
    'hq_sele' may be used uninitialized in this function: => 924

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

24 Feb, 2011

1 commit

  • 1472d3a87   rtlwifi: rtl8192ce: rtl8192cu: Fix multiple def errors for allyesconfig build ... Browse Code »

    As noted by Stephan Rothwell, an allyesconfig build fails since rtl8192cu
    was merged with failures such as:

    drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_phy_sw_chnl':
    (.opd+0xf30): multiple definition of `rtl92c_phy_sw_chnl'
    drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0xb70): first defined here
    drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_fill_h2c_cmd':
    (.opd+0x288): multiple definition of `rtl92c_fill_h2c_cmd'
    drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0x288): first defined here

    These are caused because the code shared between rtl8192ce and rtl8192cu
    is included in both drivers. This has been fixed by creating a new modue that
    contains the shared code.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

22 Feb, 2011

1 commit

12 Feb, 2011

1 commit

  • 8c96fcf72   rtlwifi: rtl8192ce: Refactor rtl8192ce/dm ... Browse Code »

    To reuse as much code as possible when adding additional drivers to the
    rtlwifi tree, the common parts of various routines are moved to
    drivers/net/wireless/rtlwifi. This patch does that for the version of
    dm.{h,c} used by rtl8192ce.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger