21 Dec, 2012
1 commit
-
Pull kbuild misc changes from Michal Marek:
"This is the non-critical part of kbuild- scripts/kernel-doc requires a "Return:" section for non-void
functions
- ARCH=arm SUBARCH=... support for make tags
- COMPILED_SOURCE=1 support for make tags (only indexes .c files for
which a .o exists)
- New coccinelle check
- Option parsing fix for scripts/config"* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
scripts/config: Fix wrong "shift" for --keep-case
scripts/tags.sh: Support compiled source
scripts/tags.sh: Support subarch for ARM
scripts/coccinelle/misc/warn.cocci: use WARN
scripts/kernel-doc: check that non-void fcts describe their return value
Kernel-doc: Convention: Use a "Return" section to describe return values
19 Dec, 2012
1 commit
-
Ensure that calls to d_find_alias() have a corresponding dput().
Signed-off-by: Cyril Roelandt
Cc: Julia Lawall
Cc: Gilles Muller
Cc: Nicolas Palix
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 Dec, 2012
1 commit
-
Use WARN(1,...) rather than printk followed by WARN(1).
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
12 Oct, 2012
1 commit
-
Pull kbuild misc changes from Michal Marek:
"In the non-critical part of kbuild, I have
- Some make coccicheck improvements and two new tests
- Support for a cleaner html output in scripts/kernel-doc, named
html5 (no, it does not play videos, yet)BTW, Randy wants to route further kernel-doc patches through the
kbuild tree."* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
Update SmPL/Coccinelle section of MAINTAINERS
coccicheck: Add the rep+ctxt mode
scripts/coccinelle/tests/odd_ptr_err.cocci: semantic patch for IS_ERR/PTR_ERR inconsistency
scripts/tags.sh: Add magic for pci access functions
scripts/coccinelle: ptr_ret: Add ternary operator version
scripts/kernel-doc: drop maintainer
scripts/kernel-doc: added support for html5
11 Oct, 2012
1 commit
-
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
02 Oct, 2012
1 commit
-
Pull the trivial tree from Jiri Kosina:
"Tiny usual fixes all over the place"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (34 commits)
doc: fix old config name of kprobetrace
fs/fs-writeback.c: cleanup riteback_sb_inodes kerneldoc
btrfs: fix the commment for the action flags in delayed-ref.h
btrfs: fix trivial typo for the comment of BTRFS_FREE_INO_OBJECTID
vfs: fix kerneldoc for generic_fh_to_parent()
treewide: fix comment/printk/variable typos
ipr: fix small coding style issues
doc: fix broken utf8 encoding
nfs: comment fix
platform/x86: fix asus_laptop.wled_type module parameter
mfd: printk/comment fixes
doc: getdelays.c: remember to close() socket on error in create_nl_socket()
doc: aliasing-test: close fd on write error
mmc: fix comment typos
dma: fix comments
spi: fix comment/printk typos in spi
Coccinelle: fix typo in memdup_user.cocci
tmiofb: missing NULL pointer checks
tools: perf: Fix typo in tools/perf
tools/testing: fix comment / output typos
...
01 Sep, 2012
1 commit
-
Signed-off-by: Fengguang Wu
Signed-off-by: Jiri Kosina
31 Aug, 2012
1 commit
-
Add a ternary operator version of the open-coded PTR_RET().
Signed-off-by: Lars-Peter Clausen
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
14 Jul, 2012
1 commit
-
If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure. Thus this value should not be used after
the end of the iterator.Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
13 Jul, 2012
1 commit
-
Since commit 1c6c69525b ("genirq: Reject bogus threaded irq requests") threaded
IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise
the request will fail. This semantic patch will help to statically identify
(and fix) such cases.Signed-off-by: Lars-Peter Clausen
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
29 May, 2012
1 commit
-
Pull misc kbuild changes from Michal Marek:
"The non-critical part of kbuild for 3.5 includes- two new coccinelle checks
- fix for make deb-pkg to include generated headers in arch/*/includeI have more make-deb-pkg fixes in the backlog, but these will likely
have to wait for 3.6."* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
builddeb: include autogenerated header files
scripts/coccinelle: sizeof of pointer
scripts/coccinelle: address test is always true
25 May, 2012
2 commits
-
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
06 Apr, 2012
2 commits
-
Merge batch of fixes from Andrew Morton:
"The simple_open() cleanup was held back while I wanted for laggards to
merge things.I still need to send a few checkpoint/restore patches. I've been
wobbly about merging them because I'm wobbly about the overall
prospects for success of the project. But after speaking with Pavel
at the LSF conference, it sounds like they're further toward
completion than I feared - apparently davem is at the "has stopped
complaining" stage regarding the net changes. So I need to go back
and re-review those patchs and their (lengthy) discussion."* emailed from Andrew Morton : (16 patches)
memcg swap: use mem_cgroup_uncharge_swap fix
backlight: add driver for DA9052/53 PMIC v1
C6X: use set_current_blocked() and block_sigmask()
MAINTAINERS: add entry for sparse checker
MAINTAINERS: fix REMOTEPROC F: typo
alpha: use set_current_blocked() and block_sigmask()
simple_open: automatically convert to simple_open()
scripts/coccinelle/api/simple_open.cocci: semantic patch for simple_open()
libfs: add simple_open()
hugetlbfs: remove unregister_filesystem() when initializing module
drivers/rtc/rtc-88pm860x.c: fix rtc irq enable callback
fs/xattr.c:setxattr(): improve handling of allocation failures
fs/xattr.c:listxattr(): fall back to vmalloc() if kmalloc() failed
fs/xattr.c: suppress page allocation failure warnings from sys_listxattr()
sysrq: use SEND_SIG_FORCED instead of force_sig()
proc: fix mount -t proc -o AAA -
Find instances of an open-coded simple_open() and replace them with
calls to simple_open().Signed-off-by: Julia Lawall
Reported-by: Stephen Boyd
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
27 Mar, 2012
1 commit
-
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
25 Feb, 2012
5 commits
-
Signed-off-by: Julia Lawall
Reviewed-by: Rusty Russell
Signed-off-by: Michal Marek -
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
15 Jan, 2012
3 commits
-
This patch ensures that all semantic patches in the scripts/coccinelle
directory provide the report option. Report messages that include line
numbers now have the line number preceded by "line" for easier subsequent
processing.Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
devm_ functions allocate memory that is to remain allocated until the
device is detached. This patch checks for freeing of such memory using
standard memory freeing functions.Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
devm_ functions allocate memory that is to remain allocated until the
device is detached. This patch checks for opportunities for using the
function devm_request_and_ioremap.Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
03 Dec, 2010
1 commit
-
For doubleinit.cocci, Coccinelle 0.2.4 requires a comma after ... in a
field list. Coccinelle also now behaves gracefully when a definition is
provided for a virtual that doesn't exist, so there is no need for the
semantic patch code to check for this case.Updated the documentation to reflect the fact that the best results will
now be obtained with Coccinelle version 0.2.4 or later.Signed-off-by: Julia Lawall
28 Oct, 2010
2 commits
-
Signed-off-by: Julia Lawall
Signed-off-by: Nicolas Palix
Signed-off-by: Michal Marek -
Signed-off-by: Julia Lawall
Signed-off-by: Nicolas Palix
Signed-off-by: Michal Marek
13 Oct, 2010
1 commit
-
Use new comment format to separate proposed commit message
and information about generated false positivesSigned-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
31 Aug, 2010
12 commits
-
Find confusingly indented code in or after an if. An if branch should
be indented. The code following an if should not be indented.
Sometimes, code after an if that is indented is actually intended to be
part of the if branch.This has a high rate of false positives, because Coccinelle's column
calculation does not distinguish between spaces and tabs, so code that
is not visually aligned may be considered to be in the same column.Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Find duplicate field initializations. This has a high rate of false
positives due to #ifdefs, which Coccinelle is not aware of in a structure
initialization.Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
alloc contains various semantic patches related
to the allocation APIsSigned-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Use kmemdup_user rather than duplicating its implementation
This is a little bit restricted to reduce false positivesSigned-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Use kmemdup rather than duplicating its implementation
Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Use kstrdup rather than duplicating its implementation
Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Find a use after free. Values of variables may imply that some
execution paths are not possible, resulting in false positives.
Another source of false positives are macros such as
SCTP_DBG_OBJCNT_DEC that do not actually evaluate their argumentSigned-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
list_for_each_entry uses its first argument to get from one element of
the list to the next, so it is usually not a good idea to reassign it.
The first rule finds such a reassignment and the second rule checks
that there is a path from the reassignment back to the top of the loop.Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
Many iterators have the property that the first argument is always bound
to a real list element, never NULL. False positives arise for some
iterators that do not have this property, or in cases when the loop
cursor is reassigned. The latter should only happen when the matched
code is on the way to a loop exit (break, goto, or return).Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek -
for_each_node iterators only exit normally when the loop cursor is
NULL, so there is no point to call of_node_put on the final value.Signed-off-by: Nicolas Palix
Signed-off-by: Julia Lawall
Signed-off-by: Michal Marek
