14 Jul, 2010

1 commit

  • Newer gcc has a -femit-struct-debug-baseonly option that dramatically
    reduces the size of object files with debug info. What it does
    is to only emit type information for structures when the structures
    are defined in the same file or in a header file.

    This means the type information for most headers are not included.
    This is not good when the type information is actually
    needed (e.g. with kgdb or systemtap)

    But often kernel hackers only care about line numbers and don't
    need all the type information anyways. In this case setting
    the option can be a big win:

    A build dir for a specific x86-64 configuration with gcc 4.5
    shrunk from 2.3G to 1.2G. The compilation was also nearly a minute
    faster.

    Signed-off-by: Andi Kleen
    [mmarek: reformatted help text]
    Signed-off-by: Michal Marek

    Andi Kleen
     

29 Jun, 2010

1 commit

  • After commit 85a256d8e0116c8f5ad276730830f5d4d473344d, 'make kernelrelease'
    doesn't show the correct full kernel version. This patch fixes it,
    'make kernelrelease' will show the same version name with the one
    you finally get.

    Cc: David Rientjes
    Cc: Michal Marek
    Signed-off-by: Amerigo Wang
    [mmarek: merged with 0915512 and added dependency on
    include/config/kernel.release]
    Signed-off-by: Michal Marek

    Amerigo Wang
     

18 Jun, 2010

2 commits


04 Jun, 2010

1 commit

  • commit 37a8d9f67f18de1e2cbc7387311ce22d4dbff518 tried to combine some
    duplicate code and accidentally broke how KBUILD_SYMTYPES worked

    This fixes the code to match the original intention by the author who
    originally added the code I believe.

    The fixes include:
    - removing extra whitespaces in the if-statements
    - moving the if-statement from around the -r to the -T
    - adding a second arg to cmd_gensymtypes to simplify the options passed
    to genksyms.

    Tested by instrumenting genksyms and seeing what options were passed in
    during a make, KBUILD_SYMTYPES make, and when a foo.symref was created.

    Everything compiled and looked ok.

    Signed-off-by: Don Zickus
    Signed-off-by: Michal Marek

    Don Zickus
     

27 May, 2010

1 commit


06 May, 2010

1 commit

  • I'm looking Makefile in the -mm branch (dated 2010-04-28-16-53) and
    seeing what looks like a bug in the checking of scm-identifier. The
    "ifneq ($scm-identifier)" seems to always execute "ifeq
    ($(LOCALVERSION,)) ...". This patch fixes the checking of
    scm-identifier.

    Signed-off-by: Greg Thelen
    Acked-by: David Rientjes
    Signed-off-by: Michal Marek

    Greg Thelen
     

14 Apr, 2010

6 commits

  • There's a button in gconfig to "Show all options", but I think
    normally we are not interested in those configs which have no
    prompt and thus can't be changed, so here I add a new button to
    show hidden options which have prompts.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • Usage:
    Press to show all config symbols which have prompts.

    Quote Tim Bird:

    | I've been bitten by this numerous times. I most often
    | use ftrace on ARM, but when I go back to x86, I almost
    | always go through a sequence of searching for the
    | function graph tracer in the menus, then realizing it's
    | completely missing until I disable CC_OPTIMIZE_FOR_SIZE.
    |
    | Is there any way to have the menu item appear, but be
    | unsettable unless the SIZE option is disabled? I'm
    | not a Kconfig guru...

    I myself found this useful too. For example, I need to test
    ftrace/tracing and want to be sure all the tracing features are
    enabled, so I enter the "Tracers" menu, and press to
    see if there is any config hidden.

    I also noticed gconfig and xconfig have a button "Show all options",
    but that's a bit too much, and I think normally what we are not
    interested in those configs which have no prompt thus can't be
    changed by users.

    Exmaple:

    --- Tracers
    -*- Kernel Function Tracer
    - - Kernel Function Graph Tracer
    [*] Interrupts-off Latency Tracer
    - - Preemption-off Latency Tracer
    [*] Sysprof Tracer

    Here you can see 2 tracers are not selectable, and then can find
    out how to make them selectable.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • This option is a no-op, so remove it.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • Just use sym_get_type() and prop_get_type_name().

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • zconfdump(), which is used for debugging, can't recognize P_SELECT,
    P_RANGE and P_MENU (if associated with a symbol, aka "menuconfig"),
    and output something like this:

    config X86
    boolean
    default y
    unknown prop 6!
    unknown prop 6!
    unknown prop 6!
    ...

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • - fix a typo in documentation
    - fix a typo in a printk on error
    - fix comments in dialog_inputbox()

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     

08 Apr, 2010

1 commit


23 Mar, 2010

4 commits

  • Expand the dependency set used for the initrd to include the
    CONFIG_INITRAMFS_SOURCE file and the generator script itself.
    Otherwise changing the initramfs file list does not rebuild the CPIO.

    Signed-off-by: Jason Gunthorpe
    Signed-off-by: Michal Marek

    Jason Gunthorpe
     
  • A symbol's value won't be recalc-ed until we save config file or
    enter the menu where the symbol sits.

    So If I enable OPTIMIZE_FOR_SIZE, and search FUNCTION_GRAPH_TRACER:

    Symbol: FUNCTION_GRAPH_TRACER [=y]
    Prompt: Kernel Function Graph Tracer
    Defined at kernel/trace/Kconfig:140
    Depends on: ... [=y] && (!X86_32 [=y] || !CC_OPTIMIZE_FOR_SIZE [=y])
    ...

    From the dependency it should result in FUNCTION_GRAPH_TRACER=n,
    but it still shows FUNCTION_GRAPH_TRACER=y.

    Signed-off-by: Li Zefan
    Signed-off-by: Michal Marek

    Li Zefan
     
  • Ignore files compressed with lzop.

    Signed-off-by: Philipp Kohlbecher
    Signed-off-by: Michal Marek

    Philipp Kohlbecher
     
  • Minor perlcritic warning:
    headerdep.pl: "return" statement with explicit "undef" at line 84, column 2. See page 199 of PBP. (Severity: 5)

    The rationale according to PBP is that an explicit return of undef
    (contrary to most people's expectations) doesn't
    always evaluate as false. It has to with the fact that perl return value
    depends on context the function is called. If function is used in
    list context, the appropriate return value for false is an empty list;
    whereas in scalar context the return value for false is undefined.
    By just using a "return" both cases are handled.

    In the context of a trivial script this doesn't matter. But one script
    may be cut-paste into later code (most people like me only know 50%
    of perl), that is why perlcritic always complains

    Signed-off-by: Stephen Hemminger
    Signed-off-by: Michal Marek

    Stephen Hemminger
     

11 Mar, 2010

1 commit


10 Mar, 2010

1 commit


08 Mar, 2010

10 commits

  • This reverts commit eb8f844c0a41c4529a7d06b7801296eca9ae67aa. Ian
    Campbell writes:
    > I keep my kernel source tree on a more powerful build box where I run my
    > builds etc (including "make cscope") but run my editor from my
    > workstation with an NFS mount to the source. This worked fine for me
    > using relative paths for cscope. Using absolute paths in cscope breaks
    > this previously working setup because the root path is not the same on
    > both systems. I guess this is similar to moving the source tree around.
    >
    > Without wanting to start a flamewar it really sounds to me like we are
    > working around a vim (or cscope) bug here, emacs with cscope bindings
    > works fine in this configuration.

    Given that absolute paths can be forced by make O=. cscope, change the
    default back to relative paths.

    Ian Campbell
    Cc: Daniel Vetter
    Signed-off-by: Michal Marek

    Michal Marek
     
  • Only regenerate it if the configuration has changed. Also, do this after
    the modules build to fix errors with some weird Makefiles that are
    generated during build.

    Reported-by: Eric Miao
    Signed-off-by: Michal Marek

    Michal Marek
     
  • Better practice to use 3 arg open and local file handles.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • According to PBP; best way practice is to use local reference for file
    handle and three argument open. Also perl prototypes are a mistake.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • Use local file handles, use three argument open.
    Don't modify arguments in perl grep (use sed instead)

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • Turn on strict checking.
    Simplify code by using "unless" statement.

    Signed-off-by: Stephen Hemminger
    Acked-by: WANG Cong
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • Use local file handle not global.
    Make loop and other variables local in scope.

    Signed-off-by: Stephen Hemminger
    Cc: Hui Zhu
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • Turn on strict checking.
    Use three arguement open
    Standard practice in perl is to use undef not zero for false

    Signed-off-by: Stephen Hemminger
    Cc: Cong Wang
    Cc: Ralf Baechle
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • Turn on strict checking.
    Use local file handles.
    Use three argument open.

    Signed-off-by: Stephen Hemminger
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     
  • Cleanup checkstack script:
    * Turn on strict checking
    * Fix resulting error message because the declaration syntax
    was incorrect.
    * Remove incorrect and misleading use of prototype
    - prototype not required for this type of sort function
    because $a and $b are being used in this contex
    - if prototype was being used it should be for both arguments
    * Use closure for sort function

    Signed-off-by: Stephen Hemminger
    Cc: Steven Rostedt
    Cc: Arjan van de Ven
    Cc: Cong Wang
    Cc: Michal Marek
    Signed-off-by: Andrew Morton
    Signed-off-by: Michal Marek

    Stephen Hemminger
     

07 Mar, 2010

1 commit


03 Mar, 2010

9 commits