Doug / smarc-fsl-linux-kernel

24 Jan, 2012

1 commit

  • d07a74a54   dmaengine: fix missing 'cnt' in ?: in dmatest ... Browse Code »

    Hi,
    On the latest tree my compiler has started giving the warning:

    drivers/dma/dmatest.c:575:28: warning: the omitted middle operand in ?: will always be ?true?, suggest explicit middle operand [-Wparentheses]

    The following patch fixes the missing middle clause with the same
    fix that Nicolas Ferre used in the similar clauses.
    (There seems to have been a race between him fixing that and
    the extra clause going in a little later).

    I don't actually know the dmatest code/structures, nor do I own
    any hardware to test it on (assuming it needs a DMA engine);
    but this patch builds, the existing code is almost certainly
    wrong and the fix is the same as the corresponding lines above it.

    (WTH is x=y?:z legal C anyway?)

    Signed-off-by: Dr. David Alan Gilbert
    Reported-by: Dan Carpenter
    Reported-by: Paul Gortmaker
    Acked-by: Nicolas Ferre
    Signed-off-by: Dan Williams

    Dr. David Alan Gilbert
     

24 Nov, 2011

1 commit

  • adfa543e7   dmatest: don't use set_freezable_with_signal() ... Browse Code »

    Commit 981ed70d8e (dmatest: make dmatest threads freezable) made
    dmatest kthread use set_freezable_with_signal(); however, the
    interface is scheduled to be removed in the next merge window.

    The problem is that unlike userland tasks there's no default place
    which handles signal pending state and it isn't clear who owns and/or
    is responsible for clearing TIF_SIGPENDING. For example, in the
    current code, try_to_freeze() clears TIF_SIGPENDING but it isn't sure
    whether it actually owns the TIF_SIGPENDING nor is it race-free -
    ie. the task may continue to run with TIF_SIGPENDING set after the
    freezable section.

    Unfortunately, we don't have wait_for_completion_freezable_timeout().
    This patch open codes it and uses wait_event_freezable_timeout()
    instead and removes timeout reloading - wait_event_freezable_timeout()
    won't return across freezing events (currently racy but fix scheduled)
    and timer doesn't decrement while the task is in freezer. Although
    this does lose timer-reset-over-freezing, given that timeout is
    supposed to be long enough and failure to finish inside is considered
    irrecoverable, I don't think this is worth the complexity.

    While at it, move completion to outer scope and explain that we're
    ignoring dangling pointer problem after timeout. This should give
    slightly better chance at avoiding oops after timeout.

    Signed-off-by: Tejun Heo
    Acked-by: Dan Williams
    Cc: Guennadi Liakhovetski
    Cc: Nicolas Ferre

    Tejun Heo
     

29 Aug, 2011

1 commit

08 Aug, 2011

1 commit

22 Jun, 2011

1 commit

  • b7f080cfe   net: remove mm.h inclusion from netdevice.h ... Browse Code »

    Remove linux/mm.h inclusion from netdevice.h -- it's unused (I've checked manually).

    To prevent mm.h inclusion via other channels also extract "enum dma_data_direction"
    definition into separate header. This tiny piece is what gluing netdevice.h with mm.h
    via "netdevice.h => dmaengine.h => dma-mapping.h => scatterlist.h => mm.h".
    Removal of mm.h from scatterlist.h was tried and was found not feasible
    on most archs, so the link was cutoff earlier.

    Hope people are OK with tiny include file.

    Note, that mm_types.h is still dragged in, but it is a separate story.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     

19 May, 2011

1 commit

26 Apr, 2011

1 commit

  • 85ee7a1d3   treewide: cleanup continuations and remove logging message whitespace ... Browse Code »

    Using C line continuation inside format strings is error prone.
    Clean up the unintended whitespace introduced by misuse of \.
    Neaten correctly used line continations as well for consistency.

    drivers/scsi/arcmsr/arcmsr_hba.c has these errors as well,
    but arcmsr needs a lot more work and the driver should likely be
    moved to staging instead.

    Signed-off-by: Joe Perches
    Acked-by: Randy Dunlap
    Signed-off-by: Jiri Kosina

    Joe Perches
     

23 Mar, 2011

1 commit

  • d42efe6bf   dmaengine/dmatest: Pass timeout via module params ... Browse Code »

    When we try to test all channels present on our controller together, some
    channels of lower priority may be very slow as compared to others. If number of
    transfers is unlimited, some channels may timeout and will not finish within 3
    seconds. Thus, while doing such regress testing we may need to have higher value
    of timeouts. This patch adds support for passing timeout value via module
    parameters. Default value is 3 msec, a negative value means max timeout
    possible.

    Signed-off-by: Viresh Kumar
    Signed-off-by: Dan Williams

    Viresh Kumar
     

12 Mar, 2011

1 commit

05 Aug, 2010

1 commit

  • b9033e682   dma: dmatest: fix potential sign bug ... Browse Code »

    'cnt' is unsigned, so this code may become wrong in future as
    dmatest_add_threads() can return error code:

    cnt = dmatest_add_threads(dtc, DMA_MEMCPY);
    thread_count += cnt > 0 ? cnt : 0;
    ^^^^^^^

    Now it can return only -EINVAL if and only if second argument of
    dmatest_add_threads() is not one of DMA_MEMCPY, DMA_XOR, DMA_PQ.
    So, now it is not wrong but may become wrong in future.

    The semantic patch that finds this problem (many false-positive results):
    (http://coccinelle.lip6.fr/)

    //
    @ r1 @
    identifier f;
    @@
    int f(...) { ... }

    @@
    identifier r1.f;
    type T;
    unsigned T x;
    @@

    *x = f(...)
    ...
    *x > 0

    Signed-off-by: Kulikov Vasiliy
    Signed-off-by: Dan Williams

    Kulikov Vasiliy
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

04 Mar, 2010

1 commit

01 Mar, 2010

2 commits

  • 67b9124f7   dmatest: fix handling of an even number of xor_sources ... Browse Code »

    Just like commit ac5d73fc, we need to be careful to use 'src_cnt' as it
    contains the fixed up number of xor sources (forced odd) to meet dmatest's
    data verification scheme.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • 94de648d7   dmatest: correct raid6 PQ test ... Browse Code »

    The number of PQ sources specified by module parameter "pq_sources"
    is always forced odd to fit into dmatest's destination verificaton
    scheme. But number of PQ sources and coefficients as passed to the
    driver's prep_dma_pq() is not adjusted accordingly.

    Fix it now to get correct PQ testing results in the case passed
    "pq_sources" parameter is even.

    Signed-off-by: Anatolij Gustschin
    Signed-off-by: Andrew Morton
    Cc: Maciej Sosnowski
    Signed-off-by: Dan Williams

    Anatolij Gustschin
     

06 Feb, 2010

1 commit

11 Dec, 2009

1 commit

09 Sep, 2009

3 commits

30 Aug, 2009

1 commit

  • 58691d64c   dmatest: add pq support ... Browse Code »

    Test raid6 p+q operations with a simple "always multiply by 1" q
    calculation to fit into dmatest's current destination verification
    scheme.

    Reviewed-by: Andre Noll
    Acked-by: Maciej Sosnowski
    Signed-off-by: Dan Williams

    Dan Williams
     

23 Jul, 2009

3 commits

09 Apr, 2009

1 commit

  • c56c81abe   dmatest: fix max channels handling ... Browse Code »

    The check for reaching max_channels is short circuited by 'continuing'
    after successfully adding a channel.

    [ Impact: make the 'max_channels' module parameter actually have an effect ]

    Cc:
    Reported-by: Dan Carpenter
    Signed-off-by: Dan Williams

    Dan Williams
     

26 Mar, 2009

2 commits

05 Mar, 2009

1 commit

14 Jan, 2009

1 commit

07 Jan, 2009

4 commits

  • 41d5e59c1   dmaengine: add a release for dma class devices and dependent infrastructure ... Browse Code »

    Resolves:
    WARNING: at drivers/base/core.c:122 device_release+0x4d/0x52()
    Device 'dma0chan0' does not have a release() function, it is broken and must be fixed.

    The dma_chan_dev object is introduced to gear-match sysfs kobject and
    dmaengine channel lifetimes. When a channel is removed access to the
    sysfs entries return -ENODEV until the kobject can be released.

    The bulk of the change is updates to existing code to handle the extra
    layer of indirection between a dma_chan and its struct device.

    Reported-by: Alexander Beregalov
    Acked-by: Stephen Hemminger
    Cc: Haavard Skinnemoen
    Signed-off-by: Dan Williams

    Dan Williams
     
  • 7dd602510   dmaengine: kill enum dma_state_client ... Browse Code »

    DMA_NAK is now useless. We can just use a bool instead.

    Reviewed-by: Andrew Morton
    Signed-off-by: Dan Williams

    Dan Williams
     
  • 33df8ca06   dmatest: convert to dma_request_channel ... Browse Code »

    Replace the client registration infrastructure with a custom loop to
    poll for channels. Once dma_request_channel returns NULL stop asking
    for channels. A userspace side effect of this change if that loading
    the dmatest module before loading a dma driver will result in no
    channels being found, previously dmatest would get a callback. To
    facilitate testing in the built-in case dmatest_init is marked as a
    late_initcall. Another side effect is that channels under test can not
    be used for any other purpose.

    Cc: Haavard Skinnemoen
    Reviewed-by: Andrew Morton
    Signed-off-by: Dan Williams

    Dan Williams
     
  • 6f49a57aa   dmaengine: up-level reference counting to the module level ... Browse Code »

    Simply, if a client wants any dmaengine channel then prevent all dmaengine
    modules from being removed. Once the clients are done re-enable module
    removal.

    Why?, beyond reducing complication:
    1/ Tracking reference counts per-transaction in an efficient manner, as
    is currently done, requires a complicated scheme to avoid cache-line
    bouncing effects.
    2/ Per-transaction ref-counting gives the false impression that a
    dma-driver can be gracefully removed ahead of its user (net, md, or
    dma-slave)
    3/ None of the in-tree dma-drivers talk to hot pluggable hardware, but
    if such an engine were built one day we still would not need to notify
    clients of remove events. The driver can simply return NULL to a
    ->prep() request, something that is much easier for a client to handle.

    Reviewed-by: Andrew Morton
    Acked-by: Maciej Sosnowski
    Signed-off-by: Dan Williams

    Dan Williams
     

12 Nov, 2008

1 commit

19 Sep, 2008

2 commits

09 Jul, 2008

1 commit

  • 4a776f0aa   dmatest: Simple DMA memcpy test client ... Browse Code »

    This client tests DMA memcpy using various lengths and various offsets
    into the source and destination buffers. It will initialize both
    buffers with a repeatable pattern and verify that the DMA engine copies
    the requested region and nothing more. It will also verify that the
    bytes aren't swapped around, and that the source buffer isn't modified.

    The dmatest module can be configured to test a specific device, a
    specific channel. It can also test multiple channels at the same time,
    and it can start multiple threads competing for the same channel.

    Changes since v2:
    * Support testing multiple channels at the same time
    * Support testing with multiple threads competing for the same channel
    * Use counting test patterns in order to catch byte ordering issues

    Changes since v1:
    * Remove extra dashes around "help"
    * Remove "default n" from Kconfig
    * Turn TEST_BUF_SIZE into a module parameter
    * Return DMA_NAK instead of DMA_DUP
    * Print unhandled events
    * Support testing specific channels and devices
    * Move to the end of the Makefile

    Acked-by: Maciej Sosnowski
    Signed-off-by: Haavard Skinnemoen
    Signed-off-by: Dan Williams

    Haavard Skinnemoen