23 Oct, 2012

1 commit

  • The "wusb_cap_descr_default" is never used. GCC doesn't complain about
    it because we have that line ".bLength = sizeof(wusb_cap_descr_default)"
    inside the definition itself. Clang complains though.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Greg Kroah-Hartman

    Dan Carpenter
     

01 Nov, 2011

1 commit

  • With module.h being implicitly everywhere via device.h, the absence
    of explicitly including something for EXPORT_SYMBOL went unnoticed.
    Since we are heading to fix things up and clean module.h from the
    device.h file, we need to explicitly include these files now.

    Use the lightweight version of the header that has just THIS_MODULE
    and EXPORT_SYMBOL variants.

    Signed-off-by: Paul Gortmaker

    Paul Gortmaker
     

23 Apr, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

03 Mar, 2010

1 commit


12 Dec, 2009

1 commit


18 Apr, 2009

2 commits


03 Apr, 2009

1 commit

  • It is a fairly common operation to have a pointer to a work and to need a
    pointer to the delayed work it is contained in. In particular, all
    delayed works which want to rearm themselves will have to do that. So it
    would seem fair to offer a helper function for this operation.

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Jean Delvare
    Acked-by: Ingo Molnar
    Cc: "David S. Miller"
    Cc: Herbert Xu
    Cc: Benjamin Herrenschmidt
    Cc: Martin Schwidefsky
    Cc: Greg KH
    Cc: Pekka Enberg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jean Delvare
     

25 Mar, 2009

1 commit

  • To permit a userspace application to associate with WUSB devices
    using numeric association, control transfers to unauthenticated WUSB
    devices must be allowed.

    This requires that wusbcore correctly sets the device state to
    UNAUTHENTICATED, DEFAULT and ADDRESS and that control transfers can be
    performed to UNAUTHENTICATED devices.

    Signed-off-by: David Vrabel
    Signed-off-by: Greg Kroah-Hartman

    David Vrabel
     

07 Jan, 2009

1 commit


23 Dec, 2008

1 commit


25 Nov, 2008

1 commit

  • ASL/PZL updates while the WUSB channel is inactive (i.e., the PZL and
    ASL are stopped) may not complete. This causes hangs when removing the
    whci-hcd module if a device is still connected (removing the device
    does an endpoint_disable which results in an ASL update to remove the
    qset).

    If the WUSB channel is inactive the update can simply be skipped as the
    WHC doesn't care about the state of the ASL/PZL.

    Signed-off-by: David Vrabel

    David Vrabel
     

19 Nov, 2008

1 commit

  • The UWB radio manager coordinates the use of the radio between the
    PALs that may be using it. PALs request use of the radio with
    uwb_radio_start() and the radio manager will start beaconing if its
    not already doing so. When the last PAL has called uwb_radio_stop()
    beaconing will be stopped.

    In the future, the radio manager will have a more sophisticated channel
    selection algorithm, probably following the Channel Selection Policy
    from the WiMedia Alliance when it is finalized. For now, channel 9
    (BG1, TFC1) is selected.

    The user may override the channel selected by the radio manager and may
    force the radio to stop beaconing.

    The WUSB Host Controller PAL makes use of this and there are two new
    debug PAL commands that can be used for testing.

    Signed-off-by: David Vrabel

    David Vrabel
     

28 Oct, 2008

1 commit

  • Using a Reset Device IE to reset a WUSB device is too heavyweight as it
    causes the devcie to disconnect (which the USB stack does not expect and
    cannot handle). Instead, do a SetAddress(0); SetAddress(AuthAddr) for
    authenticated devices.

    Unauthenticated devices will not be reset and the stack will have to rely
    on the device timing out after TrustTimeout and disconnecting.

    Signed-off-by: David Vrabel

    David Vrabel
     

16 Oct, 2008

1 commit


17 Sep, 2008

2 commits